45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
34 lines
1.0 KiB
Ruby
34 lines
1.0 KiB
Ruby
# typed: true # rubocop:disable Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
class Formula
|
|
undef valid_platform?
|
|
undef std_cmake_args
|
|
|
|
sig { returns(T::Boolean) }
|
|
def valid_platform?
|
|
requirements.none?(LinuxRequirement)
|
|
end
|
|
|
|
sig {
|
|
params(
|
|
install_prefix: T.any(String, Pathname),
|
|
install_libdir: T.any(String, Pathname),
|
|
find_framework: String,
|
|
).returns(T::Array[String])
|
|
}
|
|
def std_cmake_args(install_prefix: prefix, install_libdir: "lib", find_framework: "LAST")
|
|
args = generic_std_cmake_args(install_prefix:, install_libdir:,
|
|
find_framework:)
|
|
|
|
# Avoid false positives for clock_gettime support on 10.11.
|
|
# CMake cache entries for other weak symbols may be added here as needed.
|
|
args << "-DHAVE_CLOCK_GETTIME:INTERNAL=0" if MacOS.version == "10.11" && MacOS::Xcode.version >= "8.0"
|
|
|
|
# Ensure CMake is using the same SDK we are using.
|
|
args << "-DCMAKE_OSX_SYSROOT=#{MacOS.sdk_for_formula(self).path}" if MacOS.sdk_root_needed?
|
|
|
|
args
|
|
end
|
|
end
|