45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
54 lines
1.2 KiB
Ruby
54 lines
1.2 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "warnings"
|
|
Warnings.ignore(/warning: callcc is obsolete; use Fiber instead/) do
|
|
require "continuation"
|
|
end
|
|
|
|
# Provides the ability to optionally ignore errors raised and continue execution.
|
|
module Ignorable
|
|
# Marks exceptions which can be ignored and provides
|
|
# the ability to jump back to where it was raised.
|
|
module ExceptionMixin
|
|
attr_accessor :continuation
|
|
|
|
def ignore
|
|
continuation.call
|
|
end
|
|
end
|
|
|
|
def self.hook_raise
|
|
Object.class_eval do
|
|
alias_method :original_raise, :raise
|
|
|
|
def raise(*)
|
|
callcc do |continuation|
|
|
super
|
|
rescue Exception => e # rubocop:disable Lint/RescueException
|
|
unless e.is_a?(ScriptError)
|
|
e.extend(ExceptionMixin)
|
|
T.cast(e, ExceptionMixin).continuation = continuation
|
|
end
|
|
super(e)
|
|
end
|
|
end
|
|
|
|
alias_method :fail, :raise
|
|
end
|
|
|
|
return unless block_given?
|
|
|
|
yield
|
|
unhook_raise
|
|
end
|
|
|
|
def self.unhook_raise
|
|
Object.class_eval do
|
|
alias_method :raise, :original_raise
|
|
alias_method :fail, :original_raise
|
|
undef :original_raise
|
|
end
|
|
end
|
|
end
|