 45978435e7
			
		
	
	
		45978435e7
		
			
		
	
	
	
	
		
			
			- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
		
			
				
	
	
		
			302 lines
		
	
	
		
			8.3 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			302 lines
		
	
	
		
			8.3 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| # typed: true # rubocop:todo Sorbet/StrictSigil
 | |
| # frozen_string_literal: true
 | |
| 
 | |
| require "dependable"
 | |
| 
 | |
| # A dependency on another Homebrew formula.
 | |
| #
 | |
| # @api internal
 | |
| class Dependency
 | |
|   extend Forwardable
 | |
|   include Dependable
 | |
|   extend Cachable
 | |
| 
 | |
|   sig { returns(String) }
 | |
|   attr_reader :name
 | |
| 
 | |
|   sig { returns(T.nilable(Tap)) }
 | |
|   attr_reader :tap
 | |
| 
 | |
|   def initialize(name, tags = [])
 | |
|     raise ArgumentError, "Dependency must have a name!" unless name
 | |
| 
 | |
|     @name = name
 | |
|     @tags = tags
 | |
| 
 | |
|     return unless (tap_with_name = Tap.with_formula_name(name))
 | |
| 
 | |
|     @tap, = tap_with_name
 | |
|   end
 | |
| 
 | |
|   def ==(other)
 | |
|     instance_of?(other.class) && name == other.name && tags == other.tags
 | |
|   end
 | |
|   alias eql? ==
 | |
| 
 | |
|   def hash
 | |
|     [name, tags].hash
 | |
|   end
 | |
| 
 | |
|   def to_formula
 | |
|     formula = Formulary.factory(name, warn: false)
 | |
|     formula.build = BuildOptions.new(options, formula.options)
 | |
|     formula
 | |
|   end
 | |
| 
 | |
|   sig { params(minimum_version: T.nilable(Version), minimum_revision: T.nilable(Integer)).returns(T::Boolean) }
 | |
|   def installed?(minimum_version: nil, minimum_revision: nil)
 | |
|     formula = begin
 | |
|       to_formula
 | |
|     rescue FormulaUnavailableError
 | |
|       nil
 | |
|     end
 | |
|     return false unless formula
 | |
| 
 | |
|     return true if formula.latest_version_installed?
 | |
| 
 | |
|     return false if minimum_version.blank?
 | |
| 
 | |
|     # If the opt prefix doesn't exist: we likely have an incomplete installation.
 | |
|     return false unless formula.opt_prefix.exist?
 | |
| 
 | |
|     installed_keg = formula.any_installed_keg
 | |
|     return false unless installed_keg
 | |
| 
 | |
|     # If the keg name doesn't match, we may have moved from an alias to a full formula and need to upgrade.
 | |
|     return false unless formula.possible_names.include?(installed_keg.name)
 | |
| 
 | |
|     installed_version = installed_keg.version
 | |
| 
 | |
|     # Tabs prior to 4.1.18 did not have revision or pkg_version fields.
 | |
|     # As a result, we have to be more conversative when we do not have
 | |
|     # a minimum revision from the tab and assume that if the formula has a
 | |
|     # the same version and a non-zero revision that it needs upgraded.
 | |
|     if minimum_revision.present?
 | |
|       minimum_pkg_version = PkgVersion.new(minimum_version, minimum_revision)
 | |
|       installed_version >= minimum_pkg_version
 | |
|     elsif installed_version.version == minimum_version
 | |
|       formula.revision.zero?
 | |
|     else
 | |
|       installed_version.version > minimum_version
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   def satisfied?(inherited_options = [], minimum_version: nil, minimum_revision: nil)
 | |
|     installed?(minimum_version:, minimum_revision:) &&
 | |
|       missing_options(inherited_options).empty?
 | |
|   end
 | |
| 
 | |
|   def missing_options(inherited_options)
 | |
|     formula = to_formula
 | |
|     required = options
 | |
|     required |= inherited_options
 | |
|     required &= formula.options.to_a
 | |
|     required -= Tab.for_formula(formula).used_options
 | |
|     required
 | |
|   end
 | |
| 
 | |
|   def option_names
 | |
|     [name.split("/").last].freeze
 | |
|   end
 | |
| 
 | |
|   sig { overridable.returns(T::Boolean) }
 | |
|   def uses_from_macos?
 | |
|     false
 | |
|   end
 | |
| 
 | |
|   sig { returns(String) }
 | |
|   def to_s = name
 | |
| 
 | |
|   sig { returns(String) }
 | |
|   def inspect
 | |
|     "#<#{self.class.name}: #{name.inspect} #{tags.inspect}>"
 | |
|   end
 | |
| 
 | |
|   sig { params(formula: Formula).returns(T.self_type) }
 | |
|   def dup_with_formula_name(formula)
 | |
|     self.class.new(formula.full_name.to_s, tags)
 | |
|   end
 | |
| 
 | |
|   class << self
 | |
|     # Expand the dependencies of each dependent recursively, optionally yielding
 | |
|     # `[dependent, dep]` pairs to allow callers to apply arbitrary filters to
 | |
|     # the list.
 | |
|     # The default filter, which is applied when a block is not given, omits
 | |
|     # optionals and recommends based on what the dependent has asked for
 | |
|     #
 | |
|     # @api internal
 | |
|     def expand(dependent, deps = dependent.deps, cache_key: nil, &block)
 | |
|       # Keep track dependencies to avoid infinite cyclic dependency recursion.
 | |
|       @expand_stack ||= []
 | |
|       @expand_stack.push dependent.name
 | |
| 
 | |
|       if cache_key.present?
 | |
|         cache[cache_key] ||= {}
 | |
|         return cache[cache_key][cache_id dependent].dup if cache[cache_key][cache_id dependent]
 | |
|       end
 | |
| 
 | |
|       expanded_deps = []
 | |
| 
 | |
|       deps.each do |dep|
 | |
|         next if dependent.name == dep.name
 | |
| 
 | |
|         case action(dependent, dep, &block)
 | |
|         when :prune
 | |
|           next
 | |
|         when :skip
 | |
|           next if @expand_stack.include? dep.name
 | |
| 
 | |
|           expanded_deps.concat(expand(dep.to_formula, cache_key:, &block))
 | |
|         when :keep_but_prune_recursive_deps
 | |
|           expanded_deps << dep
 | |
|         else
 | |
|           next if @expand_stack.include? dep.name
 | |
| 
 | |
|           dep_formula = dep.to_formula
 | |
|           expanded_deps.concat(expand(dep_formula, cache_key:, &block))
 | |
| 
 | |
|           # Fixes names for renamed/aliased formulae.
 | |
|           dep = dep.dup_with_formula_name(dep_formula)
 | |
|           expanded_deps << dep
 | |
|         end
 | |
|       end
 | |
| 
 | |
|       expanded_deps = merge_repeats(expanded_deps)
 | |
|       cache[cache_key][cache_id dependent] = expanded_deps.dup if cache_key.present?
 | |
|       expanded_deps
 | |
|     ensure
 | |
|       @expand_stack.pop
 | |
|     end
 | |
| 
 | |
|     def action(dependent, dep, &block)
 | |
|       catch(:action) do
 | |
|         if block
 | |
|           yield dependent, dep
 | |
|         elsif dep.optional? || dep.recommended?
 | |
|           prune unless dependent.build.with?(dep)
 | |
|         end
 | |
|       end
 | |
|     end
 | |
| 
 | |
|     # Prune a dependency and its dependencies recursively.
 | |
|     sig { void }
 | |
|     def prune
 | |
|       throw(:action, :prune)
 | |
|     end
 | |
| 
 | |
|     # Prune a single dependency but do not prune its dependencies.
 | |
|     sig { void }
 | |
|     def skip
 | |
|       throw(:action, :skip)
 | |
|     end
 | |
| 
 | |
|     # Keep a dependency, but prune its dependencies.
 | |
|     #
 | |
|     # @api internal
 | |
|     sig { void }
 | |
|     def keep_but_prune_recursive_deps
 | |
|       throw(:action, :keep_but_prune_recursive_deps)
 | |
|     end
 | |
| 
 | |
|     def merge_repeats(all)
 | |
|       grouped = all.group_by(&:name)
 | |
| 
 | |
|       all.map(&:name).uniq.map do |name|
 | |
|         deps = grouped.fetch(name)
 | |
|         dep  = deps.first
 | |
|         tags = merge_tags(deps)
 | |
|         kwargs = {}
 | |
|         kwargs[:bounds] = dep.bounds if dep.uses_from_macos?
 | |
|         dep.class.new(name, tags, **kwargs)
 | |
|       end
 | |
|     end
 | |
| 
 | |
|     private
 | |
| 
 | |
|     def cache_id(dependent)
 | |
|       "#{dependent.full_name}_#{dependent.class}"
 | |
|     end
 | |
| 
 | |
|     def merge_tags(deps)
 | |
|       other_tags = deps.flat_map(&:option_tags).uniq
 | |
|       other_tags << :test if deps.flat_map(&:tags).include?(:test)
 | |
|       merge_necessity(deps) + merge_temporality(deps) + other_tags
 | |
|     end
 | |
| 
 | |
|     def merge_necessity(deps)
 | |
|       # Cannot use `deps.any?(&:required?)` here due to its definition.
 | |
|       if deps.any? { |dep| !dep.recommended? && !dep.optional? }
 | |
|         [] # Means required dependency.
 | |
|       elsif deps.any?(&:recommended?)
 | |
|         [:recommended]
 | |
|       else # deps.all?(&:optional?)
 | |
|         [:optional]
 | |
|       end
 | |
|     end
 | |
| 
 | |
|     def merge_temporality(deps)
 | |
|       new_tags = []
 | |
|       new_tags << :build if deps.all?(&:build?)
 | |
|       new_tags << :implicit if deps.all?(&:implicit?)
 | |
|       new_tags
 | |
|     end
 | |
|   end
 | |
| end
 | |
| 
 | |
| # A dependency that's marked as "installed" on macOS
 | |
| class UsesFromMacOSDependency < Dependency
 | |
|   attr_reader :bounds
 | |
| 
 | |
|   sig { params(name: String, tags: T::Array[Symbol], bounds: T::Hash[Symbol, Symbol]).void }
 | |
|   def initialize(name, tags = [], bounds:)
 | |
|     super(name, tags)
 | |
| 
 | |
|     @bounds = bounds
 | |
|   end
 | |
| 
 | |
|   def ==(other)
 | |
|     instance_of?(other.class) && name == other.name && tags == other.tags && bounds == other.bounds
 | |
|   end
 | |
| 
 | |
|   def hash
 | |
|     [name, tags, bounds].hash
 | |
|   end
 | |
| 
 | |
|   sig { params(minimum_version: T.nilable(Version), minimum_revision: T.nilable(Integer)).returns(T::Boolean) }
 | |
|   def installed?(minimum_version: nil, minimum_revision: nil)
 | |
|     use_macos_install? || super
 | |
|   end
 | |
| 
 | |
|   sig { returns(T::Boolean) }
 | |
|   def use_macos_install?
 | |
|     # Check whether macOS is new enough for dependency to not be required.
 | |
|     if Homebrew::SimulateSystem.simulating_or_running_on_macos?
 | |
|       # Assume the oldest macOS version when simulating a generic macOS version
 | |
|       return true if Homebrew::SimulateSystem.current_os == :macos && !bounds.key?(:since)
 | |
| 
 | |
|       if Homebrew::SimulateSystem.current_os != :macos
 | |
|         current_os = MacOSVersion.from_symbol(Homebrew::SimulateSystem.current_os)
 | |
|         since_os = MacOSVersion.from_symbol(bounds[:since]) if bounds.key?(:since)
 | |
|         return true if current_os >= since_os
 | |
|       end
 | |
|     end
 | |
| 
 | |
|     false
 | |
|   end
 | |
| 
 | |
|   sig { override.returns(T::Boolean) }
 | |
|   def uses_from_macos?
 | |
|     true
 | |
|   end
 | |
| 
 | |
|   sig { override.params(formula: Formula).returns(T.self_type) }
 | |
|   def dup_with_formula_name(formula)
 | |
|     self.class.new(formula.full_name.to_s, tags, bounds:)
 | |
|   end
 | |
| 
 | |
|   sig { returns(String) }
 | |
|   def inspect
 | |
|     "#<#{self.class.name}: #{name.inspect} #{tags.inspect} #{bounds.inspect}>"
 | |
|   end
 | |
| end
 |