94aeabfc8a
When the file isn't world-readable, `brew audit` prints a failure message including a suggestion to `chmod +r` the file. Unfortunately, this isn't quite right: with both macOS and coreutils, leaving out the "who" in a chmod only affects bits which would be set in the umask. So, if the umask doesn't allow world-readable (which might be why the file wasn't world-readable in the first place), the suggested chmod command does nothing. Change to print `chmod a+r` instead; that does have the intended effect. No other `chmod` suggestions in this file have the same problem.
47 lines
1.7 KiB
Ruby
47 lines
1.7 KiB
Ruby
# typed: true
|
|
# frozen_string_literal: true
|
|
|
|
require "rubocops/extend/formula_cop"
|
|
|
|
module RuboCop
|
|
module Cop
|
|
module FormulaAudit
|
|
# This cop makes sure that a formula's file permissions are correct.
|
|
#
|
|
# @api private
|
|
class Files < FormulaCop
|
|
def audit_formula(node, _class_node, _parent_class_node, _body_node)
|
|
return unless file_path
|
|
|
|
# Codespaces routinely screws up all permissions so don't complain there.
|
|
return if ENV["CODESPACES"] || ENV["HOMEBREW_CODESPACES"]
|
|
|
|
offending_node(node)
|
|
actual_mode = File.stat(file_path).mode
|
|
# Check that the file is world-readable.
|
|
if actual_mode & 0444 != 0444
|
|
problem format("Incorrect file permissions (%03<actual>o): chmod %<wanted>s %<path>s",
|
|
actual: actual_mode & 0777,
|
|
wanted: "a+r",
|
|
path: file_path)
|
|
end
|
|
# Check that the file is user-writeable.
|
|
if actual_mode & 0200 != 0200
|
|
problem format("Incorrect file permissions (%03<actual>o): chmod %<wanted>s %<path>s",
|
|
actual: actual_mode & 0777,
|
|
wanted: "u+w",
|
|
path: file_path)
|
|
end
|
|
# Check that the file is *not* other-writeable.
|
|
return if actual_mode & 0002 != 002
|
|
|
|
problem format("Incorrect file permissions (%03<actual>o): chmod %<wanted>s %<path>s",
|
|
actual: actual_mode & 0777,
|
|
wanted: "o-w",
|
|
path: file_path)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|