45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
85 lines
2.1 KiB
Ruby
85 lines
2.1 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
module RuboCop
|
|
module Cask
|
|
# Constants available globally for use in all cask cops.
|
|
module Constants
|
|
ON_SYSTEM_METHODS = [:arm, :intel, *MacOSVersion::SYMBOLS.keys].map { |option| :"on_#{option}" }.freeze
|
|
ON_SYSTEM_METHODS_STANZA_ORDER = [
|
|
:arm,
|
|
:intel,
|
|
*MacOSVersion::SYMBOLS.reverse_each.to_h.keys, # Oldest OS blocks first since that's more common in Casks.
|
|
].map { |option, _| :"on_#{option}" }.freeze
|
|
|
|
STANZA_GROUPS = [
|
|
[:arch, :on_arch_conditional],
|
|
[:version, :sha256],
|
|
ON_SYSTEM_METHODS_STANZA_ORDER,
|
|
[:language],
|
|
[:url, :appcast, :name, :desc, :homepage],
|
|
[:livecheck],
|
|
[:deprecate!, :disable!],
|
|
[
|
|
:auto_updates,
|
|
:conflicts_with,
|
|
:depends_on,
|
|
:container,
|
|
],
|
|
[
|
|
:suite,
|
|
:app,
|
|
:pkg,
|
|
:installer,
|
|
:binary,
|
|
:manpage,
|
|
:colorpicker,
|
|
:dictionary,
|
|
:font,
|
|
:input_method,
|
|
:internet_plugin,
|
|
:keyboard_layout,
|
|
:prefpane,
|
|
:qlplugin,
|
|
:mdimporter,
|
|
:screen_saver,
|
|
:service,
|
|
:audio_unit_plugin,
|
|
:vst_plugin,
|
|
:vst3_plugin,
|
|
:artifact,
|
|
:stage_only,
|
|
],
|
|
[:preflight],
|
|
[:postflight],
|
|
[:uninstall_preflight],
|
|
[:uninstall_postflight],
|
|
[:uninstall],
|
|
[:zap],
|
|
[:caveats],
|
|
].freeze
|
|
|
|
STANZA_GROUP_HASH =
|
|
STANZA_GROUPS.each_with_object({}) do |stanza_group, hash|
|
|
stanza_group.each { |stanza| hash[stanza] = stanza_group }
|
|
end.freeze
|
|
|
|
STANZA_ORDER = STANZA_GROUPS.flatten.freeze
|
|
|
|
UNINSTALL_METHODS_ORDER = [
|
|
:early_script,
|
|
:launchctl,
|
|
:quit,
|
|
:signal,
|
|
:login_item,
|
|
:kext,
|
|
:script,
|
|
:pkgutil,
|
|
:delete,
|
|
:trash,
|
|
:rmdir,
|
|
].freeze
|
|
end
|
|
end
|
|
end
|