45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
64 lines
1.5 KiB
Ruby
64 lines
1.5 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "requirement"
|
|
|
|
# A requirement on Xcode.
|
|
class XcodeRequirement < Requirement
|
|
fatal true
|
|
|
|
attr_reader :version
|
|
|
|
satisfy(build_env: false) do
|
|
T.bind(self, XcodeRequirement)
|
|
xcode_installed_version
|
|
end
|
|
|
|
def initialize(tags = [])
|
|
@version = tags.shift if tags.first.to_s.match?(/(\d\.)+\d/)
|
|
super
|
|
end
|
|
|
|
sig { returns(T::Boolean) }
|
|
def xcode_installed_version
|
|
return false unless MacOS::Xcode.installed?
|
|
return true unless @version
|
|
|
|
MacOS::Xcode.version >= @version
|
|
end
|
|
|
|
sig { returns(String) }
|
|
def message
|
|
version = " #{@version}" if @version
|
|
message = <<~EOS
|
|
A full installation of Xcode.app#{version} is required to compile
|
|
this software. Installing just the Command Line Tools is not sufficient.
|
|
EOS
|
|
if @version && Version.new(MacOS::Xcode.latest_version) < Version.new(@version)
|
|
message + <<~EOS
|
|
|
|
Xcode#{version} cannot be installed on macOS #{MacOS.version}.
|
|
You must upgrade your version of macOS.
|
|
EOS
|
|
else
|
|
message + <<~EOS
|
|
|
|
Xcode can be installed from the App Store.
|
|
EOS
|
|
end
|
|
end
|
|
|
|
sig { returns(String) }
|
|
def inspect
|
|
"#<#{self.class.name}: version>=#{@version.inspect} #{tags.inspect}>"
|
|
end
|
|
|
|
def display_s
|
|
return "#{name.capitalize} (on macOS)" unless @version
|
|
|
|
"#{name.capitalize} >= #{@version} (on macOS)"
|
|
end
|
|
end
|
|
|
|
require "extend/os/requirements/xcode_requirement"
|