38 Commits

Author SHA1 Message Date
Mike McQuaid
a4f86ba973
Don’t require aligned arguments for taps. 2019-04-30 09:19:29 +01:00
Mike McQuaid
f76b083b91
Use FrozenStringLiteralComment instead of flag.
Unfortunately we cannot use `--frozen-string-literal` with Ruby 2.3 due
to https://bugs.ruby-lang.org/issues/12031 and our usage of ERB.
2019-04-20 13:25:33 +09:00
Mike McQuaid
420e63ebcd
Freeze more mutable constants.
This rule adjustment is experimental in RuboCop as it may double-freeze
objects but this isn't an error (and freezing too much is better than
too little).
2019-04-19 18:08:05 +09:00
Mike McQuaid
d64429a736
rubocop: enable Style/IfUnlessModifier. 2019-02-21 12:55:49 +00:00
Mike McQuaid
eed1444d61
Update deprecations and cleanup
- Move `odeprecated` to `odisabled`
- Remove `odisabled`
- Enable automatic cleanup on install/reinstall/upgrade.
2019-01-23 21:57:40 +00:00
Mike McQuaid
5c7fbaf259
Update RuboCop RSpec rules
Create a new, seperate RuboCop file that uses our RSpec rule
configuration if a specified tap has a `spec` directory.

Also, while we're here, fix up the various rules so that we don't have
any outdated TODOs, disable some rules for good and fix `brew style`
for Homebrew/bundle.
2019-01-21 13:39:11 +00:00
Markus Reiter
04908dcb19 Fix RuboCop for Casks. 2018-11-12 05:01:33 +01:00
Jan Viljanen
3a73c6c9b2 remove exclusions 2018-09-30 16:40:20 +02:00
Jan Viljanen
e5b3b7e326 further updates 2018-09-30 15:35:49 +02:00
Jan Viljanen
53109455b8 move requirement 2018-09-28 18:09:03 +02:00
Mike McQuaid
79c2ccd0bc
Generate rubocop_todo.yml for RuboCop RSpec 2018-09-20 13:36:42 +01:00
commitay
b3e39014c9 Library/Homebrew/.rubocop.yml: remove RescueEnsureAlignment 2018-09-18 13:21:17 +10:00
Markus Reiter
e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
Mike McQuaid
80d75bc0d8
Homebrew/.rubocop: tweak rules.
Adjust the rules based on the current codebase. Remove various enable,
disables and default values that are unnecessary. Add more comments
explaining why. Make minor changes needed to enable a few more rules.
2018-09-02 20:15:09 +01:00
Mike McQuaid
bcb1ec5499
Improve Homebrew/brew line length.
Use 124 max line length everywhere. Also, reduce tap max line length to
189 as Homebrew/homebrew-core has that as a maximum now. In future
Homebrew/homebrew-core will also be reduced to 124 maximum line length.
2018-09-02 16:15:09 +01:00
Markus Reiter
bf856117ba Allow unused keyword arguments. 2018-07-12 10:39:27 +02:00
Andrew Janke
e0a8a79921 Style fixes for Rubocop 0.57.1 2018-06-30 19:40:14 -04:00
Andrew Janke
f99d7b29ef upgrade to Rubocop 0.57.1 2018-06-30 16:27:19 -04:00
Andrew Janke
abb917f381 rubocop: exclude .simplecov under vendor 2018-06-12 18:00:50 -04:00
Andrew Janke
996825dd27 Split out rspec-specific Rubocop config to fix warning 2018-06-07 00:23:44 -04:00
Markus Reiter
16fb563d49 Refactor MissingFormula spec. 2018-04-20 19:11:22 +02:00
Mike McQuaid
718a2112d7 rubocop.yml: adjust rules for 0.53.0. 2018-03-08 14:10:02 +00:00
Mike McQuaid
8cd0d85afb rubocop 0.52.1 2018-01-15 16:17:32 +00:00
Mike McQuaid
47bfad64b0 rubocop.yml: re-add Homebrew metrics maximums. 2017-10-27 14:20:37 +01:00
Markus Reiter
71b6e239d7 Set RuboCop maximum to current maximum. 2017-10-10 17:00:04 +02:00
Markus Reiter
175ca909ee Clean up code style and remove .rubocop_todo.yml. 2017-10-08 16:10:37 +02:00
Markus Reiter
643b2a168c Refactor cask/cli specs. 2017-10-03 10:56:40 +02:00
Mike McQuaid
9eb51db400 Rubocop 0.50 and target 2.3. 2017-09-24 21:23:59 +01:00
Mike McQuaid
4356016b4a Use parallel RuboCop
This requires updating to Rubocop 0.49.0 which will require some fixes
to rules, in Homebrew/brew and Homebrew/homebrew-core but opening this
for now so I remember.
2017-05-29 18:42:02 +01:00
Markus Reiter
df1864ee43 Add CLI::Options DSL. 2017-05-22 02:51:17 +02:00
Markus Reiter
f85d3d1f7f Convert Requirement test to spec. 2017-02-12 22:06:44 +01:00
Markus Reiter
8d15bddedb Auto-correct block delimiters. 2016-10-23 14:44:14 +02:00
Markus Reiter
13e3272e37 Remove Cask’s RuboCop configuration. 2016-10-23 14:13:16 +02:00
Mike McQuaid
6c4042f593 More Rubocop tweaks.
- Don't enforce hash rockets on external commands.
- Enabled accidentally disabled ParenthesesAsGroupedExpression.
2016-10-22 15:55:13 +01:00
Mike McQuaid
1f963267b6 Update Rubocop style.
Another look at the current Rubocop rules and how they fit with our
existing and desired future style. Almost all of these changes were
automatic. Split some rules between formulae/brew where brew doesn't
have millions of cases that need fixed.
2016-10-22 13:32:46 +01:00
Mike McQuaid
5b31507fda Use Library/.rubocop.yml file.
This allows having a shared style that’s use for Homebrew/brew and taps
which can be overridden by Homebrew/brew.
2016-10-01 12:13:09 +01:00
Markus Reiter
cea796c09b Rename shared RuboCop config to .rubocop_common.yml. 2016-09-29 22:59:49 +02:00
Markus Reiter
5800f2f084 Use separate .rubocop.yml in Library/Taps and Library/Homebrew. 2016-09-29 22:58:41 +02:00