admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
24,630 Commits 15 Branches 471 Tags
Commit Graph

24630 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Max Howell
00e227ac46 More tweaking of main exception handler output 2009-11-12 01:37:02 +00:00
Max Howell
6488212a54 Show kernel architecture in brew --config output 2009-11-11 21:51:44 +00:00
Max Howell
4bd32c615e Fix system() exception showing regression 
Rather than showing a backtrace that says "couldn't find command blah". Admittedly it's possible that the error will be something else, but unlikely. And this is neater.

Ideally we'd push the bt through an error pipe like we do with install.rb. And I guess we'll do this eventually.
 2009-11-11 19:42:35 +00:00
Max Howell
627034c441 Re-raise SystemExit so the correct exit code is set 
The reason we rescue this exception at all is because otherwise our general purpose Exception handler catches it.
 2009-11-11 18:56:37 +00:00
Adam Vandenberg
5e915653d7 Be specific about 3.1 point release. 2009-11-11 10:49:01 -08:00
Max Howell
fffa3eb22f dump_config for certain exceptions 
Ideally we could do a get request and fill in the issue form at GitHub. Presumably though, we'd only do this if the user typed brew report or somesuch.

Someone should get that implemented!
 2009-11-11 18:43:03 +00:00
Max Howell
8c21cd4c64 It's about time we bumped the version eh? 0.5 2009-11-11 18:43:03 +00:00
Max Howell
a0b89fe9a3 Include macports or fink info with brew --config 2009-11-11 18:43:02 +00:00
Max Howell
450845889b Include HEAD SHA with brew --config 2009-11-11 18:37:13 +00:00
Max Howell
45a1a2ba3c Tty.em; bold white underlined 2009-11-11 18:36:50 +00:00
Max Howell
fd3ddf8a72 Disable watch_out_for_spill temporarily 
It's a great feature but it seems to conflict with our new system() replacement. Clearly the bug is still in our system() but what exactly it is is not clear and this bug sucks.

See Homebrew/homebrew#124
 2009-11-11 17:29:34 +00:00
Max Howell
a46206bdc9 Ignore spill in all /*/Library/Caches 2009-11-11 17:29:34 +00:00
Max Howell
8e3f846911 My idea of tidy, sorry Adam… 2009-11-09 18:48:05 +00:00
Max Howell
b99324fbeb DRY gcc_build and llvm_build 2009-11-09 18:47:26 +00:00
Adam Vandenberg
20d7ef3d45 Add OS X, Ruby, compiler & hardware info to --config 2009-11-09 18:35:39 +00:00
Max Howell
04f3ddeac0 Ignore stdout during GitDownloadStrategy.stage 2009-11-09 18:24:36 +00:00
Max Howell
75c7c942a1 Don't ignore interupts during Formula.system 
As I understand it (I tested too), signal propogation is handled by the parent Ruby process. However this was working mostly anyway. So I don't fully understand what is going on. However this seems to not hang in Process.wait where it was before for one test case.
 2009-11-09 17:55:13 +00:00
Max Howell
1da26d89ea Don't use Kernel.system much 
It just seems to behave strangely with SIGINT. Eg. SIGINT causes tar to exit, but the SIGINT is ignored by our process. This is not the case when used with curl.
 2009-11-09 17:55:11 +00:00
Max Howell
590f64e302 Don't error out if .DS_Store is in a keg 2009-11-09 17:55:06 +00:00
Max Howell
20b7fa6ef8 Don't watch for spill for Quicktime stuff 2009-11-08 22:00:03 +00:00
Max Howell
bc364655fc Don't error out before Cellar is created 
We need a test for this.
 2009-11-08 16:23:08 +00:00
Max Howell
c35887b6f3 Warn users about Xcode versions that are too old 
Closes Homebrew/homebrew#116
 2009-11-08 16:22:15 +00:00
Max Howell
80b555057c Ignore spill for certain system paths 2009-11-08 15:21:15 +00:00
Max Howell
fe15b9b003 Reap the process or make zombies 2009-11-08 15:21:15 +00:00
Max Howell
96d790edc1 Simplify the library path determination code a little 2009-11-08 15:21:15 +00:00
Max Howell
86516e563f Set ENV[HOMEBREW_BREW_FILE] 
Thus install.rb gets the path to the instantiating brew process rather than whichever is first in the PATH. Not to mention Homebrew doesn't *have* to be in the PATH.
 2009-11-08 15:21:14 +00:00
Max Howell
6b18d5572d Rename BREW_FILE HOMEBREW_BREW_FILE 
Because it's a global.h constant and that file can be included by other projects.
 2009-11-08 15:21:14 +00:00
Max Howell
4266d6c1c7 Ensure BREW_FILE is an absolute path 
It's a constant and Dir.getwd can change.
 2009-11-08 15:21:14 +00:00
Max Howell
2dc17b19f4 List --HEAD/-H in brew usage 2009-11-08 15:21:14 +00:00
Max Howell
22afc5e1c7 Use our own popen implementation in Formula.system 
The rationale here is that the --verbose mode had a bug where it didn't escape its parameters properly. Which caused ocassionally cryptic issues.
 2009-11-08 15:21:09 +00:00
Max Howell
1e879eaee8 Propagate exit status in ExecutioError exception 2009-11-07 18:22:36 +00:00
Max Howell
0ec10c68ca Include /Library in watch_out_for_spill 2009-11-07 18:22:36 +00:00
Max Howell
455271ed12 Blacklist RubyGems creation 2009-11-07 18:22:36 +00:00
Max Howell
fba0a5c5cd brew edit works if the file in question won't parse 2009-11-07 18:22:36 +00:00
Max Howell
57fc32d279 Solve the brew install, brew rm, brew install problem for HEAD formula 
The problem was that git checkout -b doesn't work the second time. This simple solution works by never creating a local branch.
 2009-11-07 18:22:36 +00:00
Erik Kastner
96de6ba870 adding zsh completion 2009-11-07 18:22:36 +00:00
Max Howell
a4e86bb326 Move BuildError and ExceutionError to global.h 
More sensible, and fixes brew
 2009-11-07 18:22:35 +00:00
Max Howell
6386ce4df5 Provide system info for build errors 2009-11-07 18:22:34 +00:00
Max Howell
7ec2874746 Fix ENV.m32 when LDFLAGS already exists 2009-11-07 18:22:34 +00:00
Max Howell
c5eb65332d Don't require hardware.rb globally 2009-11-07 18:22:33 +00:00
Max Howell
107235c5dd Typo correction 2009-11-07 18:22:33 +00:00
Max Howell
173f5f4a87 Fixed SIGINT handling, so we can have our newline 
We trap the INT in the install process now so the newline race condition is avoided. Much neater and more polished now.
 2009-11-07 18:22:33 +00:00
Max Howell
e587c68a2a Better error for unknown brew commands 2009-11-07 18:22:33 +00:00
Max Howell
3d89578b5c Use HOMEBREW_REPOSITORY for brew log 2009-11-07 18:22:33 +00:00
Max Howell
8f46b32d26 Raise if ARGV.next is out of bounds 2009-11-07 18:22:33 +00:00
Max Howell
78d7cbc812 Slightly better ARGV.usage for contribution 2009-11-07 18:22:33 +00:00
Max Howell
8081a95c4a Better errors if missing keg or formula arguments 2009-11-07 18:22:33 +00:00
Max Howell
03ca3e24d0 Don't throw if named.empty? 
Generally this isn't desired or useful.
 2009-11-07 18:22:33 +00:00
Max Howell
794a55a72b brew install improvements 
Couldn't make this atomic, apologies.

Fixes a few things, like deps failing to build not aborting the install.
--force now works properly again.

Overall more robust code. I went back over it all and gave it a lot of
thought.

Cleaner separation of logic. Less code in brew, now the only code there is
ARGV handling, and basic sanity checks.

Not extending ARGV or ENV in global now as that would propagate to other tools
or utilities you may write.
 2009-11-07 18:22:28 +00:00
Max Howell
e046e1e640 More useful Macports/Fink detection function 2009-11-04 16:27:37 +00:00