24630 Commits

Author SHA1 Message Date
Jack Nagel
66489b70d7 audit: only generate aliases list once 2013-05-07 18:40:14 -05:00
Jack Nagel
fedf9ddae3 audit: only set up the build environment once 2013-05-07 18:39:45 -05:00
Misty De Meo
57534cf7b2 ArchRequirement: takes a single arch
Fixes Homebrew/homebrew#19646.
2013-05-06 22:50:01 -05:00
Jack Nagel
7412a71e9d Fix type error in conflict_requirement
Fixes Homebrew/homebrew#19636.
2013-05-06 17:49:36 -05:00
Jack Nagel
5bf652ecdd Avoid extra array allocations 2013-05-06 16:52:26 -05:00
Jack Nagel
b322020338 Reduce allocations in dependency construction
By always passing around a single, unnested array rather than splatting
and then defensively flattening and compacting things, we can avoid
allocating a bunch of unnecessary arrays. This gives a performance boost
of roughly 4% when enumerating 2500 formulae, and has the side effect of
cleaning up the dependency API.
2013-05-06 16:08:50 -05:00
Jack Nagel
894a6c9776 TypeError is appropriate here 2013-05-06 16:08:49 -05:00
Jack Nagel
666b48e391 Check Requirement before Dependency
It's much more likely that an instance of Requirement is passed.
2013-05-06 16:08:49 -05:00
Jack Nagel
f47e43aa2b Extract string and class logic from parse_spec 2013-05-06 16:08:49 -05:00
Misty De Meo
9ec3102e57 Formula: fix to_hash output for bottles 2013-05-05 10:58:12 -05:00
Adam Vandenberg
9f853973d7 superenv: svn should provide a list, not a string
Closes Homebrew/homebrew#19601.
2013-05-03 15:53:45 -07:00
Adam Vandenberg
1c12c8b7a2 Add frameworks helper to formula 2013-05-03 11:41:55 -07:00
Mike McQuaid
c479c680b8 brew-test-bot: fix output handling. 2013-05-03 17:17:12 +01:00
Mike McQuaid
a70c44993f brew-test-bot: handle empty log files. 2013-05-03 16:39:14 +01:00
Jack Nagel
9dd7672ae7 info: re-raise on blacklist miss 2013-05-02 21:34:48 -05:00
Mike McQuaid
80a73bea79 brew-test-bot: force checkout master with cleanup. 2013-05-02 22:02:28 +01:00
Adam Vandenberg
afd2dde474 --env: show HOMEBREW_CC in superenv
Closes Homebrew/homebrew#18247.
2013-05-02 11:36:30 -07:00
Adam Vandenberg
070758689b Update HOMEBREW_DEBUG in man page.
Closes Homebrew/homebrew#17344.
2013-04-30 13:46:57 -07:00
Jack Nagel
0bfcad4cd3 completion: avoid unnecessary brew invocations 2013-04-30 01:24:11 -05:00
Adam Vandenberg
b163ed03e9 info: try blacklist for unknown formula names
Closes Homebrew/homebrew#17399.
2013-04-29 10:12:40 -07:00
Jack Nagel
c2889de323 Avoid capturing groups when unnused 2013-04-27 15:21:06 -05:00
Jack Nagel
364c5c3473 Combine GitHub version regexes 2013-04-27 15:21:05 -05:00
Jack Nagel
16723afaa8 Only remove DS_Store on ENOTEMPTY 2013-04-27 15:21:05 -05:00
Jack Nagel
bffe090b21 Don't test error message
Now that we are testing for a custom exception type, we don't need to
make any assertion about the message.
2013-04-27 14:50:35 -05:00
Jack Nagel
9b5cb6cfb6 Allow brew versions to work with underspecified formulae 2013-04-27 14:44:48 -05:00
Jack Nagel
62db042277 audit: fix interpolation check
Fixes Homebrew/homebrew#19363.
2013-04-26 19:18:13 -05:00
Mike McQuaid
7b7d4d2f1b brew-tests: install deps before tests. 2013-04-26 22:32:26 +01:00
Mike McQuaid
17667c03d0 Add deps target to tests Rakefile for needed gems. 2013-04-26 22:32:26 +01:00
Misty De Meo
f4cf04b95e doctor: don't shell out in coreutils check 2013-04-25 18:23:43 -05:00
Misty De Meo
814b969963 doctor: add default-names findutils check
Fixes Homebrew/homebrew#19265.
2013-04-25 18:23:43 -05:00
Jack Nagel
b7066b6e74 Add a couple more version tests 2013-04-24 15:02:05 -05:00
Jack Nagel
be32a3ee88 Split up big version detection test 2013-04-24 15:01:54 -05:00
Jack Nagel
8a74e648e7 audit: warn about top-level methods 2013-04-22 15:19:03 -05:00
Simon Sigurdhsson
4f45077fde Remove global methods from formulae
Removes any global methods from formulae, and moves #kext_prefix (which
seems to be at least somewhat abstractable) into the Formula class. The
only formula with global methods is now aspell; it (and its generating
script in contrib) has been changed to prefix that method with
`aspell_`, to minimize the risk of name collisions.

Closes Homebrew/homebrew#19331.
Closes Homebrew/homebrew#19343.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-04-21 23:48:50 -05:00
Mike McQuaid
9234a82a7b Update SUPPORTERS.md 2013-04-21 18:06:55 +02:00
Jack Nagel
51bfd4fc1e Avoid calling to_s on the same Pathname multiple times 2013-04-20 13:50:42 -05:00
Jeremy Walker
1e2cb0fd65 SUPPORTERS.md: turn names into links.
Closes Homebrew/homebrew#19324.
2013-04-20 15:58:15 +01:00
Jack Nagel
368ba306d7 Don't accept Formula objects as dep specs
It was pointed out that this isn't used at all.
2013-04-18 01:17:15 -05:00
Jack Nagel
7ea15918bb Reorder dep spec types by frequency 2013-04-17 14:12:41 -05:00
Adam Vandenberg
a7714a804b Add :hg build requirement.
Closes Homebrew/homebrew#19074.
2013-04-17 10:01:38 -07:00
Xiyue Deng
869642e635 Fix download strategy for SVN HEAD
After converting to Pathname to create paths, using '+=' will result in
path concatenation by '/', which result in weird path like
'gcc--svn/-HEAD'. This patch should fix this.

Closes Homebrew/homebrew#19233.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-04-16 16:17:48 -05:00
Jack Nagel
b7c0c53ffc VersionElement: attempt most likely match first 2013-04-16 14:56:22 -05:00
Jack Nagel
42da1295ce Only call Pathname#to_s once per Version object 2013-04-16 14:32:32 -05:00
Jack Nagel
1426b92a82 Only dup and shift when specs hash is populated 2013-04-16 14:18:23 -05:00
Jack Nagel
0fb4f9c426 Reduce repeated array inclusion check
Currently we check if "tag" is present in LANGUAGE_MODULES for every
String dep, even if tag is nil. Stop doing this, and make the
LANGUAGE_MODULES array into a Set instead to improve lookup performance.
2013-04-16 09:53:02 -05:00
Jack Nagel
3a0726406b Add tests for FormulaPin and simplify implementation 2013-04-16 01:58:11 -05:00
Ashley Towns
d600d6c0be Update for Xcode 4.6.2
Closes Homebrew/homebrew#19227.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-04-15 21:44:12 -05:00
Jack Nagel
d504d50dcb Don't create MacOS.version multiple times 2013-04-15 16:04:35 -05:00
Jack Nagel
466a32df02 Optimize Version#<=> 2013-04-15 15:00:57 -05:00
Jack Nagel
49682e854d Avoid expensive Pathname concatenation 2013-04-15 15:00:57 -05:00