24630 Commits

Author SHA1 Message Date
Rylan Polster
2a941ec6b1 audit, tap: incorporate suggestions from code review 2020-11-05 16:14:09 -05:00
Mike McQuaid
0606c9fd82
outdated/upgrade: fix upgrade alias edge case.
If you're going to follow an alias to find the outdated formula then
ensure that the latest one isn't already installed.

Fixes https://github.com/Homebrew/homebrew-core/issues/63971
2020-11-05 20:33:51 +00:00
Tie
afd7bb8889 make suggestions 2020-11-05 12:27:22 -05:00
Rylan Polster
089810709c audit: add tap_audit_exceptions attribute 2020-11-05 09:27:06 -05:00
Jonathan Chang
1b95059c2b
Restrict audit to homebrew/core
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-11-06 00:49:48 +11:00
Jonathan Chang
777dc10aa8 audit: deprecate requirements in core
This strict audit ensures that new formulae that depend on Requirements
like :x11, :java, and :osxfuse are not introduced into homebrew/core.
2020-11-06 00:20:34 +11:00
Mike McQuaid
0e36cdcf0f
Merge pull request #9051 from MikeMcQuaid/versioned-audit-fix
audit: tweak versioned formulae logic (again).
2020-11-05 11:03:38 +00:00
Mike McQuaid
c4fc81b26b
audit: tweak versioned formulae logic (again).
References https://github.com/Homebrew/brew/pull/9027#issuecomment-722042589
2020-11-05 10:28:02 +00:00
Rylan Polster
6171b51a82 audit: migrate VERSIONED_HEAD_SPEC_ALLOWLIST to Homebrew/core 2020-11-05 01:43:01 -05:00
Rylan Polster
fe1c7c16b0 audit: add tap audits for audit exceptions 2020-11-05 01:25:13 -05:00
Tie
b5d5be3474 fix typecheck 2020-11-05 00:53:12 -05:00
Rylan Polster
f33a4bff37 tap: no-op on invalid audit exception files
Also shift logic to directory-based organization instead of a single file with all lists
2020-11-04 23:43:22 -05:00
Rylan Polster
e1f463ff26 audit: use name tap_audit_exceptions 2020-11-04 23:42:42 -05:00
Tie
b5427e5095 fix style issues 2020-11-04 18:53:03 -05:00
Tie
10ae9bcde7 modify autoremove to use uninstall 2020-11-04 17:15:32 -05:00
Dawid Dziurla
0fa417706a cmd: add autoremove command 2020-11-04 17:15:32 -05:00
Tie
4127a7b624 move some uninstall tests to new file 2020-11-04 17:14:43 -05:00
Tie
30a3561448 move uninstall logic to new file 2020-11-04 16:45:52 -05:00
Tie
f95e1729a2 move logic from leaves to formula 2020-11-04 16:45:14 -05:00
Mike McQuaid
cbb0b87e75
Merge pull request #9013 from hyuraku/add_how-to-set-env_to_doc
how to set ENV in doc
2020-11-04 14:21:20 +00:00
Mike McQuaid
3e36285575
Merge pull request #9028 from MikeMcQuaid/update-test-tweaks
update-test: more improvements.
2020-11-04 13:58:45 +00:00
hyuraku
b193564050 how to set ENV for formula install 2020-11-04 22:49:33 +09:00
Mike McQuaid
878cbb634f
update-test: more improvements.
- Explain why `HOMEBREW_UPDATE_TEST` is set and what it does.
- Avoid auto-updating (this should already be not happening but let's
  make sure).
- Set environment variables to ensure we're testing the default update
  behaviour (rather than deferring to user configuration).
- Use `HOMEBREW_BREW_GIT_REMOTE` as well as setting
  `git config remote.origin.url` ourselves.
- Run `brew help` quietly first to hide irrelevant portable Ruby output.
- Run `brew update --verbose --debug` to get even more output on
  failure.

Fixes https://github.com/Homebrew/brew/issues/8979
2020-11-04 13:22:59 +00:00
Mike McQuaid
18e19df9b8
Merge pull request #9046 from MikeMcQuaid/diagnostic-deleted-tweaks
diagnostic: improve deleted message.
2020-11-04 11:27:11 +00:00
Mike McQuaid
7e2b228460
diagnostic: improve deleted message.
Raised in #9036.
2020-11-04 10:20:14 +00:00
Mike McQuaid
b2ea420e7a
Merge pull request #9045 from MikeMcQuaid/link-no-formula
link: link kegs without formulae.
2020-11-04 10:18:35 +00:00
Mike McQuaid
1f971ba2a0
link: link kegs without formulae.
Needed for `brew diy`.

Fixes #9036
2020-11-04 08:57:30 +00:00
Michka Popoff
084f2e75eb
Merge pull request #8907 from iMichka/onlinux
formula: add on_linux and on_macos blocks
2020-11-03 23:30:37 +01:00
Michka Popoff
8b85ef2e88 formula: add on_linux and on_macos blocks
for install and others
2020-11-03 22:54:07 +01:00
Rylan Polster
55e86125a6 audit: don't fail if exception list doesn't exist 2020-11-03 14:38:44 -05:00
Rylan Polster
869941bccd audit: migrate throttle list to Homebrew/core 2020-11-03 13:06:33 -05:00
Mike McQuaid
4a505fce31
Merge pull request #9038 from MikeMcQuaid/ls-flags-again
list: more parameters fixes.
2020-11-03 17:30:52 +00:00
Mike McQuaid
438874af3c
list: more parameters fixes.
- Remove incorrect `--formula` requirements.
- Fix bad `OptionConstraintError` output message.

Fixes #9037.
2020-11-03 16:50:03 +00:00
Mike McQuaid
dbdf7cf265
Merge pull request #9035 from MikeMcQuaid/ls-flags
list: fix flag handling.
2020-11-03 15:00:25 +00:00
Mike McQuaid
5adb76a5ba
list: fix flag handling.
Fix `-1` and other flags so they're handled correctly with casks. Use
the "right" exceptions for declaring invalid combinations and change
their parent class so that `--help` is printed nicely too.

Fixes #9033
2020-11-03 12:29:58 +00:00
Mike McQuaid
18c638de30
Merge pull request #9029 from MikeMcQuaid/diy-downcase
diy: downcase names.
2020-11-03 11:47:13 +00:00
Mike McQuaid
9115ef7e8e
Merge pull request #9034 from EricFromCanada/1password-image
README: update 1Password image
2020-11-03 11:26:43 +00:00
EricFromCanada
7106d762f4 README: update 1Password image 2020-11-02 18:14:34 -05:00
Mike McQuaid
5465a866a9
Merge pull request #9022 from chenrui333/bypass-artifact-check-for-vifm
audit: bypass artifact check for vifm-osx-0.11
2020-11-02 16:57:33 +00:00
Mike McQuaid
488a43ecd7
Merge pull request #9027 from Homebrew/revert-9016-revert-9009-improve-versioned-linking
Improve @-versioned formulae linking.
2020-11-02 14:33:32 +00:00
chenrui
f41afe6256
audit: use the specific url for vifm allowlist
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-11-02 09:10:44 -05:00
Mike McQuaid
5648ae12f2
Merge pull request #9031 from MikeMcQuaid/keg-for-realpath
Keg.for: handle non-existent path.
2020-11-02 14:09:32 +00:00
Mike McQuaid
05bbb41022
Merge pull request #9030 from MikeMcQuaid/gpg-tweaks
Unify and use Git username/email/GPG handling.
2020-11-02 14:09:08 +00:00
Mike McQuaid
5eebe35652
Merge pull request #9018 from acristoffers/patch-1
Fixes #9017
2020-11-02 14:06:43 +00:00
Álan Crístoffer
393291bc27
brew.fish: pass --formula to brew list.
`--formula` is now required for `brew list`, otherwise an error message
is printed.

Fixes #9017
2020-11-02 13:29:24 +00:00
Mike McQuaid
b54b022f73
Keg.for: handle non-existent path.
Otherwise `path.realpath` will raise `Errno::ENOENT` rather than the
expected `NotAKegError`.

Fixes https://github.com/Homebrew/brew/issues/9015
2020-11-02 12:56:59 +00:00
Mike McQuaid
4f3c590873
Unify and use Git username/email/GPG handling.
We're using essentially the same logic to setup Git for committing in
multiple places but the way we're doing so is inconsistent. Moved to
using two shared utility methods and use them consistently.
2020-11-02 12:21:18 +00:00
Mike McQuaid
a9c988772b
diy: downcase names.
Fixes #9026
2020-11-02 12:09:25 +00:00
Mike McQuaid
4ecd5d9824
Merge pull request #9023 from Homebrew/dependabot/bundler/Library/Homebrew/rspec-3.10.0
build(deps): bump rspec from 3.9.0 to 3.10.0 in /Library/Homebrew
2020-11-02 12:06:17 +00:00
Mike McQuaid
d6d38e35d4
Merge pull request #9021 from EricFromCanada/requirements-display
Update display of requirements
2020-11-02 11:58:01 +00:00