admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
35,755 Commits 15 Branches 471 Tags
Commit Graph

28897 Commits

Author SHA1 Message Date
Mike McQuaid
aa894fbfcd
Merge pull request #15127 from issyl0/tap-workflows-bump-actions-cache-version 
dev-cmd/tap-new: Use `actions/cache@v3` as v1 is very deprecated
 2023-04-03 08:47:16 +01:00
Mike McQuaid
b10ba24c80
Merge pull request #15123 from carlocab/only_dependencies_earlier 
install: check for `--only-dependencies` flag earlier
 2023-04-03 08:44:38 +01:00
Mike McQuaid
85a1b79154
service: fix typo. 2023-04-03 08:41:21 +01:00
Mike McQuaid
830ec2847b
Merge pull request #15114 from dduugg/ignorable-type 
Enable typing in Ignorable
 2023-04-03 08:37:34 +01:00
Markus Reiter
6e5ab67838
Consider version of .apps containing installers. 2023-04-03 04:56:37 +02:00
Markus Reiter
cf7a9df923
Include screen savers in :extract_plist strategy. 2023-04-03 03:56:04 +02:00
Douglas Eichelberger
bc588cc04f Fix tests 2023-04-02 16:38:30 -07:00
Issy Long
28f8cbe8da
Handle when the URL has interpolation: use source not str_content 
- We see this a lot in real Casks.
 2023-04-02 23:39:43 +01:00
Issy Long
41c35986f8
Simplify the 'should not start with https?://' message wording 
Co-authored-by: Markus Reiter <me@reitermark.us>
 2023-04-02 22:43:57 +01:00
Issy Long
21da074346
Only 'verified' stanzas with 0 or >1 path components should end with "/" 
Handle good things like:

```ruby
url "https://example.org/download",
    verified: "example.org/download" # This is fine.
```

And bad things like:

```ruby
url "https://example.org/",
    verified: "example.org" # This should end with a slash.
```
 2023-04-02 22:26:23 +01:00
Douglas Eichelberger
4df5a80c73 brew style --fix 2023-04-02 12:25:55 -07:00
Douglas Eichelberger
0079cefc95 Enable types in remaining untyped extensions 2023-04-02 12:24:11 -07:00
Issy Long
17c0eaab25
Fix indentation of verified in url stanza examples 2023-04-02 16:41:29 +01:00
Issy Long
09ce7a1da6
dev-cmd/tap-new: Use actions/cache@v3 as v1 is very deprecated 
- We forgot about this workflow when we bumped the versions of our
  actual workflows as part of issue 14692.
 2023-04-02 15:43:24 +01:00
Issy Long
b586d97f84
rubocops/cask: Ensure that "verified" URLs with paths end with "/" 
- These were being fixed manually[1], so let's make a RuboCop for any
  further occurrences since this is a good rule to enforce[2].

[1] - https://github.com/Homebrew/homebrew-cask/pull/144179#issuecomment-1489857249
[2] - https://github.com/Homebrew/homebrew-cask/pull/80965#issuecomment-616232313
 2023-04-02 15:29:53 +01:00
Douglas Eichelberger
6397229f68 Enable types in extensions, etc. 2023-04-01 18:56:42 -07:00
Carlo Cabrera
6c3361e80f
install: check for --only-dependencies flag earlier 
Currently, doing `brew install --only-dependencies` with an unlinked
formula does nothing and returns a message saying the formula is already
installed but just not linked.

I think that we should just install the dependencies as requested here
instead of complaining that the formula isn't linked.

Before:

    ❯ brew unlink adplug
    Unlinking /usr/local/Cellar/adplug/2.3.3... 8 symlinks removed.
    ❯ brew install --only-dependencies adplug
    Warning: adplug 2.3.3 is already installed, it's just not linked.
    To link this version, run:
      brew link adplug

After:

    ❯ brew install --only-dependencies adplug
    ==> Fetching dependencies for adplug: libbinio
    ==> Fetching libbinio
    ==> Downloading https://ghcr.io/v2/homebrew/core/libbinio/manifests/1.5
    [snip]

See Homebrew/homebrew-core#127133 for additional context.
 2023-04-02 01:39:23 +08:00
David Baumgold
64ff386744 fix tests 2023-04-01 14:32:27 +02:00
David Baumgold
a62543f304 forgot splat 2023-04-01 13:36:58 +02:00
David Baumgold
5f51e1549c unless 2023-04-01 12:36:58 +02:00
David Baumgold
38a2703aa7 Python: allow --no-build-isolation for pip install 2023-04-01 11:31:29 +02:00
apainintheneck
39092fa629 service: handle string run cmd 
This was not handled at all during deserialization.
The string argument gets turned into an array internally
but we skip that to preserve all args in the @run_params
variable. That means that we have to handle strings when
deserializing too.
 2023-03-31 20:33:21 -07:00
Razvan Azamfirei
dfa7a60038
Feat 2023-03-31 21:23:09 -04:00
Issy Long
e9f233e333
Remove unused output_warnings? Cask audit method 2023-04-01 02:02:23 +01:00
Issy Long
df8e97fef6
Consolidate add_{warning,error} methods into one 
- Specify `strictish: true` in `add_error` to specify that it's not a
  super big critical error.
- These will be shown only if `brew audit --strict` is requested.
 2023-04-01 01:56:47 +01:00
Issy Long
2b8127d518
Turn cask warnings into errors when --strict is passed (or implied) 
- Ignore them and don't show them otherwise.
- Part three of issue 15074:
  > As a result, I propose that all current cask audit warnings are never
  > displayed as warnings but the underlying audit checks turned into
  > errors displayed only with --strict (or one of the other relevant
  > flags).
 2023-04-01 01:56:46 +01:00
Issy Long
a4e8f9e22b
audit: Make --display-failures-only the default for Casks 
- Cask warnings are really noisy and numerous. Let's only show them if
  the user passes `--strict` or something implying `--strict`, like
  `--new-cask`.
- Additionally remove `display_passes` since we would like silence if
  nothing is wrong with the cask, the same as with formula audits.
 2023-04-01 01:56:45 +01:00
Razvan Azamfirei
540a5b9d30
temp 2023-03-31 18:01:34 -04:00
Ruoyu Zhong
e3eb632034
dev-cmd/bump-cask-pr: fix sha265 typo 2023-04-01 01:07:21 +08:00
Markus Reiter
244359f314
Merge pull request #15088 from reitermarkus/cask-commit-format 
Make `bump-cask-pr` commit format more concise.
 2023-03-31 17:45:53 +02:00
Douglas Eichelberger
7dcabd466e Remove unnecessary T.let 2023-03-31 08:38:02 -07:00
Douglas Eichelberger
d1dfce578c Enable typing in Ignorable 2023-03-31 08:35:20 -07:00
Bo Anderson
8bafbcd65a
Split prof gems into their own group 2023-03-31 13:32:38 +01:00
Mike McQuaid
cfa427fbb2
Merge pull request #15098 from Homebrew/ghpr-create-mod 
github: set maintainer_can_modify for PR creation
 2023-03-31 11:00:41 +01:00
Mike McQuaid
4c4fb3b9a0
Merge pull request #15101 from Homebrew/dependabot/bundler/Library/Homebrew/net-http-persistent-4.0.2 
build(deps): bump net-http-persistent from 4.0.1 to 4.0.2 in /Library/Homebrew
 2023-03-31 10:38:40 +01:00
Dawid Dziurla
5e1253ba0d
github: set maintainer_can_modify for PR creation 2023-03-31 11:29:05 +02:00
Nanda H Krishna
6bf7788761
Merge pull request #15100 from Homebrew/dependabot/bundler/Library/Homebrew/rspec-mocks-3.12.5 
build(deps): bump rspec-mocks from 3.12.4 to 3.12.5 in /Library/Homebrew
 2023-03-31 04:43:13 -04:00
BrewTestBot
c5199a6198
Update RBI files for rspec-mocks. 
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
 2023-03-31 08:27:46 +00:00
BrewTestBot
60ff2b05de
Update RBI files for net-http-persistent. 
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
 2023-03-31 08:25:59 +00:00
BrewTestBot
62b7b43f5f
brew vendor-gems: commit updates. 2023-03-31 08:21:00 +00:00
Mike McQuaid
5f49293e5b
Merge pull request #15111 from Homebrew/revert-15089-head-get 
Revert "Remove `--request GET` workaround for HEAD requests."
 2023-03-31 09:19:27 +01:00
BrewTestBot
1529f303e6
brew vendor-gems: commit updates. 2023-03-31 08:18:53 +00:00
dependabot[bot]
44894676ff
build(deps): bump rspec-mocks from 3.12.4 to 3.12.5 in /Library/Homebrew 
Bumps [rspec-mocks](https://github.com/rspec/rspec-mocks) from 3.12.4 to 3.12.5.
- [Release notes](https://github.com/rspec/rspec-mocks/releases)
- [Changelog](https://github.com/rspec/rspec-mocks/blob/main/Changelog.md)
- [Commits](https://github.com/rspec/rspec-mocks/compare/v3.12.4...v3.12.5)

---
updated-dependencies:
- dependency-name: rspec-mocks
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-03-31 08:14:33 +00:00
dependabot[bot]
758071bad7
build(deps): bump net-http-persistent in /Library/Homebrew 
Bumps [net-http-persistent](https://github.com/drbrain/net-http-persistent) from 4.0.1 to 4.0.2.
- [Release notes](https://github.com/drbrain/net-http-persistent/releases)
- [Changelog](https://github.com/drbrain/net-http-persistent/blob/master/History.txt)
- [Commits](https://github.com/drbrain/net-http-persistent/compare/v4.0.1...v4.0.2)

---
updated-dependencies:
- dependency-name: net-http-persistent
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-03-31 08:14:09 +00:00
Mike McQuaid
0d17bbbec6
Merge pull request #15104 from dduugg/enable-io-types 
Enable IO and UpdateTest types
 2023-03-31 09:12:25 +01:00
Mike McQuaid
ec15acf7dc
Revert "Remove --request GET workaround for HEAD requests." 2023-03-31 09:07:02 +01:00
Nanda H Krishna
b8fb963516
dev-cmd/tests: temporary fix for BuildPulse failure 2023-03-31 03:50:05 -04:00
Ruiyang Wu
007c896c97 Fix brew install --skip-post-install 
Previous #15042 doesn't pass the flag all the way to
`FormulaInstaller.new`
 2023-03-30 21:08:40 -04:00
Douglas Eichelberger
f9e512bf83 Enable update-test types 2023-03-30 17:31:07 -07:00
Douglas Eichelberger
4f5fc770f6 rm popen sigs 2023-03-30 17:22:02 -07:00