admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
34,539 Commits 15 Branches 471 Tags
Commit Graph

2655 Commits

Author SHA1 Message Date
Mike McQuaid
0465278254 brew-aspell-dictionaries: move to homebrew/core. 
Experiment with moving this from Homebrew/brew to Homebrew/homebrew-core
(to allow future additions of formula-specific `cmd`s).
 2017-12-04 16:13:57 +00:00
Martin Schimandl
0db069602e Refactor: Move FormulaAudit.check_http_content to utils/curl 2017-12-03 14:02:55 +01:00
Mike McQuaid
fb6cf0c3f8 More environment filtering fixes 
- Make `brew pull` pass through Git environment variables
- Whitelist all `TRAVIS_` variables.
 2017-11-27 10:48:03 +00:00
ilovezfs
590ba4cbf6 bump-formula-pr: fix for when hub isn't configured 2017-11-21 08:16:12 -08:00
Mike McQuaid
28f4d68b31 bottle: use HOMEBREW_GIT_* vars. 
This allows them to be passed through from `brew test-bot`.
 2017-11-18 11:22:46 +00:00
Mike McQuaid
441c212f2d
Merge pull request #3416 from zmwangx/bump-formula-pr-fix-message 
bump-formula-pr: --message: add newlines before and after hr
 2017-11-10 17:53:10 +00:00
Mike McQuaid
127bdfdc71 bump-formula-pr: use HOMEBREW_BROWSER. 2017-11-07 07:54:34 +00:00
Mike McQuaid
3f8f2c6726 bump-formula-pr: use GitHub vars under env filter. 
Ensure that the various variables are passed through and reset
correctly. If we end up doing this in a bunch of places we may add some
helpers to simplify this.
 2017-11-07 07:54:34 +00:00
Zhiming Wang
04367c4daf
bump-formula-pr: --message: add newlines before and after hr 
Without an empty line before the horizontal rule (---), "Created with `brew
bump-formula-pr`." is treated as a setext header.

The newline before the hr is not part of the heredoc because putting it in
would trip up Rubocop.
 2017-11-03 10:02:26 -04:00
Mike McQuaid
6ddf3f8796 bump-formula-pr: add --no-browse option. 
If `--no-browse` is passed, don't pass the `--browse` argument to `hub`
which opens the pull request URL in a browser. Instead, output it to the
command line.
 2017-10-30 09:14:53 +00:00
Mike McQuaid
e88fd4a868 bump-formula-pr: always use HOMEBREW_PATH. 
Fixes this when using environment filtering.
 2017-10-28 21:46:30 +01:00
Mike McQuaid
7f46dcfa35 Merge pull request #3313 from GauthamGoli/audit_line_rubocop_part_4_rebase_attempt_1 
audit: Port line_problems to rubocop and add tests part 4
 2017-10-24 10:36:31 +01:00
Shaun Jackman
f9d42659ea pull: Fix pull --bottle 1234 
Fix the error:
Error: undefined method `casecmp' for nil:NilClass
 2017-10-22 08:52:16 -07:00
Gautham Goli
7b2fab8ec5 Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1 2017-10-21 13:53:44 +05:30
Gautham Goli
bdc7eba4b3 Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1 2017-10-21 01:48:00 +05:30
Mike McQuaid
76cd7c7949 Merge pull request #3319 from reitermarkus/squiggly-heredocs 
Use “squiggly” heredocs.
 2017-10-20 14:10:50 +01:00
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
Shaun Jackman
3ee3b78fbd pull: Move test_bot_user to a new module GitHub 
Address the style issue:
C: Module has too many lines. [364/360]
 2017-10-17 17:11:26 -07:00
Shaun Jackman
9cd4fff051 pull: Add --test-bot-user 
Infer the name of the test-bot GitHub user if it is not provided.
 2017-10-17 16:53:12 -07:00
Shaun Jackman
76021db602 pull: Add --bintray-org 
Infer the name of the Bintray organization if it's not provided.
 2017-10-17 16:53:12 -07:00
Mike McQuaid
77f3fcf254 Merge pull request #3293 from DomT4/predicate_audit 
audit: more *_predicate nudging/tweaks
 2017-10-17 21:12:21 +01:00
Gautham Goli
7fa51f71f1 Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1 2017-10-13 19:50:46 +05:30
Dominyk Tiller
0865ab0d1b audit: nudge to use predicate for 'executable?' as well 2017-10-10 15:45:41 +01:00
Viktor Szakats
811f5fd145 pull: fix bintray verification failing due to redirection 2017-10-10 13:35:49 +00:00
Dominyk Tiller
a0f4861934
audit: broaden refute_predicate nudge 2017-10-09 16:46:01 +01:00
Mike McQuaid
56458f03fc Merge pull request #3277 from sjackman/audit-notable 
audit: Silence not notable on non-Homebrew taps
 2017-10-08 13:41:15 -07:00
Shaun Jackman
53dd0e3f28 audit: Silence not notable on non-Homebrew taps 
Silence "GitHub repository not notable" on non-Homebrew taps.
 2017-10-08 10:35:53 -07:00
Markus Reiter
175ca909ee Clean up code style and remove .rubocop_todo.yml. 2017-10-08 16:10:37 +02:00
Dominyk Tiller
2a25825a12
audit: tweak assert/refute_predicate audit 
Addresses some of the issues I raised in https://github.com/Homebrew/homebrew-core/pull/19127#issue-263566817.
Would still like to work out a way to check `File.exist?`-style language
inside the `test do` block exclusively but for now it's better to be
too conservative on the audit than to be overly-zealous and flag too
much.
 2017-10-08 06:54:49 +01:00
Dominyk Tiller
4e957165d1
audit: prefer assert/refute_predicate over File.exist? 2017-10-05 02:52:21 +01:00
Markus Reiter
7cadff0a33 Use PATH where possible. 2017-09-29 22:18:24 +02:00
Mike McQuaid
bcca2a7c6b brew: handle Ruby 2.3 more gracefully. 
- `brew.rb` needed updated to fail unless on Ruby 2.3
- `brew update` should unset `HOMEBREW_RUBY_PATH` to ensure that this
  doesn't "stick" on a Ruby 2.0 version after a portable Ruby has been
  installed.
 2017-09-29 19:53:50 +01:00
Mike McQuaid
134bd00d10 audit: don't care about shadowing official taps. 
We're trying to import all of these formulae anyway.
 2017-09-29 16:23:02 +01:00
ilovezfs
feda0242be bump-formula-pr: fix duplicates check 
`return unless pull_requests && !pull_requests.empty?` and
`return unless pull_requests&.empty?` are not equivalent.
 2017-09-25 23:03:19 -07:00
Mike McQuaid
cf5fdeef1d Rubocop: manual rule fixes. 2017-09-24 21:23:59 +01:00
Mike McQuaid
01e9ec9a9f Rubocop: automatic rule fixes. 2017-09-24 21:23:59 +01:00
ilovezfs
28c7838450 audit: also skip homebrew/science duplicates found by search_taps 
Follow-up to #3202.
 2017-09-24 00:29:34 -07:00
ilovezfs
e984623214 audit: don't check for homebrew/science duplicates 
It's just noise to turn the migration PRs red over expected duplicates.
 2017-09-23 23:00:29 -07:00
Mike McQuaid
56ab1ef5a8 audit: hack around El Capitan audit failure. 2017-09-23 21:10:25 +01:00
Mike McQuaid
ffdda0eb9f Tweaks for older Mac OS X versions. 
- `brew update` should try to install `curl` before `git` on older
  versions of Mac OS X where it is needed for accessing modern SSL
  certificates.
- We don't need an HTTP mirror for `git` because `curl` will already be
  installed before it is downloaded.
- Don't recommend GCC on Mac OS X versions where it can't be built with
  the default system compiler.
- Start using the Homebrew `curl` on Mac OS X versions where it is
  needed as soon as it is installed.
 2017-09-16 12:41:08 +01:00
Mike McQuaid
2e43d95498 audit: fix check_http_content args. 2017-09-15 10:17:40 +01:00
Mike McQuaid
03ace9b110 Require more HTTP mirrors for old OS X versions. 
This allows the bootstrap of `curl` and `git` on versions of Mac OS X
that cannot reliably download from HTTPS servers any longer. Once these
are both installed users are able to update Homebrew and download files
securely.

Also, as we're doing this, don't point 10.5 users to Tigerbrew as they
are already given caveats for using Homebrew itself.
 2017-09-14 19:58:37 +01:00
Mike McQuaid
ef60688704 Merge pull request #3126 from DomT4/curl_audit 
audit: stop demanding a HTTP HEAD mirror for curl
 2017-09-12 15:48:11 +01:00
Mike McQuaid
929edca531 Merge pull request #3061 from mislav/hub-fork-forward-compat 
bump-formula-pr: forward compatibility with `hub fork`
 2017-09-08 18:46:07 +01:00
Mike McQuaid
bf0ab938e7 Merge pull request #3091 from GauthamGoli/audit_line_rubocop_part_3 
audit: Port line_problems to rubocop and add tests part 3
 2017-09-05 18:10:02 +01:00
Dominyk Tiller
9562cceef1
audit: stop demanding a HTTP HEAD mirror for curl 
Not sure if this is how you want to handle it but having a HEAD mirror
for `curl` is just silliness.

Ref: e36b95849a
 2017-09-05 03:35:44 +01:00
Gautham Goli
d45ff9c0fd audit: Add a global flag to silent warning when auditing 2017-09-04 23:57:09 +05:30
Gautham Goli
4ec26aea40 audit: Port audit_class to rubocop, add tests and autocorrect 2017-09-04 23:43:42 +05:30
Gautham Goli
267def28fa audit: Port rules from line_problems to rubocop part 3 2017-09-04 15:05:43 +05:30
Mike McQuaid
73cd2a1db8 Merge pull request #3119 from MikeMcQuaid/audit-subversion-url-fix 
audit: fix subversion remote check logic.
 2017-09-04 01:54:28 +01:00