152 Commits

Author SHA1 Message Date
Markus Reiter
fd477365b5 curl_download: Retry once on error 33. 2017-08-10 22:51:09 +02:00
Markus Reiter
2cba322200 Allow curl args to be overriden. 2017-08-08 23:06:40 +02:00
Markus Reiter
ae4bafdb36 Simplify CurlDownloadStrategy. 2017-08-08 18:10:13 +02:00
ilovezfs
986887b413 Revert "Refactor SVN and cURL download strategies." 2017-08-07 14:31:56 -07:00
Markus Reiter
dc5a2c1764 Simplify CurlDownloadStrategy. 2017-08-07 21:31:17 +02:00
Mike McQuaid
baa61f5a6e Use https for all docs.brew.sh links.
May as well use the more secure link when possible.
2017-07-27 15:59:37 +01:00
Markus Reiter
a1f9032b95 🗑️ Use AppleScript instead of Swift for trashing. 2017-06-24 09:15:37 +02:00
Markus Reiter
fc739bf82e Add trash util. 2017-06-20 15:53:33 +02:00
Mike McQuaid
cd7e3cd39d Merge pull request #2778 from jasonkarns/tap-full-name
refactor: DRY up redundant formulations of {#user}/homebrew-{#repo}
2017-06-19 15:46:48 +01:00
Jason Karns
c2899b6559
Tap learns to form its own full_name
full_name is formed from `{user}/homebrew-{repo}` and is always
lowercase.
2017-06-19 09:42:59 -04:00
Mike McQuaid
021cef4b2b Autocorrect Rubocop Style/SpecialGlobalVars. 2017-06-12 09:11:42 +01:00
Mike McQuaid
99c897acad BuildError: report options to analytics.
Without this it's not easy to make much sense of these failures.
2017-06-09 14:53:01 +03:00
Mike McQuaid
5367f1b408 analytics: remove unused analytics.
We didn't end up using the `screenview` and `exception` analytics as
much as expected so let's remove them and focus on stuff that's
formula-specific.
2017-06-07 16:34:54 +01:00
Mike McQuaid
2cf2c020ba tty: handle non-tty stdin.
When stdin is not a tty then the message `stty: stdin isn't a terminal`
will be produced. Silence this message and fall back to `tput` when it
fails and default to 80 if we get no results at all.

Follow-up from #2714.
2017-06-07 06:57:50 +01:00
Enrico Ghirardi
a9c83f14a7
Use stty instead of tput to get terminal width
Fixes https://github.com/Homebrew/brew/issues/2707
2017-06-02 17:00:52 +02:00
Markus Reiter
d700a5ba18 Use Formatter::pluralize where possible. 2017-05-29 17:50:13 +02:00
Markus Reiter
dc4f303937 Remove unused popen_read_text method. 2017-05-29 01:45:05 +02:00
Misty De Meo
67dc3323ed
lock: simplify ruby conditional 2017-05-24 09:12:21 -07:00
Misty De Meo
94ed3e3583
lock: check tools are executable 2017-05-23 18:36:06 -07:00
Misty De Meo
129ee966f8 Optionally use Python's flock instead of Ruby's
Ruby first gained flock in 1.8.7, which is a problem since we're using
this lock utility in `vendor-install` in order to install a newer Ruby.

Fortunately, Python 2.3(!) has flock support.
2017-05-23 17:50:22 -07:00
Markus Reiter
1a96dc39d1 Add audit check to see if both version and checksum changed. 2017-05-22 02:01:57 +02:00
Markus Reiter
5828eefd01 Remove to_s from some Pathnames. 2017-05-08 13:37:28 +02:00
Markus Reiter
133e5ddf6a Remove unnecessary block. 2017-04-25 12:29:01 +02:00
Markus Reiter
2bda194bd9 Add GitHub::search_code method. 2017-04-25 12:29:01 +02:00
Mike McQuaid
45a7730f61 Fix and remove various TODOs.
Fix those that can be done so without tearing Homebrew to pieces and
remove the comments for those that can never be done.
2017-04-23 15:10:18 +01:00
Mike McQuaid
ba3c46d24f More deprecations.
Deprecate more methods. Internal APIs have been verified to be unused
elsewhere and removed. External APIs have had deprecation methods added.
Existing deprecations have been either upgraded to produce warnings or
no longer deprecated and the reasoning documented.
2017-04-22 16:28:07 +01:00
Mike McQuaid
d0bbadde22 github: don't print when searching PRs. 2017-03-23 08:39:28 +00:00
Markus Reiter
44d367edca Deprecate #plural. 2017-03-11 21:16:37 +01:00
Markus Reiter
c594ffefbc Add Formatter::pluralize. 2017-03-11 21:12:51 +01:00
Mike McQuaid
0a8c8f90b6 Merge pull request #1708 from joshka/feature/install-tap-cmd-completions
install tap cmd completions
2017-02-27 08:42:17 +00:00
Joshua McKinney
25396d9c4d Install tap command completions and manpages
Taps can include completion scripts for external commands under
`completions/bash`, `completions/fish`, or `completions/zsh`. `brew tap`
will automatically install these into the correct directories during
install.
2017-02-26 15:40:52 -06:00
David Broder-Rodgers
ed9f775b77 Added support for returning HTTP status codes and for git and svn URLs 2017-02-20 19:24:19 +00:00
ilovezfs
ac7a593730 InreplaceError: fix undefined method crash
When the first parameter to inreplace was an array, and the replacement
failed, InreplaceError would end up crashing with an undefined method
exception because the order of operations resulted in super not being
passed the value of the entire inject block.
2017-01-12 07:22:34 -08:00
Mike McQuaid
e7a81caaf4 Allow brew audit to fake a Safari user-agent.
This allows us to detect if homepages such as e.g. `aiccu` which
blocks `curl` are up or not.
2017-01-07 14:03:08 +00:00
Mike McQuaid
a3bffe70bc Use docs.brew.sh links. 2017-01-04 11:13:41 +00:00
Mike McQuaid
e6fb3c3114 curl: make curl_args more configurable.
Allow configuring whether output should be shown or the default the
default user agent is used.
2016-12-29 12:51:12 +00:00
Mike McQuaid
ebe45490b6 analytics: don't raise if tap doesn't exist. 2016-12-11 13:43:32 +00:00
William Woodruff
d07b9ed7f2
Replace Utils::JSON with corelib JSON calls. 2016-11-20 20:06:25 -05:00
William Woodruff
54d18cee17
compat: deprecate Utils::JSON in favor of corelib JSON. 2016-11-20 15:02:47 -05:00
William Woodruff
4278ec38e4
utils/json: Replace OkJson with Ruby's core JSON.
Removes OkJson from vendor/, as Ruby has included its own JSON
parser in corelib since 1.9.x and Homebrew is now guaranteed to be
running on 2.x+.
2016-11-17 23:16:21 -05:00
Mike McQuaid
9edf8eb1fe Check the lock directory is writable.
And, if it isn't, print more helpful debugging messages.

Fixes #1456.
2016-11-11 22:52:21 +00:00
Mike McQuaid
3c7446f3ff Improve GitHub API scopes output.
Improve the GitHub API scope and token related messaging by
autopopulating the scopes we need on the new scopes page and, in the
case of a lacking a scope we need, output what scope was required.

Also, DRY up the personal access token code.
2016-10-30 15:38:19 -04:00
William Woodruff
72b81844ed
Redirect stderr output from git (shim) invocations to /dev/null.
These invocations occur before we can actually automatically install git via
bottle, and as such their output isn't relevant.
2016-10-26 16:33:35 -04:00
Mike McQuaid
1f963267b6 Update Rubocop style.
Another look at the current Rubocop rules and how they fit with our
existing and desired future style. Almost all of these changes were
automatic. Split some rules between formulae/brew where brew doesn't
have millions of cases that need fixed.
2016-10-22 13:32:46 +01:00
Andrew Janke
e72f1139ad Formatter: identifier: only reset color, not full styling 2016-10-17 00:45:37 -04:00
Markus Reiter
581a1245bf Move Formatter.columns into utils/formatter. 2016-10-15 17:22:10 +02:00
Markus Reiter
198bf4d3bd Convert puts_columns to puts Formatter.columns. 2016-10-15 17:13:38 +02:00
Markus Reiter
429327cac8 Use proc to fallback to puts. 2016-10-15 17:13:38 +02:00
Markus Reiter
5ee6df6d82 Fallback to $stdout.tty? unless respond_to?(:tty?). 2016-10-15 17:13:38 +02:00
Markus Reiter
4bfeaaf212 puts_columns only has to be defined inside module Kernel. 2016-10-15 17:13:38 +02:00