3566 Commits

Author SHA1 Message Date
Seeker
e77c156690 dev-cmd/audit: rename USES_FROM_MACOS_ALLOWLIST
Rename to PROVIDED_BY_MACOS_DEPENDS_ON_ALLOWLIST
2020-07-21 08:21:09 -07:00
William Ma
fa0f6f4d5b outdated: Update tests for deprecation warning 2020-07-20 16:16:18 -04:00
Dawid Dziurla
2cd72908bc
Merge pull request #7863 from iMichka/single-resource
on_os resources: allow linux-only or mac-only resources
2020-07-20 16:58:30 +02:00
Rylan Polster
70dfaf3b42 Add link to pypi downloads page to problem message 2020-07-18 14:22:05 -04:00
Rylan Polster
5f3f7d010b Require long urls for pypi and pythonhosted urls 2020-07-18 14:05:46 -04:00
Issy Long
47826fd01d
Merge pull request #7997 from issyl0/git-test-last_revision_commit_of_files
utils/git_spec: Add a test for `last_revision_commit_of_files`
2020-07-16 17:07:29 +01:00
Issy Long
e1383c2898
utils/git_spec: Make example files easier to reason about
- Give the files real names, like `README.md`, rather than having to
  parse the difference between "bleh" and "blah" when reading the tests.
2020-07-14 00:18:45 +01:00
Issy Long
981726c088
utils/git_spec: Add a test for last_revision_commit_of_files
- This method, called from `brew extract` in the case of extraction from
  third-party taps, was untested. This led to it breaking when we refactored
  some of it to appease Sorbet (see PR 7933). If I make the same
  (flawed) change here and run these tests, they fail.
- There's a fair bit going on here, but most of it is setup for
  committing changes to more files, as we're testing operations on
  multiple files in a Homebrew repo.
- I originally tried to write tests for `brew extract`, but that
  required _a lot_ of refactoring because those tests (and their helper
  methods) aren't designed for third-party taps - they rely on
  `CoreTap`. So testing the underlying method is a better solution.
2020-07-14 00:18:44 +01:00
Sean Molenaar
4f5e6d5638
Merge pull request #7966 from SMillerDev/cask/list_json
cask: add list --json
2020-07-13 07:24:06 +02:00
Rylan Polster
d8fb850fa9 fix pkgshare missing slash issue 2020-07-12 14:20:50 -04:00
Dustin Rodrigues
963605e682 refactor throttled update logic to improve efficiency 2020-07-11 12:05:47 -04:00
Michka Popoff
edd1685d37 on_os resources: allow linux-only or mac-only resources
This is now allowed since #7833 has been fixed.
2020-07-10 23:16:43 +02:00
Sean Molenaar
832073a3c7
cask: add list --json 2020-07-10 21:05:12 +02:00
Rylan Polster
9e52712b08 style: don't need require "formula" 2020-07-10 11:17:37 -04:00
Rylan Polster
e0b5c2093a style: refactor OptionDeclarations cop 2020-07-10 11:17:37 -04:00
Rylan Polster
1859162735 style: use pkgshare instead of share/foo 2020-07-10 11:17:37 -04:00
Rylan Polster
792533462a style: don't use prefix + directory 2020-07-10 11:17:37 -04:00
Rylan Polster
b4a9565b8b style: require java dependency for JAVA_HOME 2020-07-10 11:17:37 -04:00
Rylan Polster
9ad342eba0 style: don't concatenate in string interpolation 2020-07-10 11:17:37 -04:00
Rylan Polster
63b81d847a style: env :userpaths is deprecated 2020-07-10 11:17:37 -04:00
Rylan Polster
1e943d7b6f style: env :std deprecated in homebrew-core 2020-07-10 11:17:37 -04:00
Rylan Polster
bd8805b14f style: separate make commands 2020-07-10 11:17:37 -04:00
Mike McQuaid
a2ae8741a9
Merge pull request #7871 from MLH-Fellowship/license-forbidden
License forbidden
2020-07-10 15:38:51 +01:00
Claudia
374c734d9b
Make Hardware.oldest_cpu depend on architecture
Starting with Xcode 12 Beta 2, builds that used to work on Apple Silicon
now break due to `Hardware#oldest_cpu` returning `:nehalem` [1].

This commit is the first in a series of improvements to
`Hardware#oldest_cpu`. It resolves the Xcode 12 Beta 2 issue for now.

[1]: https://github.com/Homebrew/brew/issues/7857#issuecomment-655536261
2020-07-08 20:59:10 +02:00
Lionell
55878cab99 Merge remote-tracking branch 'origin/master' into license-forbidden 2020-07-09 00:05:23 +08:00
EricFromCanada
8540aaf218 audit: disallow capitalization and period in conflicts_with reason 2020-07-07 13:25:54 -04:00
lionellloh
56bde378f3 remove integration tests 2020-07-07 21:42:30 +08:00
lionellloh
ebb3b50cc1 style fixes 2020-07-07 21:34:49 +08:00
lionellloh
29622c35d1 tests: wrote up more tests for brew install 2020-07-07 21:34:49 +08:00
Mike McQuaid
fa760a2f26
Fix brew style. 2020-07-07 13:12:37 +01:00
Mike McQuaid
6211d0da13
Merge pull request #7691 from Rylan12/popen_read-audit
style: separate shell command arguments
2020-07-06 09:15:52 +01:00
Mike McQuaid
1558179a50
Merge pull request #7853 from MLH-Fellowship/integrate-uninstall-reinstall
Allow references to casks when running uninstall and reinstall
2020-07-06 09:10:19 +01:00
Rylan Polster
ae0d37e911 Transfer to FormulaAuditStrict 2020-07-05 13:57:49 -04:00
Rylan Polster
0786003fe9 Add tests for autocorrect 2020-07-05 12:12:36 -04:00
Jonathan Chang
c6e9cff125 dev-cmd: add brew-sponsors.rb 2020-07-05 15:45:36 +10:00
William Ma
6e8f5d0958 Modify MultipleVersionsInstalledError to have a generic message 2020-07-03 18:25:49 -04:00
Rylan Polster
e252de5295 style: improve keg_only style checks 2020-07-03 14:35:32 -04:00
Mike McQuaid
fea704b454
Move .codecov.yml
>  the file must still be located in the root, dev/, or .github/ directories

https://docs.codecov.io/docs/codecov-yaml#can-i-name-the-file-codecovyml
2020-07-03 17:03:29 +01:00
Mike McQuaid
6a7e5f2e9d
dev-cmd/audit: tweak checksum audit.
Compare against the latest `origin/master` checksum rather than
whatever the previous one was.
2020-07-03 09:21:53 +01:00
Mike McQuaid
9fc0799d5e
Merge pull request #7880 from MikeMcQuaid/check_dependents_install_reinstall
Check installed dependents on install and reinstall
2020-07-02 13:30:29 +01:00
Mike McQuaid
2c133a3d45
Check installed dependents on install and reinstall
It's not sufficient to do this merely on `brew upgrade` because
`brew install` and `brew reinstall` can also result in formulae being
upgraded.

This requires moving logic from `cmd/upgrade.rb` to `upgrade.rb`. To
save you searching the diff the changes that resulted from doing that:

- Query the installed formulae from class state in `FormulaInstaller`
  rather than the (incomplete) list that we passed into it.
- Don't output the "Checking dependents" message. It was there for
  systems and configurations where this is slow but for most users
  and most installations this will be a (annoying, noisy) no-op.

Fixes https://github.com/Homebrew/brew/issues/7860
2020-07-02 12:53:52 +01:00
Mike McQuaid
14ed1adb6c
Add CodeCov YAML file.
This should make the output and statuses a bit more friendly.
2020-07-02 12:50:56 +01:00
Mike McQuaid
170b38892a
Use CodeCov for coverage reporting. 2020-07-02 10:22:54 +01:00
Mike McQuaid
97f68e6a3a
Revert "disable license check for new formulae" 2020-07-02 09:04:58 +01:00
Rui Chen
8ff1ca644d disable license check for new formulae
return when license is blank

Co-authored-by: Bo Anderson <mail@boanderson.me>
2020-07-01 17:22:07 -04:00
Mike McQuaid
4e10341277
Merge pull request #7752 from SMillerDev/cask/readall
Support casks in readall
2020-07-01 12:19:30 +01:00
Mike McQuaid
0166211ffd
integration_test: don't error on missing bin. 2020-07-01 11:55:42 +01:00
Mike McQuaid
7d53104c46
cmd/search_spec: split Linux/macOS tests. 2020-07-01 11:55:25 +01:00
Jonathan Chang
b57290b23f
Merge pull request #7844 from jonchang/signoff-approving-reviews
pr-pull: add commit message trailers for pull requests with approved reviews
2020-07-01 19:18:27 +10:00
lionellloh
7358dd7bba style fixes 2020-06-30 23:25:51 +08:00