32614 Commits

Author SHA1 Message Date
Max Eisner
3fec64f386
skip offenses for heredoc scripts and calls with custom env
needed for e.g. àwscli`, `hatch`, `pipenv`
2022-09-06 14:42:02 +02:00
Max Eisner
02c9cc0720
add check if executable and subcmd are the same before combining
e.g. ˚jrsonnet˚ needs this
2022-09-06 14:42:01 +02:00
Max Eisner
cf84800939
fix style 2022-09-06 14:42:01 +02:00
Max Eisner
4e286ee36d
fix test 2022-09-06 14:42:01 +02:00
Max Eisner
45d1c70559
add test 2022-09-06 14:42:01 +02:00
Max Eisner
5b3f5dcbf2
fix whitespace removal, fix string concatenation 2022-09-06 14:42:01 +02:00
Max Eisner
8282b15a2a
simplify and unify node handling 2022-09-06 14:42:01 +02:00
Max Eisner
e18432089b
fix typecheck 2022-09-06 14:42:00 +02:00
Max Eisner
ab6a4d757a
fix dangling enclosed comma 2022-09-06 14:42:00 +02:00
Max Eisner
a175d6b7a1
fix style 2022-09-06 14:42:00 +02:00
Max Eisner
a56feff5d0
adapt to executable and subcmd being mandatory 2022-09-06 14:42:00 +02:00
Max Eisner
60db35096f
simplify and comment dangling comma handling 2022-09-06 14:42:00 +02:00
Max Eisner
ab09d15703
remove newlines left behind after correction 2022-09-06 14:42:00 +02:00
Max Eisner
de7ef64f61
use #inspect instead of wrapping symbols 2022-09-06 14:41:59 +02:00
Max Eisner
a002463362
#delete_suffix instead of #sub 2022-09-06 14:41:59 +02:00
Max Eisner
1b15d03634
remove always-true condition 2022-09-06 14:41:59 +02:00
Max Eisner
8398dfbae0
fix condition array substraction 2022-09-06 14:41:59 +02:00
Max Eisner
06518ec613
add RuboCop to combine multiple calls 2022-09-06 14:41:59 +02:00
Max Eisner
e4b67e84dd
fix shell parameter type 2022-09-06 14:41:59 +02:00
Max Eisner
d963a1ae2f
style 2022-09-06 14:41:59 +02:00
Max Eisner
2329844f50
refactor: naming 2022-09-06 14:41:58 +02:00
Max Eisner
50ae38a372
add :arg shell_parameter 2022-09-06 14:41:58 +02:00
Max Eisner
b901e5873d
do not use parantheses if no args given to method 2022-09-06 14:41:58 +02:00
Max Eisner
0509eebda4
fix: don't write binary param if base_name == binary/base_name 2022-09-06 14:41:58 +02:00
Max Eisner
fd98c3df58
add preliminary RuboCop for generate_completions DSL 2022-09-06 14:41:57 +02:00
Carlo Cabrera
db921d88d9
Merge pull request #13812 from carlocab/fetch-tries
cmd/fetch: rename `fetch_failed` to `fetch_tries`.
2022-09-06 19:13:50 +08:00
Mike McQuaid
ed916a5315
Merge pull request #13813 from Homebrew/revert-13746-chore/cask/cleanup_audit
Revert "Cask: automatically add cask audits"
2022-09-06 12:12:08 +01:00
Mike McQuaid
1661837465
Revert "Cask: automatically add cask audits" 2022-09-06 11:46:40 +01:00
Mike McQuaid
f958302b58
Merge pull request #13811 from Homebrew/maintainers-man-completions
Update manpage and completions.
2022-09-06 11:42:42 +01:00
Carlo Cabrera
708935d2c8
cmd/fetch: rename fetch_failed to fetch_tries.
This makes the code substantially easier to understand. Follow-up to #13807.
2022-09-06 18:35:34 +08:00
BrewTestBot
6b06a40803
Update manpage and completions.
Autogenerated by the [update-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/maintainers-man-completions.yml) workflow.
2022-09-06 10:11:21 +00:00
Mike McQuaid
ccc235171f
Merge pull request #13807 from carlocab/retry-with-exponential-backoff
cmd/fetch: `--retry` with exponential backoff.
2022-09-06 11:10:15 +01:00
Carlo Cabrera
360052af57
cmd/fetch: --retry with exponential backoff.
See discussion at Homebrew/homebrew-test-bot#826.
2022-09-06 01:25:34 +08:00
Mike McQuaid
9cfa3d9f2a
Merge pull request #13790 from MikeMcQuaid/all_deprecation
Deprecate reading all formulae through commands
2022-09-05 14:27:42 +01:00
Mike McQuaid
79c6ab25e2
Merge pull request #13805 from Homebrew/workflows-fixes
.github/workflows: various fixes.
2022-09-05 13:58:26 +01:00
Mike McQuaid
e2759fbdff
Deprecate reading all formulae through commands
We added the `--all` flag (now renamed to `--eval-all`) for various
commands for this behaviour so let's start deprecating this.

Also, introduce a `HOMEBREW_EVAL_ALL` environment variable to use the
existing, less secure, behaviour by default and avoid passing
`--eval-all` everywhere.
2022-09-05 13:57:22 +01:00
Mike McQuaid
56cca1edd3
.github/workflows: various fixes.
- don't try to `brew update-sponsors`, @BrewTestBot doesn't have
  `admin:org` rights, nor should they
- allow testing the `maintainers-man-completions` workflow on branches
- cache RubyGems for `brew generate-man-completions`
- add `workflow_dispatch` support to `spdx` workflow for easier testing
2022-09-05 13:27:50 +01:00
Mike McQuaid
552dc93242
Merge pull request #13802 from Rylan12/fix-bump-cask-pr
bump-cask-pr: cleanup handling of multiple hashes
2022-09-05 12:14:18 +01:00
Carlo Cabrera
6def5fc53b
Merge pull request #13799 from apainintheneck/ignore-missing-unversioned-formula-after-rename
Ignore renamed formulae when checking for unversioned formulae
2022-09-05 19:14:02 +08:00
Mike McQuaid
997fd648ce
Merge pull request #13788 from Homebrew/sponsors
Automate sponsors updates
2022-09-05 12:07:31 +01:00
Carlo Cabrera
a2c23f022b
Merge pull request #13796 from carlocab/linux-gcc-linkage 2022-09-05 16:04:53 +08:00
Bo Anderson
9972cbaba2
Merge pull request #13801 from Bo98/pr-pull-github-api
dev-cmd/pr-pull: avoid expensive search API calls
2022-09-04 01:09:46 +01:00
Rylan Polster
092095a249
bump-cask-pr: cleanup handling of multiple hashes 2022-09-03 19:28:23 -04:00
Bo Anderson
04f6f53b58
dev-cmd/pr-pull: avoid expensive search API calls 2022-09-03 21:19:37 +01:00
apainintheneck
bb1c783817 Ignore renamed formulae when checking for unversioned formulae
There is an audit for versioned formulae that makes sure
an unversioned formulae of the same name exists already.
This ignores that check when we exlicitly removed the
unversioned formula by checking if it was renamed.

Also, there is no need to check for formula.tap because
formula.core_formula? guarantees the presence of formula.tap.
2022-09-02 23:02:07 -07:00
Rylan Polster
f765382cb6
Merge pull request #13798 from max-ae/fix/generate-completion-none
generate_completions: fix `shell_parameter_format: :none`
2022-09-02 19:27:57 -04:00
Max Eisner
20e432c0d5
fix style 2022-09-02 22:26:58 +02:00
Max Eisner
02860aa0e8
use #blank? instead of #nil?
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
2022-09-02 22:23:26 +02:00
Carlo Cabrera
b2cc1720f8
Add comment explaining gcc exception for undeclared_deps. 2022-09-02 22:04:38 +08:00
Max Eisner
b41dd8c729
generate_completions: fix shell_parameter_format: :none 2022-09-02 15:40:24 +02:00