13875 Commits

Author SHA1 Message Date
Gautham Goli
fba52e2f74 cli_parser: Store parsed args in Homebrew.args and access args everywhere else 2018-05-30 00:05:39 +05:30
Mike McQuaid
f8f77ea52d cmd/list: add common ls options.
We need to manually specify these now so let's add a few that we'd
either previously documented or we've caught being used in the wild and
adjust the documentation accordingly.
2018-05-29 18:45:46 +01:00
Tom Schoonjans
ecbd9b9a26 Add gtk-mac-integration to gnome_devel_whitelist 2018-05-29 10:38:38 +01:00
Markus Reiter
0cb960951f Fix tap unavailable error for migrated Cask taps. 2018-05-29 10:57:33 +02:00
Mike McQuaid
67db701ae5
Merge pull request #4067 from maxim-belkin/fix-multiple
list.rb: use CLI::Parser and improve handling of flags
2018-05-28 20:52:03 +01:00
Mike McQuaid
517d147e33
Merge pull request #4219 from alyssais/version_comparison
Fix comparison with Version::NULL on RHS
2018-05-28 20:35:49 +01:00
Mike McQuaid
513c179e60
Merge pull request #4213 from reitermarkus/refactoring
Refactoring
2018-05-28 20:26:09 +01:00
Mike McQuaid
a276a48253
Merge pull request #4222 from reitermarkus/silence-parser-compatibility
Silence `Parser` compatibility warning.
2018-05-28 20:25:43 +01:00
Markus Reiter
a0ca601a1a Silence Parser compatibility warning. 2018-05-26 16:24:48 +02:00
Markus Reiter
c89ae8c5ab Fall back to CaskLoader.load to get a better error message. 2018-05-26 16:05:51 +02:00
Alyssa Ross
472d1a22c5
Fix comparison with Version::NULL on RHS
This was accounted for in Version::NULL.<=>, but not in Version#<=>,
so these could only be compared if Version::NULL was the left hand
side.

The check had to go above the check that `other` is a version because
`Version::NULL`'s anonymous class does not inherit from `Version`.
(The type check feels like it's probably a smell, but out of scope).
2018-05-26 14:45:53 +02:00
Markus Reiter
579a30c7bf Fix rspec deprecations. 2018-05-25 23:19:13 +02:00
Markus Reiter
df2a40d207 Use remote instead of path.git_origin. 2018-05-25 22:54:34 +02:00
Markus Reiter
d1fb1d2abc Use simpler check. 2018-05-25 22:47:41 +02:00
Markus Reiter
50a43cf678 Reset repo_var in clear_cache. 2018-05-25 22:47:31 +02:00
Markus Reiter
054229be90 Update Cask tap regex. 2018-05-25 18:53:08 +02:00
Markus Reiter
de246cc528 Update Homebrew-Cask references. 2018-05-25 18:20:02 +02:00
Markus Reiter
27f1613cd3 Reset repo_var so it actually is re-computed. 2018-05-25 18:02:12 +02:00
Markus Reiter
c4222141ac Revert "Update Homebrew-Cask references."
This reverts commit 4475651b548afdcf15c4cf7a7cb57baca1885186.
2018-05-25 17:57:32 +02:00
Markus Reiter
4475651b54 Update Homebrew-Cask references. 2018-05-25 17:56:16 +02:00
Markus Reiter
675d5fe61f Fix spec_helper cleanup. 2018-05-25 17:28:43 +02:00
Markus Reiter
7b017b6ca9 Add compatibility layer for brew update revisions. 2018-05-25 16:22:46 +02:00
Markus Reiter
54834ccbe3 Move repo_var method to Tap class. 2018-05-25 16:21:37 +02:00
Markus Reiter
8895acf059 Activate Homebrew-Cask tap migration. 2018-05-25 15:55:28 +02:00
Maxim Belkin
f7e308ab44
list.rb: use new syntax correctly 2018-05-25 06:17:40 -05:00
Maxim Belkin
288c9c6dc7
list.rb: new syntax for multiple + versions flags 2018-05-25 06:17:40 -05:00
Maxim Belkin
da66bf96b7
list.rb: use CLI::Parser to better handle args
* --multiple now assumes --versions
* Use CLI::Parser (that, in turns, uses OpenStruct) to handle arguments
2018-05-25 06:17:40 -05:00
Gautham Goli
67a1235487
Merge pull request #4207 from GauthamGoli/switch-constraints
cli_parser: Add depends_on, required_for and conflicts for switch options
2018-05-25 14:28:00 +05:30
Gautham Goli
0d53002dbc cli_parser: Add depends and conflicts for switch options 2018-05-25 04:05:45 +05:30
Mike McQuaid
0408b78a23 tests: remove linkage cache env.
Otherwise this will mess with `brew tests`.
2018-05-24 15:09:41 +01:00
Mike McQuaid
63aacd71d3 linkage_checker: fix bad instance variable usage. 2018-05-24 14:53:03 +01:00
Mike McQuaid
4c365ea353 spec_helper: don't truncate output expectations.
It's really useful to be able to see the full output particularly when
a backtrace is in it.
2018-05-24 14:53:03 +01:00
Mike McQuaid
0c216bc5b8 spec_helper: don't truncate output expectations.
It's really useful to be able to see the full output particularly when
a backtrace is in it.
2018-05-24 14:28:20 +01:00
Mike McQuaid
97645d061d
Merge pull request #3720 from AndrewMcBurney/cache-optimization
Cache optimization for `brew linkage` command.
2018-05-24 09:14:02 +01:00
commitay
dc96e6f735
Merge pull request #4170 from commitay/new-formulae-options
audit: new formulae should not have options
2018-05-24 07:16:11 +10:00
Andrew R. McBurney
a9606b4a18 Added trivial integration tests for brew linkage. 2018-05-23 13:00:05 -04:00
Mike McQuaid
24025a3ab5
Merge pull request #4202 from MikeMcQuaid/remove-some-integration-tests
Remove some integration tests
2018-05-23 15:07:46 +01:00
Mike McQuaid
f6bf989378 Remove some integration tests
We have an awful lot of integration tests and they are (comparatively)
really slow. Let's kill those that test edge case conditions and focus
on those that test that our functionality works as expected. Edge cases
can be better tested with unit tests.
2018-05-23 14:41:31 +01:00
Mike McQuaid
63ffbd3298
Merge pull request #4161 from alyssais/pull-gpg
Fix brew pull with git commit.gpgsign enabled
2018-05-23 14:21:40 +01:00
commitay
c297d39420 audit: add back new formulae condition for patches 2018-05-23 07:36:59 +10:00
Alyssa Ross
bdfbc70c87
pull: only add gpg to path if enabled in git 2018-05-22 23:35:50 +02:00
Andrew R. McBurney
218a7362dc Fixed failing tests. 2018-05-22 15:31:58 -04:00
Andrew R. McBurney
91f7a5eb76 Added unit tests for CacheStoreDatabase and LinkageCacheStore. 2018-05-22 15:01:56 -04:00
Andrew R. McBurney
ddb7f06e9f Fixed rubocop offenses from brew style. 2018-05-22 12:54:54 -04:00
Mike McQuaid
c7aa286336 audit: tweak line length/style. 2018-05-22 14:52:02 +01:00
Mike McQuaid
44f5d3ec79 Refactor cache store code. 2018-05-22 14:46:14 +01:00
Gautham Goli
38c832b029 audit: exit with code 1 if regular audit errors or new formula audit errors when comment is not created 2018-05-22 19:14:18 +05:30
Gautham Goli
b01446d059 audit: Add condition check on new_formula_audits 2018-05-22 17:55:40 +05:30
commitay
9d55fed15f audit: new formulae should not have options 2018-05-22 19:39:14 +10:00
Mike McQuaid
3794d53575
Merge pull request #3835 from GauthamGoli/bot-comment
audit:  `--new-formula`, Don't fail CI instead comment on PR about audit violations
2018-05-22 10:26:13 +01:00