30268 Commits

Author SHA1 Message Date
Michael Cho
f81dcd8c58
go_resource deprecation comments
Signed-off-by: Michael Cho <michael@michaelcho.dev>
2024-04-01 09:00:32 -04:00
Mike McQuaid
1f41dff48f
Merge pull request #16971 from cho-m/language-types
language/*: enable `typed: strict`
2024-04-01 13:51:34 +01:00
Mike McQuaid
0bbfa434cf
unpack_strategy/dmg: fix permissions when needed.
`ditto` behaves weirdly when the EUID is different from the UID. This
fix ensures that the BOM file is written with the correct permissions
in this case.
2024-04-01 09:49:10 +01:00
Mike McQuaid
8a59266e92
Merge pull request #16988 from Homebrew/remove-unnecessary-cache-clearing-in-tests
tests: remove unnecessary cache clearing
2024-04-01 08:12:45 +01:00
Mike McQuaid
120eb553dd
Merge pull request #16968 from samford/livecheck/add-extract-plist-skip-to-skip-conditions
livecheck: Add ExtractPlist skip to SkipConditions
2024-04-01 08:11:49 +01:00
Mike McQuaid
3c86be2648
Merge pull request #16986 from Homebrew/update-keg-sorting-method
keg: update sorting by version logic
2024-04-01 08:11:17 +01:00
Mike McQuaid
2ae0174a6d
Merge pull request #16972 from cho-m/m4-shim
shims/mac/super/m4: use gm4 if missing m4 (e.g. Xcode 15.3 CLT)
2024-04-01 08:10:16 +01:00
Mike McQuaid
e600cc6fef
language/python: tweak Pathname syntax.
Co-authored-by: Markus Reiter <me@reitermark.us>
2024-04-01 08:09:42 +01:00
apainintheneck
226239da4c tests: remove unnecessary cache clearing
This PR removes all remaining unnecessary cache clearing in tests
from the codebase since we now clear all cachable classes between
tests making this functionally unnecessary.

Original PR to automatically clear caches:
- https://github.com/Homebrew/brew/pull/16746

I also moved the `Utils::Analytics` module to use cachable so
that we don't have to clear caches specifically in tests anymore.
2024-03-31 18:38:03 -07:00
Sam Ford
111ac5810c
livecheck: Clean up whitespace, ordering 2024-03-31 21:01:40 -04:00
Sam Ford
a4134125f2
livecheck: Clarify --extract-plist behavior
From the description of the `--extract-plist` option, it would seem
that the `ExtractPlist` strategy is only enabled when the option is
used. Instead, livecheck automatically enables the strategy if the
command is run on only one cask. This rewords descriptions of the
option to clarify the behavior.
2024-03-31 21:01:40 -04:00
Sam Ford
a8d506fdda
livecheck: Add ExtractPlist skip to SkipConditions
When the `--extract-plist` option was added to livecheck, conditions
were added in `#run_checks` to skip casks using `ExtractPlist` if the
`--extract-plist` isn't used and the run involves multiple
formulae/casks. This integrates the skip into the `SkipConditions`
class.
2024-03-31 21:01:39 -04:00
apainintheneck
db507be41a keg: update sorting by version logic
This updates logic to add a `#scheme_and_version` method to be used
with `.sort_by` and `.max_by`. Using `Keg#version` by itself can be
inaccurate when different version schemes are present. This also
updates the behavior of `Formula#eligible_kegs_for_cleanup` to match
the previous behavior. We were dropping the wrong keg based on the
sort being reversed in a previous PR.
2024-03-31 17:52:32 -07:00
BrewTestBot
1f79926c68
sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
2024-04-01 00:22:05 +00:00
Michael Cho
c4695307e4
shims/mac/super/m4: use gm4 if missing m4 (e.g. Xcode 15.3 CLT)
Signed-off-by: Michael Cho <michael@michaelcho.dev>
2024-03-31 19:29:56 -04:00
Douglas Eichelberger
471e94d1e8 Add missing require 2024-03-31 13:14:56 -07:00
Mike McQuaid
5e5aee4a1d
Merge remote-tracking branch 'origin/master' into no-tty
# Conflicts:
#	Library/Homebrew/test/cmd/deps_spec.rb
#	Library/Homebrew/test/cmd/info_spec.rb
2024-03-31 19:31:40 +01:00
Mike McQuaid
87bf4af3fc
Merge pull request #16872 from cho-m/cleanup-cask-broken-symlinks
cleanup: remove broken symlink for uninstalled migrated Casks
2024-03-31 19:30:02 +01:00
Mike McQuaid
21dd3c263f
Merge pull request #16975 from Homebrew/ported-cmds
Begin porting non-dev commands to use AbstractCommand
2024-03-31 19:28:30 +01:00
Bo Anderson
da456da315
Merge pull request #16977 from Homebrew/cleanup-fixes
cleanup: fix various cases where cache wasn't being removed properly
2024-03-31 19:27:56 +01:00
Mike McQuaid
3e8dc3cf7d
Merge pull request #16983 from bartekpacia/fix/github_pat_finegrained
make fine-grained PATs work as $HOMEBREW_GITHUB_API_TOKEN
2024-03-31 19:26:33 +01:00
Douglas Eichelberger
914e53e9d5 Move isolated matchers into the specs that uses them 2024-03-30 20:24:06 -07:00
Douglas Eichelberger
fde7d380f7 Don't include FileUtils everywhere 2024-03-30 19:10:56 -07:00
Douglas Eichelberger
c1a4a806e1 rm unused OutputAsTTY helper 2024-03-30 18:44:39 -07:00
Douglas Eichelberger
221fde4ad8
Merge pull request #16979 from Homebrew/rspec-cleanup
Enable and fix RSpec/DescribedClassModuleWrapping
2024-03-30 18:16:26 -07:00
Douglas Eichelberger
7f78fed676 rm unnecessary description 2024-03-30 16:50:28 -07:00
Douglas Eichelberger
65f8420232 Make things private 2024-03-30 16:43:11 -07:00
Douglas Eichelberger
22bfd9b230 Port Homebrew::Cmd::Link 2024-03-30 16:24:11 -07:00
Douglas Eichelberger
8ab9d2cbad Port Homebrew::Cmd::Leaves 2024-03-30 16:16:52 -07:00
Bartek Pacia
1aa2565cd0
make fine-grained PATs work as $HOMEBREW_GITHUB_API_TOKEN 2024-03-30 22:56:48 +01:00
Douglas Eichelberger
cd2397ca2c removed unused code paths 2024-03-30 14:44:47 -07:00
Patrick Linnane
75ac45e52d
Merge pull request #16981 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-runtime-and-sorbet-static-and-runtime-0.5.11319 2024-03-30 14:10:58 -07:00
Patrick Linnane
88251708a6
Merge pull request #16982 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-performance-1.21.0 2024-03-30 14:10:16 -07:00
Kevin
5128d526c5
Merge pull request #16976 from rrotter/tap-info-skip-untapped-core-taps
tap-info cmd: skip untapped core taps
2024-03-30 14:00:47 -07:00
BrewTestBot
9cd7298e15
brew vendor-gems: commit updates. 2024-03-30 20:59:52 +00:00
BrewTestBot
b40f3baf70
brew vendor-gems: commit updates. 2024-03-30 20:59:16 +00:00
dependabot[bot]
f4b5688400
build(deps-dev): bump rubocop-performance in /Library/Homebrew
Bumps [rubocop-performance](https://github.com/rubocop/rubocop-performance) from 1.20.2 to 1.21.0.
- [Release notes](https://github.com/rubocop/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-performance/compare/v1.20.2...v1.21.0)

---
updated-dependencies:
- dependency-name: rubocop-performance
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-03-30 20:58:53 +00:00
dependabot[bot]
0168ad9bde
build(deps): bump sorbet-runtime and sorbet-static-and-runtime
Bumps [sorbet-runtime](https://github.com/sorbet/sorbet) and [sorbet-static-and-runtime](https://github.com/sorbet/sorbet). These dependencies needed to be updated together.

Updates `sorbet-runtime` from 0.5.11318 to 0.5.11319
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

Updates `sorbet-static-and-runtime` from 0.5.11318 to 0.5.11319
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: sorbet-static-and-runtime
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-03-30 20:58:22 +00:00
Douglas Eichelberger
330d209e03 Set ivars directly 2024-03-30 13:50:39 -07:00
Issy Long
75db3b8e21
Apply suggestions from code review
Co-authored-by: Douglas Eichelberger <697964+dduugg@users.noreply.github.com>
2024-03-30 19:54:51 +00:00
Issy Long
9dfe11870e
Convert the EnvConfig RBI generator to a Tapioca compiler 2024-03-30 18:30:20 +00:00
Douglas Eichelberger
03b815df82 Enable and fix RSpec/DescribedClassModuleWrapping 2024-03-30 11:29:34 -07:00
Issy Long
a3932b44c0
Merge pull request #16899 from Homebrew/tapioca-compiler-for-tty-rbi
Convert the `utils/tty` RBI generator to a Tapioca compiler
2024-03-30 18:10:41 +00:00
Issy Long
db39e939b0
Apply suggestions from code review 2024-03-30 18:00:39 +00:00
Douglas Eichelberger
0fd082a1ff Port Homebrew::Cmd::InstallCmd 2024-03-30 09:36:47 -07:00
Ryan Rotter
d856d88c17 tap-info cmd: skip untapped core taps
When homebrew/core or homebrew/cask are untapped `brew tap-info` fails because
Tap.each includes them and tap.private? fails without a git repo interrogate.

This restores the behavior of `brew tap-info` before #16710
2024-03-30 01:41:31 -04:00
Bo Anderson
58de9e0dda
cleanup: better support bottle manifests 2024-03-30 03:30:58 +00:00
Bo Anderson
92d44912e2
cleanup: better handle version_scheme scenarios 2024-03-30 03:30:31 +00:00
Bo Anderson
bb0252875e
utils/bottles: fix outdated bottle check 2024-03-30 03:29:51 +00:00
Douglas Eichelberger
d25956668d Fix tests 2024-03-29 19:12:25 -07:00