admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
4,448 Commits 15 Branches 471 Tags
Commit Graph

3595 Commits

Author SHA1 Message Date
Jack Nagel
aa2554640d Split up unreadable conditional 2013-07-21 16:41:50 -05:00
Jack Nagel
13df53166a These should be integers 2013-07-21 07:56:30 -05:00
Jack Nagel
5acaa3374b Remove unnecessary use of globals in compiler version methods 2013-07-20 22:40:23 -05:00
Jack Nagel
e23a3492f4 Don't report llvm-gcc if it's actually clang 2013-07-20 22:40:22 -05:00
Jack Nagel
8e0158b4d7 Add String#end_with? 
I'm tired of not remembering if start_with?/end_with? are portable, so
just add them both if they're not defined.
 2013-07-19 22:32:57 -05:00
Jack Nagel
b1e5f5ee81 Fix String#start_with? implementation 
It is supposed to accept a variable number of prefixes, and also to
check if they are convertible to strings. This matches behavior
documented in RubySpec.
 2013-07-19 22:31:07 -05:00
Adam Coffman
753adbb0ce upgrade: put exit statements in both conditional branches 
This check was only occurring in one branch of the conditional.
As a result, if you ran `brew upgrade` with no args and there were no packages to upgrade,
the nonsensical message

"==> Upgrading 0 outdated package, with result:"

would be printed.

Closes Homebrew/homebrew#21316.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2013-07-18 15:35:17 -05:00
Mike McQuaid
f3821364a7 Warn more about failing bottle version detection. 
This is needed for local bottle installation and also possible when
detecting bottle versions from URLs.
 2013-07-18 09:56:55 -07:00
Mike McQuaid
4f2725cde3 Move getting formula names from bottles to method. 2013-07-18 09:56:55 -07:00
Mike McQuaid
e3a7260c1a Formula: temporarily set PYTHONPATH. 
Needs a less hacky fix but at least this will stop failing tests.
 2013-07-18 09:56:55 -07:00
Mike McQuaid
f526bd5017 check_PATH: return early if (s)bin doesn't exist. 2013-07-17 09:36:44 -07:00
Jack Nagel
16b69317fe Remove stray quotation mark 2013-07-17 11:27:07 -05:00
Jack Nagel
1bb7dfcafd Escape interpolation examples 2013-07-17 11:22:00 -05:00
Adam Vandenberg
ebcf8be789 audit: skip an audit for mongodb 2013-07-17 06:58:11 -07:00
Adam Vandenberg
456621bb54 audit: ARGV.find is a warning, .value is allowed 2013-07-17 06:58:10 -07:00
Adam Vandenberg
d8d6b254f7 add ARGV.value 2013-07-17 06:58:10 -07:00
Samuel John
702b5e5ba2 doctor: Using Xcode-only is no longer experimental 
In 10.9 we'll probably have to use that code path
anyways and by now we have adapted all formulae
to be able to build on Xcode-only.
 2013-07-17 15:18:00 +02:00
Samuel John
1721cd9c08 Typo in comments 2013-07-17 09:52:30 +02:00
Jack Nagel
d9790309a6 Fix SYMROOT audit 2013-07-16 23:15:22 -05:00
Adam Vandenberg
f432a59fd0 add full lib path to audit 2013-07-16 20:50:45 -07:00
Jack Nagel
86cf6f0329 More linewise audits 2013-07-16 21:39:46 -05:00
Jack Nagel
b4bb0bf1c0 Audit text linewise 2013-07-16 21:25:02 -05:00
Jack Nagel
a632994403 Audit conditional deps that can be made declarative 2013-07-16 21:24:54 -05:00
Jack Nagel
51023ef15b Fix some false-positive build-time dep audits 2013-07-16 15:49:11 -05:00
Mike McQuaid
897607b3d7 audit: use FormulaCellarChecks module. 
Perform post-installation checks if a formula is installed.
Added for brew test-bot to be able to fail on bad Cellar installation.
 2013-07-16 13:29:37 -07:00
Mike McQuaid
91c5c15a48 FormulaInstaller: move Cellar checks to module. 2013-07-16 13:29:37 -07:00
Mike McQuaid
a3ea2b566b FormulaInstaller: cleanup check_/audit_ functions. 2013-07-16 13:29:37 -07:00
Samuel John
8f0a073bf6 Audit LanguageModuleDependency for python 
LanguageModuleDependency.new(:python,...) is deprecated now.
Replace it by
    depends_on :python => ['module' => 'name-on-PyPi']
 2013-07-16 11:10:14 +02:00
Samuel John
fb7f16fc94 Allow specifying version in depends_on :python 
Note, in the explict form:

    PythonInstalled.new('2.7') => :recommended

the tag :recommended is ignored (not a limitation
of PythonInstalled itself). One solution was to write

    PythonInstalled.new('2.7', [:recommended])

but that is not as beautiful as we like it.

Therefore, now it is possible to:

    depends_on :python => ['2.7', :recommended]

Only the first tag is attempted to be parsed as
a version specifyer "x" or "x.y" or "x.y.z"...
 2013-07-16 11:04:57 +02:00
Jack Nagel
9fb163d34c upgrade: don't rely on return value of 'onoe' 2013-07-15 23:47:04 -05:00
Jack Nagel
42cceeb4a0 upgrade: make condition clearer 2013-07-15 23:47:03 -05:00
Jack Nagel
b4419992ab upgrade: move require out of method body 2013-07-15 23:47:03 -05:00
Jack Nagel
1678a4a65d upgrade: remove redundant conditional 
Since e1c62c35465eb6149688c745e4309438c08c410b, we exit early if the
outdated array is empty, so we no longer need to check this before
proceeding.
 2013-07-15 23:47:02 -05:00
Samuel John
e143c3a799 Fix multiple execution of python do ... end blocks 
Only run the `python do ... end` loop once even if
multiple `depends_on :python => 'module-name'` are
present.
 2013-07-15 21:28:37 +02:00
Jack Nagel
6b299c4207 Clarify behavior of brew search without an argument 
As documented in the man page, when given no arguments, `brew search`
will list all formulae. This is different than giving an *empty*
argument.
 2013-07-15 10:59:00 -05:00
Jack Nagel
d912bc5ff3 GitHub API access may result in SSL errors 
Closes Homebrew/homebrew#21216.
 2013-07-15 10:57:55 -05:00
Mike McQuaid
4eb7116c9c bottle: fix cellar output. 2013-07-14 12:11:57 -07:00
Jack Nagel
528e750f7b Handle NULs in link targets in Pathname#resolved_path_exists? 
Fixes Homebrew/homebrew#19475.
Fixes Homebrew/homebrew#21184.
 2013-07-13 16:56:43 -05:00
Adam Vandenberg
7964aa6648 keg: more gnome folders 2013-07-13 10:15:54 -07:00
Adam Vandenberg
aba88a8502 audit: improve comment 2013-07-12 23:00:08 -07:00
Adam Vandenberg
34ae063c67 audit: remove github warning 
All core formulae have been migrated to .io addresses except
for software maintained by github itself.
 2013-07-12 21:26:55 -07:00
Jack Nagel
c8e79c3309 Move inreplace off of Object 
Closes Homebrew/homebrew#21163.
 2013-07-12 16:23:06 -05:00
Jack Nagel
38c1d25036 Remove unreachable branch in ENV.fortran 
Now that this is handled by a Requirement with a default formula, this
code cannot be triggered under normal circumstances.

The advice given has now been moved to the Formula Cookbook on the wiki.
 2013-07-11 13:03:25 -05:00
Adam Vandenberg
e805b8636c Show symlink target if linking fails 
Closes Homebrew/homebrew#21060.
 2013-07-10 08:54:18 -07:00
Adam Vandenberg
ae9401291d fix deps 
Closes Homebrew/homebrew#21113.
 2013-07-10 06:59:45 -07:00
Adam Vandenberg
37e64a2402 github doesn't use .io urls 2013-07-09 20:50:30 -07:00
Jack Nagel
9b51f986c8 Remove duplication in updater tests 2013-07-09 22:12:08 -05:00
phinze
9a94a77fa3 Properly define tapped formulae in update 
A tapped formula is a ruby file present:

  - in the root of the tap
  - in directory of the tap called Formula
  - in a directory of the tap called HomebrewFormula

And nowhere else. This corrects an overzealous definition of tapped
formula in the updater. (the correct definition has been in Pathname
since e613cbe5783cea2abb8100b56c22126a1ab6b9f2)

Refs Homebrew/homebrew#19743.
Closes Homebrew/homebrew#21087.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2013-07-09 20:52:51 -05:00
Jack Nagel
81984411b0 Respect $VISUAL when picking an editor 2013-07-09 20:12:53 -05:00
Adam Vandenberg
a90ec1ae80 fix comment typo 2013-07-09 09:06:12 -07:00