381 Commits

Author SHA1 Message Date
Issy Long
189d10b32b
workflows/sorbet: Rename from Tapioca as it does more than Tapioca now
- This uses the `--update` switch to do both RBI file updates and pruning of
  deleted files from `sorbet/files.yaml`. The assumption is that only
  this automated task will run this command.
2020-09-21 08:59:33 +01:00
Issy Long
34ea8cbc9d
PULL_REQUEST_TEMPLATE: Add a checklist item for brew man
- I've been changing command flags recently. I always forget to run
  `brew man`, then I feel bad about causing red CI on my PRs. This has
  happened to others too, so make `brew man` more obvious as a thing
  that one should check.
2020-09-18 16:22:41 +01:00
Issy Long
3bf5136e82
dev-cmd/typecheck: Delete old files from sorbet/files.yaml
- I was going through the `sorbet/files.yaml` moving various things to
  `true`, playing around locally, and happened upon some files that it
  was tracking that had been deleted.
- We want to do some automation of new files, but I'm not sure we'd ever
  considered the possibility of code being removed. :-D
- This adds a `--prune-files-list` switch and updates the Tapioca GitHub
  Actions workflow to use it. Any changes to the `sorbet/files.yaml`
  file will be committed as part of the scheduled Tapioca update job.
2020-09-18 12:30:43 +01:00
Mike McQuaid
16ee849c43
Merge pull request #8632 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-performance-1.8.0
build(deps): bump rubocop-performance from 1.7.1 to 1.8.0 in /Library/Homebrew
2020-09-11 11:58:49 +01:00
Mike McQuaid
5a20968c19 Tweak tests annotations
- Don't skip Git installation tests on generic OS; remove it instead.
- Install Subversion for macOS Subversion tests.
2020-09-11 11:11:42 +01:00
Mike McQuaid
ba54a54dfc tests: handle tapped homebrew/bundle. 2020-09-11 11:00:42 +01:00
Mike McQuaid
ca7339da21 workflows: reduce scheduled PR workflow's frequency.
Once every 24h should be sufficient for both of these.
2020-09-04 14:11:23 +01:00
Mike McQuaid
5ac1ea8762 workflows: make homebrew lowercase again for Docker.
Otherwise this fails.
2020-09-03 13:31:34 +01:00
Mike McQuaid
a5fae14f1f workflows: tweak docker.
- Note GitHub Packages specifically in step names
- Use uppercase for Homebrew name/tag (in case it makes a difference)
- Use `--password-stdin` to avoid a warning
2020-09-03 11:16:59 +01:00
Mike McQuaid
8d07f4f15c workflows: migrate to GitHub Container Registry.
This seems a better fit for us (unauthenticated anonymous access) than
GitHub Packages Docker registry was.

Followed steps on:
https://docs.github.com/en/packages/getting-started-with-github-container-registry/migrating-to-github-container-registry-for-docker-images
2020-09-03 09:41:37 +01:00
Mike McQuaid
d5486ffcf6 ISSUE_TEMPLATE: direct people to GitHub Discussions
Let's trial this and see how it goes.
2020-09-02 12:57:27 +01:00
Maxim Belkin
5035e59fd3
Merge pull request #8102 from maxim-belkin/feature-template/shorter-titles
feature and issue templates: change warning formatting
2020-08-28 09:38:17 -05:00
Mike McQuaid
6f311852d6 Fix unvendored RubyGems
- Avoid caching RubyGems in GitHub Actions `tests.yml` to catch this in
  future.
- Run `brew doctor` in GitHub Actions `tests.yml` after installing
  RubyGems to catch this in future.
- Ignore relevant RubyGems (and fix outdated comments)
- Never auto-`require` RubyGems that aren't vendored.
- Update `bundler/setup.rb`.
2020-08-27 14:03:03 +01:00
Mike McQuaid
943762f745 workflows/tests: run brew typecheck --quiet.
This will allow us to verify that we can merge new sorbet/tapioca
updates.
2020-08-27 08:49:25 +01:00
Mike McQuaid
c5f3afa992 workflows/tapioca: remove unnecessary steps. 2020-08-27 08:49:04 +01:00
vidusheeamoli
98f8235755 .github/workflows: use brew typecheck in tapioca.yml 2020-08-27 02:42:50 +05:30
Mike McQuaid
9ae0208347 workflows: improve scheduled behaviour. 2020-08-26 14:24:58 +01:00
Mike McQuaid
c6a5ea5f11 workflows: don't test paths on master.
This avoids weirdness like the merged PR commits being pushed to scheduled opened PRs after merging.

It also avoids wasting resources.
2020-08-26 14:02:44 +01:00
Mike McQuaid
d550ed65ac
Scheduled workflows fixes
- Ensure `spdx.yml` has same fixes as `tapioca.yml`.
- Don't `reset --hard` to ensure that `brew` commands used are those in
  the same branch rather than always from `origin/master`
- Don't check for an existing branch but instead force-push to it if
  there's any updates.
- Provide sample `brew typecheck` command that can be used.
2020-08-24 15:28:16 +01:00
Dawid Dziurla
0c94fac28c
workflows/tapioca: no HEAD for diff 2020-08-22 19:36:41 +02:00
Dawid Dziurla
b72ee12e8e
workflows/tapioca: add after diff 2020-08-22 19:31:13 +02:00
Dawid Dziurla
a9c8077947
workflows/tapioca: reset earlier 2020-08-22 19:25:17 +02:00
Dawid Dziurla
dcc6e7c514
workflows/tapioca: fetch origin/master and reset to it 2020-08-22 18:03:27 +02:00
Issy Long
e9b46b1967
workflows/tapioca: Don't reset tapioca-update branch to origin/master
- In all of the PRs that this Action triggered, the `tapioca-update`
  branch was >200 commits behind the latest `master`.
- As per https://github.com/Homebrew/brew/pull/8435#issuecomment-678546024,
  we shouldn't rely on the `Homebrew/actions/setup-homebrew` master
  (the `origin/master` ref) branch being up to date, so resetting to
  `origin/master` was a bad idea.
- A side effect of this is that when we raise PRs to change the Action,
  the PRs that it generates will include local commits. But functionally
  all we care about is the Action that runs on a schedule.
2020-08-22 16:52:06 +01:00
Dawid Dziurla
dc56b53392
workflows: add missing git subcommand 2020-08-22 00:21:50 +02:00
Mike McQuaid
235a663df0
scheduled workflows: fix branch, add new files.
- ensure we reset to `origin/master` so we only have the commit we care
  about in the PR
- ensure we `git add` to include any new files
- don't use `git commit -a` and instead rely only on files added with
  `git add`
2020-08-21 16:51:01 +01:00
Maxim Belkin
d7d754f23f Revert short titles 2020-08-21 15:08:56 +00:00
Mike McQuaid
1d3adda693
workflows: cleanup/fix tapioca and spdx update. 2020-08-21 15:34:57 +01:00
Issy Long
3b71e3d4fd
OK so the push needs the plain, Actions run GITHUB_TOKEN 2020-08-21 14:52:04 +01:00
Issy Long
b169ac85cb
Put all of the commit message in the autogenerated PR description
- This'll stop needs-response[bot] from moaning at us.
2020-08-21 14:52:04 +01:00
Issy Long
0244eb89ae
Push commits and raise PR using `HOMEBREW_GITHUB_API_TOKEN (BrewTestBot's)
- The github-actions[bot] PRs don't to trigger CI runs, and are hence
  unmergeable without manual intervention.
2020-08-21 14:52:04 +01:00
vidusheeamoli
982c7adaf2
.github/workflows: add action to update tapioca definitions
- Tapioca is a companion gem to Sorbet that generates RBI files for the
  Ruby gems in a project.
- Whenever Dependabot updates a gem, Tapioca has to regenerate that gem's
  RBI files so that Sorbet can accurately assess the state of the typing
  of a codebase.
- We also must regenerate Sorbet's view of
  [things defined at runtime](https://sorbet.org/docs/rbi#the-hidden-definition-rbi):
  this is what it calls `hidden-definitions`.
- Obviously, this got tedious to do manually. So here's an Action that
  runs every three days and raises a PR if there are any changes.

Co-authored-by: Vidushee Amoli <vidushee.amoli@gmail.com>
Co-authored-by: Issy Long <me@issyl0.co.uk>
Co-authored-by: Jonathan Chang <jchang641@gmail.com>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-08-21 14:52:03 +01:00
Maxim Belkin
57c02af359 Add template titles 2020-08-20 14:40:40 +00:00
Rylan Polster
90d9454d1e utils/spdx: add support for complex expressions
Co-authored-by: Seeker <meaningseeking@protonmail.com>
2020-08-19 12:47:58 -04:00
Mike McQuaid
d2fc08d942
GitHub Actions cleanup
- Add consistent spacing
- Remove `pull_request: []` warning
- remove identical, implicit `name` usage
- use `actions/cache@v1` for compatibility
2020-08-13 14:54:22 +01:00
Mike McQuaid
117cba9126
Merge pull request #8313 from maxim-belkin/gh-tests-tweaks
tests.yml: minor tweaks
2020-08-13 11:46:43 +01:00
Maxim Belkin
2b859282e0
tests.yml: address review comments 2020-08-12 07:52:36 -05:00
Maxim Belkin
133155397c
tests.yml: use proper matrix syntax
Co-authored-by: Bo Anderson <mail@boanderson.me>
2020-08-11 19:00:36 -05:00
Maxim Belkin
f6463c5a33
tests.yml: minor tweaks 2020-08-11 17:41:02 -05:00
Mike McQuaid
844c330cc5
workflows: test on "push" not "pull_request".
This ensures they have access to the correct secrets.
2020-08-11 14:01:27 +01:00
Markus Reiter
c92cfda328 Actually run brew cask style on all taps. 2020-08-09 18:04:21 +02:00
Mike McQuaid
a1dc809f5b
bin/brew: don't filter GitHub Actions variables. 2020-08-07 10:19:00 +01:00
Mike McQuaid
3e4da13934
Cleanup more GitHub Actions usage
Increase consistency between workflows, use more of our actions and
`@main`.
2020-08-06 19:35:39 +01:00
Mike McQuaid
b23d2f02a8
workflows/tests: cleanup steps.
Set up Homebrew should handle both the Git and Ruby setup for us (and
do so faster).
2020-08-06 14:02:47 +01:00
Mike McQuaid
b0d26b0dcf
workflows/tests: use setup-homebrew GitHub Action.
This allows more code reuse.
2020-08-06 10:55:18 +01:00
Mike McQuaid
d8442d175e
workflows/tests: tweak step naming.
This should make it a bit more obvious what is being tested each time.

The homebrew-core/linuxbrew-core style step actually runs the same
command but, as far as I can tell, there's no way of altering the string
that's output as the `name` based on the OS.
2020-08-04 16:04:09 +01:00
Jonathan Chang
bacc40b5be workflows: run spdx only on Homebrew/brew 2020-08-04 10:44:16 +10:00
Bo Anderson
5ebb5fa1a6
Merge pull request #8157 from Bo98/codecov-patch
codecov.yml: mark patch status as informational
2020-07-31 21:26:18 +01:00
Bo Anderson
2c9c876eb8 codecov.yml: mark patch status as informational 2020-07-31 17:19:20 +01:00
Mike McQuaid
8f4188926a
workflows/tests: run brew audit on homebrew/core.
Run brew audit without Git, style (RuboCop) or online checks for
homebrew/core. This is fast enough now (takes under a minute on my
machine) and these are the audit failures we should never accept
failures on (or introduce new ones without fixing them first).
2020-07-31 17:03:31 +01:00