20710 Commits

Author SHA1 Message Date
Mike McQuaid
2200b1ed40
Merge pull request #7231 from hyuraku/audit_github-prerelease_or_not
audit whether GitHub prerelease or not
2020-04-13 09:09:20 +01:00
Mike McQuaid
c5c161adb3
Merge pull request #7334 from Bo98/std-nehalem
ENV/std: conditionally apply AES-NI workaround
2020-04-13 09:05:29 +01:00
Mike McQuaid
9b8762f5c8
Merge pull request #7335 from Bo98/std-isysroot
ENV/std: remove space in -isysroot
2020-04-13 09:05:00 +01:00
Jonathan Chang
a2e16294e6
Merge pull request #7342 from jonchang/fix-audit
audit: fix keg_only check
2020-04-13 17:16:27 +10:00
Jonathan Chang
e6e5571a07 audit: fix keg_only check 2020-04-13 14:19:58 +10:00
Michka Popoff
c7927f5af5 formula: add linux and macos only function blocks 2020-04-12 23:51:41 +02:00
Issy Long
9e4dfaf726
Merge pull request #7337 from difelice/patch-1
Fix KegOnlyReason property access.
2020-04-12 21:39:38 +01:00
Alessandro Di Felice
b752efbd37
Fix KeyOnlyReason property access. 2020-04-12 10:08:35 -05:00
Mike McQuaid
afa5713e63
audit: cleanup prerelease detection. 2020-04-12 14:51:49 +01:00
Bo Anderson
32744e1746 ENV/std: remove space in -isysroot 2020-04-12 14:51:21 +01:00
Bo Anderson
df47668113 ENV/std: conditionally apply AES-NI workaround 2020-04-12 14:50:49 +01:00
Gautham G
b05c72b98b cli/args: Make build_from_source public instance method 2020-04-12 19:12:16 +05:30
Mike McQuaid
793407a2e0
Merge pull request #7328 from MikeMcQuaid/keg_only_tweaks
keg_only tweaks
2020-04-12 14:39:47 +01:00
Mike McQuaid
6ea6db9026
dev-cmd/audit: test presence of formulae in lists. 2020-04-12 14:17:06 +01:00
Mike McQuaid
b75733f1bd
rubocops: downgrade strict cops (passing in core). 2020-04-12 14:17:06 +01:00
Mike McQuaid
56c02485e0
rubocops: test whitelists. 2020-04-12 14:17:05 +01:00
Mike McQuaid
45908d8ff2
uses_from_macos: update openssl in whitelist. 2020-04-12 14:17:05 +01:00
Mike McQuaid
fbeeae96ef
rubocops/text: check openssl and openssl@1.1. 2020-04-12 14:17:05 +01:00
Mike McQuaid
3ded55aec2
rubocops/options: refactor unless ==. 2020-04-12 14:17:05 +01:00
Mike McQuaid
20998ed6e3
rubocop/lines: extract whitelist to constant. 2020-04-12 14:17:05 +01:00
Mike McQuaid
2e74e50f82
rubocop/conflicts: use full name in whitelist. 2020-04-12 14:17:05 +01:00
Mike McQuaid
c5b8983da4
rubocops/class: refactor unless && 2020-04-12 14:17:04 +01:00
Mike McQuaid
6b30a64831
Merge pull request #7332 from dawidd6/pr-uniq
pr-*: only unique named args
2020-04-12 13:31:54 +01:00
Mike McQuaid
0caa0718f5
Merge pull request #7331 from Bo98/pc-cflags
os/mac/pkgconfig: delete most cflags on 10.14+
2020-04-12 13:18:12 +01:00
Mike McQuaid
7f32e23a65
cmd/link: don't link shadowed macOS software. 2020-04-12 13:12:03 +01:00
Mike McQuaid
373650d00d
KegOnlyReason: add reason helpers, rename valid. 2020-04-12 13:12:02 +01:00
hyuraku
5578845e3f repair regex condition 2020-04-12 20:23:43 +09:00
Issy Long
c8867e5352
Merge pull request #7327 from issyl0/pull-deprecate-bottle
pull: Deprecate `--bottle` flag
2020-04-12 11:41:37 +01:00
Issy Long
3e2f183c60
pull: Remove --bottle flag
- Muscle memory is a thing, as is relying heavily on one's shell
  history. Now that the Jenkins runners are gone, `brew pull --bottle`
  no longer works. This removes the option. If maintainers are confused,
  they should [look at recent changes to the
  docs](https://docs.brew.sh/Brew-Test-Bot-For-Core-Contributors#bottling),
  or ask in Slack.
- An earlier iteration of this showed a deprecation warning and a link
  to the docs, but when an option no longer physically works it's a bit
  late for deprecation *warnings*.
- This also fixes a `brew style` warning from futher up in the file.

pull: Appease RuboCop
2020-04-12 11:24:22 +01:00
Dawid Dziurla
08309749d4
pr-*: only unique named args
also tweak usage to show that the commands accept multiple arguments
2020-04-12 12:13:53 +02:00
Jonathan Chang
56090cc03a
Merge pull request #7311 from jonchang/tap-shallow
tap: permit creating shallow taps
2020-04-12 15:20:13 +10:00
Bo Anderson
d8b1c4ff1f os/mac/pkgconfig: delete most cflags on 10.14+ 2020-04-12 00:42:18 +01:00
Markus Reiter
850a84ea1c
Merge pull request #7296 from reitermarkus/cask-commands
Refactor cask command parsing logic.
2020-04-11 17:21:58 +02:00
Gautham G
2bdbca1280 Revert "Merge pull request #7289 from Homebrew/revert-7279-argv-cleanup-18"
This reverts commit 64fd839c955b3c32855067d26fed7daf65183877, reversing
changes made to 6f50801b37b7d829afc37da76d2ef0a1ac1c9f5f.
2020-04-11 18:50:24 +05:30
Jonathan Chang
bec303de86
tap: update shallowing logic
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2020-04-11 22:41:04 +10:00
Jonathan Chang
c45116ebbc
Merge pull request #7326 from jonchang/pr-pull-dont-try-to-fetch-artifacts-when-not-needed
pr-pull: don't try to fetch artifacts for a pull request when the changed formulae don't use bottles
2020-04-11 22:40:24 +10:00
Jonathan Chang
cdd609357f
Merge pull request #7325 from jonchang/new-pr-pull-docs
docs: Update for new pr-* workflows
2020-04-11 22:31:54 +10:00
Mike McQuaid
0eff14db55
Merge pull request #7323 from Bo98/std-pc
Revert "ENV/std: withdraw support for Homebrew supplied *.pc files"
2020-04-11 13:12:58 +01:00
Mike McQuaid
73df5891ef
Merge pull request #7283 from claui/fix-make-tmpfile
Ensure TMPDIR is set for Xcode’s `make`
2020-04-11 13:11:30 +01:00
Jonathan Chang
e2507968da docs: remove old Jenkins assets 2020-04-11 20:06:32 +10:00
Jonathan Chang
cf63925005 docs: Update for new pr-* workflows 2020-04-11 20:06:31 +10:00
Jonathan Chang
f575eecabc pr-pull: don't try to fetch unneeded artifacts 2020-04-11 19:37:43 +10:00
Jonathan Chang
e974dce16e pr-pull: don't pass dry_run everywhere 2020-04-11 19:26:32 +10:00
Claudia
29538c89cd
Set TMPDIR for Xcode’s make
This fixes an issue where at least in Xcode 11.0, `make` uses
`/var/tmp` as a fallback for temporary files unless `TMPDIR` is set:

```
$ strings "$(xcrun -f make)" | grep -B 3 fopen
TMPDIR
/var/tmp/
GmXXXXXX
fopen (temporary file)
```

Given that Homebrew filtered `TMPDIR`, and the `/var/tmp` directory may
not be writable for non-root users, this would cause Homebrew’s
build environment to error out:

```
$ brew ruby -e 'puts ENV["TMPDIR"]; puts `: | make -f -`'
```

```
Ignoring bigdecimal-2.0.0 because its extensions are not built. Try: gem pristine bigdecimal --version 2.0.0
[…]
Ignoring zlib-1.1.0 because its extensions are not built. Try: gem pristine zlib --version 1.1.0
make: *** fopen (temporary file): Permission denied.  Stop.
```

In practice, this would break `brew audit`, `brew style`, and other
commands, which would run `make` to build native gem extensions.

This commit sets `TMPDIR` to `${HOMEBREW_TEMP}` in the gem environment, which
mirrors the behaviour we already have in other places.
We choose `HOMEBREW_TEMP` because that’s user-controlled but also falls
back to `/tmp` in case `TMPDIR` is not set in the user’s environment.

Thanks to Bo Anderson for helping find the bug.

CC: Bo Anderson <mail@boanderson.me>
2020-04-11 08:01:05 +02:00
Jonathan Chang
945fb11d51 tap: default to --shallow on CI 2020-04-11 13:12:09 +10:00
Markus Reiter
30c313b7b9 Refactor cask command parsing logic. 2020-04-11 01:29:44 +02:00
Bo Anderson
8900e852d6 Revert "ENV/std: withdraw support for Homebrew supplied *.pc files"
This reverts commit fa3591681800f9da06cd2d0179a5ef9e63b10729.
2020-04-10 21:47:54 +01:00
Markus Reiter
5b775afedd
Merge pull request #7322 from reitermarkus/spec-helper
Improve spec helper.
2020-04-10 20:44:06 +02:00
Bo Anderson
2c7908a979
Merge pull request #7321 from Bo98/pkg_config
ENV/super: don't set PKG_CONFIG
2020-04-10 19:26:03 +01:00
Markus Reiter
a6be0e62af Improve spec helper. 2020-04-10 19:39:43 +02:00