17311 Commits

Author SHA1 Message Date
Mike McQuaid
b33c823111
Merge pull request #7417 from claui/fix-cask-loading
Fix cask loading after adding an artifact type
2020-04-27 08:40:19 +01:00
Mike McQuaid
8c681d836b
Merge pull request #7441 from bayandin/bump-revision-stable-do
bump-revision: re-apply proper fix for handling stable block
2020-04-27 08:39:44 +01:00
Mike McQuaid
5618b9c53b
Merge pull request #7446 from Bo98/hombrew
cmd/list: fix Hombrew typo
2020-04-27 08:37:55 +01:00
dependabot-preview[bot]
00ae9f5a2e
build(deps): bump mime-types-data in /Library/Homebrew
Bumps [mime-types-data](https://github.com/mime-types/mime-types-data) from 3.2019.1009 to 3.2020.0425.
- [Release notes](https://github.com/mime-types/mime-types-data/releases)
- [Changelog](https://github.com/mime-types/mime-types-data/blob/master/History.md)
- [Commits](https://github.com/mime-types/mime-types-data/compare/v3.2019.1009...v3.2020.0425)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-27 06:01:38 +00:00
Bo Anderson
95f226cf51 cmd/list: fix Hombrew typo 2020-04-27 00:47:24 +01:00
Bo Anderson
c7120f1cfb os/mac/pkgconfig: add libffi.pc 2020-04-26 23:26:16 +01:00
Bo Anderson
c49c21faa3 os/mac/pkgconfig: add libedit.pc 2020-04-26 22:10:20 +01:00
Bo Anderson
29c121be98 os/mac/pkgconfig: add ncurses.pc & ncursesw.pc 2020-04-26 21:38:44 +01:00
EricFromCanada
5a4a57310f bump-revision: insert after homepage if stable block is present 2020-04-26 15:13:34 +01:00
Alexander Bayandin
7ba0f34f72 Revert "Merge pull request #7316 from bayandin/fix-bump-revision"
This reverts commit a7fdc7046f5cda8743591040117e409cd24dae76, reversing
changes made to bfa175d118112989b24908ea16c5a97c1dd011e4.
2020-04-26 15:11:31 +01:00
Frank Lam
dabbfe3e3e
Fix linter offenses 2020-04-26 21:31:21 +08:00
Mike McQuaid
bdc7ebf3c7
Merge pull request #7434 from GauthamGoli/argv-cleanup-22
ARGV: Deprecate ARGV.build_bottle? and replace with Homebrew.args.build_bottle
2020-04-26 14:14:35 +01:00
Frank Lam
f2fa2c5d30
Add JSON support to brew cask outdated
* brew outdated already has JSON support, now users and tools can get
similar results with brew cask outdated --json
2020-04-26 21:13:19 +08:00
Frank Lam
65ff9155f8
Add Cask#outdated_info to format output 2020-04-26 21:07:42 +08:00
Mike McQuaid
193f2c09fa
Merge pull request #7435 from bayandin/patch-2
bintray: fix package creation for verbose output
2020-04-26 13:40:27 +01:00
Mike McQuaid
a7fdc7046f
Merge pull request #7316 from bayandin/fix-bump-revision
bump-revision: fix handling formula with stable block
2020-04-26 13:31:45 +01:00
Gautham G
b0ac5bab31
ARGV: Deprecate ARGV.build_bottle? and replace with Homebrew.args.build_bottle 2020-04-26 13:28:44 +01:00
Alexander Bayandin
1d7ed982ec bintray: force curl to fail on server errors 2020-04-26 10:03:32 +01:00
Bo Anderson
d5ab6534c0
Merge pull request #7426 from Bo98/std-sdk
ENV/std: port superenv SDK changes
2020-04-24 20:43:02 +01:00
Bo Anderson
fb65d5a1f8 shims/super/cc: relax restrictions with -Xclang 2020-04-24 00:29:02 +01:00
Bo Anderson
41a666febb ENV/std: port superenv SDK changes 2020-04-23 18:11:10 +01:00
Mike McQuaid
d5ffb96d24
Merge pull request #7425 from Bo98/super-xcode
ENV/super: always set HOMEBREW_SDKROOT for Xcode builds
2020-04-23 11:54:59 +01:00
Bo Anderson
ae6c58c7bc ENV/super: always set HOMEBREW_SDKROOT for Xcode builds 2020-04-23 11:10:54 +01:00
EricFromCanada
78b87b7f23 sh: fix custom shell prompt for zsh 2020-04-23 00:38:36 -04:00
Bo Anderson
ef471e9767
Merge pull request #7423 from EricFromCanada/ruby-canonical_segments
ruby.sh: allow running on older Ruby versions
2020-04-22 23:21:00 +01:00
Alexander Bayandin
28def587f0 bintray: fix style 2020-04-22 22:42:26 +01:00
Eric Knibbe
fa1ce146e4 ruby.sh: allow running on older ruby versions 2020-04-22 17:36:00 -04:00
Bo Anderson
b619e31457 dev-cmd/audit: fix false openssl@1.1 versioned formula audit 2020-04-22 01:00:35 +01:00
Claudia
d026cb91e7
Fix cask loading after adding an artifact type
This commit fixes an issue where we added a new global artifact
and then updated a cask to make use of that new artifact.
This caused a number of `brew cask` commands to fail for users
who had the cask installed before the artifact was added.

When loading the definition of an installed cask, we configure it
using a snapshot from install time, e. g. `/usr/local/Caskroom/markdownmdimporter/.metadata/config.json`.

The snapshot looks like this:

```
{
  "default": {
    "appdir": "/Applications",
    "prefpanedir": "/Users/claudia/Library/PreferencePanes",
    "qlplugindir": "/Users/claudia/Library/QuickLook",
    "dictionarydir": "/Users/claudia/Library/Dictionaries",
    "fontdir": "/Users/claudia/Library/Fonts",
    "colorpickerdir": "/Users/claudia/Library/ColorPickers",
    "servicedir": "/Users/claudia/Library/Services",
    "input_methoddir": "/Users/claudia/Library/Input Methods",
    "internet_plugindir": "/Users/claudia/Library/Internet Plug-Ins",
    "audio_unit_plugindir": "/Users/claudia/Library/Audio/Plug-Ins/Components",
    "vst_plugindir": "/Users/claudia/Library/Audio/Plug-Ins/VST",
    "vst3_plugindir": "/Users/claudia/Library/Audio/Plug-Ins/VST3",
    "screen_saverdir": "/Users/claudia/Library/Screen Savers"
  },
  "env": {},
  "explicit": {}
}
```

Note that there is no `mdimporterdir` because the cask was installed
before the artifact was added.

The root cause is that the cask loading code still expects the snapshot
to contain directory configuration for all artifact types.
Since the snapshot never learned about the new artifact type, cask
loading would fail.

The fix applied in this commit is to fall back to the global default
whenever the `default` directory map of a configuration snapshot is
incomplete.

See also:
- https://github.com/Homebrew/brew/pull/7286#issuecomment-613376568
- https://discourse.brew.sh/t/cask-definition-is-invalid-invalid-mdimporter-stanza-key-not-found-mdimporterdir
2020-04-21 18:29:14 +02:00
Claudia
374f788a3c
cask/config_spec: add failing test
We recently added a new global artifact and then updated a cask to
make use of that new artifact. This caused a number of `brew cask`
commands to fail for users who had the cask installed before the
artifact was added.

This commit adds test cases for that failure mode.

See also:
- https://github.com/Homebrew/brew/pull/7286#issuecomment-613376568
- https://discourse.brew.sh/t/cask-definition-is-invalid-invalid-mdimporter-stanza-key-not-found-mdimporterdir
2020-04-21 18:26:51 +02:00
Alexander Bayandin
bd24f5a45e bintray: fix package creation 2020-04-21 14:36:01 +01:00
Mike McQuaid
b3a7ad7ca6
formula_installer: fix build_from_source? call.
This should check the local instance variable rather than the global
value as it varies for dependencies and requested formulae.
2020-04-21 13:26:37 +01:00
Shaun Jackman
6b547a5c5e pr-upload: Fix a bug introduced by PR #7406
Fix the error:
Error: No such file or directory @ rb_sysopen - bottle
2020-04-20 15:16:08 -07:00
Mike McQuaid
d6e7003ef2
Merge pull request #7407 from sjackman/uses_from_macos
uses_from_macos: Add gzip rsync to the white list
2020-04-20 20:13:24 +01:00
Mike McQuaid
6d999f95d2
Merge pull request #7406 from sjackman/pr-upload-root-url
pr-upload: Add argument root-url
2020-04-20 20:12:59 +01:00
Mike McQuaid
cc74c4a742
Merge pull request #7409 from MikeMcQuaid/brew-pull-args
pull: fix head_revision definition.
2020-04-20 20:12:09 +01:00
Mike McQuaid
9457d1af5e
pull: fix head_revision definition.
Fixes #7405.
2020-04-20 19:54:38 +01:00
Shaun Jackman
ffb405019d uses_from_macos: Add gzip rsync to the white list
/usr/bin/gzip and /usr/bin/rsync are provided by macOS.
2020-04-20 11:52:58 -07:00
Shaun Jackman
29ae567868 pr-upload: Add argument root-url
The argument root-url is needed for third-party taps.
2020-04-20 11:47:57 -07:00
Mike McQuaid
fb0fa419ab
cask/cmd/upgrade_spec: remove more flaky tests. 2020-04-20 16:45:44 +01:00
Gautham G
676ebf7419
ARGV: Deprecate ARGV.force_bottle? 2020-04-20 16:45:43 +01:00
Mike McQuaid
a5b6c5f262
Merge pull request #7382 from dawidd6/whitelist-bin-config
diagnostic: whitelist /bin and /sbin for *-config files
2020-04-20 16:38:56 +01:00
Mike McQuaid
c4fed07d34
Merge pull request #7401 from dawidd6/pr-upload
Add pr-upload command
2020-04-20 16:33:06 +01:00
Dawid Dziurla
80e118cba3
diagnostic: whitelist /bin and /sbin for *-config files 2020-04-20 16:18:56 +01:00
Dawid Dziurla
3dd5a7465d
add pr-upload command 2020-04-20 13:37:05 +02:00
Mike McQuaid
f074e3a355
Merge pull request #7399 from MikeMcQuaid/uses_from_macos_updates
rubocops/uses_from_macos: update list.
2020-04-20 10:56:15 +01:00
Mike McQuaid
9eed1e4e7e
Merge pull request #7400 from MikeMcQuaid/cleanup_max_age_days
cleanup: all configuring max age days.
2020-04-20 10:54:58 +01:00
Mike McQuaid
c6d5bdcb82
Merge pull request #7402 from MikeMcQuaid/cli-args-formula-options
Remove ARGV_WITHOUT_MONKEY_PATCHING
2020-04-20 10:54:46 +01:00
Mike McQuaid
cddc67b451
rubocops/uses_from_macos: update list.
Also, provide details on how to update this in future and split it into
two.

Fixes #7396
2020-04-20 10:36:42 +01:00
Mike McQuaid
701c1811d5
cleanup: all configuring max age days.
Fixes #7320
2020-04-20 10:33:15 +01:00