16336 Commits

Author SHA1 Message Date
Samuel John
a3a0146d7c Python module deps, ext. python fix and 10.6 fix
* Fixes Homebrew/homebrew#20572 by tweaking the logic that decides
  which python is used by the `python` object
  inside a formula. There was a bug when on 10.6
  there is no Python 2.7 but a :recommended
  Python was still treated as being available.

* Use the user's PATH when looking for an external
  Python. Until now only brewed or OS X system's
  python have been found by `depends_on :python`.

  But now we support any Python in PATH (e.g.
  pyenv's python).

* Further, instead of handling python modules
  and import tests in LanguageModuleDependency,
  these are now handled by:

        depends_on :python => 'numpy'  # for example

  The old style

        depends_on 'numpy' => :python

  is still supported and is only an alias
  for the newer style (only for :python, the
  other languages are not altered by this commit).

  The reasoning is that if a formula requires
  a python module, it basically also needs
  python itself - and further that specific
  version of python has to provide the module.
  So the `PythonInstalled` is the natural place
  to check for the availability of a python
  module.

  Using a python module and other tags like
  :optional or :recommended is done like so:

        depends_on :python => [:optional, 'numpy']

  Specifying another PyPi (Python Package index)
  name than the module import name is seldom used
  but supported, too:

         depends_on :python => ['enchant'=>'pyenchant']

  A last note: For clarity, you can define
  multiple depends_on statements with different
  modules to be importable.`
2013-06-18 10:30:17 +02:00
Clemens Gruber
c5f9f42e51 Fix Xcode builds on 10.9.
CLT-only builds are still broken and need to be fixed at some point.

Closes Homebrew/homebrew#20524.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2013-06-17 09:14:17 +01:00
Adam Vandenberg
32f637d590 Add minimum OS X version requirement
Closes Homebrew/homebrew#19998.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2013-06-16 20:36:50 -07:00
Jack Nagel
45d3e436ee Simplify regexp match 2013-06-15 19:51:49 -05:00
Jack Nagel
d98ff95b3e These also get coerced to strings 2013-06-15 19:51:35 -05:00
Jack Nagel
49c9097b07 Push MacOS.cat logic down into MacOS::Version 2013-06-15 19:40:42 -05:00
Jack Nagel
3cd1a0e696 Add MacOS::Version.from_symbol 2013-06-15 19:39:27 -05:00
Jack Nagel
e9d245cf3a Avoid unnecessary float to string conversion 2013-06-15 10:13:20 -05:00
Jack Nagel
2e2d922190 Run tests under actual OS version 2013-06-14 19:19:26 -05:00
Jack Nagel
9e771b0e34 Simplify setting MACOS_VERSION 2013-06-14 19:19:25 -05:00
Jack Nagel
e59456515d Pass these as strings, they get converted anyway 2013-06-14 19:10:14 -05:00
Jack Nagel
113125d394 Remove Version#to_a alias
Exposing this as "to_a" was a mistake, versions are not arrays and it
causes incorrect behavior when splatted or using Kernel#Array(). Use the
more correct name "tokens" instead.
2013-06-14 18:37:27 -05:00
Adam Vandenberg
ca10e5005a Fix pretty names 2013-06-14 14:47:16 -07:00
Adam Vandenberg
8739eeab7d Move pretty_name into MacOS::Version
Closes Homebrew/homebrew#20507.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2013-06-14 13:36:20 -07:00
Jack Nagel
5539c97191 Fix another constant reference 2013-06-14 11:49:00 -05:00
Jack Nagel
a463398a8b Fix constant reference 2013-06-14 11:09:53 -05:00
Jack Nagel
eee5a09202 Favor compound if over compound unless 2013-06-14 10:34:20 -05:00
Jack Nagel
9427704176 Use ||= instead of unless 2013-06-14 10:34:20 -05:00
Jack Nagel
e73f869d84 Remove outdated comment 2013-06-14 10:34:20 -05:00
Jack Nagel
381255adec Assign this inline 2013-06-14 10:34:19 -05:00
Jack Nagel
3252f9a2c9 Delete rather than assign nil 2013-06-14 10:34:19 -05:00
Jack Nagel
723f7ed111 Simplify nested conditional 2013-06-14 10:34:19 -05:00
Jack Nagel
4e4a5af731 Use has_key? rather than accessing the value 2013-06-14 10:34:18 -05:00
Jack Nagel
020a505970 Rename single-letter variable 2013-06-14 10:34:18 -05:00
Jack Nagel
a458555ccb Make flag lists into constants 2013-06-14 10:34:18 -05:00
Jack Nagel
7d6371cd19 ENV: clean up set_cpu_flags and set_cpu_cflags usage 2013-06-14 10:34:18 -05:00
Jack Nagel
50db35e5d3 Use Hardware::CPU module 2013-06-14 10:34:17 -05:00
Jack Nagel
dc454aad92 Freeze optimization flags hash rather than duping it 2013-06-14 10:34:17 -05:00
Jack Nagel
4498db7887 Xcode 4.6.3 2013-06-13 18:22:28 -05:00
Adam Vandenberg
313134fbe3 ScriptFileFormula: remove override warning
Closes Homebrew/homebrew#20445.
2013-06-13 09:34:43 -07:00
Clemens Gruber
fc649af17a superenv: apply apr-1-config fix to 10.8+
Fixes Homebrew/homebrew#20417.
Closes Homebrew/homebrew#20474.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-06-13 11:33:16 -05:00
Simon Sigurdhsson
776c08490f Fix bug in brew list --pinned
Pinned formulae which were pinned at a previous version but then upgraded
would not be listed by `brew list --pinned`. This is due to the good old
"File.exist? thinks broken symlinks don't exist" gotcha, so the test in
the select block in list_pinned has been changed to check if the pin file
exists _or_ is a symlink.

Closes Homebrew/homebrew#20423.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-06-13 10:22:03 -05:00
Jack Nagel
0f314f9808 Remove unused variable 2013-06-12 17:25:29 -05:00
Jack Nagel
630aa27c56 Rename variables for clarity 2013-06-12 14:48:17 -05:00
Jack Nagel
5482092bd0 Extract search_taps method 2013-06-12 14:48:17 -05:00
Jack Nagel
e0fba99699 Pull tap list into a constant 2013-06-12 14:48:17 -05:00
Jack Nagel
c30f00c37c Remove use of global variable 2013-06-12 14:48:17 -05:00
Jack Nagel
d1a1a3b031 Rename method 2013-06-12 14:48:16 -05:00
Jack Nagel
1d1c292bcb Extract query construction 2013-06-12 14:48:16 -05:00
Jack Nagel
90768d03d2 Use inspect instead of escaping quotes 2013-06-12 14:48:16 -05:00
Jack Nagel
13a2ceef5c Move require out of method 2013-06-12 12:23:45 -05:00
Jack Nagel
2045217a68 install: remove overcautious array manipulation 2013-06-12 09:02:20 -05:00
Jack Nagel
5369199df3 Fix version misdetection from fa582cb9ac65 2013-06-11 17:34:21 -05:00
Jack Nagel
fdaea3189d Check method existence rather than Ruby version 2013-06-11 17:05:44 -05:00
Jack Nagel
28b9790dbd FormulaInstaller: ensure locks are always released 2013-06-11 15:35:30 -05:00
Clemens Gruber
15626b38ca Recognize OS X 10.9 and Xcode 5.0
Closes Homebrew/homebrew#20410.
Closes Homebrew/homebrew#20401.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-06-11 10:20:23 -05:00
Jack Nagel
652e0982f0 Add doctor check for OS X > 10.8 2013-06-11 10:18:24 -05:00
Misty De Meo
ef054a2d02 doctor: add check for osx-gcc-installer
This might not detect all cases, but should detect the two most
common ones.
2013-06-11 08:13:24 -05:00
Jack Nagel
580eea89be Cast deps to formula before passing them to superenv
Dependency names retain the "tap prefix", e.g. the "homebrew/dupes"
part of "homebrew/dupes/zlib". However formula objects do not, and this
is desired because we do not record the tap name as part of the
installation prefix.

So we need to ensure the correct dep names are passed to superenv,
otherwise it will not add the correct directories to various environment
variables.
2013-06-10 17:38:52 -05:00
Jack Nagel
784c9670f1 Add failing test for a misdetected version 2013-06-10 14:55:23 -05:00