admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
20,710 Commits 15 Branches 471 Tags
Commit Graph

3156 Commits

Author SHA1 Message Date
Mike McQuaid
3bde17c9f9
Cleanup from dev-cmd test changes 
- Remove added whitespace in `extend/os/linux/keg_relocate`
- Cleanup testball bottles
 2019-03-27 10:31:26 +00:00
Mike McQuaid
59d680a626
dev-cmd: only one integration test per command. 
Integration tests are useful in detecting breakages but much slower so
let's only use one per command and install formula outside the
integration test framework (which is also slow).
 2019-03-27 09:45:48 +00:00
Mike McQuaid
cf4511f72a
Merge pull request #5538 from zachauten/brew-info-display-casks 
Make brew info output cask if no formula exists
 2019-03-25 16:54:03 +00:00
Zach Auten
999c4743d0 Added flag for cask_reason to output cask info or just message with cask name 2019-03-24 15:28:34 -04:00
Mike McQuaid
3615f891f7
tap-new: improve output. 
Note the tap path.

References #5901.
 2019-03-23 12:41:35 +00:00
Zach Auten
63a0aa92d1 Removed info_spec integration test and replaced with unit test in missing_formula_spec 2019-03-21 17:18:21 -04:00
Shaun Jackman
5cb458d687 install_symlink_p: Fix when dest includes a symlink 
install_symlink_p does not work as intended when dst includes a symlink in its path.
relative_path_from requires that both src and dst be real paths without symlinks.

From https://ruby-doc.org/stdlib-2.3.7/libdoc/pathname/rdoc/Pathname.html#method-i-relative_path_from
This method doesn't access the filesystem. It assumes no symlinks.
 2019-03-16 23:11:59 -07:00
Zach Auten
9eadee9408 moved info_spec cask test to its own describe block to fix error 2019-03-15 22:19:12 -04:00
Zach Auten
75b9eec7ef Renamed print_caveats, updated an info_spec test to macos only 2019-03-11 21:20:02 -04:00
Jonathan Chang
90f402d8a2 cpu: tests permit new families and architectures 2019-03-08 16:05:12 +11:00
Zach Auten
dd4daa247f Merge branch 'master' of https://github.com/Homebrew/brew into brew-info-display-casks 2019-03-06 17:56:22 -05:00
Zach Auten
fe643758d7 Updated get_info 
- get_info builds info string by appending helper functions
  - removed unnecessary returns
  - fixed indentation in missing_formula
  - reduced size of regex in info_spec
  - missing_formula will indicate when it finds a cask with same name
 2019-03-06 00:27:48 -05:00
Markus Reiter
42d90f8bd9 Use same logic for installer script: and uninstall script:. 2019-03-03 06:21:11 +01:00
Shaun Jackman
82da3b43cc audit: Keg-only :provided_by_macos dep okay on Linux 
Disable this brew audit error on Linux:
* Dependency 'zlib' may be unnecessary as it is provided by macOS;
try to build this formula without it.
 2019-03-02 13:29:49 -08:00
Mike McQuaid
17f3ee1957
Improve Bundler cleanup 
Rather than trying to be smart and doing this ourselves in `brew cleanup` let’s just installed Bundler somewhere it doesn’t try to clean itself up and use `bundle install --cleanup` when we need cleanup done.

Also, use `ohai` and `odie` when possible as they look nicer.
 2019-02-27 14:02:46 +00:00
Mike McQuaid
d1f755959a
Merge pull request #5805 from BenMusch/handle-conflicts 
Fix bug in CLI arg/env var prioritization + corresponding tests
 2019-02-26 07:55:19 +00:00
Ben Muschol
4c6ca1c5d9 Fix stub orders, :env_var reference 2019-02-25 15:18:14 -05:00
Mike McQuaid
fcfabfb3c6
dev-cmd/pull_spec: require Homebrew/homebrew-core for subtest. 2019-02-25 17:21:09 +00:00
Mike McQuaid
921d4aad77
Unify test/vendor Gemfiles and bundler configuration. 2019-02-21 16:34:19 +00:00
Mike McQuaid
e095da4d01
rubocop: enable Layout/EmptyLineAfterGuardClause. 2019-02-21 12:55:49 +00:00
Mike McQuaid
d64429a736
rubocop: enable Style/IfUnlessModifier. 2019-02-21 12:55:49 +00:00
dependabot[bot]
eca4af2031
Bump rubocop from 0.64.0 to 0.65.0 in /Library/Homebrew/test 
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.64.0 to 0.65.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.64.0...v0.65.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-02-21 12:55:49 +00:00
Zach Auten
554106d2e0 Updated missing formula cask reason 
- search_for_cask in missing_formula renamed to is_a_cask_reason
    - is_a_cask calls new getInfo method in cask/cmd/info.rb to return info
      string
    - self.info in info.rb now calls getInfo and puts return value
    - added ohai_title to return the ohai printout for only titles, so that
      ohai printout could be added to the getInfo return string without
      calling puts.
    - refactored ohai to use ohai_title
    - updated info_spec.rb cask info test to be more specific when
      matching stderr.
    - is_a_cask_reason will respect 'silent'
    - refactored print_caveats to return instead of print
 2019-02-18 03:33:57 -05:00
Zach Auten
648c8e4672 Merge branch 'master' into brew-info-display-casks 2019-02-18 03:26:43 -05:00
Shaun Jackman
3bcffeae15 tests: Disable tests that require being non-root 
Set the environment variable USER=root which is required by
brew tests --only=utils/user

Fix these tests:
rspec ./test/diagnostic_checks_spec.rb:26 # Homebrew::Diagnostic::Checks #check_access_directories
rspec ./test/pathname_spec.rb:120 # Pathname#ensure_writable makes a file writable and restores permissions
rspec ./test/utils/user_spec.rb:22 # User#gui? when the current user is in a console session gui? should equal true
rspec ./test/utils/user_spec.rb:6 # User should eq nil
 2019-02-16 12:55:09 -08:00
Mike McQuaid
f3716fe2d8
Merge pull request #5738 from BenMusch/handle-conflicts 
Prioritize CLI arguments over env vars when they conflict
 2019-02-16 19:15:05 +00:00
Ben Muschol
c7831a457d Get brew style to pass 2019-02-16 07:56:12 -05:00
Ben Muschol
c745738c55 Make from: required, fix flaky test 2019-02-15 14:15:34 -05:00
Markus Reiter
78d4373543 Simplify DEFAULT_DIRS. 2019-02-15 10:09:14 +01:00
Markus Reiter
707cb33346 Add tests for Cask::Config. 2019-02-15 10:09:14 +01:00
Markus Reiter
190ff7558a Use saved cask config for reinstall/upgrade/uninstall. 2019-02-15 10:09:14 +01:00
Markus Reiter
fda6e0cab3 Split cask config into three tiers. 2019-02-15 10:09:14 +01:00
Markus Reiter
1e1ce1c471 Save config file for casks. 2019-02-15 10:09:14 +01:00
Ben Muschol
f8d84249aa Prioritize CLI arguments over env vars when they conflict 2019-02-15 00:52:30 -05:00
Mike McQuaid
3060125c45
rubocop: autofix problems. 2019-02-11 09:50:09 +00:00
Mike McQuaid
a30d0c7961
Merge remote-tracking branch 'origin/dependabot/bundler/Library/Homebrew/vendor/rubocop-0.64.0' into dependabot/bundler/Library/Homebrew/test/rubocop-0.64.0 2019-02-11 09:44:40 +00:00
Markus Reiter
6ae600b5e6
Merge pull request #5689 from Homebrew/dependabot/bundler/Library/Homebrew/test/parallel_tests-2.28.0 
Bump parallel_tests from 2.27.1 to 2.28.0 in /Library/Homebrew/test
 2019-02-11 03:28:11 +01:00
dependabot[bot]
f1c217b32b
Bump rubocop from 0.63.1 to 0.64.0 in /Library/Homebrew/test 
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.63.1 to 0.64.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.63.1...v0.64.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-02-10 13:56:34 +00:00
Markus Reiter
0fcc62db31 Run uninstall rmdir: after uninstalling artifacts. 2019-02-08 01:09:48 +01:00
dependabot[bot]
1304c329d0
Bump parallel_tests from 2.27.1 to 2.28.0 in /Library/Homebrew/test 
Bumps [parallel_tests](https://github.com/grosser/parallel_tests) from 2.27.1 to 2.28.0.
- [Release notes](https://github.com/grosser/parallel_tests/releases)
- [Commits](https://github.com/grosser/parallel_tests/compare/v2.27.1...v2.28.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-02-07 19:27:02 +00:00
Danny Weinberg
b0124c4fb0 Cask handle already downloaded file 
The current logic for curl_download tries to restart any existing
partial download, but this fails for some servers when the file is
already fully downloaded, returning a status code 416. This updates the
function to check for the file being already downloaded and if so bails
early.

The following command used to fail when run more than once but now works
as expected:
```
brew cask info https://raw.githubusercontent.com/homebrew/homebrew-cask/master/Casks/docker.rb
```
 2019-02-01 14:57:50 -08:00
Mike McQuaid
fd4e45c688
lines_spec: fix a typo. 2019-01-30 21:59:55 +00:00
Mike McQuaid
4ace1af297
help: improve command --help output. 2019-01-30 21:39:29 +00:00
Mike McQuaid
9eabcdad7d
Make install/reinstall/upgrade options more consistent. 2019-01-29 19:25:59 +00:00
Mike McQuaid
618f75c071
Merge pull request #5619 from GauthamGoli/install-args 
install: Use CLI::Parser to parse args
 2019-01-29 14:11:22 +00:00
Mike McQuaid
49d3849507
cmd/install_spec: test new invalid option behaviour. 2019-01-29 10:48:39 +00:00
Mike McQuaid
24eb8e8e54
Remove (now) unused invalid_option_names. 
This is handled by `OptionParser` now instead in `cmd/install`.
 2019-01-29 08:31:45 +00:00
Markus Reiter
a198b0ef43
Merge pull request #5628 from reitermarkus/conflicts-with 
Refactor `ConflictsWith` to be a `DelegateClass(Hash)`.
 2019-01-28 22:31:08 +01:00
Mike McQuaid
28fa8a7c97
version: add CPU tests. 
Add a new API inspired by discussion in
https://github.com/Homebrew/homebrew-core/pull/36435 to query if a given
CPU option is supported by a version of macOS.
 2019-01-28 19:31:21 +00:00
Markus Reiter
d22c2eca9e Refactor ConflictsWith to be a DelegateClass(Hash). 2019-01-27 21:48:12 +01:00