admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
34,668 Commits 15 Branches 471 Tags
Commit Graph

2662 Commits

Author SHA1 Message Date
Mike McQuaid
5e0b3d24e5 audit: fix "version should not decrease" (again). 
- output the max version and current version to make the message more
  obvious.
- Don't compare the development spec version to the formula version and
  then complain the formula version is lower (it should always be!)
 2016-11-15 09:02:50 +00:00
Markus Reiter
c648518f35 Rename single line block parameters to acc/elem. 2016-11-13 23:36:04 +01:00
Mike McQuaid
c78aa43386 audit: fix "version should not decrease" check. 
Fix the "version should not decrease" check so it correctly handles
`version_scheme`s.

Fixes #1489.
 2016-11-13 13:35:25 +00:00
Mike McQuaid
bc67414b9a Merge pull request #1449 from ilovezfs/bottle-improve-relocatability-check 
bottle: improve relocatability check
 2016-11-06 08:15:13 -05:00
ilovezfs
c5bd5c4aa7 bottle: improve relocatability check 
Given how common it is for formulae to hard-code `etc` and `var`, check
for those paths (`/usr/local/etc` and `/usr/local/var`) when determing
relocatability.
 2016-11-06 04:00:14 -08:00
Baptiste Fontaine
bfa19b3385 audit: Escape interpolated string in regexp 
This avoids issues with names containing special characters like e.g. [

Fixes #1431
 2016-11-03 18:17:11 +01:00
Mandar Gokhale
0e15ffff62 Correct a few typos 
...and update man pages where applicable
 2016-11-03 12:09:44 +00:00
Mike McQuaid
2a865f085e Merge pull request #1424 from MikeMcQuaid/audit-more-test-system 
audit: check more unscoped test calls.
 2016-11-02 21:50:54 -04:00
Steven Peters
72f889fef0 audit: restore check that was lost in #927 
This audit check ensures that certain build dependencies
are explicitly marked either as `:build` or `:run`.
It seems to have been lost in #927.
It was also adjusted in #1290.
 2016-11-02 16:52:09 -07:00
Mike McQuaid
f35a86ff70 audit: stricter test system calls check. 
Ensure that the name is suffixed with whitespace or quotes.
 2016-11-02 15:57:19 -04:00
Mike McQuaid
7aa26f7817 audit: check more unscoped test calls. 
Also check `def test`, `shell_output`, `pipe_output` and method calls
using parentheses.
 2016-11-02 13:23:38 -04:00
Mike McQuaid
b3ef8bd044 Merge pull request #1369 from MikeMcQuaid/boneyard-reason 
boneyard-formula-pr: add reason argument.
 2016-11-02 12:00:33 -04:00
Mike McQuaid
9f382bfd53 boneyard-formula-pr: add reason argument. 
Used to provide a user-facing reason why this formula was boneyarded.
 2016-10-30 15:40:11 -04:00
Baptiste Fontaine
127461d879 audit: don't check new formulae revision/versions. 2016-10-30 13:51:23 -04:00
Mike McQuaid
ef58225749 audit: check the version does not decrease. 
This will prevent brew upgrade from working correctly.
 2016-10-30 13:51:21 -04:00
Mike McQuaid
8d5df2ea87 Merge pull request #1402 from MikeMcQuaid/audit-system-test 
audit: check test system calls are fully scoped.
 2016-10-30 13:30:03 -04:00
Mike McQuaid
20c8c5958e Merge pull request #1367 from MikeMcQuaid/audit-check-master-branch 
audit: check for master branch tar/zipballs.
 2016-10-30 13:29:47 -04:00
Mike McQuaid
a093c62b16 Revert "audit: check the version does not decrease." 2016-10-30 07:32:20 -04:00
Markus Reiter
5e44184b35 Merge pull request #1400 from reitermarkus/move-bundle-path 
Move `test/vendor/bundle` to `vendor/bundle`.
 2016-10-30 01:41:10 +02:00
Mike McQuaid
0bd0fec6a6 audit: check test system calls are fully scoped. 
This doesn't matter for everything but it does for the binaries that
are installed. Have a limited name/alias check when not installed and
a better one that iterates bin/sbin if installed.
 2016-10-29 17:53:05 -04:00
Mike McQuaid
337810bf3e audit: check for master branch tar/zipballs. 
These have unstable checksums and aren't the tagged, stable releases
we require.
 2016-10-29 17:52:13 -04:00
Mike McQuaid
9ab38dd751 Merge pull request #1366 from MikeMcQuaid/audit-check-version-decrease 
audit: check the version does not decrease.
 2016-10-29 17:50:41 -04:00
Markus Reiter
f863d61374 Move vendor/bundle up one level to HOMEBREW_LIBRARY_PATH. 2016-10-29 18:28:07 +02:00
Mike McQuaid
59933f5cd9 update-test: fix --to-tag failure on new tag. 
Without this updating to a tag will always have the same start commit
and end commit as there's been no updates to `master` since the tag was
created.
 2016-10-29 09:09:00 -04:00
Mike McQuaid
84d1661b9a Merge pull request #1365 from MikeMcQuaid/audit-stable-url-beta 
audit: check for alpha/beta/rc usage in URLs.
 2016-10-25 08:17:40 -04:00
Zhiming Wang
dd527bfcdc
bottle: fix nonexistent pyc bug 
We were deleting pyc files *after* replace_locations_with_placeholders
and recording changed_files, meaning that some of the recorded files
were to be deleted. The correct order is the opposite.

A sample failed session: https://bot.brew.sh/job/Homebrew%20Core/10080/version=el_capitan/testReport/junit/brew-test-bot/el_capitan/bottle_buku/.
 2016-10-25 01:44:40 -04:00
Josh Hagins
9c519bbdbc keg_relocate: refactor relocate_text_files 
Replace relocate_text_files with three methods that clarify intent:
replace_locations_with_placeholders, replace_placeholders_with_locations
and replace_text_in_files, the first two calling the third.
 2016-10-24 16:21:08 -04:00
Josh Hagins
c46155aba4 keg_relocate: cache files rewritten during brew bottle 
`brew bottle` replaces instances of the Homebrew prefix, cellar, and
repository with placeholders in all text files. Cache these files in
INSTALL_RECEIPT.json so that we don't have to check every single text
file for placeholders on install.
 2016-10-24 16:21:08 -04:00
Markus Reiter
b28b21fd7f Don’t use bare percent literals. 2016-10-24 17:27:20 +02:00
Mike McQuaid
b39f87e710 audit: check for alpha/beta/rc usage in URLs. 
Stable URLs should not use unstable versions.
 2016-10-24 14:54:28 +01:00
Mike McQuaid
762b76e437 audit: check the version does not decrease. 
This will prevent `brew upgrade` from working correctly.
 2016-10-24 10:21:07 +01:00
Josh Hagins
1d8e59b31f dev-cmd/man: use SOURCE_PATH instead of HOMEBREW_LIBRARY 
Don't Repeat Yourself.
 2016-10-23 01:22:56 -04:00
Mike McQuaid
c521ff4a94 Merge pull request #1345 from MikeMcQuaid/rubocop-style 
Update Rubocop style.
 2016-10-22 15:25:28 +01:00
Mike McQuaid
22182403c5 Merge pull request #1310 from MikeMcQuaid/changelog 
Add `brew release-notes` developer command.
 2016-10-22 13:40:05 +01:00
Mike McQuaid
1f963267b6 Update Rubocop style. 
Another look at the current Rubocop rules and how they fit with our
existing and desired future style. Almost all of these changes were
automatic. Split some rules between formulae/brew where brew doesn't
have millions of cases that need fixed.
 2016-10-22 13:32:46 +01:00
Mike McQuaid
0c661f5c90 Add brew release-notes developer command. 
Outputs the merged pull requests on Homebrew/brew between two Git refs.
 2016-10-22 12:10:48 +01:00
Mike McQuaid
56ae868cf1 audit: don't complain about trailing whitespace. 
This is handled by `brew style` now.
 2016-10-18 08:11:02 +01:00
Mike McQuaid
7ac90613fd Merge pull request #1290 from maxnordlund/patch-1 
Fix wrong ordering on when clauses in audit.rb
 2016-10-15 17:52:54 +01:00
Max Nordlund
c7fde5ddc9 Fix when clause ordering. 2016-10-15 18:31:06 +02:00
Mike McQuaid
f435adc2d0 Rename tap-readme command to tap-new. 
Write the README but also a `.travis.yml` file (and in future perhaps a
`Jenkinsfile`).
 2016-10-15 12:32:34 +01:00
Max Nordlund
d9242c540d Fix wrong ordering on when clauses in audit.rb 
It looks like a rebase/merge conflict remmenet.
 2016-10-14 23:05:34 +02:00
Mike McQuaid
26e4899fde Deprecate apr requirement. 
It's not used on enough configurations now that there's little point in
keeping it around. See e.g. `:autoconf` for prior art.
 2016-10-12 15:37:33 +01:00
Jonathan Chang
5b360c57e3 audit: forbid deprecated_option in new formulae 2016-10-05 15:59:16 -07:00
Markus Reiter
cafe149780 Merge pull request #1145 from reitermarkus/module-function 
Use `module_function` for `Homebrew` module.
 2016-10-04 10:31:49 +02:00
Mike McQuaid
ea5aff8d7c Merge pull request #1193 from MatzFan/fix_verbose_tests 
fix tests failing when verbose set
 2016-10-03 16:50:24 +01:00
Mike McQuaid
c6f5d24238 update-test: fix tag updating, skip core tap. 
Fix updating the `stable` branch used for tagged updates and ensure
that the core tap isn’t retapped (the slowest part by far of this test).
 2016-10-02 17:16:35 +01:00
Markus Reiter
6201f01722 Fix Tty.gray. 2016-10-02 08:40:38 +02:00
Markus Reiter
8b06a01e5b Merge pull request #823 from reitermarkus/refactoring-tty 
Refactor Tty.
 2016-10-02 05:36:50 +02:00
Markus Reiter
c36f42ce95 Remove private_class_method from commands. 2016-10-02 00:24:47 +02:00
Markus Reiter
0ab750bf24 Use module_function for commands. 2016-10-02 00:24:47 +02:00