17921 Commits

Author SHA1 Message Date
vidusheeamoli
0ee9cc0b08 sorbet/files.yaml: add new files 2020-06-30 12:40:03 +05:30
dependabot-preview[bot]
0475c73b67
build(deps): bump diff-lcs from 1.4.2 to 1.4.3 in /Library/Homebrew
Bumps [diff-lcs](https://github.com/halostatue/diff-lcs) from 1.4.2 to 1.4.3.
- [Release notes](https://github.com/halostatue/diff-lcs/releases)
- [Changelog](https://github.com/halostatue/diff-lcs/blob/master/History.md)
- [Commits](https://github.com/halostatue/diff-lcs/compare/v1.4.2...v1.4.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-30 05:33:46 +00:00
lionellloh
4dcbe8790f update-license-data: use of unlink to remove existing file 2020-06-30 01:29:45 +08:00
lionellloh
0ea6245094 Revert "Pathname::write: allow optional override"
This reverts commit 93d46c6d6c69d5279404bce211cb2f48120076f9.
2020-06-30 01:28:58 +08:00
Rylan Polster
d921e94a2b rubocop: separate args for shell commands
Use `system "foo", "bar"` instead of `system "foo bar"`. Also applies to
`Utils.popen_read` and `Utils.popen_write` commands. RuboCop can
automatically fix these problems.
2020-06-29 13:26:58 -04:00
lionellloh
5b3ac1fcb2 update-license-data: modify arguments when calling methods 2020-06-30 01:14:05 +08:00
lionellloh
02bc870e91 curl: modified curl to allow optional print_stdout 2020-06-30 01:13:02 +08:00
lionellloh
074f66f912 write .stdout instead of SystemCommand::Result 2020-06-30 01:08:29 +08:00
lionellloh
93d46c6d6c Pathname::write: allow optional override 2020-06-30 01:08:09 +08:00
William Ma
4dc2df6e6a uninstall: Run cask uninstall tests only on macos 2020-06-29 10:13:29 -04:00
Mike McQuaid
84f3dc4783
Merge pull request #7850 from Homebrew/dependabot/bundler/Library/Homebrew/zeitwerk-2.3.1
build(deps): bump zeitwerk from 2.3.0 to 2.3.1 in /Library/Homebrew
2020-06-29 11:12:38 +01:00
Mike McQuaid
a15cd4bdd5
brew vendor-gems: commit updates. 2020-06-29 09:57:15 +01:00
Jonathan Chang
9cab9b7f39
pr-pull: handle empty string cases
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-06-29 18:55:47 +10:00
Mike McQuaid
3fc76171ca
spec_helper: retry failing CI tests.
This should help avoid a bit of the flakiness we see in builds at the
cost of a slight slowdown on retries.
2020-06-29 09:54:06 +01:00
Mike McQuaid
4398e7bf79
Revert "cask/pkg_spec: remove flaky test."
This reverts commit 924af100b73d24dffb2199fa46ae118e8b3bbb29.
2020-06-29 09:50:51 +01:00
Mike McQuaid
2ee93a2476
Revert "remove flaky cask upgrade test"
This reverts commit 626f9406b1987932382814bc7d7cae3b41b771f4.
2020-06-29 09:50:43 +01:00
Mike McQuaid
a9877088ea
Revert "test/cask/cmd/upgrade_spec: remove flaky test."
This reverts commit 8a0e6a1603ce823eb66cc183a692f722668d9c67.
2020-06-29 09:50:36 +01:00
Mike McQuaid
cc0ea9aec3
Revert "cask/cmd/upgrade_spec: remove flaky test."
This reverts commit 75c74e4674d3f6a85c4afce79a6096bcc5cca9fc.
2020-06-29 09:50:29 +01:00
Mike McQuaid
af2c57dbeb
Revert "cask/cmd/upgrade_spec: remove more flaky tests."
This reverts commit fb0fa419abc750bf33695a396244b9cffbea1554.
2020-06-29 09:50:18 +01:00
Lionell Loh Jian An
da007134c4
Apply suggestions from code review
Code review changes

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-06-29 16:20:07 +08:00
dependabot-preview[bot]
ae8fb6c8a7
build(deps): bump zeitwerk from 2.3.0 to 2.3.1 in /Library/Homebrew
Bumps [zeitwerk](https://github.com/fxn/zeitwerk) from 2.3.0 to 2.3.1.
- [Release notes](https://github.com/fxn/zeitwerk/releases)
- [Changelog](https://github.com/fxn/zeitwerk/blob/master/CHANGELOG.md)
- [Commits](https://github.com/fxn/zeitwerk/compare/v2.3.0...v2.3.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-29 08:15:08 +00:00
Lionell
688a9ade0d change .nil? to .blank? 2020-06-29 16:12:05 +08:00
Mike McQuaid
d5306b87b3
Merge pull request #7839 from EricFromCanada/list-command-options
cmd/options: add flag to list a command's options
2020-06-29 08:49:36 +01:00
Mike McQuaid
045610ef8d
Merge pull request #7846 from samford/add-version-blank-empty
version: add empty? method
2020-06-29 08:42:36 +01:00
Mike McQuaid
61b4e7c414
Merge pull request #7745 from dtrodrigues/bump-pr-dupes
bump-formula-pr: search for closed dupe PRs
2020-06-29 08:39:30 +01:00
Jonathan Chang
bada8dd759 pr-pull: add review approval trailers on signoff 2020-06-29 12:53:03 +10:00
Jonathan Chang
90309e5f42 github: fetch approved reviews for a pull request 2020-06-29 12:53:03 +10:00
EricFromCanada
68947f2af9 cmd/options: add flag to list a command's options 2020-06-28 12:42:23 -04:00
Sam Ford
15bc09d916
version: add empty? method 2020-06-27 21:03:16 -04:00
Michka Popoff
b4cd99c67c
Merge pull request #7833 from iMichka/resource-empty
software_spec: do not add empty resources
2020-06-27 22:20:55 +02:00
Lionell
5f6917ae7c Merge branch 'master' into license 2020-06-28 02:07:53 +08:00
lionellloh
4d4f6a8fac audit: remove unnecessary nil assignment 2020-06-28 02:07:32 +08:00
Lionell Loh Jian An
759708fae7
Apply suggestions from code review
Code Review Changes

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-06-28 01:54:41 +08:00
Michka Popoff
36b62c50e0 software_spec: do not add empty resources
Empty resources are allowed to exist under the following form:

resource "filelock" do
  on_linux do
      url "6ee2168387/filelock-3.0.12.tar.gz"
      sha256 "18d82244ee114f543149c66a6e0c14e9c4f8a1044b5cdaadd0f82159d6a6ff59"
  end
end

In this case (or for the on_macos only resource case), just ignore the resource block.

Fixes:
/usr/local/Homebrew/Library/Homebrew/dependency_collector.rb:148:in `resource_dep'
/usr/local/Homebrew/Library/Homebrew/dependency_collector.rb:99:in `parse_spec'
/usr/local/Homebrew/Library/Homebrew/dependency_collector.rb:53:in `build'
/usr/local/Homebrew/Library/Homebrew/dependency_collector.rb:40:in `block in fetch'
/usr/local/Homebrew/Library/Homebrew/dependency_collector.rb:40:in `fetch'
/usr/local/Homebrew/Library/Homebrew/dependency_collector.rb:40:in `fetch'
/usr/local/Homebrew/Library/Homebrew/dependency_collector.rb:30:in `add'
/usr/local/Homebrew/Library/Homebrew/software_spec.rb:120:in `resource'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2439:in `block in resource'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2438:in `each'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2438:in `resource'
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/aws-google-auth.rb:149:in `<class:AwsGoogleAuth>'
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/aws-google-auth.rb:1:in `load_formula'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:38:in `rescue in load_formula'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:35:in `load_formula'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:56:in `load_formula_from_path'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:138:in `load_file'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:128:in `klass'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:124:in `get_formula'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:333:in `factory'
/usr/local/Homebrew/Library/Homebrew/cli/args.rb:87:in `block in formulae'
/usr/local/Homebrew/Library/Homebrew/cli/args.rb:86:in `map'
/usr/local/Homebrew/Library/Homebrew/cli/args.rb:86:in `formulae'
/usr/local/Homebrew/Library/Homebrew/cmd/install.rb:133:in `install'
/usr/local/Homebrew/Library/Homebrew/brew.rb:111:in `<main>'
2020-06-27 19:25:10 +02:00
Dustin Rodrigues
f684a59fa5 bump-formula-pr: search for closed dupe PRs 2020-06-27 12:50:43 -04:00
Mike McQuaid
ba62b988e1
Merge pull request #7840 from Rylan12/remove-iso-8601-hyphen
Remove hyphen in ISO 8601 in rubocops/deprecate_spec.rb
2020-06-27 13:15:55 +01:00
Mike McQuaid
1dac6272f7
Merge pull request #7832 from iMichka/backtrace
install: add backtrace on failure
2020-06-27 13:12:12 +01:00
Mike McQuaid
58de51f2ce
Merge pull request #7837 from FTLam11/7392-migrate-audit-rules-to-rubocop
audit: Move patch checks from brew audit to rubocop
2020-06-27 13:11:51 +01:00
Mike McQuaid
21069e3797
Merge pull request #7696 from Rylan12/audit-shell-variables
style: set shell variables in hash
2020-06-27 13:10:35 +01:00
Michka Popoff
6eb80c67a4 install: add backtrace on failure
The error message might be useless alone
2020-06-27 09:59:56 +02:00
Rylan Polster
9c44e39a39 Remove hyphen in ISO 8601 in rubocops/deprecate_spec.rb 2020-06-26 21:32:18 -04:00
Rylan Polster
e82084583a style: set shell variables in hash
When running Utils.popen (or similar popen command), having a line like
"SHELL=bash ..." doesn't work properly. Instead, use:
`Utils.popen({ "SHELL" => "bash" }, "...")`
2020-06-26 16:39:39 -04:00
Rylan Polster
1df0a62532
Merge pull request #7835 from Rylan12/rubocop-deprecation-date
style: enforce ISO 8601 in deprecation date
2020-06-26 16:19:37 -04:00
Frank Lam
ffb1cc8e19
Find patch nodes nested inside blocks 2020-06-27 03:13:50 +08:00
Frank Lam
b2eafdf11d
Remove patch checks from audit 2020-06-27 02:37:57 +08:00
Frank Lam
afb8445380
Add inline patch checks to patches cop 2020-06-27 01:10:52 +08:00
Rylan Polster
9520eabc35 style: enforce ISO-8601 in deprecation date 2020-06-26 11:53:42 -04:00
Mike McQuaid
ac27a98d07
Merge pull request #7836 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-ast-0.1.0
build(deps): bump rubocop-ast from 0.0.3 to 0.1.0 in /Library/Homebrew
2020-06-26 14:59:39 +01:00
William Ma
1044cb91c3 Merge branch 'master' into integrate-uninstall-reinstall 2020-06-26 09:18:19 -04:00
dependabot-preview[bot]
33a86ba247
build(deps): bump rubocop-ast from 0.0.3 to 0.1.0 in /Library/Homebrew
Bumps [rubocop-ast](https://github.com/rubocop-hq/rubocop-ast) from 0.0.3 to 0.1.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-ast/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-ast/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-ast/compare/v0.0.3...v0.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-26 05:20:09 +00:00