admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
21,547 Commits 15 Branches 471 Tags
Commit Graph

17921 Commits

Author SHA1 Message Date
Mike McQuaid
183670296f
Merge pull request #7493 from GauthamGoli/argv-cleanup-26 
ARGV: Deprecate ARGV.cc and replace with Homebrew.args.cc
 2020-05-23 14:10:20 +01:00
Mike McQuaid
d5ff4f5327
Remove ARGV.env 
Replace with `Homebrew.args.env`.

Part of #5730.
 2020-05-23 13:49:38 +01:00
Mike McQuaid
e5d15c8b19
Merge branch 'master' into argv-cleanup-26 2020-05-23 13:44:42 +01:00
Mike McQuaid
11cf77be17
formula_installer: prelude before fetch. 
This ensures that dependencies are verified and tapped before they are
fetched. `FormulaInstaller#lock` has been moved into
`FormulaInstaller#install` to avoid locking until necessary.

While we're here, don't compute dependencies before fetching if we're
not going to use them.
 2020-05-23 13:40:13 +01:00
Mike McQuaid
e9d45a6692
Merge pull request #7634 from zmwangx/bump-formula-pr-fix-formula-guessing 
bump-formula-pr: fix forking error when formula is guessed from url
 2020-05-23 13:10:21 +01:00
Zhiming Wang
83fa24741e
bump-formula-pr: fix forking error when formula is guessed from url 
Regression introduced in f90612ccf0db03681dc6cbf6585cca5bc27b84b1 (#6718).

`tap_full_name` returned from `use_correct_linux_tap` has been
required (`GitHub.create_fork(tap_full_name)`), but it was never set when the
formula is guessed from args.url, resulting in an API request to
https://api.github.com/repos//forks which 404s (note the missing :owner/:repo),
and subsequently

    Error: Unable to fork: Not Found!
 2020-05-23 14:20:35 +08:00
Bo Anderson
6b06043289 formula_installer: fix pruning of test deps also marked as build 2020-05-23 00:05:20 +01:00
Mike McQuaid
e10ade758d
Revert "formulary: install tap if needed." 2020-05-22 16:19:30 +01:00
Mike McQuaid
61b48d8557
formulary: install tap if needed. 
This matches what `cask_loader` does and is low risk given we no longer
allow tap pinning.

Fixes #7626
 2020-05-22 14:21:40 +01:00
Mike McQuaid
ca47992a6c
Fix rubocop-performance brew style. 2020-05-22 08:52:26 +01:00
Mike McQuaid
d02b15d31a
brew vendor-gems: commit updates. 2020-05-22 08:30:19 +01:00
dependabot-preview[bot]
bab32515fa
build(deps): bump rubocop-performance in /Library/Homebrew 
Bumps [rubocop-performance](https://github.com/rubocop-hq/rubocop-performance) from 1.5.2 to 1.6.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-performance/compare/v1.5.2...v1.6.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-05-22 05:34:28 +00:00
Maxim Belkin
5d3456f485
utils/ruby.sh: make code more readable 
1. Repurpose 'vendor_ruby_current_version' variable:
   now this is not a pointer to a file but actual version number
2. Introduce 'vendor_ruby_latest_version' variable:
   it holds the value of the latest version of portable Ruby
 2020-05-21 17:15:14 -05:00
Maxim Belkin
db561eb7b9
utils/ruby.sh: setup-ruby: handle 'vendor-install' cmd early 
Exit from the 'setup-ruby' function when user issued
`vendor-install` command.
We do so instead of wrapping everything in

```sh
if [[ "$HOMEBREW_COMMAND" != "vendor-install" ]]
```

`git diff` when whitespaces are ignored:

$ git diff -w
diff --git a/Library/Homebrew/utils/ruby.sh b/Library/Homebrew/utils/ruby.sh
index 7974e909c..4be204309 100644
--- a/Library/Homebrew/utils/ruby.sh
+++ b/Library/Homebrew/utils/ruby.sh
@@ -27,8 +27,11 @@ If there's no Homebrew Portable Ruby available for your processor:

   unset HOMEBREW_RUBY_PATH

-  if [[ "$HOMEBREW_COMMAND" != "vendor-install" ]]
+  if [[ "$HOMEBREW_COMMAND" == "vendor-install" ]]
   then
+    return 0
+  fi
+
   if [[ -x "$vendor_ruby_path" ]]
   then
     HOMEBREW_RUBY_PATH="$vendor_ruby_path"
@@ -85,7 +88,6 @@ If there's no Homebrew Portable Ruby available for your processor:
       HOMEBREW_RUBY_PATH="$vendor_ruby_path"
     fi
   fi
-  fi

   export HOMEBREW_RUBY_PATH
 }
 2020-05-21 15:06:21 -05:00
Markus Reiter
a7a8569d70
Merge pull request #7607 from reitermarkus/cask-help-usage 
Implement `brew cask help <command>`.
 2020-05-21 21:02:02 +02:00
Rylan Polster
d0bd687a3d brew cask zap prompts when Full Disk Access is needed 2020-05-21 10:24:28 -04:00
Mike McQuaid
e33dc9e916
utils: brew style --fix. 2020-05-21 10:15:34 +01:00
dependabot-preview[bot]
abd61f176e
build(deps): bump rubocop from 0.83.0 to 0.84.0 in /Library/Homebrew 
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.83.0 to 0.84.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.83.0...v0.84.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-05-21 08:50:50 +00:00
Mike McQuaid
575055e36a
env_config_spec: remove unneeded BAT_CONFIG tests. 2020-05-21 08:41:18 +01:00
Mike McQuaid
bb44b71647
Merge pull request #7619 from mathaeus/migrate_vcs_scheme_checks_to_rubocop 
audit: Migrate scheme checks for `cvs`, `bzr`, `hg`, `fossil` and `svn+http` to `Rubocop` + add tests
 2020-05-21 08:22:13 +01:00
Mathäus Zingerle
bb9665ced8 Migrate scheme checks for cvs, bzr, hg, fossil, and svn+http to Rubocop 2020-05-20 20:52:00 -05:00
Bo Anderson
a3f589801f formula_installer: fix build/test reqs not being pruned correctly 
Fixes #7618.
 2020-05-20 23:39:30 +01:00
Maxim Belkin
8dcb1636ce
utils/ruby.sh: add explanatory comments 2020-05-20 12:29:45 -05:00
Daniel Bayley
e477a38958 [WIP] cat: Allow 'bat' to find existing configuration file 2020-05-20 16:51:36 +01:00
Bo Anderson
6ac9d43599 formula_installer: fix already-satisfied test deps not being pruned 2020-05-20 13:28:10 +01:00
Mike McQuaid
bfc081ee0b
Merge pull request #7613 from MikeMcQuaid/requirement_test 
formula_installer: fix :test requirement expansion.
 2020-05-20 12:55:55 +01:00
Mike McQuaid
89a0984d42
formula_installer: fix :test requirement expansion. 2020-05-20 12:24:54 +01:00
Mike McQuaid
0ea2c5f15b
os/mac/diagnostic: suggest untapping phinze/cask. 
As seen in https://github.com/Homebrew/brew/issues/7605.
 2020-05-20 10:05:23 +01:00
Mike McQuaid
d254730e78
Merge pull request #7610 from MikeMcQuaid/bad-todo 
audit: remove incorrect TODO.
 2020-05-20 09:41:01 +01:00
Mike McQuaid
ceb3513b86
Merge pull request #7609 from Bo98/include_test-dependents 
Further test dep fixes
 2020-05-20 08:22:57 +01:00
Mike McQuaid
633501ab08
audit: remove incorrect TODO. 
This check can't really be in RuboCop (as it relies on the URL strategy
logic).
 2020-05-20 08:17:14 +01:00
Mike McQuaid
1ebb1c2885
Merge pull request #7580 from tharun208/brew-cask-analytics 
Added analytics for cask info
 2020-05-20 08:06:46 +01:00
Bo Anderson
5b5833c33b dependency: return test deps on all levels 
Filtering for this is now handled properly in places where this function is used.

In some scenarios, we _want_ test deps on more than the first level (Homebrew.args.include_formula_test_deps?).
 2020-05-19 19:17:17 +01:00
Bo Anderson
b8ba083e12 dependencies: fix recursive_includes not handling deps of test deps 2020-05-19 19:14:48 +01:00
Bo Anderson
a2939be08a formula_installer: don't propagate --include-test unless requested 2020-05-19 19:12:47 +01:00
Markus Reiter
7f400d8e4e Fix brew cask <command> --help. 2020-05-19 19:30:46 +02:00
Maxim Belkin
dcc486fa9e
utils/ruby.sh: find usable Ruby from PATH only 2020-05-19 12:24:00 -05:00
Markus Reiter
6d9a20614a Implement brew cask help <command>. 2020-05-19 19:23:31 +02:00
Tharun
aeede8374f fixed review changes 2020-05-19 21:41:02 +05:30
Mike McQuaid
b2fc8ad7b3
Merge pull request #7585 from hyuraku/brew_doctor-shows-deleted_formulae 
brew doctor shows deleted formulae
 2020-05-19 17:07:32 +01:00
hyuraku
38e0aa8800 change condition 2020-05-19 23:58:33 +09:00
Tharun
84f2edc884 replaced json and used dictionary 2020-05-19 19:35:30 +05:30
Mike McQuaid
8b98ed1f47
Further tweak :test dependency handling 
- ensure that cases where `:build` and `:test` both apply to a
  dependency that we handle it appropriately
- fix reintroduced regression
  (https://github.com/Homebrew/brew/pull/6471#issuecomment-533414923).
  Fixes #6470.
 2020-05-19 14:25:10 +01:00
hyuraku
c263c755aa check tap_path size 2020-05-19 22:22:31 +09:00
Tharun
6a50f31feb fixed proper parsing of mock data for analytics 2020-05-19 17:25:16 +05:30
Tharun
7186600a5c renamed get_formulae_api 2020-05-19 14:59:43 +05:30
Tharun
9e26a451e3 Updated mocking analytics call 2020-05-19 14:58:55 +05:30
Mike McQuaid
2fc643421f
formula_installer: fix test dependencies. 
Only prune test dependencies from the tree when they aren't also build
dependencies (and vice-versa with build dependencies) and the include
test argument hasn't been passed.
 2020-05-19 09:34:50 +01:00
Mike McQuaid
3588e6a5c6
bottle_arch: ensure a symbol is used when needed. 
Fixes #7597.
 2020-05-19 08:47:59 +01:00
Mike McQuaid
0e9897c86d
Merge pull request #7577 from vidusheeamoli/add-byebug 
Set up Byebug debugger
 2020-05-19 08:27:53 +01:00