admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
21,547 Commits 15 Branches 471 Tags
Commit Graph

350 Commits

Author SHA1 Message Date
Mike McQuaid
4398e7bf79
Revert "cask/pkg_spec: remove flaky test." 
This reverts commit 924af100b73d24dffb2199fa46ae118e8b3bbb29.
 2020-06-29 09:50:51 +01:00
Mike McQuaid
2ee93a2476
Revert "remove flaky cask upgrade test" 
This reverts commit 626f9406b1987932382814bc7d7cae3b41b771f4.
 2020-06-29 09:50:43 +01:00
Mike McQuaid
a9877088ea
Revert "test/cask/cmd/upgrade_spec: remove flaky test." 
This reverts commit 8a0e6a1603ce823eb66cc183a692f722668d9c67.
 2020-06-29 09:50:36 +01:00
Mike McQuaid
cc0ea9aec3
Revert "cask/cmd/upgrade_spec: remove flaky test." 
This reverts commit 75c74e4674d3f6a85c4afce79a6096bcc5cca9fc.
 2020-06-29 09:50:29 +01:00
Mike McQuaid
af2c57dbeb
Revert "cask/cmd/upgrade_spec: remove more flaky tests." 
This reverts commit fb0fa419abc750bf33695a396244b9cffbea1554.
 2020-06-29 09:50:18 +01:00
Mike McQuaid
ac0665daff
Refer to default branch in links with HEAD 
Anywhere we can use `blob/master` we can use `blob/HEAD` instead. This
will make life easier if we ever rename our default branch in future
(once/if Git and GitHub provides the necessary tooling to do so).
 2020-06-25 11:38:40 +01:00
Sean Molenaar
523c24684d
cask: audit locales 2020-06-16 11:41:06 +02:00
Sean Molenaar
d64afece81
Merge pull request #7690 from SMillerDev/cask/audit/token 
cask: codify the token rules
 2020-06-16 11:40:25 +02:00
Sean Molenaar
4a24908fe4
cask: codify the token rules 2020-06-11 19:34:36 +02:00
Issy Long
8eba9b86ab
Change occurrences of "blacklist" to "denylist" or "disallow" 
- Depending on context, I've gone for either "denylist" or "disallow"
  here. "Disallow" for things in sentences, or actions, and "denylist"
  for list of things.
 2020-06-06 22:38:33 +01:00
Sean Molenaar
3567892802
Add notibility checks for casks 2020-05-26 14:21:25 +02:00
Tharun
aeede8374f fixed review changes 2020-05-19 21:41:02 +05:30
Tharun
84f2edc884 replaced json and used dictionary 2020-05-19 19:35:30 +05:30
Tharun
6a50f31feb fixed proper parsing of mock data for analytics 2020-05-19 17:25:16 +05:30
Tharun
9e26a451e3 Updated mocking analytics call 2020-05-19 14:58:55 +05:30
Tharun
6e543f7289 Updated test with stubing cask analytics call 2020-05-18 20:46:43 +05:30
Tharun
4aba04556e Updated tests 2020-05-17 02:55:07 +05:30
Mike McQuaid
e8a29a2d72
Merge pull request #7440 from FTLam11/FTLam11-#7432-add-json-option-to-brew-cask-outdated 
Add JSON support for brew cask outdated, fixes #7432
 2020-04-29 11:40:22 +01:00
Claudia
cad8be3278
Add broken test, revealing test helper flaw 
This commit adds a broken test, which is meant to expose a flaw in the
constructor of `Cask::Config`.

That (broken) test still passes because there’s also a flaw in our
test helper code.

The helper flaw happens to neutralize the `Cask::Config` flaw.
 2020-04-27 15:00:22 +02:00
Claudia
dd3267ece0
Add test for JSON-based cask config loader 
Previously, the JSON-based cask config loader was untested.
This commit changes the interface to accept a string, making the loader
easier to test. The commit also adds a test.
 2020-04-27 14:54:56 +02:00
Frank Lam
dabbfe3e3e
Fix linter offenses 2020-04-26 21:31:21 +08:00
Frank Lam
f2fa2c5d30
Add JSON support to brew cask outdated 
* brew outdated already has JSON support, now users and tools can get
similar results with brew cask outdated --json
 2020-04-26 21:13:19 +08:00
Claudia
374f788a3c
cask/config_spec: add failing test 
We recently added a new global artifact and then updated a cask to
make use of that new artifact. This caused a number of `brew cask`
commands to fail for users who had the cask installed before the
artifact was added.

This commit adds test cases for that failure mode.

See also:
- https://github.com/Homebrew/brew/pull/7286#issuecomment-613376568
- https://discourse.brew.sh/t/cask-definition-is-invalid-invalid-mdimporter-stanza-key-not-found-mdimporterdir
 2020-04-21 18:26:51 +02:00
Mike McQuaid
fb0fa419ab
cask/cmd/upgrade_spec: remove more flaky tests. 2020-04-20 16:45:44 +01:00
Mike McQuaid
75c74e4674
cask/cmd/upgrade_spec: remove flaky test. 2020-04-20 09:25:16 +01:00
Mike McQuaid
8a0e6a1603
test/cask/cmd/upgrade_spec: remove flaky test. 
This is the second flaky test removed in this file. Tempting to just
remove the whole file if there's more.
 2020-04-18 14:37:10 +01:00
Markus Reiter
30c313b7b9 Refactor cask command parsing logic. 2020-04-11 01:29:44 +02:00
Dario Vladovic
d12784533b
Update options spec 2020-04-06 15:24:15 +02:00
Dawid Dziurla
626f9406b1
remove flaky cask upgrade test 2020-03-23 19:27:48 +01:00
Daniel Bayley
f3a0fcfb6d Make rmdir: recursive 2020-02-11 07:56:15 +00:00
Vítor Galvão
497a160cda cask version MAJOR_MINOR_PATCH_REGEX: allow any word character instead of only digits 2019-12-07 14:04:55 +00:00
Mike McQuaid
c1b00297e0
cask/cmd/style_spec: add rubocop test. 
This verifies the cask configuration hasn't been broken.
 2019-12-01 15:04:32 +00:00
Mike McQuaid
924af100b7
cask/pkg_spec: remove flaky test. 2019-11-06 14:28:05 +00:00
Mike McQuaid
6670ae6202
global: require rubygems for activesupport. 2019-11-06 10:36:40 +00:00
Markus Reiter
78725740e2 Refactor cask dependency resolution. 2019-10-31 20:20:55 +01:00
Markus Reiter
df3bbd0299 Reduce need for interpolating appdir in casks. 2019-10-24 17:07:30 +02:00
Markus Reiter
e6cfb4a3c2
Merge pull request #6629 from timsly/manpage-artifact 
Add Manpage artifact
 2019-10-24 13:48:52 +02:00
Tim Masliuchenko
91ddb6e53d Cleanup specs 2019-10-24 14:22:13 +03:00
Tim Masliuchenko
87f29857f0 Pass section to the constructor 2019-10-23 18:34:16 +03:00
Tim Masliuchenko
22d821323c Feedbacks 2019-10-23 16:28:00 +03:00
Markus Reiter
04493e2dde Fix trash.swift without arguments. 2019-10-23 06:59:39 +02:00
Tim Masliuchenko
3ef5e06943 Add Manpage artifact 2019-10-22 15:21:49 +03:00
Markus Reiter
7a5e4d1269 Remove User::automation_access?. 2019-10-22 07:38:35 +02:00
Mike McQuaid
8a93230c15
test/cask: remove disabled functionality tests. 2019-10-15 09:52:33 +01:00
Mike McQuaid
1b4fdc17f4
Raise deprecation exceptions in tests 
Previously tests which hit `odeprecated` would print warnings but not
always raise exceptions or fail. Combine this with the ability to have
`odeprecated` to turn into `odisabled` on certain dates and you have
tests that may fail just on the clock changing (this is bad).

Instead, ensure that tests always raise deprecations as exceptions so
that new deprecations will have their tests handled immediately.
 2019-10-15 08:52:42 +01:00
Issy Long
341ea60807
Auto-fix Style/RedundantBegin offenses 
- This also required auto-fixes for Layout/EmptyLinesAroundBlockBody and
  Layout/InconsistentIndentation once the auto-fixer had got rid of the
  "redundant begin"s.
 2019-10-13 16:04:27 +01:00
Mike McQuaid
e3ee64a5fd
Ruby 2.6.3 brew tests fixes 2019-10-10 16:17:06 +01:00
Markus Reiter
b6b9cd248c Refactor brew cask style. 2019-10-04 23:43:48 +02:00
Markus Reiter
7f39d333bc Move assert_success to SystemCommand::Result. 2019-10-04 23:39:25 +02:00
Markus Reiter
e351e6b31c
Merge pull request #6482 from alecclarke/run-style-checks-on-test-casks 
Include test casks in the cask style check.
 2019-10-04 23:15:59 +02:00