admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
21,547 Commits 15 Branches 471 Tags
Commit Graph

3286 Commits

Author SHA1 Message Date
Mike McQuaid
6211d0da13
Merge pull request #7691 from Rylan12/popen_read-audit 
style: separate shell command arguments
 2020-07-06 09:15:52 +01:00
Mike McQuaid
1558179a50
Merge pull request #7853 from MLH-Fellowship/integrate-uninstall-reinstall 
Allow references to casks when running uninstall and reinstall
 2020-07-06 09:10:19 +01:00
Rylan Polster
ae0d37e911 Transfer to FormulaAuditStrict 2020-07-05 13:57:49 -04:00
Rylan Polster
0786003fe9 Add tests for autocorrect 2020-07-05 12:12:36 -04:00
Jonathan Chang
c6e9cff125 dev-cmd: add brew-sponsors.rb 2020-07-05 15:45:36 +10:00
William Ma
6e8f5d0958 Modify MultipleVersionsInstalledError to have a generic message 2020-07-03 18:25:49 -04:00
Rylan Polster
e252de5295 style: improve keg_only style checks 2020-07-03 14:35:32 -04:00
Mike McQuaid
fea704b454
Move .codecov.yml 
>  the file must still be located in the root, dev/, or .github/ directories

https://docs.codecov.io/docs/codecov-yaml#can-i-name-the-file-codecovyml
 2020-07-03 17:03:29 +01:00
Mike McQuaid
6a7e5f2e9d
dev-cmd/audit: tweak checksum audit. 
Compare against the latest `origin/master` checksum rather than
whatever the previous one was.
 2020-07-03 09:21:53 +01:00
Mike McQuaid
9fc0799d5e
Merge pull request #7880 from MikeMcQuaid/check_dependents_install_reinstall 
Check installed dependents on install and reinstall
 2020-07-02 13:30:29 +01:00
Mike McQuaid
2c133a3d45
Check installed dependents on install and reinstall 
It's not sufficient to do this merely on `brew upgrade` because
`brew install` and `brew reinstall` can also result in formulae being
upgraded.

This requires moving logic from `cmd/upgrade.rb` to `upgrade.rb`. To
save you searching the diff the changes that resulted from doing that:

- Query the installed formulae from class state in `FormulaInstaller`
  rather than the (incomplete) list that we passed into it.
- Don't output the "Checking dependents" message. It was there for
  systems and configurations where this is slow but for most users
  and most installations this will be a (annoying, noisy) no-op.

Fixes https://github.com/Homebrew/brew/issues/7860
 2020-07-02 12:53:52 +01:00
Mike McQuaid
14ed1adb6c
Add CodeCov YAML file. 
This should make the output and statuses a bit more friendly.
 2020-07-02 12:50:56 +01:00
Mike McQuaid
170b38892a
Use CodeCov for coverage reporting. 2020-07-02 10:22:54 +01:00
Mike McQuaid
97f68e6a3a
Revert "disable license check for new formulae" 2020-07-02 09:04:58 +01:00
Rui Chen
8ff1ca644d disable license check for new formulae 
return when license is blank

Co-authored-by: Bo Anderson <mail@boanderson.me>
 2020-07-01 17:22:07 -04:00
Mike McQuaid
4e10341277
Merge pull request #7752 from SMillerDev/cask/readall 
Support casks in readall
 2020-07-01 12:19:30 +01:00
Mike McQuaid
0166211ffd
integration_test: don't error on missing bin. 2020-07-01 11:55:42 +01:00
Mike McQuaid
7d53104c46
cmd/search_spec: split Linux/macOS tests. 2020-07-01 11:55:25 +01:00
Jonathan Chang
b57290b23f
Merge pull request #7844 from jonchang/signoff-approving-reviews 
pr-pull: add commit message trailers for pull requests with approved reviews
 2020-07-01 19:18:27 +10:00
lionellloh
7358dd7bba style fixes 2020-06-30 23:25:51 +08:00
lionellloh
1422542a07 components_order and test 2020-06-30 23:18:04 +08:00
Lionell
fb4db63e3b Merge branch 'master' into license 2020-06-30 22:25:17 +08:00
lionellloh
96d60c271a Merge remote-tracking branch 'mlh/license' into license 2020-06-30 22:12:03 +08:00
Lionell Loh Jian An
5b3530b23d
Apply suggestions from code review 
Code review changes

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2020-06-30 22:11:36 +08:00
lionellloh
ff95f08591 audit test: modified code for reading json file 2020-06-30 22:08:36 +08:00
Michka Popoff
8d55c87adb
components order: fix audit and add test 2020-06-30 08:36:11 +01:00
Rylan Polster
d921e94a2b rubocop: separate args for shell commands 
Use `system "foo", "bar"` instead of `system "foo bar"`. Also applies to
`Utils.popen_read` and `Utils.popen_write` commands. RuboCop can
automatically fix these problems.
 2020-06-29 13:26:58 -04:00
Mike McQuaid
3fc76171ca
spec_helper: retry failing CI tests. 
This should help avoid a bit of the flakiness we see in builds at the
cost of a slight slowdown on retries.
 2020-06-29 09:54:06 +01:00
Mike McQuaid
4398e7bf79
Revert "cask/pkg_spec: remove flaky test." 
This reverts commit 924af100b73d24dffb2199fa46ae118e8b3bbb29.
 2020-06-29 09:50:51 +01:00
Mike McQuaid
2ee93a2476
Revert "remove flaky cask upgrade test" 
This reverts commit 626f9406b1987932382814bc7d7cae3b41b771f4.
 2020-06-29 09:50:43 +01:00
Mike McQuaid
a9877088ea
Revert "test/cask/cmd/upgrade_spec: remove flaky test." 
This reverts commit 8a0e6a1603ce823eb66cc183a692f722668d9c67.
 2020-06-29 09:50:36 +01:00
Mike McQuaid
cc0ea9aec3
Revert "cask/cmd/upgrade_spec: remove flaky test." 
This reverts commit 75c74e4674d3f6a85c4afce79a6096bcc5cca9fc.
 2020-06-29 09:50:29 +01:00
Mike McQuaid
af2c57dbeb
Revert "cask/cmd/upgrade_spec: remove more flaky tests." 
This reverts commit fb0fa419abc750bf33695a396244b9cffbea1554.
 2020-06-29 09:50:18 +01:00
Jonathan Chang
90309e5f42 github: fetch approved reviews for a pull request 2020-06-29 12:53:03 +10:00
Sam Ford
15bc09d916
version: add empty? method 2020-06-27 21:03:16 -04:00
Lionell
5f6917ae7c Merge branch 'master' into license 2020-06-28 02:07:53 +08:00
Mike McQuaid
ba62b988e1
Merge pull request #7840 from Rylan12/remove-iso-8601-hyphen 
Remove hyphen in ISO 8601 in rubocops/deprecate_spec.rb
 2020-06-27 13:15:55 +01:00
Mike McQuaid
58de51f2ce
Merge pull request #7837 from FTLam11/7392-migrate-audit-rules-to-rubocop 
audit: Move patch checks from brew audit to rubocop
 2020-06-27 13:11:51 +01:00
Mike McQuaid
21069e3797
Merge pull request #7696 from Rylan12/audit-shell-variables 
style: set shell variables in hash
 2020-06-27 13:10:35 +01:00
Rylan Polster
9c44e39a39 Remove hyphen in ISO 8601 in rubocops/deprecate_spec.rb 2020-06-26 21:32:18 -04:00
Rylan Polster
e82084583a style: set shell variables in hash 
When running Utils.popen (or similar popen command), having a line like
"SHELL=bash ..." doesn't work properly. Instead, use:
`Utils.popen({ "SHELL" => "bash" }, "...")`
 2020-06-26 16:39:39 -04:00
Frank Lam
ffb1cc8e19
Find patch nodes nested inside blocks 2020-06-27 03:13:50 +08:00
Frank Lam
b2eafdf11d
Remove patch checks from audit 2020-06-27 02:37:57 +08:00
Rylan Polster
9520eabc35 style: enforce ISO-8601 in deprecation date 2020-06-26 11:53:42 -04:00
Frank Lam
644ae115f5
Prepare inline patch specs 2020-06-25 22:29:34 +08:00
Lionell
ff7a80ebf5 Merge branch 'master' into license 2020-06-25 21:51:39 +08:00
Mike McQuaid
ac0665daff
Refer to default branch in links with HEAD 
Anywhere we can use `blob/master` we can use `blob/HEAD` instead. This
will make life easier if we ever rename our default branch in future
(once/if Git and GitHub provides the necessary tooling to do so).
 2020-06-25 11:38:40 +01:00
Lionell
5aa0eb487e rename spec file 2020-06-25 17:51:47 +08:00
Lionell
57fd1fdc7e Merge branch 'master' into license 2020-06-25 13:42:27 +08:00
lionellloh
fbd5c32d22 bunch of style fixes 2020-06-25 05:46:18 +08:00