10715 Commits

Author SHA1 Message Date
Mike McQuaid
f4496e85e5 audit: don't allow universal for new formulae.
We're frowning on these now so may as well turn that into code.
2017-01-15 02:31:11 -08:00
Mike McQuaid
ebf3d939d1 Merge pull request #1808 from MikeMcQuaid/deprecate-linkapps
Deprecate brew (un)linkapps.
2017-01-11 11:13:26 -08:00
Mike McQuaid
0a7e69173d Merge pull request #1816 from MikeMcQuaid/xcode-xquartz-default-path
xcode, xquartz: use default location when possible.
2017-01-11 11:08:52 -08:00
Mike McQuaid
6d13c31fa4 Merge pull request #1814 from MikeMcQuaid/json_runtime_dependencies
formula: return runtime_dependencies in to_hash.
2017-01-11 11:06:49 -08:00
Mike McQuaid
a17f38dd36 xcode: use default location when possible.
Xcode can be installed anywhere but for most people it's in
`/Applications/Xcode.app` so just look there if `xcode-select` isn't
helpful before looking at Spotlight which can return weird results on
e.g. backup disks.

Fixes #1587.
2017-01-09 21:10:55 -08:00
Mike McQuaid
2c6915a48f xcode: general cleanup. 2017-01-09 21:10:55 -08:00
Mike McQuaid
4a39070c26 xquartz: use default location when possible.
Xcode can be installed anywhere but for most people it's in
`/Applications/Xcode.app` so just look there by default before looking
at Spotlight which can return weird results on e.g. backup disks.
2017-01-09 21:10:55 -08:00
Mike McQuaid
d8adae0f92 formulary: read from formula in opt prefix.
We want to prefer the newer/versioned formulae when possible but this
is preferable to a random cached formula or, worse, no formula.

This means `brew info foo` will never complain that `foo` is a missing
formula.
2017-01-09 21:42:09 +00:00
Mike McQuaid
28ad8a06cc formula: return runtime_dependencies in to_hash.
Which, in turn, provides it for `brew info --json=v1` so other tools
such as e.g. `brew bundle` can make use of this information.
2017-01-09 21:03:37 +00:00
Mike McQuaid
c0a29d6644 caveats, keg: remove linkapps caveats code. 2017-01-09 14:10:26 +00:00
Mike McQuaid
f5b63f4a8d Deprecate brew (un)linkapps.
Unfortunately `brew linkapps` cannot behave nicely with e.g. Spotlight
using either aliases or symlinks and Homebrew formulae do not build
"proper" `.app` bundles that can be relocated. Instead, please consider
using `brew cask` and migrate formulae using `.app`s to casks.
2017-01-09 14:10:26 +00:00
Mike McQuaid
9cce3414fb Merge pull request #1806 from MikeMcQuaid/audit-virtualenv-setuptools
audit: check virtualenv and setuptools resource.
2017-01-09 14:08:30 +00:00
Mike McQuaid
346d68eb04 audit: check virtualenv and setuptools resource.
`virtualenv_install_with_resources` will automatically define and
install a `setuptools` resource so this is unnecessary.

References https://github.com/Homebrew/homebrew-core/pull/8570
2017-01-09 13:24:51 +00:00
Mike McQuaid
c276a44eba bump-formula-pr: check for URL presence.
If it's not there, produce a nicer error.

Fixes #1805.
2017-01-09 12:16:55 +00:00
William Woodruff
6b63abb850
keg_relocate: Check HOMEBREW_TEMP's realpath when excluding name changes.
Since /tmp (the default HOMEBREW_TEMP) is a symlink to /private/tmp,
some build systems (like Parrot's) will attempt to use the realpath
instead of the literal /tmp we supply it with. This breaks the relocation
code, which only tested the literal HOMEBREW_TEMP and not its realpath.
2017-01-07 15:06:46 -05:00
Mike McQuaid
8712139327 Merge pull request #1798 from MikeMcQuaid/audit-fake-safari-user-agent
Allow `brew audit` to fake a Safari user-agent.
2017-01-07 19:28:53 +00:00
Mike McQuaid
e7a81caaf4 Allow brew audit to fake a Safari user-agent.
This allows us to detect if homepages such as e.g. `aiccu` which
blocks `curl` are up or not.
2017-01-07 14:03:08 +00:00
Mike McQuaid
dc9819b86c Revert "uses: properly handle untapped formulae in recursive dependency expansion" 2017-01-07 13:15:18 +00:00
Mike McQuaid
4f9c13926e Merge pull request #1784 from alyssais/uses_tap_exception
uses: properly handle untapped formulae in recursive dependency expansion
2017-01-07 12:50:45 +00:00
Mike McQuaid
4a51111454 Merge pull request #1786 from rwhogg/perl-version-may-lack-brackets
PerlRequirement: Perl version string may lack parentheses
2017-01-07 12:43:51 +00:00
Mike McQuaid
14e8f252ad Merge pull request #1792 from javian/whitelistphpshadowedheader
Whitelist PHP formulas in shadowed header audit check
2017-01-07 12:18:14 +00:00
Mike McQuaid
f814ee87fb Revert "cc: always filter flags on deps." 2017-01-07 09:52:01 +00:00
Jan Viljanen
80b7d4c1aa Whitelist PHP formulas in shadowed header audit check 2017-01-06 23:43:25 +01:00
Mike McQuaid
4497190593 keg: use resolved_path not realpath.
This guards against this being a non-symlink in which case it will fail.
2017-01-06 16:35:41 +00:00
ilovezfs
1a394aa7e5 Merge pull request #1782 from ilovezfs/prefix-fixups
Fix abv and prefix_linked?
2017-01-06 02:03:39 -08:00
Mike McQuaid
1a4ff22447 formula: tweak versioned prefix approach. 2017-01-06 08:50:35 +00:00
Mike McQuaid
6c2b614a04 pathname: make compute_disk_usage handle symlinks. 2017-01-06 08:50:20 +00:00
Mike McQuaid
3fde8624b3 Merge pull request #1780 from MikeMcQuaid/use-docs-links
Use docs.brew.sh links.
2017-01-05 17:17:07 +00:00
Mike McQuaid
2040adbe4a Merge pull request #1787 from alyssais/formula_comments
formula: correct grammar in comments
2017-01-05 17:06:52 +00:00
Mike McQuaid
3dabf82d4d Merge pull request #1771 from alyssais/license_year
licenses: update copyright year
2017-01-05 17:02:44 +00:00
Alyssa Ross
e466a65b8d formula: correct grammar in comments 2017-01-05 12:21:50 +00:00
Shaun Jackman
cd18536eff PerlRequirement: version number might not be wrapped in parentheses
For example:
This is perl, v5.10.1 (*) built for x86_64-linux-thread-multi
2017-01-04 22:57:14 -08:00
Alyssa Ross
536b6e2396 uses: properly handle recursive deps exceptions
Fixes #1776.

If any known formula had a dependency on an untapped tap,
Formula#recursive_dependencies would throw an exception, which would be
caught by the outer exception handler, causing the rest of the
dependencies for that formula to be skipped and incomplete output to be
generated.

To fix this, I added a check to avoid analysing the dependencies of
formulae from uninstalled taps.

Additionally, I removed the aforementioned outer exception handler added
in 5fdb89aed90f03413cdb21af430411c4a722876e, because the only other
place that should be capable of throwing such an exception is the
statement that was surrounded by another wider exception handler in
Homebrew/legacy-homebrew#40682.
2017-01-05 00:33:44 +00:00
Alyssa Ross
4c061fc183 dependency: TapDependency#tap returns a Tap
Previously, this returned a String, but a Tap instance seems much more
sensible.

I couldn't find anywhere this method was actually used, so the change
shouldn't break anything.
2017-01-05 00:22:56 +00:00
ilovezfs
a68d38743a formula: make prefix_linked? use versioned prefix
otherwise whenever prefix is unversioned, prefix_Linked will be false
2017-01-04 12:45:32 -08:00
ilovezfs
6195d6592b formula: realpath prefix before computing abv
versioned prefix is a directory, but unversioned is a symlink, so
realpath it before computing abv
2017-01-04 10:23:15 -08:00
Mike McQuaid
98dadd907e Merge pull request #1777 from alyssais/tests_tab_version
tests: remove temporary tab homebrew_version override
2017-01-04 11:37:48 +00:00
Mike McQuaid
a3bffe70bc Use docs.brew.sh links. 2017-01-04 11:13:41 +00:00
Alyssa Ross
56d6695bf3 tab: set homebrew_version in Tab.empty 2017-01-04 00:56:06 +00:00
Alyssa Ross
b7e10ba239 tests: remove temp tab homebrew_version override
This had to be added in #1750 to work around special-casing for tabs
generated with Homebrew versions < 1.1.6. Now that 1.1.6 is the current
version, we can remove this hack.
2017-01-04 00:46:44 +00:00
Mike McQuaid
d7ab913f31 audit: deprecate env :std/:userpaths for strict.
This should apply only for new formulae but we should start gradually
phasing it out for older ones too.
2017-01-03 22:12:21 +00:00
Mike McQuaid
fc11f633b2 Merge pull request #1677 from MikeMcQuaid/formula-prefix-opt
formula: make prefix usually return opt_prefix.
2017-01-03 20:10:22 +00:00
Mike McQuaid
619791e83d Merge pull request #1768 from MikeMcQuaid/deprecate-homebrew-versions-devel-only
Deprecate Homebrew/versions, Homebrew/devel-only.
2017-01-03 19:59:53 +00:00
Alyssa Ross
6ecf2ca013 cask: remove license
See https://github.com/Homebrew/brew/pull/1771#issuecomment-270179479.
2017-01-03 18:08:02 +00:00
Mike McQuaid
cd1579a51a Deprecate Homebrew/versions, Homebrew/devel-only.
Don't use Homebrew/versions in a test and remove them both from the
OFFICIAL_TAPS list (i.e. `brew search`).
2017-01-03 17:50:09 +00:00
Mike McQuaid
538028a735 Merge pull request #1766 from MikeMcQuaid/update-report-incoming-renames
update-report: handle homebrew/versions imports.
2017-01-02 20:42:57 +00:00
Vítor Galvão
2eed2ba434 Merge pull request #1760 from reitermarkus/version-file-separator
Disallow file separator in version strings.
2017-01-02 17:49:50 +00:00
Mike McQuaid
ed66fa3ae5 update-report: handle homebrew/versions imports.
Imports from homebrew/versions are migrated from that tap and then
renamed immediately when they hit homebrew/core. This did not trigger
our previous rename detection so address these to improve the output and
handle migration correctly.
2017-01-02 17:24:52 +00:00
Mike McQuaid
79f9896d2f bottles: --force-bottle feigns or_later.
When reproducing issues with software that hasn’t been bottled yet on
your version of macOS it can sometimes be helpful to use `or_later`
bottle functionality i.e. just use the bottle for the latest version of
macOS available. This maps well to the existing `--force-bottle`
argument so it will now act as if the latest bottle has a `or_later`
ending.
2017-01-02 16:05:14 +00:00
Markus Reiter
2c6516ef59 Disallow file separator in version strings. 2017-01-02 12:15:54 +01:00