Markus Reiter
58e36c7319
Fix Style/GuardClause.
2016-09-24 12:24:35 +02:00
Markus Reiter
fe2d51e0b9
Fix Style/IfUnlessModifier.
2016-09-23 15:30:07 +02:00
Mike McQuaid
3982950e61
rubocop --auto-correct all hash-rocket usage.
2016-09-17 16:14:13 +01:00
Mike McQuaid
6693915399
rubocop --auto-correct all remaining files.
...
But remove some manual `.freeze`s on constants that shouldn't be
constants.
2016-09-17 16:14:13 +01:00
Mike McQuaid
72d10fff0b
Use constants for LinkedKegs/PinnedKegs/Locks.
...
These definitions are scattered throughout the codebase which makes it
hard to refactor them later (my goal is to move them outside of
HOMEBREW_LIBRARY). Unify their definitions for clearer code and easier
movement later.
2016-09-15 18:28:42 +01:00
Xu Cheng
bfb44d9e67
migrator: use Tap#core_tap?
2016-03-08 21:55:09 +08:00
Xu Cheng
b52af53e71
various: use Tap abstraction
...
formula_rename and tap_migrations are now handled inside Tap.
Closes Homebrew/homebrew#49549 .
Signed-off-by: Xu Cheng <xucheng@me.com>
2016-02-26 17:00:17 +08:00
Xu Cheng
571011ad59
migrator: tap is a Tap object now
2015-12-09 16:56:59 +08:00
Xu Cheng
48950f2cc0
centralize the logic of handling homebrew- in Tap.fetch
...
Closes Homebrew/homebrew#46537 .
Signed-off-by: Xu Cheng <xucheng@me.com>
2015-12-03 13:46:59 +08:00
Mike McQuaid
be45e6a0c5
migrator: link Cellar and opt before the keg.
...
When there's absolute symlinks in a linked directory in the `keg`
(e.g. `bin`)that point to the `Cellar` or `opt` then linking the `keg`
will fail before the `Cellar` or `opt` has been linked.
Closes Homebrew/homebrew#44306 .
Closes Homebrew/homebrew#44329 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-09-25 16:53:34 +01:00
Vlad Shablinsky
a29832484c
fix style problems in migrator
...
Closes Homebrew/homebrew#43473 .
Signed-off-by: Xu Cheng <xucheng@me.com>
2015-09-03 13:58:25 +08:00
Misty De Meo
cb154116c5
migrator: #each.map is redundant
2015-08-24 19:36:24 -07:00
Vlad Shablinsky
896848dd87
migrator: skip check for same taps if --force
2015-08-20 19:55:35 +08:00
Xu Cheng
a628c15afd
lock keg during migration
2015-08-20 15:47:42 +08:00
Xu Cheng
48f260f674
migrator: better exception printing
2015-08-15 20:37:24 +08:00
Vlad Shablinsky
f83d418608
migrator: don't use installed_prefix
...
Link the keg that was linked before migration. Don't use
newformula.installed_prefix to detect keg to link, because it can break
things (i.e. if intalled formula is outdated, then
newformula.installed_prefix can be not the same as installed prefix
before update).
Closes Homebrew/homebrew#42857 .
Signed-off-by: Xu Cheng <xucheng@me.com>
2015-08-15 20:16:32 +08:00
Vlad Shablinsky
9736159c03
migrator: don't link newname if oldname isn't linked
...
- link newname only if oldname used to be linked
- optlink newname only if oldname used to be optlinked.
2015-08-15 20:16:31 +08:00
Vlad Shablinsky
2c1d8bcf65
migrator: check if old_opt_record exist before using realpath
...
- check if old_opt_record exist before using realpath
- don’t check old_opt_record.exist? in link_old_opt
because it doesn’t have to exist.
2015-08-15 20:16:31 +08:00
Mike McQuaid
49dce3e7ae
outdated: check if formula needs to be migrated.
...
Closes Homebrew/homebrew#42938 .
2015-08-14 15:18:45 +01:00
Vlad Shablinsky
f88f2b7054
update tabs only if core formula installed
...
Closes Homebrew/homebrew#42745 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-08-10 16:09:26 +01:00
Vlad Shablinsky
832c5875b0
add migrator class for migrating renamed formulae
2015-08-10 13:57:59 +01:00
