admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
29,684 Commits 15 Branches 471 Tags
Commit Graph

4320 Commits

Author SHA1 Message Date
Mike McQuaid
2e5272d04c Deprecate/disable code for Homebrew 2.5.0. 
Do the usual "disable deprecations" and "uncomment pending deprecations"
dance and delete/deprecate/disable relevant/related code.
 2020-09-03 10:34:22 +01:00
Maxim Belkin
a6d29894d9 cleanup: fix and reuse portable ruby logic. 
Align the logic in `cleanup_portable_ruby` with that in `ruby.sh`.

Co-authored-by: Maxim Belkin <maxim.belkin@gmail.com>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2020-09-03 09:43:41 +01:00
Mike McQuaid
8604cdb15a
Merge pull request #8541 from claui/fix-patch-stdout 
Return standard output in `popen_write`
 2020-09-02 17:48:12 +01:00
Mike McQuaid
64eaa80c47
Merge pull request #8522 from rmNULL/elf-fixtures 
spec:  Pathname#rpath, Pathname#interpreter and Pathname#patch!
 2020-09-02 17:21:47 +01:00
Markus Reiter
4d1fa19a18 Add test for GitHub::Actions::Annotation. 2020-09-02 16:44:16 +02:00
Markus Reiter
ebd4ce467c Output GitHub Actions annotations for brew style. 2020-09-02 16:44:16 +02:00
rmnull
7863cc6f80
remove {rust,cpp,go}.elf fixutres. 2020-09-02 18:58:36 +05:30
rmnull
f5ca649e1d
new elf fixtures, and basic tests for Pathname#rpath(=), and Pathname#interpreter(=). 2020-09-02 18:58:36 +05:30
Mike McQuaid
5e5dabcadd
Merge pull request #8431 from SeekingMeaning/formula/installed_prefix 
formula: rename `installed_prefix` and `opt_or_installed_prefix_keg`
 2020-09-01 19:22:50 +01:00
Markus Reiter
b9f3589ab7 Test casks are already tested covered brew style. 2020-09-01 19:26:46 +02:00
Seeker
f366280e18 formula: add any_installed_version 2020-09-01 09:45:54 -07:00
Seeker
5def0701ba formula: rename opt_or_installed_prefix_keg to any_installed_keg 2020-09-01 09:39:20 -07:00
Markus Reiter
b4d14c193f Use Homebrew::Style for brew cask style. 2020-09-01 18:34:26 +02:00
Seeker
5acdcd26d0 formula: rename installed_prefix to latest_installed_prefix 2020-09-01 09:32:32 -07:00
Mike McQuaid
8b97c27c21 brew style manual fixes 2020-09-01 14:26:45 +01:00
Markus Reiter
6994556d19 Don't allow platform in cask descriptions. 2020-09-01 13:18:59 +02:00
Markus Reiter
3038ff8726 Improve detection of descriptions starting with cask/formula name. 2020-09-01 02:53:25 +02:00
Rylan Polster
4d0a1ff775 deprecate!, disable!: allow symbols for reason 2020-08-31 10:11:08 -04:00
Rylan Polster
842335d47b style: check disable! dates and reasons 2020-08-31 10:11:08 -04:00
Rylan Polster
6162799d63 style: check deprecate! reason 2020-08-31 10:11:08 -04:00
nandahkrishna
e5fe57c1fe
Migrate livecheck to Homebrew/brew 
Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
Co-authored-by: Thierry Moisan <thierry.moisan@gmail.com>
Co-authored-by: Dawid Dziurla <dawidd0811@gmail.com>
Co-authored-by: Maxim Belkin <maxim.belkin@gmail.com>
Co-authored-by: Issy Long <me@issyl0.co.uk>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Co-authored-by: Seeker <meaningseeking@protonmail.com>
 2020-08-31 17:08:28 +05:30
nandahkrishna
8151016531
livecheck: remove test for livecheck_formulae 2020-08-31 16:37:37 +05:30
Mike McQuaid
854a139a79
Merge pull request #8533 from Rylan12/deprecate-date-issue 
style: fix deprecation date check
 2020-08-31 08:16:57 +01:00
Mike McQuaid
30e177f563
Merge pull request #8254 from nandahkrishna/migrate-livecheck-module 
livecheck migration: create Homebrew::Livecheck
 2020-08-31 08:09:58 +01:00
Claudia
772032f18a
Add failing tests for popen_write 
When using `popen_write`, the expectation is to return the
standard output of the child process.

This expectation is evident in how `safe_popen_write` is written:

```
  def self.safe_popen_write(*args, **options, &block)
    output = popen_write(*args, **options, &block)
    return output if $CHILD_STATUS.success?

    raise ErrorDuringExecution.new(args, status: $CHILD_STATUS, output: [[:stdout, output]])
  end
```

However, no code has been written to actually *obtain* that output
from the child process. The side effects of that are described in
issue #8244. [1]

[1]: https://github.com/Homebrew/brew/issues/8244

The newly-added tests reveal that `popen_write` only returns the
number 4 instead of the expected standard output.

For example, given a file `foo` with the content `Foo\n`, one test
calls `popen_write` with `cat foo -` and an input of `Bar`.
The expected output would be `Foo\nBar\n` but the actual output is
the number 4 (which is what Ruby’s `IO#write` method returns).
 2020-08-30 22:29:46 +02:00
Markus Reiter
0129247391 Refuse to install Git if HOMEBREW_TEST_GENERIC_OS is set. 2020-08-29 21:45:51 +02:00
Markus Reiter
bb1be7ef9d Call clear_available_cache before and after Git specs. 2020-08-29 21:42:24 +02:00
Rylan Polster
b1c374b729 style: fix deprecation date check 2020-08-29 10:57:07 -04:00
Nanda H Krishna
3cab6042d8
livecheck: update URL in test 
Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
 2020-08-29 03:23:10 +05:30
nandahkrishna
062156365b
livecheck: modified test 2020-08-29 02:18:18 +05:30
nandahkrishna
2550af57df
livecheck: changes made and improved test 2020-08-29 00:32:34 +05:30
Seeker
4377a08b6e version: allow implicitly converting tokens to strings 2020-08-28 10:25:52 -07:00
nandahkrishna
4e0cc48b65
livecheck: changes made and tests added 2020-08-27 22:46:06 +05:30
nandahkrishna
c9f0642d45
livecheck migration: create Homebrew::Livecheck 
Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
Co-authored-by: Thierry Moisan <thierry.moisan@gmail.com>
Co-authored-by: Dawid Dziurla <dawidd0811@gmail.com>
Co-authored-by: Maxim Belkin <maxim.belkin@gmail.com>
Co-authored-by: Issy Long <me@issyl0.co.uk>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Co-authored-by: Seeker <meaningseeking@protonmail.com>
 2020-08-27 21:26:58 +05:30
Mike McQuaid
ff8d30df74
Merge pull request #8255 from nandahkrishna/migrate-livecheck-strategy 
livecheck migration: add strategies
 2020-08-27 16:12:38 +01:00
nandahkrishna
f520301180
livecheck migration: add strategies 
Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
Co-authored-by: Thierry Moisan <thierry.moisan@gmail.com>
Co-authored-by: Dawid Dziurla <dawidd0811@gmail.com>
Co-authored-by: Maxim Belkin <maxim.belkin@gmail.com>
Co-authored-by: Issy Long <me@issyl0.co.uk>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Co-authored-by: Seeker <meaningseeking@protonmail.com>
 2020-08-27 20:00:30 +05:30
vidusheeamoli
2468fb127d dev-cmd: add brew typecheck cmd 
This PR adds a new `brew typecheck` developer command which checks for
typechecking errors in the current code with Sorbet.
 2020-08-27 02:41:36 +05:30
Markus Reiter
c53f362476 Refactor and document Version. 2020-08-26 03:17:39 +02:00
Mike McQuaid
31f3afa36d
Merge pull request #8480 from MikeMcQuaid/tests-timeout 
spec_helper: increase tests timeout.
 2020-08-25 11:08:17 +01:00
Mike McQuaid
2bdf0d6068
spec_helper: increase tests timeout. 
When GitHub Actions is congested some tests can take longer than this
(particularly as we're running in parallel). Globally double the time
we allow for all tests.
 2020-08-25 10:20:17 +01:00
Mike McQuaid
dbe427073d
Merge pull request #8399 from MLH-Fellowship/migrate-to-args-named 
args: Migrate usage of args loading methods to args.named
 2020-08-25 10:07:27 +01:00
Markus Reiter
75962590db
Merge pull request #8466 from reitermarkus/bundle-spec 
Remove unused metadata from `bundle` spec.
 2020-08-24 19:35:59 +02:00
Mike McQuaid
4bc2f9d705
Merge pull request #8438 from Bo98/repology-needs_network 
test/utils/repology_spec: mark as `:needs_network`
 2020-08-24 09:26:13 +01:00
Mike McQuaid
a1c5428c50
Merge pull request #8439 from Bo98/spdx_spec-noerr 
test/utils/spdx_spec: don't error if test is skipped
 2020-08-24 09:18:09 +01:00
Markus Reiter
21c502e05f Remove unused metadata from bundle spec. 2020-08-24 08:31:07 +02:00
Markus Reiter
4465a1f6fb
Merge pull request #8455 from reitermarkus/document-svn 
Refactor and document `Svn`.
 2020-08-24 00:03:21 +02:00
William Ma
fa7bd3bff6 args: Migrate usage of args loading methods to args.named 2020-08-23 09:02:20 -04:00
Markus Reiter
3118fedab9 Refactor and document Git. 2020-08-23 06:40:07 +02:00
Markus Reiter
8b26e380a2 Refactor and document Svn. 2020-08-23 06:33:58 +02:00
Markus Reiter
caa73877c0 Refactor and document Inreplace. 2020-08-23 04:48:19 +02:00