7001 Commits

Author SHA1 Message Date
Jack Nagel
efd52da101 Remove dead code 2015-05-27 21:57:41 -04:00
Dominyk Tiller
6db8e1c5a9 audit: simplify ssl/tls audit failure messages
This cuts the amount of custom code fairly drastically, applying the
same generic syntax across the different SSL/TLS enforced areas.

It also makes the failure message fit onto one terminal line, which
looks cleaner than the multi-line message we currently print
for standard-size Terminals.

Changes something like:

`ftp.gnu.org urls should be https://, not http:// (url is http://ftp.gnu.org/gnu/gawk/gawk-4.1.1.tar.xz)`

Into:

`Please use https:// for http://ftp.gnu.org/gnu/gawk/gawk-4.1.1.tar.xz`

References: Homebrew/homebrew#39421 Homebrew/homebrew#39306

Closes Homebrew/homebrew#40054.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2015-05-27 11:44:29 +01:00
pmwheatley
c178d50f29 cmd/switch: fix exception.
keg_only? should use 'rack' not 'canonical_name'

Closes Homebrew/homebrew#40124.
Closes Homebrew/homebrew#40126.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-05-27 11:39:26 +01:00
Mike McQuaid
fc5070c252 formula_installer: set tap source for bottles.
This defaults to the value that's in the bottle but that isn't
necessarily correct. For example, some Boxen modules will reuse our
old bottles and so if they are installed from there we should be sure
to set the tab's tap to the tap we've installed from rather than the one
set inside the bottle's tarball.

Closes Homebrew/homebrew#40096.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-05-27 10:21:46 +01:00
Mike McQuaid
f55257306e tab: add method to set tap. 2015-05-27 10:21:45 +01:00
Mike McQuaid
ef08db539b test-bot: always brew install as a non-developer.
Bored of dealing with the bottle conflicts errors here so I don't think
it's really worth working around.

Closes Homebrew/homebrew#40097.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-05-27 10:00:47 +01:00
Xu Cheng
e3ed1ccb15 uninstall: load formula from rack
Closes Homebrew/homebrew#39524.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-05-27 13:53:42 +08:00
Xu Cheng
bc41f947de test-bot: rescue TapFormulaAmbiguityError 2015-05-27 13:53:42 +08:00
Xu Cheng
e744e8b0f9 upgrade: use ARGV.resolved_formulae 2015-05-27 13:53:42 +08:00
Xu Cheng
3463a8fe6b unpin: use ARGV.resolved_formulae 2015-05-27 13:53:42 +08:00
Xu Cheng
356df9baee test: use ARGV.resolved_formulae 2015-05-27 13:53:42 +08:00
Xu Cheng
d338f291df reinstall: use ARGV.resolved_formulae 2015-05-27 13:53:42 +08:00
Xu Cheng
437a3182b0 postinstall: use ARGV.resolved_formulae 2015-05-27 13:53:41 +08:00
Xu Cheng
ba4d7fe615 pin: use ARGV.resolved_formulae 2015-05-27 13:53:41 +08:00
Xu Cheng
ebbeda850a outdated: use ARGV.resolved_formulae 2015-05-27 13:53:41 +08:00
Xu Cheng
da7d3c18ed missing: use ARGV.resolved_formulae 2015-05-27 13:53:41 +08:00
Xu Cheng
fb8548cae5 link: load formula from rack 2015-05-27 13:53:41 +08:00
Xu Cheng
c14794baa8 keg: add rack method 2015-05-27 13:53:41 +08:00
Xu Cheng
c41c473513 gist-logs: use ARGV.resolved_formulae 2015-05-27 13:53:41 +08:00
Xu Cheng
04c274f727 doctor: load formula from rack 2015-05-27 13:53:41 +08:00
Xu Cheng
5ca7035e32 --prefix: use ARGV.resolved_formulae 2015-05-27 13:53:41 +08:00
Xu Cheng
75eac94b57 --cellar: use ARGV.resolved_formulae 2015-05-27 13:53:41 +08:00
Xu Cheng
dcf0efc9d2 cleanup: load formula from rack and using ARGV.resolved_formulae 2015-05-27 13:53:41 +08:00
Xu Cheng
8a4dcdd5a1 bottle: use ARGV.resolved_formulae 2015-05-27 13:53:41 +08:00
Xu Cheng
ef3f0f0945 audit: handle TapFormulaAmbiguityError 2015-05-27 13:53:41 +08:00
Xu Cheng
d2f7a2c410 ARGV#kegs: try to load fomrula from rack 2015-05-27 13:53:40 +08:00
Xu Cheng
60383be032 ARGV: add resolved_formulae method 2015-05-27 13:53:40 +08:00
Xu Cheng
ec4011a46e Formula#installed: loading using Formulary.from_rack
Also handle TapFormulaAmbiguityError
2015-05-27 13:53:40 +08:00
Xu Cheng
647c7626f0 Formulary: add from_rack 2015-05-27 13:53:40 +08:00
Xu Cheng
e91d152af8 Formulary#canonical_name: handle TapFormulaAmbiguityError
If there are multiple tap formulae with the name of ref,
then ref is the canonical name
2015-05-27 13:53:40 +08:00
Xu Cheng
074de88a9b update manpage 2015-05-27 13:53:40 +08:00
Xu Cheng
171c3dd2d9 tap/untap/update/prune: remove obsolete method, add migrate_taps 2015-05-27 13:53:40 +08:00
Xu Cheng
e2b0bca931 add Formula.core_names Formula.tap_names and Formula.full_names 2015-05-27 13:53:40 +08:00
Xu Cheng
811c4c5add load tap formula through direct search 2015-05-27 13:53:40 +08:00
Xu Cheng
3a3a49bd93 add Formulary.core_path method, deprecate Formula.path 2015-05-27 13:53:40 +08:00
Xu Cheng
3108fb5d22 BottleLoader: using Formulary.path to search formula file 2015-05-27 13:53:40 +08:00
Ryan Hendrickson
a744da3b4c superenv cc: accept single-digit g++ version
Closes Homebrew/homebrew#40117.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2015-05-26 20:13:25 -04:00
Jack Nagel
be0a1e7635 Check empty? to avoid introducing nils
[].last => nil
[].max => nil
2015-05-26 19:51:30 -04:00
Larry Gilbert
5345c06e63 More explanation of HOMEBREW_{CELLAR,PREFIX,REPOSITORY}
Closes Homebrew/homebrew#39447.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2015-05-26 20:37:58 +01:00
Mike McQuaid
d8f9552cab bottle: handle nil bottle revision case. 2015-05-26 15:49:39 +01:00
Ian Lancaster
c327fdafa9 bottle: discard bottle revision from prior pkg_version
Closes Homebrew/homebrew#38628.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-05-26 19:21:15 +08:00
Ryan Hendrickson
798711cade Use canonical representation of the superenv bin directory
The xcrun script should be skipping the ENV directory when it scans
$PATH looking for tools to run. Unfortunately, the script compares the
paths found to the real path of the ENV directory (following symlinks),
but superenv was adding the nominal path to $PATH, not following
symlinks. As a consequence, platforms with Xcode < 4.3 would get into
infinite loops when trying to call non-system versions of gcc, as xcrun
calls the ENV version of gcc-X.X which calls xcrun and so on forever.

This commit changes superenv to follow symlinks when determining the bin
path to use.

Fixes Homebrew/homebrew#33731.
Closes Homebrew/homebrew#40062.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2015-05-25 22:01:12 -04:00
Nikolaus Wittenstein
664c8deaab example-formula.rb has a 'desc'
Closes Homebrew/homebrew#39911.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-05-25 17:23:51 +01:00
Nikolaus Wittenstein
f1ed19d96b brew create adds a desc field to the new formula 2015-05-25 17:23:50 +01:00
Nikolaus Wittenstein
39498af1c6 audit looks for and validates 'desc' 2015-05-25 17:23:50 +01:00
Nikolaus Wittenstein
148cafa9cd brew search can take a --desc argument to search descriptions 2015-05-25 17:23:50 +01:00
Nikolaus Wittenstein
5e73e68ab1 Info shows the desc if present 2015-05-25 17:23:50 +01:00
Nikolaus Wittenstein
86365470e6 Add a desc field to Formula 2015-05-25 17:23:49 +01:00
Xu Cheng
60f2377853 audit: formula version string should have digit
Closes Homebrew/homebrew#40025.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-05-24 20:07:44 +08:00
Xu Cheng
78ccd41251 audit: add rules for non-ascii character and encoding comment
Closes Homebrew/homebrew#40042.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-05-24 20:07:33 +08:00