admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
31,555 Commits 15 Branches 471 Tags
Commit Graph

266 Commits

Author SHA1 Message Date
Mike McQuaid
1bb44979ee
Disable and delete code for 3.5.0 
The next planned release will be 3.5.0 so let's fix things up for there.
 2022-05-30 14:59:14 +01:00
hyuraku
e46e35bb0c delete bottle deprecate key 2022-02-24 21:57:54 +09:00
Adrian Ho
af4955adfc dev-cmd/bottle: clean up intermediate tar 
Otherwise Cellar gets cluttered.

Fixes https://github.com/Homebrew/brew/issues/12744.
 2022-01-18 15:58:35 +08:00
XuehaiPan
9ef52080e3 utils: extract common word "for" in reason 2021-11-23 23:59:09 +08:00
XuehaiPan
d749173adc utils: mark reason as keyword argument in ensure_formula_installed! 2021-11-23 23:31:22 +08:00
XuehaiPan
3376479e95 utils: add method ensure_formula_installed! 2021-11-23 22:48:39 +08:00
Bo Anderson
38ebaac869
dev-cmd/bottle: fix pkg_version comparison on merge 2021-11-08 03:42:41 +00:00
Bo Anderson
d4c33634db
dev-cmd/bottle: correct all rebuild matching logic 2021-11-06 03:44:14 +00:00
Bo Anderson
d2ba21c1b1
dev-cmd/bottle: don't gen all bottles if a bottle spec already exists 2021-11-05 17:29:18 +00:00
danielnachun
e69fbaf357
bottle.rb: fix typo in go regex 2021-10-25 23:21:01 -07:00
danielnachun
0323c3ae30
bottle.rb: add workaround to make gcc have cellar :any 2021-10-19 10:55:03 -07:00
fn ⌃ ⌥
35d6839b56 archive: delete 2021-09-30 09:50:04 -07:00
Bo Anderson
b55498269f
Revamp APIs around bottle specifications 2021-09-20 15:02:05 +01:00
Rylan Polster
b1215800d4
Fix tests 2021-08-06 11:42:55 -04:00
Mike McQuaid
82c5756690
dev-cmd/bottle: use native Ruby. 
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
 2021-07-14 11:45:03 +01:00
Mike McQuaid
721ed8542b
dev-cmd/bottle: fixup macOS symlink permissions. 
These can be changed on macOS but not on Linux so we need to make them
consistent in both places for `all:` bottles to have consistent
checksums.

I investigated adding to `cleaner.rb` to fix these symlink permissions
on installation but it seems it already happens by default when
extracting so there's no need.
 2021-07-14 10:31:25 +01:00
Rylan Polster
023063d6a2
bottle: calculate rebuild correctly when removing bottle :unneeded 2021-06-01 11:39:07 -04:00
Rylan Polster
7c68b1738b
Merge pull request #11332 from Rylan12/relocate-paths-at-start 
keg_relocate: only replace matches at the start of a path
 2021-05-13 12:19:06 -04:00
Rylan Polster
4457dc904b
Cleanup using suggestions from code review 2021-05-13 11:02:39 -04:00
Bo Anderson
6d31408606
dev-cmd/bottle: make gzip creation consistent across platforms 2021-05-12 14:21:38 +01:00
Mike McQuaid
b914411ac8
Delete Bintray code 
Remove all code related to Bintray. It no longer works so there's no
point keeping it around.

Some of this could arguably be deprecated/disabled first/instead but:
I'm not sure I see the sense in keeping stuff around that's known to be
broken.
 2021-05-12 13:37:18 +01:00
Rylan Polster
5f781770b4
Extract Keg::text_matches_in_file from bottle command 2021-05-11 14:26:14 -04:00
Rylan Polster
fe7f80f647
Refactor out and correctly create path regex 2021-05-11 14:26:14 -04:00
Rylan Polster
fd3730a531
bottle: allow links to pkgconfig directory in HOMEBREW_REPOSITORY 2021-05-11 14:26:14 -04:00
Rylan Polster
9ddb531249
bottle: update keg_contain? to match correctly 2021-05-11 14:26:14 -04:00
Rylan Polster
acebeab9cb
bottle: improve style of rebuild fallback 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2021-05-05 08:27:58 -04:00
Rylan Polster
da27c70323
bottle: properly set rebuild for new formulae 2021-05-04 23:10:40 -04:00
Chris Wegrzyn
aa3e623b28 Omit warning, as brew audit already covers this 2021-05-04 09:50:42 -04:00
Chris Wegrzyn
570b62dd75 prev_f -> upstream_f 2021-05-04 09:41:53 -04:00
Chris Wegrzyn
9ab44b8b6a bottle: just check origin/HEAD for rebuild 2021-05-03 10:07:30 -04:00
Chris Wegrzyn
056c9bb37f Only consider latest rebuild 2021-05-03 10:07:29 -04:00
Mike McQuaid
08926fb1ec
dev-cmd: run Homebrew.install_bundler_gems! earlier. 
Run `Homebrew.install_bundler_gems!` a bit earlier for some developer
commands to avoid printing gem installation output in the middle of
normal developer command output.
 2021-04-30 12:00:28 +01:00
Mike McQuaid
2fa973bb3b
Merge pull request #11259 from bluelabsio/bottle-root-url-specs 
dev-cmd/bottle: Support adding root_url specs to bottle spec
 2021-04-29 19:54:53 +01:00
Chris Wegrzyn
68852c9162 Style fix 2021-04-29 12:51:15 -04:00
Chris Wegrzyn
ee8dc058d8 Better help text 2021-04-29 12:37:22 -04:00
Chris Wegrzyn
ffbabfd238 Rename download-strategy to root-url-using 2021-04-29 12:37:20 -04:00
Chris Wegrzyn
76607bbb6f Simplify conditional as suggested 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2021-04-29 12:35:50 -04:00
Chris Wegrzyn
3f60c95425 --download-strategy instead of --root-url-spec 2021-04-29 12:35:48 -04:00
Chris Wegrzyn
4025dce097 Support adding root_url specs in bottle output 2021-04-29 12:34:03 -04:00
Mike McQuaid
dcf03173e9
dev-cmd/bottle: remove double [tag]. 
Fixes https://github.com/Homebrew/brew/pull/11283#discussion_r623181245
 2021-04-29 17:08:23 +01:00
Mike McQuaid
7ba634ccb4
Merge pull request #11283 from MikeMcQuaid/no_bottle_changes_error_handling 
dev-cmd/bottle: handle empty collector tags.
 2021-04-29 16:32:35 +01:00
Michka Popoff
1a27e4fd4a
Merge pull request #11278 from iMichka/bottle 
bottle: do not fail on missing bottle block
 2021-04-29 17:22:39 +02:00
Mike McQuaid
f9589429d6
dev-cmd/bottle: handle empty collector tags. 
Fixes https://github.com/Homebrew/homebrew-core/runs/2467738434?check_suite_focus=true#step:6:458
 2021-04-29 16:00:22 +01:00
Mike McQuaid
d44d686cd5
dev-cmd: avoid uploading identical bottles. 
If the `rebuild`, `root_url`, `cellar` and checksums are all identical
between an old and new bottle block: we don't need a new bottle at
all. Handle this by deleting the relevant files with
`brew bottle --merge --write` and gracefully notifying the caller of
`brew pr-upload`.

This should avoid e.g.
39340a11ea
occurring in future.
 2021-04-29 14:48:45 +01:00
Michka Popoff
697edce654
bottle: do not fail on missing bottle block 
For :all bottle blocks in linuxbrew-core, we are going to remove the bottle
block completely before rebottling.
In linuxbrew-core, we use --keep-old to keep the macOS sha lines.

I am not sure why this exception was written initially, but it
now prevents bottling these formulae, because we have no bottle block
and use --keep-old.

I think it's safe to just skip this check, when there is no bottle block
the old_checksum can just directly return nil.
 2021-04-29 14:45:47 +02:00
Bo Anderson
a038110115
dev-cmd/bottle: fix all JSON filename 2021-04-28 22:38:06 +01:00
Mike McQuaid
40a36e422e
dev-cmd/bottle: output more filenames when verbose. 
More debugging for the bottle rebuild workflow.
 2021-04-28 20:25:02 +01:00
Mike McQuaid
16d5472e4b
dev-cmd/bottle: improve filename handling. 
Rely more heavily on the `Bottle::Filename` class rather than hacking
around things manually.

Without this the rebuilding bottles workflow is broken for `all:`
bottles.
 2021-04-28 17:10:46 +01:00
Mike McQuaid
20eeb5aca0
dev-cmd/bottle: add missing verbose puts. 
These were added but didn't actually output anything...
 2021-04-28 14:23:09 +01:00
Mike McQuaid
dd201a219c
dev-cmd: add more --verbose bottle, pr-upload output. 
This should make it easier to debug `all:` bottle upload failures.

While we're here, remove the weird `_` that ended up at the end of a
method name.
 2021-04-28 12:48:24 +01:00