8431 Commits

Author SHA1 Message Date
Misty De Meo
c757bd7c90 tap_constants: support lowercase caskroom in regex
Closes Homebrew/homebrew#50343.

Signed-off-by: Misty De Meo <mistydemeo@github.com>
2016-03-26 14:50:10 +08:00
Dominyk Tiller
81dc7316a6 ngrok: add to blacklist
Closes Homebrew/homebrew#50364.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2016-03-26 14:50:10 +08:00
Dominyk Tiller
ffc00f4836 ngrok: boneyard
ngrok 1.x has been sunset by upstream. It no longer functions for non-authenticated
users and as of April 4th will stop working entirely.

Upstream has also clarified there are no plans or intentions to make 2.x
open-source, which means we cannot carry that upgrade in core Homebrew, partially
for legal reasons.

If you wish to use the closed-source 2.x release you can still install it
via Homebrew in a couple of ways:

You can either `brew install homebrew/binary/ngrok2`
OR:
You can install it via the Caskroom, with `brew cask install ngrok`.

Closes Homebrew/homebrew#49432.
2016-03-26 14:50:10 +08:00
moofusecurity
b896629da4 connect 1.105 (migrate from boneyard)
connect is a utility that provides SOCKS and HTTPS proxy support to
SSH. I have created a new formula for version 1.104 that works
unlike the formula for 1.100 that is currently in the boneyard.

Closes Homebrew/homebrew#49716.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2016-03-26 14:50:10 +08:00
Xu Cheng
b8a4677de0 --repository: support to show tap path
This can become handy when we separate core code and formulae. For
example, we could use `cd $(brew --repo homebrew/core)` to go to core
tap path.

Closes Homebrew/homebrew#50346.

Signed-off-by: Xu Cheng <xucheng@me.com>
2016-03-24 14:52:13 +08:00
Xu Cheng
6e27e2db74 tap: cache dir path to avoid duplicated Pathname operations
As discovered in Homebrew/homebrew#50256, this becomes a performance bottleneck as we are
repeating construct same Pathname object.

At the same, this commit makes the behaviors between Tap and CoreTap more
consistence.
2016-03-23 15:01:28 +08:00
Xu Cheng
478f18a8f5 software_spec: add ExternalPatch to dependency_collector
Since we support `apply` DSL in the `patch` block, external
patch files could be any compressed archive. As result, it
could introduce dependencies like xz, 7z etc.

Add the resource of ExternalPatch to dependency_collector, so
we could track these resource dependencies.

Closes Homebrew/homebrew#50318.

Signed-off-by: Xu Cheng <xucheng@me.com>
2016-03-22 19:44:16 +08:00
Dominyk Tiller
ca5b7440c6 diagnostic: make chown recommendation consistent
This is the only place we advise `:admin` as well so might as well
change this one.

Closes Homebrew/homebrew#50279.

Closes Homebrew/homebrew#50295.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2016-03-22 18:55:19 +08:00
Dominyk Tiller
4f70064d73 test_diagnostic: update expected wording 2016-03-22 18:55:19 +08:00
Dominyk Tiller
142be05c0f diagnostic: trim unnecessary 'the' 2016-03-22 18:55:19 +08:00
Xu Cheng
99155c3b5f update: use git from ENV/scm/git
The idea is to let `scm/git` to handle all of git location resolution
throughout Homebrew codebase.

Closes Homebrew/homebrew#50116.

Signed-off-by: Xu Cheng <xucheng@me.com>
2016-03-21 19:07:38 +08:00
Xu Cheng
e0e277ecde utils/git: various improvement
* Use `ENV/scm/git` to check whether git is installed.
* Use `brew install git` to enforce pre-install checks such as sudo
  check.
2016-03-21 19:07:38 +08:00
Xu Cheng
8ca79a6df5 scm/git: handle no Xcode/CLT configuration
`/usr/bin/<tool>` will be a popup stub under such configuration.

The idea is to let `scm/git` to handle all of git location resolution
throughout Homebrew codebase.
2016-03-21 19:07:38 +08:00
Xu Cheng
ce7b32cec8 add HOMEBREW_ENV_PATH internal variable
`Library/ENV` like `Library/Homebrew` is part of Homebrew basecode. It
should be able to be accessed during the `brew tests`.

By adding HOMEBREW_ENV_PATH variable, we allow test suit to locate these
codes.
2016-03-21 19:07:38 +08:00
Xu Cheng
28b4923dad fix tests for deprecating SHA1
Closes Homebrew/homebrew#50272.

Signed-off-by: Xu Cheng <xucheng@me.com>
2016-03-20 14:55:58 +08:00
Xu Cheng
bd7e8543b3 deprecate SHA1 2016-03-20 14:55:58 +08:00
Xu Cheng
93cbab0021 Revert "brew fetch: only include sha256 in output"
This reverts commit 0b38f9b286bc61e2b2d2232f80ea8ebc5909fb07.
2016-03-20 14:55:58 +08:00
Tim D. Smith
8aaa95ee99 Add advice about keychain credentials
Fixes Homebrew/homebrew#50050. Closes Homebrew/homebrew#50059.
2016-03-20 14:55:58 +08:00
Sam McTaggart
148da47571 Improve error message for invalid regex to search
Fixes https://github.com/Homebrew/homebrew/issues/50131

This commit removes the error backtrace and improves the error message
if a bad regexp is passed to `brew search`.

Closes Homebrew/homebrew#50173.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
2016-03-19 19:14:50 +08:00
Tim D. Smith
af36139218 Document that Xcode.prefix can be nil 2016-03-19 19:14:50 +08:00
Tim D. Smith
fe37cc5271 Revert "Avoid constructing paths by string interpolation"
This reverts commit 8c7f3d859e8f715b6c63e4fe75e7a636aee4167f.
2016-03-19 19:14:50 +08:00
Tim D. Smith
87781f2a37 Avoid constructing paths by string interpolation
Closes Homebrew/homebrew#50154.
2016-03-19 19:14:50 +08:00
Tim D. Smith
f0a5abe12e More specific test for default prefix
cf. Homebrew/homebrew#50154
2016-03-19 19:14:50 +08:00
Tim D. Smith
f30c264519 Avoid pathological trailing slash
Resolves an issue where xcode-select output with a terminal slash leads
to superenv failing to strip system library paths from ccld-style
invocations.

Fixes Homebrew/homebrew#49731. Discussion in Homebrew/homebrew#50154.
2016-03-19 19:14:50 +08:00
ilovezfs
90774be2ee libodbc++: boneyard
Upstream has ignored the 64-bit patches from the original Homebrew pull
request, as well as subsequent 64-bit reports:
https://sourceforge.net/p/libodbcxx/bugs/25/

Trunk hasn't been updated since 2010 and the last tag was in 2009.

Closes Homebrew/homebrew#49980.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2016-03-19 19:14:50 +08:00
Xu Cheng
161a1e286e Revert "test-bot: better xml character filtering"
This reverts commit 7032591bd44a8f50aaa55574ac97cd5cb7261460 and
commit 946c6deb4b5168ad2ec15e62aa6e81181e9e246c.
2016-03-14 20:41:33 +08:00
Xu Cheng
60055ba890 test-bot: fix encoding caused by UTF-8 regex 2016-03-14 20:33:35 +08:00
Xu Cheng
a6b918d6c5 test-bot: better xml character filtering
Ref:
 - http://www.w3.org/TR/xml/#charsets
 - http://stackoverflow.com/a/14323524

Closes Homebrew/homebrew#50092.

Signed-off-by: Xu Cheng <xucheng@me.com>
2016-03-14 19:58:15 +08:00
Andrew Janke
a74e872409 brew fetch: only include sha256 in output
Closes Homebrew/homebrew#50067.

Signed-off-by: Andrew Janke <andrew@apjanke.net>
2016-03-14 19:39:15 +08:00
Baptiste Fontaine
236a18debe audit: fix crash when HOMEBREW_NO_GITHUB_API is set
Running brew audit --strict --online on a formula with a GitHub
homepage/url would crash if HOMEBREW_NO_GITHUB_API is set because
GitHub.repository returns `nil` and the audit code assumes it always
returns a hash.

Closes Homebrew/homebrew#50054.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2016-03-14 19:39:15 +08:00
ilovezfs
1e1184fc2d superenv: fix make_jobs regular expression
HOMEBREW_MAKE_JOBS can be a multidigit number. The regex should match
the entire number not just the last digit.

Closes Homebrew/homebrew#50016.

Signed-off-by: Tim D. Smith <git@tim-smith.us>
2016-03-13 14:32:05 +08:00
Andrew Janke
23ee1ee499 brew pull: fix encoding of brew info --json output
Fixes Homebrew/homebrew#49757
Closes Homebrew/homebrew#49775

Closes Homebrew/homebrew#49947.

Signed-off-by: Andrew Janke <andrew@apjanke.net>
2016-03-13 14:32:05 +08:00
Dominyk Tiller
ad5ee6a3f1 asm6: boneyard
The upstream URL/Homepage have been 404 for a while now and there's no credible
alternative homepage/download. We're using the wayback machine but essentially
if this breaks we're left as the sole supporter of the project and we don't
want to be in that position as a package manager.

Closes Homebrew/homebrew#47168.

Closes Homebrew/homebrew#50021.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2016-03-13 14:32:05 +08:00
Dominyk Tiller
0b97df3caf xulrunner: boneyard
Mozilla have dropped support for xulrunner and currently no developer has picked it up.

On our side of the deal, beyond this summer when a new major release of OS X is
released we'll lose the ability to build & test this formula completely as it
currently doesn't build on anything newer than Mavericks.

Ref: https://lists.mozilla.org/pipermail/dev-platform/2015-July/011178.html
Ref: https://bugzilla.mozilla.org/show_bug.cgi?id=1221724

Closes Homebrew/homebrew#33558.
2016-03-13 14:32:05 +08:00
Dominyk Tiller
5291bb4a2e arpon: boneyard
Upstream have dropped support for OS X in the latest release.

Closes Homebrew/homebrew#49442.
2016-03-13 14:32:05 +08:00
Dominyk Tiller
8a32f73b0b fleet-db: boneyard
Upstream is completely dead, formula hasn't been updated to the most recent
release which was available years ago, tried to update and resulting install
doesn't seem to function as expected.

Closes Homebrew/homebrew#49635.
2016-03-13 14:32:05 +08:00
Andrew Janke
f63b4359d7 brew pull: enable blocking bintray publish by setting content-type
Looks like the bintray publish_wait_for_secs was being ignored because the
content type wasn't being set, so it defaulted to x-www-form-urlencoded
instead of application/json.

Changes the  timeout to 0 to preserve current non-blocking behavior, which
we want in case multiple formulae are being updated.

Closes Homebrew/homebrew#49951.

Signed-off-by: Andrew Janke <andrew@apjanke.net>
2016-03-11 13:32:54 +08:00
Mike McQuaid
2c3a7e8c75 Fix brew update user agent.
This needs to be `Homebrew $HOMEBREW_VERSION` so we can be adequately
filtered.

Closes Homebrew/homebrew#49961.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2016-03-11 13:32:54 +08:00
Mike McQuaid
c8debd8fa4 utils: API Git credential tweaks.
- Use empty array when `git credential-osxkeychain` lookup fails to
  cache and avoid rerunning it when there's no valid results.
- Redirect `stderr` to avoid printing errors when there's a failure
  or no `git credential-osxkeychain` installed.

Closes Homebrew/homebrew#49954.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2016-03-10 18:45:43 +08:00
Xu Cheng
0f6def90b7 update: shallow fetch for git_init_if_necessary
Users shouldn't need to fetch all of git history.

Closes Homebrew/homebrew#49903.

Signed-off-by: Xu Cheng <xucheng@me.com>
2016-03-09 19:47:26 +08:00
Xu Cheng
e8caa48cc2 brew.sh: add tap-pin to sudo check list 2016-03-09 19:35:41 +08:00
Xu Cheng
865b788e96 Revert "update: checkout branch unconditionally"
This reverts commit 0525c9eeea27eff1a6de05e7a01ec268ae07437b.
Which breaks `brew update --rebase`.
2016-03-09 17:38:46 +08:00
Mike McQuaid
ec2a3f979e utils: use string arg to IO.popen.
Closes Homebrew/homebrew#49882.
2016-03-09 16:00:22 +08:00
Xu Cheng
bfb44d9e67 migrator: use Tap#core_tap? 2016-03-08 21:55:09 +08:00
Mike McQuaid
041c8502c5 Set HOMEBREW_API_TOKEN from Git when available.
As requested in Homebrew/homebrew#46578. Falls back to existing functionality.

Closes Homebrew/homebrew#46578.

Closes Homebrew/homebrew#49846.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2016-03-08 20:52:11 +08:00
Xu Cheng
0cbc285701 test_update_report: simplify test
Closes Homebrew/homebrew#49874.

Signed-off-by: Xu Cheng <xucheng@me.com>
2016-03-08 20:36:19 +08:00
Xu Cheng
3a4f2c1aea update: checkout branch unconditionally 2016-03-08 20:36:19 +08:00
Xu Cheng
cad2a5620f update: passing --force to git fetch
Per document:
> -f, --force
>    When git fetch is used with <rbranch>:<lbranch> refspec, it refuses
>    to update the local branch <lbranch> unless the remote branch
>    <rbranch> it fetches is a descendant of <lbranch>. This option
>    overrides that check.
2016-03-08 20:36:19 +08:00
cubuspl42
16f8b16f19 blacklist: suggest Cask for installing mactex
Closes Homebrew/homebrew#49817.

Signed-off-by: Alex Dunn <adunn@ucsb.edu>
2016-03-08 13:47:29 +08:00
Mike McQuaid
0578ba0f42 install_renamed: handle recursive installs.
Closes Homebrew/homebrew#49845.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2016-03-08 13:47:29 +08:00