21240 Commits

Author SHA1 Message Date
Sean Molenaar
43ae03d6e3
Merge pull request #7657 from SMillerDev/fix/artifact_in_pr
Only search pull requests for artifacts
2020-05-28 15:46:12 +02:00
Sean Molenaar
a99d428f6d
Only search pull requests for artifacts 2020-05-28 15:14:32 +02:00
Sean Molenaar
28b842aa4c
Merge pull request #7650 from Homebrew/SMillerDev-patch-1
Clarify what entails a versioned formula
2020-05-28 14:31:46 +02:00
Mike McQuaid
2955181654
Merge pull request #7656 from rmNULL/check-for-nil-when-patchelf-is-not-found
Instructions to install patchelf, when development tools cant locate …
2020-05-28 08:25:00 +01:00
rmnull
39c572b546
Instructions to install patchelf, when development tools cant locate patchelf. 2020-05-28 00:34:02 +05:30
Mike McQuaid
0b6ae538d1
Merge pull request #7545 from maxim-belkin/keep_ruby_path_set
utils/ruby.sh: search PATH for Ruby on Linux. update.sh: keep HOMEBREW_RUBY_PATH set.
2020-05-27 15:19:12 +01:00
Sean Molenaar
94df4a2e7b
Fix wording
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-05-27 12:36:37 +02:00
Mike McQuaid
d9dc809c9c
Merge pull request #7652 from gibfahn/cask_caveat_unsigned_accessibility
caveats: add an unsigned_accessibility caveat message
2020-05-27 10:01:27 +01:00
Mike McQuaid
0513771265 Merge pull request #7654 from Homebrew/dependabot/bundler/Library/Homebrew/parser-2.7.1.3
build(deps): bump parser from 2.7.1.2 to 2.7.1.3 in /Library/Homebrew
2020-05-27 09:59:27 +01:00
dependabot-preview[bot]
1d6ba1ef68
build(deps): bump parser from 2.7.1.2 to 2.7.1.3 in /Library/Homebrew
Bumps [parser](https://github.com/whitequark/parser) from 2.7.1.2 to 2.7.1.3.
- [Release notes](https://github.com/whitequark/parser/releases)
- [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/whitequark/parser/compare/v2.7.1.2...v2.7.1.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-27 05:41:14 +00:00
Gibson Fahnestock
3098c4735b
caveats: add an unsigned_accessibility caveat message
This is useful for applications that are not signed by the developer and
require Accessibility access.

Because the app is not signed, macOS only authorizes the current binary,
and so when it is updated (and the binary changes) the new version is
unsigned, despite the app still showing as ticked in System Preferences.
The user has to manually untick and retick the app each time.

The ideal fix is for the developer to sign their app, but not all
developers are willing to pay for this, so the best we can do is to
advise users of the workaround/solution.

Refs: https://github.com/Homebrew/homebrew-cask/pull/83157
2020-05-26 22:51:37 +01:00
Sean Molenaar
a715e28360
Clarify what entails a versioned formula 2020-05-26 20:27:39 +02:00
Sean Molenaar
bc882c6c28
Merge pull request #7427 from SMillerDev/cask/notability
Add notability checks for casks
2020-05-26 15:01:43 +02:00
Sean Molenaar
3567892802
Add notibility checks for casks 2020-05-26 14:21:25 +02:00
Mike McQuaid
8164e0804f
Merge pull request #7649 from sjackman/devcmdrun
Dockerfile: Unset gc.auto and homebrew.devcmdrun
2020-05-26 08:44:23 +01:00
Mike McQuaid
6d646cde99
Merge pull request #7648 from Homebrew/dependabot/bundler/docs/github-pages-206
build(deps-dev): bump github-pages from 204 to 206 in /docs
2020-05-26 08:36:34 +01:00
Shaun Jackman
1c0c6217e2 Dockerfile: Unset gc.auto and homebrew.devcmdrun 2020-05-25 17:29:58 -07:00
dependabot-preview[bot]
696332ee9c
build(deps-dev): bump github-pages from 204 to 206 in /docs
Bumps [github-pages](https://github.com/github/pages-gem) from 204 to 206.
- [Release notes](https://github.com/github/pages-gem/releases)
- [Commits](https://github.com/github/pages-gem/compare/v204...v206)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-25 23:01:06 +00:00
Mike McQuaid
1aee8679e5
Merge pull request #7646 from AprilArcus/csh-default-envvars
fix undefined variable interpolation in tcsh
2020-05-25 19:15:18 +01:00
April Arcus
0b4febceaf fix undefined variable interpolation in tcsh 2020-05-25 10:46:10 -07:00
Issy Long
a56c305f87
Merge pull request #7644 from issyl0/audit-fix-regex-parsing-for-git
audit: Fix Regexp for stripping `.git` from repo URLs
2020-05-25 13:23:37 +01:00
Issy Long
d14eed6cec
audit: Remove call to deprecated created_pr_comment method
```
➜ brew audit --online --new-formula --verbose turbogit
turbogit:
  * GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)
  * GitHub repository too new (<30 days old)
Error: undefined local variable or method `created_pr_comment' for Homebrew:Module
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:148:in `audit'
/usr/local/Homebrew/Library/Homebrew/brew.rb:110:in `<main>'
```

- This was removed in 4f75a77b089e65ff9e03c65d192808aa4ea6842f. We can't
  post PR comments from GitHub Actions CI from forks.
2020-05-25 13:00:38 +01:00
Issy Long
0cced8e7bd
audit: Fix Regexp for stripping .git from repo URLs
- [For a formula named
  turbogit](https://github.com/Homebrew/homebrew-core/pull/55208), we
  didn't see any of the notability checks fail CI.
- The repo name was getting truncated to `turb`, which didn't exist, so
  the audit didn't return anything for this check.
- The Regexp to strip `.git` from the end of was not escaping the `.`,
  so it would match anything ending in `git`, not a literal `.git`.
2020-05-25 12:48:16 +01:00
Mike McQuaid
b9b51421f4
Merge pull request #7625 from nandahkrishna/update-urls-cop
livecheck: modified urls cop
2020-05-25 08:12:11 +01:00
nandahkrishna
6f37dc4c41
livecheck: modified urls cop 2020-05-24 20:16:44 +05:30
Mike McQuaid
e6dda524de
Merge pull request #7638 from MikeMcQuaid/kill-argv
Remove HomebrewArgvExtension
2020-05-24 09:17:07 +01:00
Mike McQuaid
ef95b59ed4
Remove HomebrewArgvExtension
Fixes #5730
2020-05-23 19:39:11 +01:00
Michka Popoff
2e801c3077
Merge pull request #7640 from MikeMcQuaid/info-formula-missing
cmd/info: fix missing formula reference.
2020-05-23 19:09:33 +02:00
Mike McQuaid
fd343c0578
cmd/info: fix missing formula reference.
Fixes #7639
2020-05-23 16:32:39 +01:00
Mike McQuaid
a95dd7d485
Merge pull request #7637 from MikeMcQuaid/argv-debug
Remove ARGV.debug?
2020-05-23 16:31:59 +01:00
Mike McQuaid
bc27e38f18
Remove ARGV.debug?
Replace with `Homebrew.args.debug?`.

Part of #5730.
2020-05-23 14:38:58 +01:00
Mike McQuaid
e1f3c8d2b3
Merge pull request #7579 from MikeMcQuaid/deprecations
Update deprecations
2020-05-23 14:38:10 +01:00
Mike McQuaid
cd4d3b988e
Merge pull request #7636 from MikeMcQuaid/argv-env
Remove ARGV.env
2020-05-23 14:37:24 +01:00
Mike McQuaid
64602bc8ef
Merge branch 'master' into argv-env 2020-05-23 14:10:44 +01:00
Mike McQuaid
183670296f
Merge pull request #7493 from GauthamGoli/argv-cleanup-26
ARGV: Deprecate ARGV.cc and replace with Homebrew.args.cc
2020-05-23 14:10:20 +01:00
Mike McQuaid
4e67b212d7
Merge pull request #7635 from MikeMcQuaid/prelude-before-fetch
formula_installer: prelude before fetch.
2020-05-23 14:04:31 +01:00
Mike McQuaid
d5ff4f5327
Remove ARGV.env
Replace with `Homebrew.args.env`.

Part of #5730.
2020-05-23 13:49:38 +01:00
Mike McQuaid
e5d15c8b19
Merge branch 'master' into argv-cleanup-26 2020-05-23 13:44:42 +01:00
Mike McQuaid
11cf77be17
formula_installer: prelude before fetch.
This ensures that dependencies are verified and tapped before they are
fetched. `FormulaInstaller#lock` has been moved into
`FormulaInstaller#install` to avoid locking until necessary.

While we're here, don't compute dependencies before fetching if we're
not going to use them.
2020-05-23 13:40:13 +01:00
Mike McQuaid
e9d45a6692
Merge pull request #7634 from zmwangx/bump-formula-pr-fix-formula-guessing
bump-formula-pr: fix forking error when formula is guessed from url
2020-05-23 13:10:21 +01:00
Bo Anderson
d3f018de88
Merge pull request #7633 from Bo98/build-test-prune-fix
formula_installer: fix pruning of test deps also marked as build
2020-05-23 11:04:50 +01:00
Zhiming Wang
83fa24741e
bump-formula-pr: fix forking error when formula is guessed from url
Regression introduced in f90612ccf0db03681dc6cbf6585cca5bc27b84b1 (#6718).

`tap_full_name` returned from `use_correct_linux_tap` has been
required (`GitHub.create_fork(tap_full_name)`), but it was never set when the
formula is guessed from args.url, resulting in an API request to
https://api.github.com/repos//forks which 404s (note the missing :owner/:repo),
and subsequently

    Error: Unable to fork: Not Found!
2020-05-23 14:20:35 +08:00
Bo Anderson
6b06043289 formula_installer: fix pruning of test deps also marked as build 2020-05-23 00:05:20 +01:00
Shaun Jackman
9265ea0c50
Merge pull request #7631 from sjackman/docker-tag
docker.yml: Tag homebrew/brew:$brew_version
2020-05-22 12:13:01 -07:00
Shaun Jackman
3d3aef4076 docker.yml: Tag homebrew/brew:$brew_version 2020-05-22 11:46:42 -07:00
Mike McQuaid
3aabe66a79
Merge pull request #7629 from Homebrew/revert-7627-formulary_load_tap
Revert "formulary: install tap if needed."
2020-05-22 17:13:19 +01:00
Mike McQuaid
e10ade758d
Revert "formulary: install tap if needed." 2020-05-22 16:19:30 +01:00
Mike McQuaid
02733db7c7
Merge pull request #7627 from MikeMcQuaid/formulary_load_tap
formulary: install tap if needed.
2020-05-22 14:56:30 +01:00
Mike McQuaid
61b48d8557
formulary: install tap if needed.
This matches what `cask_loader` does and is low risk given we no longer
allow tap pinning.

Fixes #7626
2020-05-22 14:21:40 +01:00
Mike McQuaid
e4719cb6f3
Merge pull request #7622 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-performance-1.6.0
build(deps): bump rubocop-performance from 1.5.2 to 1.6.0 in /Library/Homebrew
2020-05-22 09:41:47 +01:00