admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
28,762 Commits 15 Branches 471 Tags
Commit Graph

314 Commits

Author SHA1 Message Date
Mike McQuaid
a6e4e195c1
rubocops/lines: recommend on_os/OS.os? based on context. 
Recommend the use of `on_macos` and `on_linux` unless we're in
`def install`, `def post_install` or `test do` in which case recommend
`OS.mac?` and `OS.linux?` instead.
 2021-09-08 13:18:07 +01:00
Mike McQuaid
227a96fd7f
rubocops/lines: remove OS.mac?/OS.linux? check. 
This will be reimplemented in https://github.com/Homebrew/brew/pull/11955
but this allows us to merge the homebrew-core changes before that PR is
merged.

Closes https://github.com/Homebrew/brew/pull/11946
 2021-09-02 13:50:23 +01:00
Nanda H Krishna
5ccfbcd1d2
Autocorrect style issues with brew style --fix 2021-07-08 12:36:39 +05:30
Mike McQuaid
321c165bd3
Merge pull request #11350 from Gcenx/audit-fix-xcode-build-check 
audit: Remove SYMROOT
 2021-05-13 13:50:40 +01:00
Dean M Greer
ceeb5ea9ec audit: Remove SYMROOT 
SYMROOT is only a valid argument when -project is used.

xcodebuild has other uses than building Xcode projects.
 2021-05-13 08:07:06 -04:00
Bo Anderson
e5285b5ed8
Add cop for IO.read usage 2021-05-12 13:07:24 +01:00
Bo Anderson
6e2f194e09
rubocops/shell_commands: add cop for shell metacharacters in exec 2021-05-10 16:30:00 +01:00
Rylan Polster
ae89577b26
style: re-enable GitLab patch URL check 2021-04-19 11:19:35 -04:00
Rylan Polster
b5dec5fdbd
style: temporarily disable GitLab patch URL check 2021-04-19 09:13:06 -04:00
Jonathan Chang
ef1e07b88b
rubocops/patches: GitLab patches should use .diff 
Only `.diff` URLs return output comparable to the diffs from
`git diff --full-index`. While the extra metadata from `.patch` is
nice, the instability of the patch contents is undesirable.

Co-Authored-By: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
 2021-04-19 09:08:14 -04:00
Bo Anderson
9063945b3e
Promote shell commands audit to global cop 2021-03-17 20:45:41 +00:00
Mike McQuaid
61427d6682
Merge pull request #10770 from SeekingMeaning/unless_logical_operators 
rubocops: use `Style/UnlessLogicalOperators`
 2021-03-05 11:45:42 +00:00
nandahkrishna
d68452f232
rubocops/patches: autocorrect some offenses 2021-03-04 12:36:18 +05:30
Seeker
7e7274aaeb rubocops: use Style/UnlessLogicalOperators 
Replaces `Style/UnlessMultipleConditions`
 2021-03-03 01:39:11 -08:00
Issy Long
e143dfdad6
Merge pull request #10658 from issyl0/rubocop-enable-rspec-context-wording 
rubocop: Enable RSpec/ContextWording cop & fix offenses
 2021-02-23 00:14:02 +00:00
Issy Long
38a427bf0d
test/option_declaration_spec: Align test description with contents 2021-02-20 00:04:05 +00:00
Issy Long
f194b5e983
test/bottle_format_spec: Align test description with contents 2021-02-20 00:03:47 +00:00
Issy Long
e1ad07190e
rubocop: Fix RSpec/ContextWording offenses 
- For some of these I changed `context` to `describe` as it fit better
  rather than contriving a "when", "with" or "without", or massively
  restructuring the tests.
 2021-02-19 23:30:41 +00:00
Rylan Polster
5f57601fd8
style: re-enable bottle order cop 2021-02-04 17:18:20 -05:00
Carlo Cabrera
2de172e050
rubocops/bottle: disable bottle order check 
This is causing CI failures at homebrew/core [1], so let's disable this
for now.

[1] 01b6830646
 2021-02-04 11:18:09 +00:00
Seeker
4c42d717fd
rubocops: add cops to check bottle format, indentation, and order 
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
Co-authored-by: Seeker <meaningseeking@protonmail.com>
 2021-02-03 20:46:20 -05:00
Rylan Polster
d5d7b6c3db
style: remove RSpec/MultipleDescribes violations 
Co-authored-by: Nanda H Krishna <nanda.harishankar@gmail.com>
 2021-02-01 20:30:51 -05:00
Rylan Polster
3e00b3ea28
style: remove RSpec/ExampleLength violations 2021-02-01 20:30:51 -05:00
Michka Popoff
38ae6e0c0d style: re-enable sha256 checks for bottle blocks 
Follow up PR to #10450
 2021-01-28 20:35:31 +01:00
EricFromCanada
a427de5bee capitalization fixes 
"curl" is the binary, while "cURL" is the umbrella project.
 2021-01-26 15:36:44 -05:00
Seeker
48e44870e6
Merge pull request #10334 from SeekingMeaning/rubocop-spec-descriptions 
rubocops/*: improve test descriptions
 2021-01-17 19:57:54 -08:00
Seeker
32ba87d254
Merge pull request #10332 from SeekingMeaning/text_spec-descriptions 
rubocops/text: improve test descriptions
 2021-01-17 19:57:23 -08:00
Seeker
8fa263bcb9 rubocops/text: add "in homebrew/core" to applicable tests 2021-01-15 08:41:47 -08:00
Seeker
7e75d8342b rubocops/urls: rename formulae to offense_list 2021-01-15 08:26:50 -08:00
Seeker
1d8372cbc8 rubocops/*: improve test descriptions 2021-01-14 19:06:37 -08:00
Seeker
3893cb312e rubocops/text: improve test descriptions 2021-01-14 18:08:05 -08:00
Seeker
33edb9f901 rubocops: point to offending OS-specific block in resource blocks 2021-01-13 23:18:32 -08:00
Jonathan Chang
641afdd2de rubocops: permit mirror in OS-specific resources 2021-01-14 17:04:40 +11:00
Jonathan Chang
ac8eb00443 rubocops/cask/*: use rubocop v1 API 2021-01-12 19:16:38 +11:00
Jonathan Chang
0366e2f7f7 rubocops/options: use rubocop v1 API 2021-01-12 19:16:38 +11:00
Jonathan Chang
23b8d0ccb8 rubocops/desc: use rubocop v1 API 2021-01-12 19:16:38 +11:00
Jonathan Chang
929e481dce rubocops/keg_only: use rubocop v1 API 2021-01-12 19:11:43 +11:00
Jonathan Chang
df8e030174 rubocops/patches: use rubocop v1 API 2021-01-12 19:11:43 +11:00
Jonathan Chang
bb497ebfe0 rubocops/caveats: use rubocop v1 API 2021-01-12 19:11:43 +11:00
Jonathan Chang
c3f797d9ac rubocops/components_order: use rubocop v1 API 2021-01-12 19:11:43 +11:00
Jonathan Chang
f57c96465c rubocops/conflicts: use rubocop v1 API 2021-01-12 19:11:43 +11:00
Jonathan Chang
92e07f5c0b rubocops/homepage: use rubocop v1 API 2021-01-12 19:11:43 +11:00
Jonathan Chang
63bebf542f rubocops/dependency_order: use rubocop v1 API 2021-01-12 19:11:43 +11:00
Jonathan Chang
098ade1319 rubocops/urls: use rubocop v1 API 2021-01-12 19:11:43 +11:00
Jonathan Chang
a778dc3bdb rubocops/class: use rubocop v1 API 2021-01-12 19:11:43 +11:00
Jonathan Chang
3bda457478 rubocops/text: use rubocop v1 API 2021-01-12 19:11:43 +11:00
Jonathan Chang
c18ffa84ca rubocops/deprecate_disable: use rubocop v1 API 2021-01-12 19:11:42 +11:00
Jonathan Chang
9046d778e0 rubocops/checksum: use rubocop v1 API 2021-01-12 19:11:42 +11:00
Jonathan Chang
b8fb568021 rubocops/lines: use rubocop v1 API 2021-01-12 19:11:42 +11:00
Seeker
2a80427755 unless_multiple_conditions: add autocorrect 2021-01-08 10:33:56 -08:00