34319 Commits

Author SHA1 Message Date
Mike McQuaid
98d9f28307
Merge pull request #14739 from issyl0/rubocop-disable-all-metrics
rubocop: Entirely disable `Metrics` cops
2023-02-21 09:16:28 +00:00
Mike McQuaid
f0fbeba2ef
Merge pull request #14723 from carlocab/zlib-mtime
utils/gzip: set `mtime = 1` when `mtime == 0`.
2023-02-21 09:04:55 +00:00
Mike McQuaid
11f94af0f2
docs: fix up more brew --prefix usage.
The new form used to be slow but both are now fast.
2023-02-21 08:57:12 +00:00
apainintheneck
0b3b54e75d api: respect --quiet 2023-02-20 23:23:42 -08:00
Jacob Ford
c70ce7a4bf Formula-Cookbook: correct HOMEBREW_NO_INSTALL_FROM_API value 2023-02-21 00:03:00 -05:00
Douglas Eichelberger
387d2f859f Use exclude_from_registry instead 2023-02-20 18:14:47 -08:00
Douglas Eichelberger
d9db5e8825 Refactor FormulaCop as a mixin 2023-02-20 18:14:47 -08:00
Jacob Ford
44a43f1a46 Formulae-Cookbook: update for Homebrew v4 2023-02-20 19:52:38 -05:00
Issy Long
0a6c59c0b3
dev-cmd/contributions: Less disgusting way to determine brew's NWO 2023-02-21 00:51:32 +00:00
Issy Long
298bb65dfb
rubocop: Entirely disable Metrics cops
- These are arbitrary length limits that had a load of disables in code.
- The limits were only increasing over time rather than decreasing.
- Fixing the problematic code to be shorter would take a long time for
  questionable gain since the problem has been around so long.
2023-02-21 00:34:17 +00:00
Nicholas (Nick) Meyer
5b80085837
Improve unversioned python location specification
brew --prefix python errors out when the python package is not
installed, so using that instead of brew --prefix prevents python
package installation issues from silently breaking, for example, shell
env scripts that add this to $PATH.

See https://github.com/orgs/Homebrew/discussions/3596#discussioncomment-5050569
2023-02-20 16:28:42 -08:00
Bo Anderson
7e48ed50f7
Merge pull request #14736 from aphedges/fix-bash-completion
Handle undeclared POSIXLY_CORRECT in Bash completions
2023-02-21 00:14:22 +00:00
Alex Hedges
5ed06a7956 Handle undeclared POSIXLY_CORRECT in Bash completions
As of `brew` 4.0.2, sourcing the Bash completions with `set -eu` causes a
failure if `POSIXLY_CORRECT` is not declared. The check will now
properly handle this situation.

I'm not sure if the resulting code is POSIX-compliant, but it prevents a
breaking change until a better solution can be found.
2023-02-20 18:36:59 -05:00
Issy Long
d3827b12f2
dev-cmd/contributions: Use GitHub APIs for commit author info
- Using `git log` was brittle with name changes and email address changes for
  contributors over the years unless we made a Git `mailmap` file which brings
  with it its own updatedness overhead.
- Let's use the GitHub commits API (importantly _not_ the search API) so that
  we can give it a username and it will return contributions associated with
  every email address on that user's account:
  https://docs.github.com/en/rest/commits/commits?apiVersion=2022-11-28#list-commits--parameters.
- This is quite significantly slower, but it's worth it for correctness
  especially when we get to all maintainers' contributions (in a separate PR).
- The commits API does not (yet?) support trailers or commit "committer"s, just
  authors.
2023-02-20 23:24:54 +00:00
Mike McQuaid
4eaaa867de
Merge pull request #14709 from issyl0/rubocop-tidying
rubocop: Some more config cleanup
2023-02-20 19:35:36 +00:00
Mike McQuaid
1f1a4775ea
Merge pull request #14734 from Homebrew/dependabot/bundler/Library/Homebrew/mime-types-data-3.2023.0218.1
build(deps): bump mime-types-data from 3.2022.0105 to 3.2023.0218.1 in /Library/Homebrew
2023-02-20 19:29:01 +00:00
BrewTestBot
63c1027b7a
Update RBI files for mime-types-data.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2023-02-20 19:13:10 +00:00
BrewTestBot
26039ed257
brew vendor-gems: commit updates. 2023-02-20 19:07:13 +00:00
dependabot[bot]
20784364aa
build(deps): bump mime-types-data in /Library/Homebrew
Bumps [mime-types-data](https://github.com/mime-types/mime-types-data) from 3.2022.0105 to 3.2023.0218.1.
- [Release notes](https://github.com/mime-types/mime-types-data/releases)
- [Changelog](https://github.com/mime-types/mime-types-data/blob/main/History.md)
- [Commits](https://github.com/mime-types/mime-types-data/compare/v3.2022.0105...v3.2023.0218.1)

---
updated-dependencies:
- dependency-name: mime-types-data
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-02-20 19:03:05 +00:00
Bo Anderson
ba6d87eed9
Merge pull request #14729 from Homebrew/revert-14711-extract-permissions
Revert "Fix permissions before moving extracted files."
4.0.3
2023-02-20 17:38:55 +00:00
Mike McQuaid
d292dbdc2b
Revert "Fix permissions before moving extracted files." 2023-02-20 17:20:57 +00:00
Mike McQuaid
ddd328ed7d
Merge pull request #14725 from Bo98/api-link_overwrite
Support `link_overwrite` and `conflicts_with` in API
2023-02-20 16:44:11 +00:00
Mike McQuaid
028487d7d9
Merge pull request #14727 from Homebrew/contributions-spaces
dev-cmd/contributions: fix spacing.
2023-02-20 16:32:29 +00:00
Bo Anderson
cacd7194f6
Support link_overwrite and conflicts_with in API 2023-02-20 16:28:07 +00:00
BrewTestBot
d1f6551909
Update manpage and completions.
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
2023-02-20 16:17:04 +00:00
Mike McQuaid
37b4780037
dev-cmd/contributions: fix spacing.
Otherwise this fails the documentation lint.
2023-02-20 16:16:08 +00:00
Carlo Cabrera
55c75618fc
utils/gzip: set mtime = 1 when mtime == 0.
This allows us to bottle formulae whose source modified time is indeed
`0`.

Needed for Homebrew/homebrew-core#123724.
2023-02-20 22:02:58 +08:00
Mike McQuaid
6b7ecd18e9
Merge pull request #14719 from MikeMcQuaid/no_api_root_url
formulary: use default bottle root_url.
4.0.2
2023-02-20 10:21:43 +00:00
Mike McQuaid
14a11f5c72
formulary: use default bottle root_url.
We never change this value in `formula.json` so ignore it for security.
2023-02-20 10:03:23 +00:00
Mike McQuaid
e51ee89a90
Merge pull request #14714 from EricFromCanada/linux-omit-home
docs: add missing template file edits
2023-02-20 09:56:04 +00:00
Mike McQuaid
7f1a0936e5
Merge pull request #14702 from issyl0/greedy-short-g
cmd/(outdated,upgrade): Document `-g` as a shorter `--greedy` for Casks
2023-02-20 09:54:18 +00:00
Mike McQuaid
315e10cbc4
Merge pull request #14712 from issyl0/contributions-primary-repos
dev-cmd/contributions: Add `--repositories=primary` to scan only `brew,core,cask`
2023-02-20 09:53:50 +00:00
Mike McQuaid
b9a291a82b
Merge pull request #14711 from reitermarkus/extract-permissions
Fix permissions before moving extracted files.
2023-02-20 09:52:40 +00:00
Mike McQuaid
aaec4014fd
Merge pull request #14710 from issyl0/rubocop-excludes
rubocop: Clean up some `Exclude`s
2023-02-20 09:51:11 +00:00
Mike McQuaid
3d3b20b6d6
Merge pull request #14675 from Bo98/api-bash
Further improvements to API handling in shell
2023-02-20 09:45:56 +00:00
Mike McQuaid
27cad91efb
Merge pull request #14705 from Homebrew/spdx-update
spdx: update license data.
2023-02-20 09:42:23 +00:00
Mike McQuaid
85f9bb8420
Merge pull request #14704 from dduugg/rubocop-cleanup
Remove redundant rubocop configs
2023-02-20 09:41:51 +00:00
Mike McQuaid
ae9763d9ce
Merge pull request #14684 from MikeMcQuaid/no_analytics_uuid
analytics: remove UUID.
2023-02-20 09:18:47 +00:00
Mike McQuaid
25bf83e58d
Merge pull request #14686 from MikeMcQuaid/build_from_source_warnings
Warn more when building from source
2023-02-20 09:06:09 +00:00
Mike McQuaid
57844530a9
analytics: remove UUID.
We don't use this at all with InfluxDB and don't need it any more for GA
so let's just remove it.
2023-02-20 09:05:15 +00:00
EricFromCanada
0d2b74d7e7
docs: add missing template file edits
plus extra instructions for completions file editing
2023-02-19 16:22:39 -05:00
Issy Long
04e476eb84
dev-cmd/contributions: Add --repositories=brew,core,cask shorthand
- For annual "has this person contributed enough", we focus on the main
  Homebrew repos: brew, core and cask. Let's make that easier than
  `--repositories=brew,core,cask`.
2023-02-19 18:36:13 +00:00
Markus Reiter
7c5b6fd10d
Add signatures for extraction methods. 2023-02-19 19:29:21 +01:00
Markus Reiter
eaca86b0a8
Fix permissions before moving extracted files. 2023-02-19 19:29:21 +01:00
Issy Long
18becae15a
rubocop: Clean up Lint/RequireRelativeSelfPath config
- The Actions logs link for the Homebrew/formula-analytics CI failure is long expired.
- I removed the excludes, ran `brew tap homebrew/formula-analytics` and then
  `brew style $(brew --repo homebrew/formula-analytics)` and there were no
  errors.
- Hence, I think we can clean this stanza up entirely.
2023-02-19 16:33:31 +00:00
Issy Long
f8654bd363
rubocop: In-line disables of Metrics/{Module,Block,Class}Length
- We're not going to make the really long things be any shorter any time soon.
- The instructions in issue 14685 say, pragmatically, "disable all the rubocop
  rules we're never going to realistically fix e.g. Metrics/ClassLength". But
  that felt like a slippery slope to more _really_ long modules/classes/blocks,
  and the limits are here for a reason.
2023-02-19 16:33:23 +00:00
Issy Long
60d9443d35
rubocop: Lint/NestedMethodDefinition excludes are not needed 2023-02-19 16:33:22 +00:00
Issy Long
4a8384e8a8
rubocop: In-line disables of Lint/ConstantDefinitionInBlock 2023-02-19 16:33:22 +00:00
Issy Long
6797f30bbf
rubocop: In-line disables of Naming/MemoizedInstanceVariableName 2023-02-19 16:33:21 +00:00
Issy Long
d84d157aaa
rubocop: Disable Bundler/GemFilename
- We have `gems.rb` and `Gemfile` and disabling the rule in `gems.rb` directly
  still errors?
2023-02-19 16:33:20 +00:00