22520 Commits

Author SHA1 Message Date
Issy Long
a56c305f87
Merge pull request #7644 from issyl0/audit-fix-regex-parsing-for-git
audit: Fix Regexp for stripping `.git` from repo URLs
2020-05-25 13:23:37 +01:00
Issy Long
d14eed6cec
audit: Remove call to deprecated created_pr_comment method
```
➜ brew audit --online --new-formula --verbose turbogit
turbogit:
  * GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)
  * GitHub repository too new (<30 days old)
Error: undefined local variable or method `created_pr_comment' for Homebrew:Module
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:148:in `audit'
/usr/local/Homebrew/Library/Homebrew/brew.rb:110:in `<main>'
```

- This was removed in 4f75a77b089e65ff9e03c65d192808aa4ea6842f. We can't
  post PR comments from GitHub Actions CI from forks.
2020-05-25 13:00:38 +01:00
Issy Long
0cced8e7bd
audit: Fix Regexp for stripping .git from repo URLs
- [For a formula named
  turbogit](https://github.com/Homebrew/homebrew-core/pull/55208), we
  didn't see any of the notability checks fail CI.
- The repo name was getting truncated to `turb`, which didn't exist, so
  the audit didn't return anything for this check.
- The Regexp to strip `.git` from the end of was not escaping the `.`,
  so it would match anything ending in `git`, not a literal `.git`.
2020-05-25 12:48:16 +01:00
Mike McQuaid
b9b51421f4
Merge pull request #7625 from nandahkrishna/update-urls-cop
livecheck: modified urls cop
2020-05-25 08:12:11 +01:00
nandahkrishna
6f37dc4c41
livecheck: modified urls cop 2020-05-24 20:16:44 +05:30
Mike McQuaid
e6dda524de
Merge pull request #7638 from MikeMcQuaid/kill-argv
Remove HomebrewArgvExtension
2020-05-24 09:17:07 +01:00
Mike McQuaid
ef95b59ed4
Remove HomebrewArgvExtension
Fixes #5730
2020-05-23 19:39:11 +01:00
Michka Popoff
2e801c3077
Merge pull request #7640 from MikeMcQuaid/info-formula-missing
cmd/info: fix missing formula reference.
2020-05-23 19:09:33 +02:00
Mike McQuaid
fd343c0578
cmd/info: fix missing formula reference.
Fixes #7639
2020-05-23 16:32:39 +01:00
Mike McQuaid
a95dd7d485
Merge pull request #7637 from MikeMcQuaid/argv-debug
Remove ARGV.debug?
2020-05-23 16:31:59 +01:00
Mike McQuaid
bc27e38f18
Remove ARGV.debug?
Replace with `Homebrew.args.debug?`.

Part of #5730.
2020-05-23 14:38:58 +01:00
Mike McQuaid
e1f3c8d2b3
Merge pull request #7579 from MikeMcQuaid/deprecations
Update deprecations
2020-05-23 14:38:10 +01:00
Mike McQuaid
cd4d3b988e
Merge pull request #7636 from MikeMcQuaid/argv-env
Remove ARGV.env
2020-05-23 14:37:24 +01:00
Mike McQuaid
64602bc8ef
Merge branch 'master' into argv-env 2020-05-23 14:10:44 +01:00
Mike McQuaid
183670296f
Merge pull request #7493 from GauthamGoli/argv-cleanup-26
ARGV: Deprecate ARGV.cc and replace with Homebrew.args.cc
2020-05-23 14:10:20 +01:00
Mike McQuaid
4e67b212d7
Merge pull request #7635 from MikeMcQuaid/prelude-before-fetch
formula_installer: prelude before fetch.
2020-05-23 14:04:31 +01:00
Mike McQuaid
d5ff4f5327
Remove ARGV.env
Replace with `Homebrew.args.env`.

Part of #5730.
2020-05-23 13:49:38 +01:00
Mike McQuaid
e5d15c8b19
Merge branch 'master' into argv-cleanup-26 2020-05-23 13:44:42 +01:00
Mike McQuaid
11cf77be17
formula_installer: prelude before fetch.
This ensures that dependencies are verified and tapped before they are
fetched. `FormulaInstaller#lock` has been moved into
`FormulaInstaller#install` to avoid locking until necessary.

While we're here, don't compute dependencies before fetching if we're
not going to use them.
2020-05-23 13:40:13 +01:00
Mike McQuaid
e9d45a6692
Merge pull request #7634 from zmwangx/bump-formula-pr-fix-formula-guessing
bump-formula-pr: fix forking error when formula is guessed from url
2020-05-23 13:10:21 +01:00
Bo Anderson
d3f018de88
Merge pull request #7633 from Bo98/build-test-prune-fix
formula_installer: fix pruning of test deps also marked as build
2020-05-23 11:04:50 +01:00
Zhiming Wang
83fa24741e
bump-formula-pr: fix forking error when formula is guessed from url
Regression introduced in f90612ccf0db03681dc6cbf6585cca5bc27b84b1 (#6718).

`tap_full_name` returned from `use_correct_linux_tap` has been
required (`GitHub.create_fork(tap_full_name)`), but it was never set when the
formula is guessed from args.url, resulting in an API request to
https://api.github.com/repos//forks which 404s (note the missing :owner/:repo),
and subsequently

    Error: Unable to fork: Not Found!
2020-05-23 14:20:35 +08:00
Bo Anderson
6b06043289 formula_installer: fix pruning of test deps also marked as build 2020-05-23 00:05:20 +01:00
Shaun Jackman
9265ea0c50
Merge pull request #7631 from sjackman/docker-tag
docker.yml: Tag homebrew/brew:$brew_version
2020-05-22 12:13:01 -07:00
Shaun Jackman
3d3aef4076 docker.yml: Tag homebrew/brew:$brew_version 2020-05-22 11:46:42 -07:00
Mike McQuaid
3aabe66a79
Merge pull request #7629 from Homebrew/revert-7627-formulary_load_tap
Revert "formulary: install tap if needed."
2020-05-22 17:13:19 +01:00
Mike McQuaid
e10ade758d
Revert "formulary: install tap if needed." 2020-05-22 16:19:30 +01:00
Mike McQuaid
02733db7c7
Merge pull request #7627 from MikeMcQuaid/formulary_load_tap
formulary: install tap if needed.
2020-05-22 14:56:30 +01:00
Mike McQuaid
61b48d8557
formulary: install tap if needed.
This matches what `cask_loader` does and is low risk given we no longer
allow tap pinning.

Fixes #7626
2020-05-22 14:21:40 +01:00
Mike McQuaid
e4719cb6f3
Merge pull request #7622 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-performance-1.6.0
build(deps): bump rubocop-performance from 1.5.2 to 1.6.0 in /Library/Homebrew
2020-05-22 09:41:47 +01:00
Mike McQuaid
527e7a7aa9
Merge pull request #7623 from kiendang/reinstall-completion
Update zsh completion
2020-05-22 08:52:53 +01:00
Mike McQuaid
ca47992a6c
Fix rubocop-performance brew style. 2020-05-22 08:52:26 +01:00
Mike McQuaid
d02b15d31a
brew vendor-gems: commit updates. 2020-05-22 08:30:19 +01:00
Kien Dang
e6c720c22c Update zsh completion 2020-05-22 15:21:51 +08:00
dependabot-preview[bot]
bab32515fa
build(deps): bump rubocop-performance in /Library/Homebrew
Bumps [rubocop-performance](https://github.com/rubocop-hq/rubocop-performance) from 1.5.2 to 1.6.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-performance/compare/v1.5.2...v1.6.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-22 05:34:28 +00:00
Maxim Belkin
5d3456f485
utils/ruby.sh: make code more readable
1. Repurpose 'vendor_ruby_current_version' variable:
   now this is not a pointer to a file but actual version number
2. Introduce 'vendor_ruby_latest_version' variable:
   it holds the value of the latest version of portable Ruby
2020-05-21 17:15:14 -05:00
Shaun Jackman
6545dcb3d6
Merge pull request #7617 from sjackman/docker
Base homebrew/brew Docker image on ubuntu:20.04
2020-05-21 15:00:22 -07:00
Maxim Belkin
db561eb7b9
utils/ruby.sh: setup-ruby: handle 'vendor-install' cmd early
Exit from the 'setup-ruby' function when user issued
`vendor-install` command.
We do so instead of wrapping everything in

```sh
if [[ "$HOMEBREW_COMMAND" != "vendor-install" ]]
```

`git diff` when whitespaces are ignored:

$ git diff -w
diff --git a/Library/Homebrew/utils/ruby.sh b/Library/Homebrew/utils/ruby.sh
index 7974e909c..4be204309 100644
--- a/Library/Homebrew/utils/ruby.sh
+++ b/Library/Homebrew/utils/ruby.sh
@@ -27,8 +27,11 @@ If there's no Homebrew Portable Ruby available for your processor:

   unset HOMEBREW_RUBY_PATH

-  if [[ "$HOMEBREW_COMMAND" != "vendor-install" ]]
+  if [[ "$HOMEBREW_COMMAND" == "vendor-install" ]]
   then
+    return 0
+  fi
+
   if [[ -x "$vendor_ruby_path" ]]
   then
     HOMEBREW_RUBY_PATH="$vendor_ruby_path"
@@ -85,7 +88,6 @@ If there's no Homebrew Portable Ruby available for your processor:
       HOMEBREW_RUBY_PATH="$vendor_ruby_path"
     fi
   fi
-  fi

   export HOMEBREW_RUBY_PATH
 }
2020-05-21 15:06:21 -05:00
Markus Reiter
a7a8569d70
Merge pull request #7607 from reitermarkus/cask-help-usage
Implement `brew cask help <command>`.
2020-05-21 21:02:02 +02:00
Rylan Polster
d0bd687a3d brew cask zap prompts when Full Disk Access is needed 2020-05-21 10:24:28 -04:00
Mike McQuaid
dee3903b57
Merge pull request #7621 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-0.84.0
build(deps): bump rubocop from 0.83.0 to 0.84.0 in /Library/Homebrew
2020-05-21 10:56:10 +01:00
Mike McQuaid
e33dc9e916
utils: brew style --fix. 2020-05-21 10:15:34 +01:00
Mike McQuaid
223762915f
gitignore: don't vendor rubocop-ast. 2020-05-21 10:14:57 +01:00
dependabot-preview[bot]
abd61f176e
build(deps): bump rubocop from 0.83.0 to 0.84.0 in /Library/Homebrew
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.83.0 to 0.84.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.83.0...v0.84.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-21 08:50:50 +00:00
Mike McQuaid
575055e36a
env_config_spec: remove unneeded BAT_CONFIG tests. 2020-05-21 08:41:18 +01:00
Mike McQuaid
bb44b71647
Merge pull request #7619 from mathaeus/migrate_vcs_scheme_checks_to_rubocop
audit: Migrate scheme checks for `cvs`, `bzr`, `hg`, `fossil` and `svn+http` to `Rubocop` + add tests
2020-05-21 08:22:13 +01:00
Shaun Jackman
0c8a7b0488 Base homebrew/brew Docker image on ubuntu:20.04
Add a new image homebrew/ubuntu16.04 for building Linux bottles.
Tag the most recent stable release of each image as latest.
2020-05-20 22:11:42 -07:00
Mathäus Zingerle
bb9665ced8 Migrate scheme checks for cvs, bzr, hg, fossil, and svn+http to Rubocop 2020-05-20 20:52:00 -05:00
Bo Anderson
dc0346a727
Merge pull request #7620 from Bo98/build-req-prune
formula_installer: fix build/test reqs not being pruned correctly
2020-05-21 00:16:39 +01:00
Bo Anderson
a3f589801f formula_installer: fix build/test reqs not being pruned correctly
Fixes #7618.
2020-05-20 23:39:30 +01:00