12215 Commits

Author SHA1 Message Date
Mike McQuaid
755be9a2ee Merge pull request #1659 from dersvenhesse/patch-1
XCode 8.2 is stable
2016-12-13 05:21:32 +00:00
Mike McQuaid
cf1fa0c5bc audit: flag use of "fails_with :llvm".
Also, add TODOs for deprecating this properly at a later point.
2016-12-13 02:10:11 +00:00
Mike McQuaid
8f80cc6568 diagnostic: check for bad tap files.
Check for Ruby files in taps that are outside of the detected `Formula`
directory for a tap but inside one of the other potential directories.

This usually indicates a formula has been added in the wrong directory
in a tap and is used to fail CI in this case.
2016-12-13 01:53:05 +00:00
Mike McQuaid
2e15f713a0 prune: don't remove top-level directories.
Even if they're empty we want to keep these top-level directories around
as the installer has nicely created them with the correct permissions
and this avoids potentially having to use `sudo` to recreate them.
2016-12-13 01:05:11 +00:00
Mike McQuaid
5efea992f0 Tweak issue template and contributing guidelines.
- Note issues may be closed without comment if sufficient information is
  not provided.
- Deprecate Homebrew/brew-evolution, note new feature request flow
- Note some issues should be created on Homebrew/brew
2016-12-13 00:49:57 +00:00
Mike McQuaid
961b5fff9d formula_installer: prevent version mismatched deps
Don't allow e.g. the use of `openssl` and `openssl@1.1` in the same
dependency tree to avoid runtime failures and general weirdness.
2016-12-13 00:37:40 +00:00
Mike McQuaid
950512ad34 diagnostic: check for multiple Cellars.
And tell people to delete the HOMEBREW_REPOSITORY one. The
HOMEBREW_PREFIX one is preferable for bottling.
2016-12-13 00:19:46 +00:00
Mike McQuaid
2b547583a3 postinstall: don't allow writes to prefix itself.
Only the top-level directories inside it. We don't want formulae writing
random junk in e.g. `/usr/local` even in `postinstall`.
2016-12-13 00:13:20 +00:00
dersvenhesse
b3174aa3e2 XCode 8.2 is stable 2016-12-12 23:29:35 +01:00
Mike McQuaid
666463ca2b Merge pull request #1592 from alyssais/runtime_dependencies
formula: runtime deps of build deps aren't runtime
2016-12-12 13:28:56 +00:00
Mike McQuaid
c317c3c31f Merge pull request #1616 from zachwhaley/zsh_functions_caveats
caveats: Differentiate zsh completion files and function files
2016-12-12 13:27:40 +00:00
Mike McQuaid
ebe45490b6 analytics: don't raise if tap doesn't exist. 2016-12-11 13:43:32 +00:00
Mike McQuaid
6a4af80b38 Merge pull request #1645 from broder/contribute_update
Made the pull request guide slightly less formula specific
2016-12-11 12:42:50 +00:00
Mike McQuaid
ef8afdf707 Merge pull request #1649 from MikeMcQuaid/prune-opt
keg: also prune opt.
2016-12-11 12:18:25 +00:00
Mike McQuaid
d085a47124 Merge pull request #1646 from MikeMcQuaid/report-deprecations-to-tap
Tell people to report URL/tap deprecations to the tap.
2016-12-11 12:17:49 +00:00
Mike McQuaid
11483d55c9 keg: also prune opt.
If there's dead symlinks in there they should be removed.
2016-12-11 11:55:07 +00:00
Uladzislau Shablinski
45ef7ea0b0 Merge pull request #1343 from vladshablinsky/explicit-specs
Allow to install any spec
2016-12-11 14:26:46 +03:00
Mike McQuaid
a3bacf1238 Merge pull request #1648 from MikeMcQuaid/remove-dependency-installer
formula_installer: remove dependency_installer.
2016-12-10 19:50:26 +00:00
Mike McQuaid
bf9da2532e formula_installer: remove dependency_installer.
This is no longer needed as the reason it was added (argument
sanitisation) is now done properly.

Also, remove `skip_deps_check?` in favour of `ignore_deps?` as it too is
no longer needed.
2016-12-10 19:21:17 +00:00
Mike McQuaid
7258557aea Merge pull request #1647 from MikeMcQuaid/fix-dependency-option-handling
Fix dependency option handling.
2016-12-10 18:20:59 +00:00
Mike McQuaid
51c31f4d51 Merge pull request #1642 from MikeMcQuaid/always-output-options
reinstall/upgrade/install: always output options.
2016-12-10 18:12:36 +00:00
Mike McQuaid
f7f15673a8 Fix dependency option handling.
- formula_installer: only recompute dependencies when necessary i.e.
when a bottle pour fails.
- formula_installer: re-add accidentally remove dependency options
- dependency: missing options are only those that actually exist on a
formula
2016-12-10 17:58:41 +00:00
David Broder-Rodgers
51e10315b7 Markup for PR guide 2016-12-10 14:25:35 +00:00
Mike McQuaid
a566540c46 Merge pull request #1641 from MikeMcQuaid/formulary-remap-options
formulary: remap deprecated options from keg.
2016-12-10 13:50:31 +00:00
Mike McQuaid
384174e542 which_all: don't assume path is a string.
Fixes #1635.
2016-12-10 13:19:01 +00:00
Mike McQuaid
e347f7ade3 reinstall/upgrade/install: always output options.
This is both easier for debugging and to communicate with users what is
being done.
2016-12-10 13:07:03 +00:00
Mike McQuaid
598c5e36f9 Tell people to report URL/tap deprecations to the tap.
Rather than Homebrew/brew or Homebrew/homebrew-core.
2016-12-10 13:04:14 +00:00
Mike McQuaid
8e2f0ccdc3 formulary: remap deprecated options from keg.
When reading a building a formula from a keg (rather than e.g. from
name) then the deprecation options were not remapped correctly as they
are only done in `Tab.for_formula` and not `Tab.for_keg`. Ensure that
after we’ve created the formula that the `used_options` are remapped
correctly.
2016-12-09 17:59:08 +00:00
Markus Reiter
f02491180b Merge pull request #1618 from rwanyoike/cask-reinstall-order
cask reinstall: download and verify cask before uninstall
2016-12-09 17:24:05 +01:00
Mike McQuaid
33b34b497c Merge pull request #1634 from strugee/patch-1
Point to GitHub Releases in CHANGELOG.md
2016-12-09 09:59:55 +00:00
David Broder-Rodgers
b83ffd53e3 Made the pull request guide slightly less formula specific 2016-12-08 22:22:38 +00:00
Alex Jordan
0b4a1ef0d4 Point to GitHub Releases in CHANGELOG.md
A lot of people (e.g. me in #1633) will look here and not find
anything. We should point them to the proper location.
2016-12-08 12:01:11 -08:00
Zach Whaley
14f46625a3 caveats: Differentiate zsh completion files and function files
When installing a file to zsh/site-functions directory, it is assumed this is a zsh completion file,
and the zsh completion caveat is printed after installation.

But not all files in the zsh/site-functions directory are completion files.
Some are files for functions that can be loaded on demand with zsh's autoload command.

- Edit Keg.completion_installed to search specifically for files in the zsh/site-functions
  directory starting with an underscore only (By convention, zsh completion files start with an underscore)
- Add Keg.zsh_functions_installed to search for non-completion files in the zsh/site-functions
- Add Caveats.zsh_function_caveats to print a caveat if non-completion files have been installed
  to zsh/site-functions
2016-12-08 07:23:26 -06:00
Zach Whaley
95688cd72e formula: Add convenience method for installing Zsh functions 2016-12-08 07:23:26 -06:00
Mike McQuaid
276d00938c Merge pull request #1615 from zachwhaley/fish_functions
Add a method for installing fish function files
2016-12-08 08:55:00 +00:00
Mike McQuaid
ba14f87825 Merge pull request #1630 from romellem/remove-mavericks-bottles-mention
os/mac: Remove mention of Mavericks bottles
2016-12-08 08:03:24 +00:00
romellem
25242fe4e9 Minimize line length 2016-12-07 16:34:52 -06:00
romellem
52aa4668d0 Generic language targeting macOS 2016-12-07 16:33:11 -06:00
Mike McQuaid
60b1be6795 Merge pull request #1629 from zmwangx/bump-formula-pr-download-to-correct-version
bump-formula-pr: use correct version in download path when --version is specified
2016-12-07 22:09:54 +00:00
Mike McQuaid
b4dd5146ed Merge pull request #1628 from zmwangx/make-boneyard-formula-pr-consistent-with-bump-formula-pr
boneyard-formula-pr: make it more consistent with bump-formula-pr
2016-12-07 22:09:05 +00:00
Mike McQuaid
0198bca567 Merge pull request #1614 from alyssais/tab_homebrew_version
tab: include HOMEBREW_VERSION
2016-12-07 21:57:50 +00:00
romellem
027a88cee0 Bottles are created for Yosemite and higher
After Issue #985 was merged, bottles for Mavericks are no longer
being built, meaning installations are triggering builds.

Update the FAQ to show that builds will most likely now be
triggers on Mavericks since their bottles are not being generated.
2016-12-06 18:02:52 -06:00
Zhiming Wang
417f27f40f
bump-formula-pr: use correct version in download
When a --version is specified, use this specified version in the name of
the downloaded file rather than the default that is parsed from the URL.
For instance,

  brew bump-formula-pr --devel \
    --url=http://www.zsh.org/pub/development/zsh-5.2-test-2.tar.gz \
    --version=5.2-test-2 zsh

should download to $HOMEBREW_CACHE/zsh-5.2-test-2.tar.gz (correct
behavior after this commit) rather than
$HOMEBREW_CACHE/zsh-2.tar.gz (wrong behavior before this commit).
2016-12-06 17:30:10 -05:00
Zhiming Wang
59f926cfd3
boneyard-formula-pr: checkout last branch when done
Make its behavior more consistent with that of bump-formula-pr.
2016-12-06 15:20:04 -05:00
Zhiming Wang
0fe532c242
boneyard-formula-pr: use ohai to print messages
Make its behavior more consistent with that of bump-formula-pr.
2016-12-06 15:19:51 -05:00
Mike McQuaid
11cf7b97c4 ISSUE_TEMPLATE: tweak based on recent issues. 2016-12-06 14:35:02 +00:00
Markus Reiter
049206bf16 Merge pull request #1464 from reitermarkus/quit-with-launchctl
Use `launchctl` to get running processes by bundle ID.
2016-12-06 15:08:21 +01:00
Mike McQuaid
29aa1c8c3d Merge pull request #1621 from MikeMcQuaid/xcode-version-cleanup
xcode: cleanup Xcode::Version usage.
2016-12-05 17:41:09 +00:00
Mike McQuaid
43f8d2c7a0 xcode: cleanup Xcode::Version usage.
Don't wrap `MacOS.version` which does comparisons properly already and
avoid stupidly long lines.
2016-12-05 11:09:21 +00:00
Raymond Wanyoike
0d67e35fb7 cask reinstall: use fetch and stage steps from #1620 2016-12-05 12:08:55 +03:00