admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
14,191 Commits 15 Branches 471 Tags
Commit Graph

113 Commits

Author SHA1 Message Date
Markus Reiter
175ca909ee Clean up code style and remove .rubocop_todo.yml. 2017-10-08 16:10:37 +02:00
Mike McQuaid
01e9ec9a9f Rubocop: automatic rule fixes. 2017-09-24 21:23:59 +01:00
ilovezfs
78a742c1ff Revert "Add check for HEAD ref in diagnostics" 2017-08-26 10:15:35 -07:00
ilovezfs
784a85f885 Revert "diagnostic: don't check CI core branch." 
This reverts commit cb5b14307ca4640e1ba68cfd28e7fef34a3b771b.
 2017-08-26 10:14:23 -07:00
ilovezfs
b1e0998f58 Revert "diagnostic: also don't check Jenkins core branch." 
This reverts commit db41f9d1182ff8c4c3b42b458e38d5c58b496ffb.
 2017-08-26 10:13:43 -07:00
Mike McQuaid
db41f9d118 diagnostic: also don't check Jenkins core branch. 2017-08-26 14:50:55 +01:00
Mike McQuaid
cb5b14307c diagnostic: don't check CI core branch. 2017-08-26 14:44:26 +01:00
Ben Muschol
7b31dd6062 Prefer if over unless, simplify messaging 2017-08-26 08:25:08 -04:00
Ben Muschol
b351c3f3ff Fix method name 2017-08-25 21:04:23 -04:00
Ben Muschol
abe47b79c8 Add check for HEAD ref in diagnostics 2017-08-25 20:25:58 -04:00
Mike McQuaid
bd06a7926c diagnostic: use ENV[] 2017-07-20 20:02:34 +01:00
Justin Baugh
0a9de6b8a6 Update source check to match style 2017-07-20 14:44:20 -04:00
Justin Baugh
e077bfe655 Address rubocop issues 2017-07-20 11:57:43 -04:00
Justin Baugh
7504d830cb Add warning to doctor if HOMEBREW_BUILD_FROM_SOURCE is set. 2017-07-20 11:08:53 -04:00
Wang Boyu
89d2cc00da diagnostic: Update whitelisted dylib used by Symantec (again) 2017-06-22 16:00:54 +08:00
Wang Boyu
803c5c3afe diagnostic: Update whitelisted dylib used by Symantec 2017-06-22 10:02:35 +08:00
Mike McQuaid
370eeed2e4 diagnostic: quiet some CI whining. 
We want to be able to symlink Homebrew/test-bot to Homebrew/core on
Linux for CI speed.
 2017-06-17 14:01:42 +01:00
Baptiste Fontaine
569180dfe5 diagnostic: Fix suggested git remote commands 2017-06-14 17:26:35 +02:00
Mike McQuaid
7a0aff1080 Autocorrect Rubocop Style/PerlBackrefs. 2017-06-10 20:23:20 +03:00
Markus Reiter
2d6ae61314 Re-revert "Fix operator spacing." 2017-06-02 19:22:05 +02:00
ilovezfs
197392b56d Revert "Fix operator spacing." 2017-06-01 04:06:40 -07:00
Markus Reiter
d34ba7395b Fix operator spacing. 2017-05-31 19:53:41 +02:00
Mike McQuaid
945cfc7cb7 diagnostic: move some more macOS doctor checks. 
Move some `brew doctor` checks that are pretty macOS specific so they
are only run on macOS.
 2017-05-27 13:34:59 +01:00
Markus Reiter
f0dc1d96c5 Merge pull request #2537 from reitermarkus/pathname-to_str 
Remove `to_s` from some `Pathname`s.
 2017-05-18 09:39:07 +02:00
Mike McQuaid
8205e61e64 More environment filtering tweaks 
- only document HOMEBREW_* variables in the manpage (although still
  read from all the original environment variables).
- resort manpage environment variables in alphabetical order
- check the original path for trailing slashes
 2017-05-13 11:42:01 +01:00
Markus Reiter
5828eefd01 Remove to_s from some Pathnames. 2017-05-08 13:37:28 +02:00
Markus Reiter
24f48ae7d9 Use PATH#select. 2017-04-30 21:11:28 +02:00
Markus Reiter
22f624b373 Make PATH enumerable. 2017-04-30 21:11:28 +02:00
Markus Reiter
f8ad9d7efd Use PATH where possible. 2017-04-30 21:11:27 +02:00
Mike McQuaid
11acadaa50 Merge pull request #2524 from MikeMcQuaid/more-env-filtering-fixes 
Hide sensitive tokens from install/test/post.
 2017-04-23 09:45:47 +01:00
Mike McQuaid
d02b4f321d Hide sensitive tokens from install/test/post. 
Hide these tokens to avoid malicious subprocesses e.g. sending them
over the network. Also, support using these tokens with environment
filtering and clear `HOMEBREW_PATH` from subprocesses to stop them
sniffing it. Finally, use `HOMEBREW_PATH` to detect Homebrew’s user’s
PATH for e.g. `brew doctor` etc.
 2017-04-22 16:31:19 +01:00
Mike McQuaid
ba3c46d24f More deprecations. 
Deprecate more methods. Internal APIs have been verified to be unused
elsewhere and removed. External APIs have had deprecation methods added.
Existing deprecations have been either upgraded to produce warnings or
no longer deprecated and the reasoning documented.
 2017-04-22 16:28:07 +01:00
Mike McQuaid
b757c927af diagnostic: also accept trailing / on git urls. 2017-03-28 19:44:30 +01:00
Mike McQuaid
46a91428f7 Merge pull request #2413 from JCount/increase-minimum-git-version 
diagnostic: increase minimum git version to 1.8.5
 2017-03-28 19:35:15 +01:00
JCount
08523d393f diagnostic: increase minimum git version to 1.8.5 
older versions do not support the 'git -C <path>' option
 2017-03-28 12:05:06 -04:00
Mike McQuaid
677db79c29 diagnostic: check homebrew/core git remote. 
Check the remote for homebrew/core as well as homebrew/brew as we've
seen a few cases (e.g. #2387) where it was misconfigured.

While we're here, tweak the messaging to tell people what to do and how
to do so with a single command.
 2017-03-26 20:28:11 +01:00
Viktor Szakats
cc8f029f22 secure urls + remove -k from in-doc curl command 2017-03-14 17:27:11 +00:00
Mike McQuaid
aaf70eb696 Merge pull request #1676 from MikeMcQuaid/doctor-tap-repo-bad-ruby-files 
diagnostic: check for bad tap files.
 2016-12-25 21:21:58 +00:00
Mike McQuaid
8f80cc6568 diagnostic: check for bad tap files. 
Check for Ruby files in taps that are outside of the detected `Formula`
directory for a tap but inside one of the other potential directories.

This usually indicates a formula has been added in the wrong directory
in a tap and is used to fail CI in this case.
 2016-12-13 01:53:05 +00:00
Mike McQuaid
950512ad34 diagnostic: check for multiple Cellars. 
And tell people to delete the HOMEBREW_REPOSITORY one. The
HOMEBREW_PREFIX one is preferable for bottling.
 2016-12-13 00:19:46 +00:00
Mike McQuaid
e330047ff9 diagnostic: silence a Jenkins doctor warning. 
Allow our Jenkins CI testing for Homebrew/brew to live outside of
`/usr/local` without complaint (as it's not using any binary packages
anyway).
 2016-11-26 16:32:48 +00:00
Mike McQuaid
771ae5c528 Revert "Merge pull request #1562 from woodruffw/check-admin-group" 
This reverts commit 7f13b37b903564e2a64cea982d6b84d1aa6b800b, reversing
changes made to 62e0ecdaafbc6779205908c7ab191c884473afd6.
 2016-11-25 16:44:33 +00:00
Mike McQuaid
64cb52ef3e Revert "Merge pull request #1567 from cesarandreu/fix-diagnostic-conditonal" 
This reverts commit 89c3348923c3450d8d32f1252abd53209b39c288, reversing
changes made to 7f13b37b903564e2a64cea982d6b84d1aa6b800b.
 2016-11-25 16:44:30 +00:00
Cesar Andreu
3b53418a2b Fix early exit condition for check_for_member_of_admin_group 2016-11-25 02:30:50 -08:00
William Woodruff
bb0e683bc4
diagnostic: check if the user is a member of the admin group. 
Non-administrative users are unable to run `brew linkapps` (and possibly other
commands) under normal circumstances.
 2016-11-24 12:26:50 -05:00
Markus Reiter
c648518f35 Rename single line block parameters to acc/elem. 2016-11-13 23:36:04 +01:00
Mike McQuaid
9edf8eb1fe Check the lock directory is writable. 
And, if it isn't, print more helpful debugging messages.

Fixes #1456.
 2016-11-11 22:52:21 +00:00
Mike McQuaid
2ce17a1137 Merge pull request #1082 from alyssais/uninstall_dependancy_error 
uninstall: refuse when dependents still installed
 2016-11-11 08:23:57 +00:00
Mike McQuaid
b8647778ee Merge remote-tracking branch 'origin/master' into HEAD 2016-11-06 17:58:24 +00:00
Mike McQuaid
262eaca56e diagnostic: add build error checks. 2016-11-05 10:58:39 -04:00