8450 Commits

Author SHA1 Message Date
Xu Cheng
deea4c82a4 fix brew tests
Fix the `brew tests` problem caused by core/formula separation.
2016-04-02 21:51:36 +08:00
Xu Cheng
2bb30fc5f0 --version/config: show core tap information 2016-04-02 21:51:36 +08:00
Xu Cheng
5bb8e8985d audit/test-bot/pull: fix for core/formula separation
All formulae are in taps now.
2016-04-02 21:51:36 +08:00
Xu Cheng
e9886cac6c descriptions: update for core/formula separation
Update the description update logic, since now all formulae are in the taps.
2016-04-02 21:51:36 +08:00
Xu Cheng
13141de0fd update-report: update for core/formula separation
Update the report logic, since now all formulae are in the taps.
2016-04-02 21:51:36 +08:00
Xu Cheng
56cb3325a6 remove migrate_taps
We don't need to migrate the tapped formulae from symlink-based to
directory-based structure any more.

Instead, we add core tap install check for `brew update-report` which
will be invoked by `brew update`.
2016-04-02 21:51:36 +08:00
Xu Cheng
a5cfc011e0 various: Homebrew/core is the core tap
Also make `Homebrew/homebrew` as an alias of this tap to keep
backward compatibility.
2016-04-02 21:51:36 +08:00
Xu Cheng
c5132daf63 introduce Homebrew/core tap as new default core tap.
It will be auto installed whenever necessary.
2016-04-02 21:51:36 +08:00
Xu Cheng
91fd357c90 Pathname: improve compute_disk_usage
* Count .DS_Store disk usage but not file count.
* Count symlink's own disk usage instead of ignoring it.
* Count hardlinks disk usage only once.
* Add testcase.

Closes Homebrew/homebrew#50563.

Closes Homebrew/homebrew#50566.

Signed-off-by: Xu Cheng <xucheng@me.com>
2016-04-01 16:30:14 +08:00
Xu Cheng
028d155e97 Pathname#version: only parse version from file basename
i.e. Ignoring the file's directory for version parsing.

Closes Homebrew/homebrew#50568.

Signed-off-by: Xu Cheng <xucheng@me.com>
2016-03-31 17:10:22 +08:00
ilovezfs
ebfd096826 superenv: refurbish --fast-math for :clang
"--fast-math" caused build failure with clang for
homebrew/science/delly-0.7.2

Apparently, clang only likes this option when it's referred to as
"-ffast-math"

Closes Homebrew/homebrew#50507.

Signed-off-by: ilovezfs <ilovezfs@icloud.com>
2016-03-31 17:10:22 +08:00
Xu Cheng
63c0a9fa92 Tap#install: set autocrlf to false
Ensure we don't munge line endings on checkout regardless with user's
global git config.

Closes Homebrew/homebrew#50514.

Signed-off-by: Xu Cheng <xucheng@me.com>
2016-03-31 14:49:01 +08:00
ilovezfs
3d3e874c68 More comments on SDK handling for >= Xcode 7
Closes Homebrew/homebrew#50537.

Signed-off-by: ilovezfs <ilovezfs@icloud.com>
2016-03-31 13:16:50 +08:00
ilovezfs
7651757709 OS::Mac::sdk: remove ensure block
Don't use ensure to do the final check because it won't affect the
return value of the overall function.

Thanks to @xucheng for catching this bug.

Closes Homebrew/homebrew#50536.

Signed-off-by: ilovezfs <ilovezfs@icloud.com>
2016-03-31 13:16:50 +08:00
ilovezfs
45e138ffc6 Xcode 7 MACOSX_DEPLOYMENT_TARGET and SDK fixes
SDK 10.10 isn't something that exists for Xcode 7, so stop looking for
it and rely on MACOSX_DEPLOYMENT_TARGET instead.

See PR Homebrew/homebrew#50137 Yosemite build failure

Closes Homebrew/homebrew#50355.

Signed-off-by: ilovezfs <ilovezfs@icloud.com>
2016-03-31 13:16:50 +08:00
ilovezfs
9bbaaca98c FormulaInstaller: rescue tap unavail for reqs too
Calling `compute_dependencies` will make sure both requirements and
dependencies are expanded, so that any referenced taps can be
auto-tapped. Prior to this commit only dependencies were expanded for
the sake of auto-tapping, so dependencies of requirements would cause
installation to fail whenever a tap unavailable exception was
encountered.

Closes Homebrew/homebrew#50271

Closes Homebrew/homebrew#50281.

Signed-off-by: ilovezfs <ilovezfs@icloud.com>
2016-03-29 16:19:37 +08:00
Christian Moritz
a87eb23a3b bump-formula-pr: fix typo in spec existence check
Closes Homebrew/homebrew#50472.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2016-03-28 18:22:47 +08:00
Mike McQuaid
6135da800e utils, gist-logs: improve/fix credential handling.
The API used (`Net::HTTP::Post`) does not handle basic authentication
credentials in the same way as `open` so fix both cases so they work.

Also, do some general usability tweaks to point out to people what could
be wrong with their tokens or credentials to help them debug.

Closes Homebrew/homebrew#50410.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2016-03-28 18:22:47 +08:00
Mike McQuaid
ca2abb2be6 bump-formula-pr: add new command.
Add a new developer command (i.e. requires `HOMEBREW_DEVELOPER` set in
your environment) to bump the version of a formula and create a new pull
request with the new version.

Closes Homebrew/homebrew#49848.
2016-03-28 18:22:47 +08:00
Misty De Meo
c757bd7c90 tap_constants: support lowercase caskroom in regex
Closes Homebrew/homebrew#50343.

Signed-off-by: Misty De Meo <mistydemeo@github.com>
2016-03-26 14:50:10 +08:00
Dominyk Tiller
81dc7316a6 ngrok: add to blacklist
Closes Homebrew/homebrew#50364.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2016-03-26 14:50:10 +08:00
Dominyk Tiller
ffc00f4836 ngrok: boneyard
ngrok 1.x has been sunset by upstream. It no longer functions for non-authenticated
users and as of April 4th will stop working entirely.

Upstream has also clarified there are no plans or intentions to make 2.x
open-source, which means we cannot carry that upgrade in core Homebrew, partially
for legal reasons.

If you wish to use the closed-source 2.x release you can still install it
via Homebrew in a couple of ways:

You can either `brew install homebrew/binary/ngrok2`
OR:
You can install it via the Caskroom, with `brew cask install ngrok`.

Closes Homebrew/homebrew#49432.
2016-03-26 14:50:10 +08:00
moofusecurity
b896629da4 connect 1.105 (migrate from boneyard)
connect is a utility that provides SOCKS and HTTPS proxy support to
SSH. I have created a new formula for version 1.104 that works
unlike the formula for 1.100 that is currently in the boneyard.

Closes Homebrew/homebrew#49716.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2016-03-26 14:50:10 +08:00
Xu Cheng
b8a4677de0 --repository: support to show tap path
This can become handy when we separate core code and formulae. For
example, we could use `cd $(brew --repo homebrew/core)` to go to core
tap path.

Closes Homebrew/homebrew#50346.

Signed-off-by: Xu Cheng <xucheng@me.com>
2016-03-24 14:52:13 +08:00
Xu Cheng
6e27e2db74 tap: cache dir path to avoid duplicated Pathname operations
As discovered in Homebrew/homebrew#50256, this becomes a performance bottleneck as we are
repeating construct same Pathname object.

At the same, this commit makes the behaviors between Tap and CoreTap more
consistence.
2016-03-23 15:01:28 +08:00
Xu Cheng
478f18a8f5 software_spec: add ExternalPatch to dependency_collector
Since we support `apply` DSL in the `patch` block, external
patch files could be any compressed archive. As result, it
could introduce dependencies like xz, 7z etc.

Add the resource of ExternalPatch to dependency_collector, so
we could track these resource dependencies.

Closes Homebrew/homebrew#50318.

Signed-off-by: Xu Cheng <xucheng@me.com>
2016-03-22 19:44:16 +08:00
Dominyk Tiller
ca5b7440c6 diagnostic: make chown recommendation consistent
This is the only place we advise `:admin` as well so might as well
change this one.

Closes Homebrew/homebrew#50279.

Closes Homebrew/homebrew#50295.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2016-03-22 18:55:19 +08:00
Dominyk Tiller
4f70064d73 test_diagnostic: update expected wording 2016-03-22 18:55:19 +08:00
Dominyk Tiller
142be05c0f diagnostic: trim unnecessary 'the' 2016-03-22 18:55:19 +08:00
Xu Cheng
99155c3b5f update: use git from ENV/scm/git
The idea is to let `scm/git` to handle all of git location resolution
throughout Homebrew codebase.

Closes Homebrew/homebrew#50116.

Signed-off-by: Xu Cheng <xucheng@me.com>
2016-03-21 19:07:38 +08:00
Xu Cheng
e0e277ecde utils/git: various improvement
* Use `ENV/scm/git` to check whether git is installed.
* Use `brew install git` to enforce pre-install checks such as sudo
  check.
2016-03-21 19:07:38 +08:00
Xu Cheng
8ca79a6df5 scm/git: handle no Xcode/CLT configuration
`/usr/bin/<tool>` will be a popup stub under such configuration.

The idea is to let `scm/git` to handle all of git location resolution
throughout Homebrew codebase.
2016-03-21 19:07:38 +08:00
Xu Cheng
ce7b32cec8 add HOMEBREW_ENV_PATH internal variable
`Library/ENV` like `Library/Homebrew` is part of Homebrew basecode. It
should be able to be accessed during the `brew tests`.

By adding HOMEBREW_ENV_PATH variable, we allow test suit to locate these
codes.
2016-03-21 19:07:38 +08:00
Xu Cheng
28b4923dad fix tests for deprecating SHA1
Closes Homebrew/homebrew#50272.

Signed-off-by: Xu Cheng <xucheng@me.com>
2016-03-20 14:55:58 +08:00
Xu Cheng
bd7e8543b3 deprecate SHA1 2016-03-20 14:55:58 +08:00
Xu Cheng
93cbab0021 Revert "brew fetch: only include sha256 in output"
This reverts commit 0b38f9b286bc61e2b2d2232f80ea8ebc5909fb07.
2016-03-20 14:55:58 +08:00
Tim D. Smith
8aaa95ee99 Add advice about keychain credentials
Fixes Homebrew/homebrew#50050. Closes Homebrew/homebrew#50059.
2016-03-20 14:55:58 +08:00
Sam McTaggart
148da47571 Improve error message for invalid regex to search
Fixes https://github.com/Homebrew/homebrew/issues/50131

This commit removes the error backtrace and improves the error message
if a bad regexp is passed to `brew search`.

Closes Homebrew/homebrew#50173.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
2016-03-19 19:14:50 +08:00
Tim D. Smith
af36139218 Document that Xcode.prefix can be nil 2016-03-19 19:14:50 +08:00
Tim D. Smith
fe37cc5271 Revert "Avoid constructing paths by string interpolation"
This reverts commit 8c7f3d859e8f715b6c63e4fe75e7a636aee4167f.
2016-03-19 19:14:50 +08:00
Tim D. Smith
87781f2a37 Avoid constructing paths by string interpolation
Closes Homebrew/homebrew#50154.
2016-03-19 19:14:50 +08:00
Tim D. Smith
f0a5abe12e More specific test for default prefix
cf. Homebrew/homebrew#50154
2016-03-19 19:14:50 +08:00
Tim D. Smith
f30c264519 Avoid pathological trailing slash
Resolves an issue where xcode-select output with a terminal slash leads
to superenv failing to strip system library paths from ccld-style
invocations.

Fixes Homebrew/homebrew#49731. Discussion in Homebrew/homebrew#50154.
2016-03-19 19:14:50 +08:00
ilovezfs
90774be2ee libodbc++: boneyard
Upstream has ignored the 64-bit patches from the original Homebrew pull
request, as well as subsequent 64-bit reports:
https://sourceforge.net/p/libodbcxx/bugs/25/

Trunk hasn't been updated since 2010 and the last tag was in 2009.

Closes Homebrew/homebrew#49980.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2016-03-19 19:14:50 +08:00
Xu Cheng
161a1e286e Revert "test-bot: better xml character filtering"
This reverts commit 7032591bd44a8f50aaa55574ac97cd5cb7261460 and
commit 946c6deb4b5168ad2ec15e62aa6e81181e9e246c.
2016-03-14 20:41:33 +08:00
Xu Cheng
60055ba890 test-bot: fix encoding caused by UTF-8 regex 2016-03-14 20:33:35 +08:00
Xu Cheng
a6b918d6c5 test-bot: better xml character filtering
Ref:
 - http://www.w3.org/TR/xml/#charsets
 - http://stackoverflow.com/a/14323524

Closes Homebrew/homebrew#50092.

Signed-off-by: Xu Cheng <xucheng@me.com>
2016-03-14 19:58:15 +08:00
Andrew Janke
a74e872409 brew fetch: only include sha256 in output
Closes Homebrew/homebrew#50067.

Signed-off-by: Andrew Janke <andrew@apjanke.net>
2016-03-14 19:39:15 +08:00
Baptiste Fontaine
236a18debe audit: fix crash when HOMEBREW_NO_GITHUB_API is set
Running brew audit --strict --online on a formula with a GitHub
homepage/url would crash if HOMEBREW_NO_GITHUB_API is set because
GitHub.repository returns `nil` and the audit code assumes it always
returns a hash.

Closes Homebrew/homebrew#50054.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2016-03-14 19:39:15 +08:00
ilovezfs
1e1184fc2d superenv: fix make_jobs regular expression
HOMEBREW_MAKE_JOBS can be a multidigit number. The regex should match
the entire number not just the last digit.

Closes Homebrew/homebrew#50016.

Signed-off-by: Tim D. Smith <git@tim-smith.us>
2016-03-13 14:32:05 +08:00