15827 Commits

Author SHA1 Message Date
Bruce Steedman
098974b2a1 @MikeMcQuaid requested changes 2016-11-12 12:03:04 +00:00
Mike McQuaid
215105a484 diagnostic: skip xcode-select check with no Xcode.
Skip the `xcode-select` configuration check if there's no CLT or Xcode
installed as in that case neither will be used.

Fixes #1055.
2016-11-12 11:32:27 +00:00
Mike McQuaid
c4519b030e Merge pull request #1480 from devkhan/patch-1
Typo: delet -> delete
2016-11-12 10:49:08 +00:00
Mike McQuaid
f184eba20b Merge pull request #1486 from MikeMcQuaid/lock_dir_permissions
Check the lock directory is writable.
2016-11-12 10:38:08 +00:00
Mike McQuaid
fe9ce9ffce Merge pull request #1485 from MikeMcQuaid/less-tap-migrate-warnings
formulary: don't warn on old formula name from keg/rack.
2016-11-12 10:38:03 +00:00
Markus Reiter
05acd4202b Merge pull request #1473 from umireon/umireon-fix-cask-tests
brew-cask tests never fail on BrewTestBot
2016-11-12 09:52:31 +01:00
Kaito Udagawa
1a4eb14b16 cask-tests: fix cask-tests always fail on the test failure
`brew cask-tests` collected the test results in an improper way so that it reports a false success in certain situations.
Specially, the session under BrewTestBot always reports success regardless of the test status.
With this update, the exit code of `brew cask-tests` is 1 when the test fails, and then CI preperly works.
2016-11-12 11:48:12 +09:00
Mike McQuaid
9edf8eb1fe Check the lock directory is writable.
And, if it isn't, print more helpful debugging messages.

Fixes #1456.
2016-11-11 22:52:21 +00:00
Mike McQuaid
b32fafa82c formulary: don't warn on old formula name from keg/rack.
If there’s an old installation of e.g. `apple-gcc42` from when it was
part of `homebrew/core` then the tab will say it was from the
`homebrew/core` tap and then we’ll complain at the user (see #1459 for
an example). Instead, we only want to complain when the user actually
types in `homebrew/core/apple-gcc42` into a `brew` command.

Closes #1459.
2016-11-11 16:42:29 +00:00
Mike McQuaid
0f6cd9d7a5 Merge pull request #1483 from MikeMcQuaid/uninstall-no-kegs-needed-force
uninstall: don't need kegs to exist for --force.
2016-11-11 13:56:05 +00:00
Mike McQuaid
4538d80db1 uninstall: don't need kegs to exist for --force.
Otherwise there's an error which is a regression on previous
functionality. This mirrors `rm -f` which doesn't fail if a file doesn't
exist.
2016-11-11 13:15:49 +00:00
Markus Reiter
8241bbb15b Merge pull request #1475 from reitermarkus/fix-locations
Fix `Hbc::Locations` in tests.
2016-11-11 13:43:38 +01:00
Markus Reiter
8fea516dcd Merge pull request #1481 from reitermarkus/sudo-askpass
Support `SUDO_ASKPASS` environment variable in `brew cask`.
2016-11-11 10:56:05 +01:00
Mike McQuaid
2ce17a1137 Merge pull request #1082 from alyssais/uninstall_dependancy_error
uninstall: refuse when dependents still installed
2016-11-11 08:23:57 +00:00
Markus Reiter
0b8a8cce28 Support SUDO_ASKPASS environment variable. 2016-11-11 00:30:05 +01:00
Misty De Meo
c7be025229 CompilerSelector: fix null check, tests 2016-11-10 15:09:36 -08:00
Misty De Meo
d8c19fd7d5 SystemConfig: fix version reporting 2016-11-10 15:09:36 -08:00
Misty De Meo
4e3d23ad14 Resource: set version to nil if version is null
Is this the right fix? This fixes version cascading from the parent.
2016-11-10 15:09:36 -08:00
Misty De Meo
d32a1c4c7d Version: add #to_f
This is used by things which used to compare against raw strings,
for example Xcode.uncached_version
2016-11-10 15:09:36 -08:00
Misty De Meo
20bbeb5e9c Return compiler versions and builds as Versions 2016-11-10 15:09:36 -08:00
Misty De Meo
16529a4de5 Version: allow coercing non-versions in comparisons
These are needed due to the raw string and fixnum comparisons which
exist for legacy reasons, for instance compiler version and build
comparisons.
2016-11-10 15:08:36 -08:00
Misty De Meo
b6acb9cb47 Version: allow comparing against nil 2016-11-10 15:08:36 -08:00
Misty De Meo
fbcf500a48 Version.parse: return Version::NULL for unparseable strings 2016-11-10 15:08:36 -08:00
Misty De Meo
9bac107b31 Add Version::NULL singleton 2016-11-10 15:08:36 -08:00
Devesh Khandelwal
9285282525 Repeated typo. 2016-11-11 04:04:50 +05:30
Devesh Khandelwal
feb34e54eb Typo: delet -> delete 2016-11-11 03:26:42 +05:30
Mike McQuaid
c2815fbb9a Merge pull request #1381 from adzenith/patch-1
`brew doctor` recommends using cask to upgrade XQuartz
2016-11-10 21:05:21 +00:00
Mike McQuaid
42aa0982f9 Merge pull request #1469 from woodruffw/ruby-macho-revendor
vendor: Update ruby-macho to 0.2.6.
2016-11-10 21:02:35 +00:00
Mike McQuaid
9889007099 Merge pull request #1466 from MikeMcQuaid/brew-rb-no-devcmdrun-fail
brew.rb: don't exit when failing to set devcmdrun.
2016-11-10 16:29:00 +00:00
Markus Reiter
9a9ab929ae Merge pull request #1476 from reitermarkus/rootless
Disallow running `brew cask` as `root`.
2016-11-10 15:57:53 +01:00
Markus Reiter
a0f9963391 Disallow running brew cask as root. 2016-11-10 15:01:29 +01:00
Markus Reiter
8dd8273d5e Remove unnecessary Hbc::Locations aliases. 2016-11-10 14:48:53 +01:00
Markus Reiter
0f673cc27f Ensure Hbc.caskroom in tests does not use legacy_caskroom. 2016-11-10 14:48:14 +01:00
Markus Reiter
842120ccf3 Merge pull request #1472 from umireon/umireon-fix-cask-reinstall-test
cask-test: fix reinstall a non installed Cask
2016-11-10 14:18:40 +01:00
Nikolaus Wittenstein
969ac3a9c6 brew doctor recommends using cask to upgrade XQuartz
Also changes exceptions.rb to use Formatter.url
2016-11-09 22:21:21 -05:00
Kaito Udagawa
ad1fa738ef cask-test: fix reinstall a non installed Cask
Trying to uninstall a non installed Cask made this test fail.
This commit remove that and thus this test passes.
Note that every Cask is uninstalled after each test case.
2016-11-10 08:04:11 +09:00
William Woodruff
9267511e6b
os/mac: Rename MachO -> MachOShim
Prevents namespace conflict with vendored ruby-macho.
2016-11-09 17:35:56 -05:00
William Woodruff
032ed07bce
os/mac: Allow MachO.dynamically_linked_libraries to be filtered by dylib type.
This allows us to filter out weak linkages during audits, preventing
a false error from occurring when the dylib cannot be found.
2016-11-09 17:35:56 -05:00
William Woodruff
7e09379669
vendor: Update ruby-macho to 0.2.6.
This brings fixes for behavior expected in #1460.
2016-11-09 17:35:56 -05:00
Vítor Galvão
f802c55c90 Merge pull request #1467 from Dorian/patch-1
Update the CaskAlreadyInstalledError with new reinstall command
2016-11-09 15:28:21 +00:00
Dorian
702d07917e Update the CaskAlreadyInstalledError with new reinstall command
e.g. this changes:

```
To re-install google-chrome, run:
  brew cask uninstall --force google-chrome && brew cask install google-chrome
```

To:

```
To re-install google-chrome, run:
  brew cask reinstall google-chrome
```
2016-11-09 15:08:12 +01:00
Mike McQuaid
007002ad6f brew.rb: don't exit when failing to set devcmdrun.
It's not necessary to make this a hard failure so don't (and this makes
it more consistent with `brew.sh`).

Fixes #1462.
2016-11-09 12:44:13 +00:00
Mike McQuaid
c091882246 Merge pull request #1465 from Homebrew/revert-1460-audit-ignore-weak-linkage
Revert "os/mac: MachO.dynamically_linked_libraries filtering."
2016-11-09 12:30:11 +00:00
Mike McQuaid
848c4461af Revert "os/mac: MachO.dynamically_linked_libraries filtering." 2016-11-09 12:29:58 +00:00
Mike McQuaid
1fb7d0fa57 Merge pull request #1460 from woodruffw/audit-ignore-weak-linkage
os/mac: MachO.dynamically_linked_libraries filtering.
2016-11-09 11:15:23 +00:00
Mike McQuaid
a7dc9e1aac Merge pull request #1463 from mistydemeo/test_tap_fix
Tap tests: sort tap names for comparison
2016-11-09 11:14:40 +00:00
William Woodruff
126c15d9ae
os/mac: Rename MachO -> MachOShim
Prevents namespace conflict with vendored ruby-macho.
2016-11-08 16:16:34 -05:00
Misty De Meo
9f03a0b255 Tap tests: sort tap names for comparison 2016-11-08 11:38:59 -08:00
William Woodruff
79b124b78d
os/mac: Allow MachO.dynamically_linked_libraries to be filtered by dylib type.
This allows us to filter out weak linkages during audits, preventing
a false error from occurring when the dylib cannot be found.
2016-11-08 09:45:56 -05:00
Mike McQuaid
42bb0f8c4d Merge pull request #1453 from ddbeck/revise-troubleshooting
Revise Troubleshooting.md
2016-11-08 08:45:07 +00:00