Mike McQuaid
fb310c57b1
sandbox: sandbox all taps by default.
...
We've been doing this in `brew test-bot`, for our CI and for
homebrew/core long enough that this is a reasonable default that
provides more protection to our users of non-homebrew/core taps.
2017-07-14 17:00:07 +01:00
Mike McQuaid
f08b518481
python_requirement: add libexec/bin to PATH.
...
This avoids having to fix formulae that use `python` to make them use
`python2`.
2017-07-14 16:58:14 +01:00
Mike McQuaid
20db5470e3
Merge pull request #2879 from GauthamGoli/audit_option_rubocop_1
...
audit: Port audit_options non-strict rules to rubocop and add tests
2017-07-14 15:32:52 +01:00
Mike McQuaid
4ca2efb12d
Merge pull request #2876 from VonUniGE/patch-1
...
Update documentation of brew install syntax to match its actual behav…
2017-07-13 21:22:55 +01:00
Mike McQuaid
7d443e6bfe
Merge pull request #2894 from MikeMcQuaid/integration-test-debugging
...
integration_test: try tests on Gem load failure.
2017-07-13 21:07:36 +01:00
Mike McQuaid
f7c254dc33
Merge pull request #2893 from MikeMcQuaid/unpin-bundler
...
tests: unpin bundler.
2017-07-13 17:54:00 +01:00
Mike McQuaid
8b63214c2e
integration_test: try tests on Gem load failure.
...
This should help with debugging `Gem::LoadError`s (e.g. for
https://github.com/Homebrew/homebrew-test-bot/pull/111 ).
2017-07-13 17:25:34 +01:00
Mike McQuaid
ec574c0e7f
tests: unpin bundler.
...
These issues were fixed by https://github.com/Homebrew/brew/pull/2872
and https://github.com/Homebrew/brew/pull/2823 .
2017-07-13 17:15:03 +01:00
Mike McQuaid
7c26dfee55
Merge pull request #2892 from MikeMcQuaid/homebrew-version-consistency
...
brew.sh: always use 7 chars for HOMEBREW_VERSION.
2017-07-13 10:41:03 +01:00
Mike McQuaid
5709002138
brew.sh: always use 7 chars for HOMEBREW_VERSION.
...
This avoids inconsistency based on Git versions.
2017-07-13 10:06:30 +01:00
Gautham Goli
222af82401
Read rubocop offenses as const from corresponding class in tests
2017-07-13 12:43:08 +05:30
Gautham Goli
b8adc1a8aa
audit: Port audit_options non-strict rules to rubocop and add tests
2017-07-13 12:41:43 +05:30
JCount
bff6af772f
Merge pull request #2887 from JCount/python_virtualenv_constants-15.1.0-update
...
python_virtualenv_constants: update virtualenv to 15.1.0
2017-07-12 21:57:24 -04:00
ilovezfs
0d03eef655
Revert "FileUtils.make: don't bypass superenv"
2017-07-12 02:58:01 -07:00
VonUniGE
7957e1a721
Add a suitable explanatory line
2017-07-11 23:43:28 +02:00
JCount
66f1b17942
python_virtualenv_constants: update virtualenv to 15.1.0
...
This release adds support for Python 3.6, the current python3
version in homebrew/core.
2017-07-11 14:20:49 -04:00
ilovezfs
6a5d24b53e
Merge pull request #2885 from DomT4/high_sierra_db3
...
High Sierra: updates for DB3 et al.
2017-07-11 09:54:54 -07:00
Dominyk Tiller
570dee5809
pkgconfig: update sqlite3 for 10.13
2017-07-11 16:20:37 +01:00
Dominyk Tiller
d0a2d1ba30
mac/xcode: update expected Clang on 10.13
2017-07-11 16:18:34 +01:00
Mike McQuaid
db08eff02e
Merge pull request #2858 from marinintim/update_to_upgrade
...
Call upgrade if something was passed to update
2017-07-11 15:56:10 +01:00
ilovezfs
53a677aba6
sandbox: allow write access to /dev/random
...
This avoids build failure for `root6`.
MacPorts currently avoids the failure with a patch, as their sandbox
doesn't yet allow write access to `/dev/random` either:
7792b2c565/science/root6/Portfile (L73-L75)
7792b2c565/science/root6/files/patch-disable-hsimple-macro.diff
The relevant code where `/dev/random` is opened with `O_WRONLY` is here:
15673deba5/interpreter/cling/lib/Utils/PlatformPosix.cpp (L63-L82)
2017-07-11 01:47:36 -07:00
Tim Marinin
156e19c6dc
Display "Use brew upgrade foo
instead" when calling update with args
...
So the user could just copy-paste the command.
2017-07-10 12:30:58 +03:00
Mike McQuaid
287ba7a6af
Merge pull request #2872 from MikeMcQuaid/fix-high-sierra-tests
...
Fix `brew tests` on High Sierra.
2017-07-10 08:18:17 +01:00
Mike McQuaid
cabb7e898a
integration_test: add simplecov libs when needed.
...
Don't add these unconditionally or with Bundler to speed things up a
bit. Also, to speed things up further cache these arguments so we don't
have to do the same generation every time.
2017-07-10 07:51:04 +01:00
Markus Reiter
4e26fdfcf6
Add test for non-TTY brew cask search
.
2017-07-10 00:09:32 +02:00
Mike McQuaid
eb02612393
Merge pull request #2877 from mistydemeo/fix_fileutils_make
...
FileUtils.make: don't bypass superenv
2017-07-09 21:10:40 +01:00
Mike McQuaid
f1fa475c4f
Merge pull request #2843 from GauthamGoli/audit_conflicts_rubocop
...
audit: Port audit_conflicts method to rubocop and add tests
2017-07-08 07:44:16 +01:00
Mike McQuaid
ded1967c6c
Merge pull request #2871 from MikeMcQuaid/rspec-focus
...
spec_helper: add focus support.
2017-07-08 07:44:00 +01:00
Misty De Meo
2aefd7eed6
FileUtils.make: don't bypass superenv
2017-07-07 16:23:46 -07:00
Markus Reiter
dccdac55a8
Add helper for testing TTY output.
2017-07-08 00:57:08 +02:00
VonUniGE
16496a0b0f
Update documentation of brew install syntax to match its actual behavior.
2017-07-08 00:22:18 +02:00
Markus Reiter
d29cb450f7
Output plain list when running brew cask search
without a TTY.
2017-07-07 19:42:03 +02:00
Mike McQuaid
0b69ca85f7
spec_helper: add focus support.
...
When adding `, :focus` as a trailing argument to a `describe` or `it`
this allows you to only run that single test.
2017-07-07 16:34:29 +01:00
Markus Reiter
8ec08479ae
Merge pull request #2865 from reitermarkus/cleanup-directories
...
Also remove directories with `brew cask cleanup`.
2017-07-07 17:25:02 +02:00
Gautham Goli
4ed34f91c2
audit: Port audit_conflicts method to rubocop and add tests
2017-07-07 20:46:57 +05:30
Mike McQuaid
0740855f81
Merge pull request #2870 from MikeMcQuaid/node-cleanup
...
language/node: general cleanup.
2017-07-07 15:59:35 +01:00
Mike McQuaid
81dbc29566
Merge pull request #2853 from GauthamGoli/disable-strict-cops-brew-style
...
style: Don't run FormulaAuditStrict cops when `brew style foo` cmd is executed
2017-07-07 15:43:55 +01:00
Mike McQuaid
cb3a47d9e2
Fix brew tests
on High Sierra.
...
The `brew test` tests were failing as they were unable to include
`test/unit/assertions`. This is because it's a gem and we were setting
the `GEM_HOME` so system gems were being ignored.
While I was there and examining the `$LOAD_PATH`: reduce the number of
things we add there by using `Bundler.with_clean_env` and only adding
`HOMEBREW_LIBRARY_PATH` in the `$LOAD_PATH` if it isn't already there
(which it always is [and has to be] for integration tests).
This also seems to have the side effect of speeding up integration
tests from 1m26s to 1m8s on my machine.
2017-07-07 15:20:19 +01:00
Mike McQuaid
9f6762d958
language/node: general cleanup.
...
- Avoid using a temporary variable where not necessary
- Use fewer, better stubs in the tests to avoid warnings and better
test the implemented functionality.
2017-07-07 15:11:41 +01:00
Mike McQuaid
1406f89ac5
Merge pull request #2863 from mistydemeo/formula_keg_only_boolean
...
Formula#keg_only should be a boolean
2017-07-07 10:14:32 +01:00
Mike McQuaid
ddb1fd7981
Merge pull request #2841 from mistydemeo/formula_assertions_constant
...
Define a custom assertion failure error for cross-version compat
2017-07-07 10:14:21 +01:00
Mike McQuaid
5c2fa1fc1f
test: use Test::Unit class.
2017-07-07 09:44:02 +01:00
Mike McQuaid
7aaa7e1b79
formula_assertions: make removable on Ruby 2.0.
2017-07-07 09:43:39 +01:00
Mike McQuaid
bddafe4d54
audit: don't suggest non-stable versioned alias.
...
Additionally handle the case where a formula has been installed as
devel/HEAD rather than just e.g. `brew audit --devel`.
2017-07-07 09:30:18 +01:00
Mike McQuaid
fa031f5045
formula: tweak keg_only? formatting.
2017-07-07 09:23:31 +01:00
Mike McQuaid
d9e0a0bce6
rubocop.yml: remove doublenegation disable.
2017-07-07 09:22:39 +01:00
Markus Reiter
0217fb5d9d
Also remove directories with brew cask cleanup
.
2017-07-06 20:59:35 +02:00
Mike McQuaid
ae33f5c79c
Merge pull request #2859 from jonchang/fix-sse3-linux
...
cpu: fix SSE3 detection on Linux
2017-07-06 08:28:20 +01:00
Misty De Meo
5adca2e33d
Disable Style/DoubleNegation cop
...
As discussed in bbatsov/rubocop#3344 , there are situations where
this is the shortest and most idiomatic way to convert a value
to a boolean - particularly for checking values which can be
nil or truthy.
2017-07-05 17:51:57 -07:00
Misty De Meo
a79dc3e65b
Formula#keg_only should be a boolean
2017-07-05 16:34:59 -07:00