13054 Commits

Author SHA1 Message Date
Martin Schimandl
5eab54f892 Reduce verbosity of artifacts hash 2017-11-10 20:16:38 +01:00
Martin Schimandl
52343142a7 Remove unused variables. Refactor code 2017-11-10 20:16:38 +01:00
Martin Schimandl
d03720320a adapt internal_stanza command to work with SortedSet of Artifacts 2017-11-10 20:16:38 +01:00
Martin Schimandl
587c5b07b3 Fix handling of artifact set 2017-11-10 20:16:38 +01:00
Martin Schimandl
255e991cc3 Remove obsolete code to fix tests. 2017-11-10 20:16:38 +01:00
Martin Schimandl
db2c86204b internal_stanza.rb: Remove obsolete code. Improve detection of missing stanzas
internal_stanza_spec.rb: change do ... end blocks to { } blocks
2017-11-10 20:16:38 +01:00
Martin Schimandl
7f70080c94 Add another test to increase coverage. 2017-11-10 20:16:38 +01:00
Martin Schimandl
dfe4e7641a combine errors to a single if-statement. fix spec test 2017-11-10 20:16:38 +01:00
Martin Schimandl
99b7636008 Fix 'brew style' issues 2017-11-10 20:16:38 +01:00
Martin Schimandl
ff2239509d Change behaviour of 'cask _stanza' command. Add tests for 'cask _stanza' command 2017-11-10 20:16:38 +01:00
Martin Schimandl
be68f3d7b4 Fix 'brew style' offenses 2017-11-10 20:16:38 +01:00
Martin Schimandl
b7a51eab6b improve 'brew cask _stanza' by checking for known stanzas 2017-11-10 20:16:38 +01:00
Mike McQuaid
441c212f2d
Merge pull request #3416 from zmwangx/bump-formula-pr-fix-message
bump-formula-pr: --message: add newlines before and after hr
2017-11-10 17:53:10 +00:00
Mike McQuaid
ee4172159b
Merge pull request #3377 from maxim-belkin/extend-pathname
pathname: new methods and improvements
2017-11-10 17:49:27 +00:00
Markus Reiter
5318907d93
Merge pull request #3432 from reitermarkus/delegate-class
Refactor `DependsOn` with `DelegateClass`.
2017-11-10 18:29:28 +01:00
L. E. Segovia
72e673afae Fix reinstall/uninstall tests 2017-11-10 11:33:44 -03:00
Mike McQuaid
4d4722c97c Remove more uses of EOS.undent. 2017-11-10 14:22:39 +00:00
Mike McQuaid
219f9691ef
Merge pull request #3292 from claui/add-audit-test-cases
Add tests for `FormulaAuditor#audit_deps`
2017-11-10 13:34:56 +00:00
L. E. Segovia
522a229dbb Fix upgrade tests and some upgrade? leftovers 2017-11-08 08:33:33 -03:00
Maxim Belkin
de0b93f912
pathname: improvements, cleanups, and new methods
- atomic_write: close file before renaming to prevent error:
  'Device or resource busy'
- ensure_writable: preserve executable bit
- new elf? and dynamic? methods
2017-11-07 14:18:25 -06:00
Mike McQuaid
ccf933f31c
Merge pull request #3435 from MikeMcQuaid/auto-update-checked
Use HOMEBREW_AUTO_UPDATE_CHECKED variable.
2017-11-07 08:26:19 +00:00
Mike McQuaid
3ad4dcafd7
Merge pull request #3427 from MikeMcQuaid/bump-formula-pr-env-filtering-github
bump-formula-pr: use GitHub vars under env filter.
2017-11-07 08:12:53 +00:00
Mike McQuaid
b96ded7ca4
Merge pull request #3430 from commitay/hash-order
brew list 'filtered_list': pass explicit sort to handle APFS
2017-11-07 08:03:48 +00:00
Mike McQuaid
5f301755c0 Use HOMEBREW_AUTO_UPDATE_CHECKED variable.
Rather than reusing `HOMEBREW_NO_AUTO_UPDATE` to indicate that we've
already made a check. This allows `HOMEBREW_NO_AUTO_UPDATE` to be
displayed properly by `brew config`.
2017-11-07 08:01:51 +00:00
Mike McQuaid
127bdfdc71 bump-formula-pr: use HOMEBREW_BROWSER. 2017-11-07 07:54:34 +00:00
Mike McQuaid
9358f678a3 Clear/mask passwords as well as tokens. 2017-11-07 07:54:34 +00:00
Mike McQuaid
3f8f2c6726 bump-formula-pr: use GitHub vars under env filter.
Ensure that the various variables are passed through and reset
correctly. If we end up doing this in a bunch of places we may add some
helpers to simplify this.
2017-11-07 07:54:34 +00:00
Mike McQuaid
2ad1799308 os/mac/diagnostic: fix XQuartz message.
Fixes #3434.
2017-11-07 07:39:10 +00:00
ilovezfs
4cc72cf3be
Merge pull request #3409 from DomT4/xcode
Xcode 9.1 Updates.
2017-11-06 23:22:50 -08:00
commitay
ac799d9f2d brew list --pinned: pass explicit sort to handle APFS 2017-11-07 12:35:40 +10:00
L. E. Segovia
94d266e2d6 Rework uninstallation step
Now the artifacts get re-staged, and upon an uninstall/finalize_upgrade
they are deleted by purge_versioned_files instead
2017-11-06 21:27:02 -03:00
L. E. Segovia
84c128411f Fix style issues 2017-11-06 18:33:29 -03:00
Markus Reiter
bd0b763292 Refactor DependsOn with DelegateClass. 2017-11-06 21:13:39 +01:00
commitay
ccecdab4cd brew list --versions: pass explicit sort to handle APFS 2017-11-06 20:27:23 +10:00
Mike McQuaid
e300713f25 xcode: check Xcode installed before using version.
This avoids infinite recursion described in:
https://github.com/Homebrew/brew/pull/3422#issuecomment-342001451
2017-11-05 20:22:01 +00:00
Mike McQuaid
ffe523a7a8
Merge pull request #3422 from MikeMcQuaid/null-versions
mac/xcode: compare with existing Version class.
2017-11-05 19:11:50 +00:00
Mike McQuaid
bef4213ffc
Merge pull request #3423 from MikeMcQuaid/commands-refactoring-fix
Refactor command handling code
2017-11-05 16:09:20 +00:00
Mike McQuaid
195f77abb0 MACOS_*VERSION: move to compat. 2017-11-05 15:40:46 +00:00
Mike McQuaid
603d6fd1f5 ENV/super: simplify version checks. 2017-11-05 15:39:43 +00:00
Mike McQuaid
8c6defd9cf diagnostic: simplify version checks. 2017-11-05 15:39:43 +00:00
Mike McQuaid
b69d71edea system_config: handle new non-string Xcode version 2017-11-05 15:39:43 +00:00
Mike McQuaid
77e3e7e4d9 version: support to_i.
This is needed for existing MacOS::Xcode.version calls that relied on
this returning a string. It mirrors similar behaviour for to_f.
2017-11-05 15:39:43 +00:00
Mike McQuaid
389188ac4f mac/xquartz: compare with existing Version class. 2017-11-05 15:39:43 +00:00
Mike McQuaid
600d58f4ca mac/xcode: compare with existing Version class.
Additionally, return null versions when it makes sense to do so. This
means that comparisons on the Xcode/CLT version do not need to be
guarded on whether Xcode/CLT is installed.
2017-11-05 15:39:43 +00:00
Mike McQuaid
7a68b4a3f9 Refactor command handling code
Don’t rely on having external commands always present in the PATH in
order to find them. Instead, provide an accessory method to Tap so
they can be added and used when needed.

While we’re here, do some general refactoring and cleanup of the
command code in these places.
2017-11-05 15:37:57 +00:00
Mike McQuaid
5bf0584308
Merge pull request #3420 from MikeMcQuaid/config-env-output
system_config: output most HOMEBREW_* variables.
2017-11-05 15:36:06 +00:00
Mike McQuaid
4892465fc4 system_config: output most HOMEBREW_* variables.
Exclude the boring ones and exclude some that are already printed that
are just using their default values. HOMEBREW_PREFIX is the only one
where we’re always interested in the output to quickly communicate it.
2017-11-05 14:45:36 +00:00
Mike McQuaid
1b69848119 system_config: output curl path and version. 2017-11-05 14:45:36 +00:00
Mike McQuaid
b369593cbd utils: correctly handle empty user gem env. 2017-11-05 14:45:36 +00:00
Mike McQuaid
f999a57620 brew.sh: cleanup some environment pollution. 2017-11-05 14:45:36 +00:00