794 Commits

Author SHA1 Message Date
Timothee Cour
ae829ed229 add brew where command 2017-02-11 16:38:06 -08:00
Markus Reiter
c4ac308302 Allow brew tests to run specs. 2017-02-11 15:59:54 +01:00
Mike McQuaid
1413cd15ba Merge pull request #1958 from maveonair/tests-cli-help
Fix: Documentation of --only in tests cmd
2017-02-10 14:56:16 +00:00
Viktor Szakats
03253a8d8b audit: enforce https://*.sourceforge.io/ homepages
Ref: https://sourceforge.net/blog/introducing-https-for-project-websites/
2017-02-10 14:53:32 +00:00
Markus Reiter
2d05c9d80c Merge pull request #1961 from vszakats/githuburl
audit: enforce https for github.com urls
2017-02-09 06:24:56 +01:00
ilovezfs
79280826f5 pull: fix false positives for nonstandard bump subjects when untapped
If the formula's tap isn't tapped yet when running `brew pull`, a false
positive occurs for the nonstandard bump subject check, and a bogus
warning is printed, which claims the bump subject should refer to the
old version not the new version.
2017-02-08 00:58:20 -08:00
Viktor Szakats
11ebfdafb2 audit: enforce https for github.com urls 2017-02-07 00:19:58 +00:00
Fabian Mettler
ba2ec8abcc Fix: Documentation of --only in tests cmd
This pull request fixes the documentation for the —only flag of the
tests cmd.
2017-02-06 14:22:17 +01:00
Gautham Goli
1f5cf4fd40 Update docs and manpages to include --fix option 2017-02-06 12:46:26 +05:30
David Broder-Rodgers
64c83f3286 Use file checksum rather than file diffing 2017-02-02 21:25:29 +00:00
David Broder-Rodgers
d4aa98d230 Updated mirror checks to compare ETags, Content-Lengths and binary files 2017-01-30 21:49:42 +00:00
David Broder-Rodgers
13a3a57fa8 Merge remote-tracking branch 'origin/master' into insecure_audit 2017-01-30 18:31:52 +00:00
Mike McQuaid
eff70115b5 pull: better handle missing bottles.
If we make a PR in which we're building many formulae (e.g.
https://github.com/Homebrew/homebrew-core/pull/9249) then we may want
to pull those that built and publish their bottles and discard those
that did not. Instead of saying bottles will be published when they
won't and then blowing up just avoid publishing them and print a warning
instead.
2017-01-27 09:36:47 +00:00
Mike McQuaid
34e03532a0 audit: improve homepage audit reliability.
Try first with an (exact, actual) browser user agent from Safari and
then try again with the default Homebrew `curl` user agent.
2017-01-26 16:19:38 +00:00
Mike McQuaid
9293ca2cef Merge pull request #1901 from alyssais/patch-1
man: remove an unnecessary `else`
2017-01-25 09:35:17 +00:00
Mike McQuaid
da54f39556 Merge pull request #1877 from ilovezfs/audit-wine-deps-exemption
audit: exempt wine's deps from the universal deprecation
2017-01-23 21:17:00 +00:00
Alyssa Ross
4291476fa3 man: remove an unnecessary else
`odie` causes the process to exit immediately, so there's no need for the
`regenerate_man_pages` call to be conditional.
2017-01-23 21:16:49 +00:00
Alyssa Ross
2c1fbe1693 Merge pull request #1890 from alyssais/global_teardown_env
tests: automatically restore ENV in teardown
2017-01-23 17:54:31 +00:00
Alyssa Ross
19e61355b3 tests: remove with_git_env method
A common git environment is now used in all tests, so this is no longer
required.
2017-01-22 20:54:37 +00:00
Xu Cheng
22f294af90
bottle: fix regex
Noted that this is intended for the revision of this formula instead of
rebuild of a bottle.
2017-01-22 19:50:14 +08:00
ilovezfs
cebe137499 audit: exempt wine's deps from the universal deprecation
This can be reverted when wine's dependencies are all vendored.
2017-01-20 07:18:51 -08:00
Gautham Goli
0b3d9031e2 Add --fix option to brew audit command 2017-01-18 22:35:37 +05:30
Mike McQuaid
9f183be358 Merge pull request #1868 from zmwangx/bottle-add-improve-regexp
bottle: add: improve regexp to recognize comments
2017-01-18 08:02:45 +00:00
Mike McQuaid
4f0505f759 audit: only warn on versioned conflicts_with.
Rather than all versioned formulae regardless. Oops.
2017-01-17 19:09:41 +00:00
Zhiming Wang
42486c1181
bottle: add: improve regexp to recognize comments
This would have eliminated the need for Homebrew/homebrew-core#9000, for
instance.
2017-01-17 10:26:01 -05:00
Mike McQuaid
dac66c4ada Add keg_only :versioned_formula.
This is used to indicate a formula is a version of another formula.
This will be used to provide a consistent interface for older formulae
versions and replaces the use of `conflicts_with`.
2017-01-17 10:50:04 +00:00
Mike McQuaid
aa104137e5 Merge pull request #1844 from MikeMcQuaid/audit-universal
audit: don't allow universal for new formulae.
2017-01-17 10:08:44 +00:00
Mike McQuaid
feea90c0dd create: handle null versions.
Fixes #1821
2017-01-16 20:15:32 +00:00
Mike McQuaid
f4496e85e5 audit: don't allow universal for new formulae.
We're frowning on these now so may as well turn that into code.
2017-01-15 02:31:11 -08:00
ilovezfs
9dca10f9dc audit: whitelist unstable versions already in core
also allow higher stable versions with the same version prefix
2017-01-13 18:59:23 -08:00
William Woodruff
82c046b3e1
audit: Check for invocations of cctools.
Now that ruby-macho is available, cctools should be invoked as little
as possible.
2017-01-11 23:07:26 -05:00
Mike McQuaid
9cce3414fb Merge pull request #1806 from MikeMcQuaid/audit-virtualenv-setuptools
audit: check virtualenv and setuptools resource.
2017-01-09 14:08:30 +00:00
Mike McQuaid
346d68eb04 audit: check virtualenv and setuptools resource.
`virtualenv_install_with_resources` will automatically define and
install a `setuptools` resource so this is unnecessary.

References https://github.com/Homebrew/homebrew-core/pull/8570
2017-01-09 13:24:51 +00:00
Mike McQuaid
c276a44eba bump-formula-pr: check for URL presence.
If it's not there, produce a nicer error.

Fixes #1805.
2017-01-09 12:16:55 +00:00
Mike McQuaid
e7a81caaf4 Allow brew audit to fake a Safari user-agent.
This allows us to detect if homepages such as e.g. `aiccu` which
blocks `curl` are up or not.
2017-01-07 14:03:08 +00:00
Mike McQuaid
a3bffe70bc Use docs.brew.sh links. 2017-01-04 11:13:41 +00:00
Mike McQuaid
d7ab913f31 audit: deprecate env :std/:userpaths for strict.
This should apply only for new formulae but we should start gradually
phasing it out for older ones too.
2017-01-03 22:12:21 +00:00
Mike McQuaid
b3c6334d3c audit: use new curl_args form.
This will use Curl’s default user agent to reduce homepage errors and
provides a function that can be used for other audits to perform
similar tests on URLs.
2016-12-30 20:17:34 +00:00
Mike McQuaid
59180ec370 audit: improve reliability of homepage audit.
- Don't run on Yosemite where the system Curl is too old for some modern
  HTTPS homepages
- Try up to 3 times in case of transient failures.
2016-12-29 12:51:12 +00:00
Mike McQuaid
8ffe231f44 audit: don't allow openssl & libressl dependency.
Formulae should not depend on both OpenSSL and LibreSSL (even
optionally). This is to avoid descending into madness where every
formulae that could use LibreSSL has to have option and switching logic.

Homebrew has standardised on OpenSSL and will do so everywhere that
LibreSSL is not a hard requirement.
2016-12-29 11:46:51 +00:00
Mike McQuaid
5b806c09ae Merge pull request #1719 from zmwangx/strip-x11-from-new-formula-template
create: remove :x11 dep from new formula template
2016-12-23 19:51:12 +00:00
Mike McQuaid
9bfeb91562 Merge pull request #1715 from zmwangx/bump-formula-pr-fix-removal-of-old-mirror
bump-formula-pr: fix removal of old mirrors
2016-12-23 19:42:31 +00:00
Mike McQuaid
161bd20fcd Merge pull request #1663 from tschoonj/meson-create-support
brew create: add meson support
2016-12-23 19:24:15 +00:00
Mike McQuaid
cd13e306a8 Merge pull request #1693 from broder/homepage_check
Updated homepage 404 check to use explicit parameters and return the …
2016-12-23 19:14:08 +00:00
David Broder-Rodgers
3c566399cf Added check for insecure mirror URLs 2016-12-23 14:55:08 +00:00
Zhiming Wang
1ab8b5e35b
create: remove :x11 dep from new formula template 2016-12-22 18:57:57 -05:00
Zhiming Wang
3ebd7df62d
bump-formula-pr: fix removal of old mirrors
Previously, old mirrors are only removed if the requested spec is
stable, and if the mirror lines only have two leading spaces. This leads
to stale mirror line(s) when the formula a stable block like

    stable do
      url "http://example.com/v1.0.tar.gz"
      mirror "http://example.net/v1.0.tar.gz"
    end

where the mirror line is lead by four spaces.

In this commit, we discard the /(^ mirror .*\n)?/ pattern, and instead
create a pattern with the exact url and flexible leading spaces for each
mirror of the requested spec.
2016-12-22 00:54:08 -05:00
Mike McQuaid
8f85eb64c4 audit: fix 32-bit check. 2016-12-20 14:26:53 +00:00
Mike McQuaid
ef6b55125c Merge pull request #1695 from MikeMcQuaid/audit-revision-map-nil
audit: handle a nil revision map.
2016-12-20 10:55:41 +00:00
Mike McQuaid
1d2390b2de Merge pull request #1698 from MikeMcQuaid/deprecate-32-bit
Deprecate 32-bit options.
2016-12-20 10:54:54 +00:00