3334 Commits

Author SHA1 Message Date
Xu Cheng
1a0f64d5f8 test-bot: don't use --build-bottle flag if bottle disabled 2015-10-19 21:50:12 +08:00
Xu Cheng
c4067cf8bb test-bot: skip bottling if it's unneeded 2015-10-19 21:41:36 +08:00
Xu Cheng
d20d08b5fe bottle: fail if bottle is disabled 2015-10-19 21:41:36 +08:00
Eric Andrew Lewis
5ec396ed38 install: make search output more intuitive.
Closes Homebrew/homebrew#42222.
Closes Homebrew/homebrew#44892.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-10-19 10:16:40 +01:00
Baptiste Fontaine
abfaa59e06 MacOS: full_version added
Closes Homebrew/homebrew#44988.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-10-18 22:57:42 +08:00
Xu Cheng
2130cb8c86 uninstall: fix indent 2015-10-17 03:59:28 +08:00
Xu Cheng
dee4c76e62 uninstall: fix when Cellar doesn't exist 2015-10-17 03:57:40 +08:00
Martin Afanasjew
e4de6907fd tap-info: tweak output for two edge cases
Improve output in the (rare) cases where a tap offers both commands and
formulae or neither. Also adjust code to stay below the 80 column limit.

Closes Homebrew/homebrew#44995.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-10-16 09:12:30 +01:00
Martin Afanasjew
7044bf7bbf update: report tap updates and improve wording
Closes Homebrew/homebrew#43468.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-10-16 09:12:29 +01:00
Martin Afanasjew
21d804eeb8 commands: ensure external commands are executable
For consistency with `brew command` and the logic in `brew.sh` (both use
`which` to find/validate an external command), we need to filter files
that are not executable.

Otherwise `brew commands` and thus bash completion will offer commands
that will produce an error when attempting to use them.

Closes Homebrew/homebrew#44999.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-10-15 19:26:27 +01:00
Xu Cheng
b5ec74c3f6 search: various improvement
* Move listing all formula names in the top to speed up shell script.
* Simplify logic.
* Only search PR and check bad regex for tty?, which will benefit to
  shell script.

Closes Homebrew/homebrew#44985.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-10-15 17:24:41 +08:00
Xu Cheng
135efb39b8 search: highlight installed formulae 2015-10-15 17:24:41 +08:00
Xu Cheng
79018e4e24 test-bot: remove unused --tap args for brew bottle 2015-10-15 16:25:17 +08:00
Xu Cheng
d162aab9c6 test-bot: ensure cleanup is running
Closes Homebrew/homebrew#44982.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-10-15 09:05:51 +01:00
Xu Cheng
c247a5b462 test-bot: merge formula's bottle before test
Fixes the bug described in
https://github.com/Homebrew/homebrew-science/pull/2866#issuecomment-148298146
2015-10-15 09:05:51 +01:00
Xu Cheng
1da0583634 bottle: allow --merge --write without commit 2015-10-15 09:05:51 +01:00
Martin Afanasjew
0114a26483 update: highlight installed formulae in report
Closes Homebrew/homebrew#44335.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-10-15 08:55:47 +01:00
Mike McQuaid
aeea953270 test-bot: readd missing --build-bottle. 2015-10-14 18:52:31 +01:00
Baptiste Fontaine
362da26ff6 test-bot: ensure install_passed is always defined 2015-10-14 17:40:14 +02:00
Vlad Shablinsky
e04a463f11 update: allow updating from local branch
Closes Homebrew/homebrew#44893.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-10-14 14:01:27 +01:00
Mike McQuaid
667fa65be8 test-bot: make master builds faster.
Just do a few things rather than doing e.g. a full compile.

Closes Homebrew/homebrew#44936.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-10-14 14:01:11 +01:00
Xu Cheng
d1222971f6 test-bot: update diff_start_sha1 unconditionally
See bfab4b0e65db4667ab09159b1040701fa75ec687

Closes Homebrew/homebrew#44889.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-10-14 00:04:57 +08:00
Søren Brokær
ed42b2eb39 let the user know what exactly was already tapped
Closes Homebrew/homebrew#44843.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-10-13 14:03:42 +02:00
Xu Cheng
76a5ba6ae5 test: allow writing to certain var directories
Closes Homebrew/homebrew#44458.

Closes Homebrew/homebrew#44773.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-10-10 11:54:10 +08:00
Xu Cheng
52de8d9373 postinstall: sanitize ARGV options 2015-10-10 11:19:22 +08:00
Xu Cheng
8c4bd3dae2 audit: use ARGV.resolved_formula
There are audit rules which check cellar. Therefore, we need
`ARGV.resolved_formula` to get proper spec and prefix.

Closes Homebrew/homebrew#44781.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-10-10 01:34:43 +08:00
Xu Cheng
fe3b69d388 test: sanitize ARGV options
Otherwise, it will use the wrong prefix to test devel/HEAD install.
2015-10-10 01:34:42 +08:00
Xu Cheng
51a585e0b4 search: don't fail because broken formulae
Fixes Homebrew/homebrew#44687.

Closes Homebrew/homebrew#44770.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-10-10 01:33:44 +08:00
Xu Cheng
1ae44d4429 use directory? to check rack existence 2015-10-09 19:06:08 +08:00
Xu Cheng
ee332c4550 handle TapFormulaWithOldnameAmbiguityError
Closes Homebrew/homebrew#44705.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-10-08 16:02:33 +08:00
Daniel Lee Harple
6b3b398858 audit: fix GitHub repository audit
In the data returned from the GitHub API, “watchers_count” is actually the
number of stars.

See https://developer.github.com/v3/activity/starring/#starring-vs-watching

Closes Homebrew/homebrew#44477.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-10-07 19:48:24 +08:00
Andrew Janke
4c80bf4324 audit: add check for 'head' and 'head do' both present
Closes Homebrew/homebrew#44626.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-10-07 09:41:24 +02:00
Rakesh
2d60187e1a brew upgrade: provides an option --cleanup
Closes Homebrew/homebrew#44305.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-10-07 14:05:11 +08:00
Baptiste Fontaine
f629bb4e0f command: fail early if no command is given
Closes Homebrew/homebrew#44450.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-10-06 09:58:05 +02:00
Forrest Fleming
e0f9994542 Remove incomplete files in cache on brew cleanup
Closes Homebrew/homebrew#44182.
Closes Homebrew/homebrew#44349.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-10-06 15:13:25 +08:00
Dominyk Tiller
bdd27d7cc0 doctor: whitelist Paragon NTFS dylib
Closes Homebrew/homebrew#44542.
2015-10-02 23:43:14 +01:00
Charlie Egan
a90363b605 doctor: minor grammar correction: 'pluralize' breakage
Closes Homebrew/homebrew#44497.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-10-02 19:06:05 +02:00
Xu Cheng
6b3704162f doctor: point Xcode download to App Store for El Capitan 2015-10-01 14:39:25 +08:00
Xu Cheng
3b520cf195 cache taps
There are plenty of IO operations inside Tap object, and it will be more
when implementing formula alias reverse look up(e.g. list all of alias
names for a formula). So let's cache them.

Some benchmark:

$ time brew info $(brew ruby -e 'puts Formula.tap_names') > /dev/null
Before: 6.40s user 2.42s system 96% cpu 9.134 total
After: 4.75s user 0.77s system 97% cpu 5.637 total

Closes Homebrew/homebrew#44377.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-09-30 16:25:30 +08:00
Xu Cheng
6240e896b2 doctor: always print to stderr
This can help to solve the broken layout of doctor.out in brew gist-logs
2015-09-30 16:20:18 +08:00
Xu Cheng
30795ddc29 doctor: temporary add -R flag in chown instruction
Will replace it when we implemented `brew repair-permission`
2015-09-30 13:55:32 +08:00
Xu Cheng
e66cb91702 update: add permissions check
Closes Homebrew/homebrew#42048

Closes Homebrew/homebrew#44434.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-09-30 13:54:04 +08:00
Xu Cheng
ff132a9ddb doctor: add check_access_homebrew_repository 2015-09-30 13:54:04 +08:00
Xu Cheng
3c54d12cec doctor: official supporting El Capitan 2015-09-30 13:54:04 +08:00
Xu Cheng
b37a285141 test-bot: fix start_revision for Travis
When a PR is merged during the test, the commit tree will be looked like
this:

master  PR
  \     /
    \ /
     |
    root

The start_revision will be poined to the commit used to merging PR,
instead of common root commit. As result, `git diff-tree start end`
will list file changes both in PR and master branch, which later
contributes to additional formulae are tested in some Travis builds.

To fix the problem, we use `git merge-base` to get common ancestor as
the real start_revision.

Closes Homebrew/homebrew#44379.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-09-28 21:46:59 +08:00
Mike McQuaid
74a2c3a509 test-bot: add comments, tweak argument handling. 2015-09-25 09:15:10 +01:00
Xu Cheng
afff98d700 travis: run --ci-master for non-PR
Closes Homebrew/homebrew#44302.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-09-24 20:35:26 +08:00
Mike McQuaid
711e079901 Export more Travis debugging and fix Git issue. 2015-09-24 08:33:08 +01:00
Dominyk Tiller
87769ee970 style: update rubocop to 0.34.2 2015-09-24 02:18:50 +01:00
Mike McQuaid
f154f4898a bottle: output maximum number of strings matches.
`brew bottle --verbose` outputs all the matches for a string found
in the files inside the Cellar. Instead of outputting all of these just
output the first 100.

Closes Homebrew/homebrew#44266.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-09-23 15:17:35 +01:00