Mike McQuaid
b9efa6336e
search: remove thread-unsafe Hash cache.
...
Doesn't appear to affect the speed of `brew search`.
Fixes #415 .
2016-08-12 21:29:49 +01:00
Mike McQuaid
850db4ebf4
search: fix repositories with formulae and casks.
...
e.g. Caskroom/homebrew-cask.
Thanks to UniqMartin for the fix.
Fixes #655 .
2016-08-08 10:55:12 +01:00
Xu Cheng
a8566c9848
various: eliminate the usage of any?
( #638 )
...
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)).
2016-08-05 22:01:32 +08:00
Martin Afanasjew
1c581a232c
search: add alias -S back to zero-argument help
...
Amends 132ada2b0ebb3751c0f8f42ca83bb257b55a50fd until we properly figure
out a way of documenting built-in aliases (or not doing that) across all
commands that currently have aliases. See #270 for full discussion.
2016-05-26 17:52:58 +02:00
Joe Gallo
132ada2b0e
Clarify brew search usage. ( #270 )
...
* Include --desc in brew search help text.
* Update brew search --desc text in README.
* Remove mention of alias in brew search help text to avoid any
confusion.
2016-05-26 16:45:25 +02:00
Max Nordlund
fa1fd70a37
Add all the top level comments
2016-04-10 22:59:25 +02:00
Sam McTaggart
148da47571
Improve error message for invalid regex to search
...
Fixes https://github.com/Homebrew/homebrew/issues/50131
This commit removes the error backtrace and improves the error message
if a bad regexp is passed to `brew search`.
Closes Homebrew/homebrew#50173 .
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
2016-03-19 19:14:50 +08:00
Tommy Sparber
d675fa0b5a
Search also in Caskroom/versions Tap
...
Extending the current search functionallity to search in
https://github.com/caskroom/homebrew-versions
Closes Homebrew/homebrew#47954 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2016-01-17 21:53:20 +00:00
Mike McQuaid
bf2315b1f4
Use (installed)
and emoji ticks consistently.
...
Across info, search and update.
Closes Homebrew/homebrew#45131 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-12-07 14:56:30 +00:00
Xu Cheng
b5ec74c3f6
search: various improvement
...
* Move listing all formula names in the top to speed up shell script.
* Simplify logic.
* Only search PR and check bad regex for tty?, which will benefit to
shell script.
Closes Homebrew/homebrew#44985 .
Signed-off-by: Xu Cheng <xucheng@me.com>
2015-10-15 17:24:41 +08:00
Xu Cheng
135efb39b8
search: highlight installed formulae
2015-10-15 17:24:41 +08:00
Xu Cheng
51a585e0b4
search: don't fail because broken formulae
...
Fixes Homebrew/homebrew#44687 .
Closes Homebrew/homebrew#44770 .
Signed-off-by: Xu Cheng <xucheng@me.com>
2015-10-10 01:33:44 +08:00
Xu Cheng
8a30f315d9
search: use full name to filter aliases result
2015-09-13 21:27:49 +08:00
Xu Cheng
0165a810f7
search: handle tap aliases
2015-09-13 17:47:53 +08:00
Xu Cheng
80514ee5d7
desc: better way to handle options
...
We allow to use options like --verbose and --debug for all commands.
And we should support switch format options, e.g. `brew desc -vs foo`
2015-09-10 13:37:57 +08:00
Dan Martinez
8374374168
Improve description searching and add a cache.
...
Closes Homebrew/homebrew#42281 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-09-08 15:23:37 +01:00
Alex Dunn
79ea14b738
cmd/search: fix filtering of aliases in results
...
By directly modifying the results array with
`results[i] = "#{name} (installed)"`, it appeared on successive
iterations that the canonical name was no longer in the array, so
aliases were not removed.
See 9efe5b554c (commitcomment-12969631)
Closes Homebrew/homebrew#43433 .
2015-08-31 07:54:59 -07:00
Alex Dunn
431ebba7af
cmd/search: mark installed formulae
...
`brew search emacs`, with homebrew/emacs tapped:
```
real 0m2.586s
user 0m1.138s
sys 0m0.121s
```
Previously:
```
real 0m2.831s
user 0m1.385s
sys 0m0.087s
```
`brew search s`:
```
real 0m2.260s
user 0m1.201s
sys 0m0.114s
```
Previously:
```
real 0m5.953s
user 0m4.827s
sys 0m0.226s
```
Closes Homebrew/homebrew#35696 .
Closes Homebrew/homebrew#42662 .
2015-08-30 11:29:13 -07:00
Xu Cheng
d62095710f
More core files style updates
2015-08-03 20:38:20 +08:00
BrewTestBot
13d544e11e
Core files style updates.
...
Closes Homebrew/homebrew#42354 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-08-03 13:22:35 +01:00
Alex Dunn
48df76dc89
cmd/search --desc: bold formula names
...
Closes Homebrew/homebrew#40717 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-07-08 13:56:00 +01:00
Xu Cheng
6af47815b0
search: cache remote tap formulae
...
Closes Homebrew/homebrew#40775 .
Signed-off-by: Xu Cheng <xucheng@me.com>
2015-06-18 14:46:29 +08:00
Baptiste Fontaine
4648aa54c0
search --desc: cache the query regexp
...
Closes Homebrew/homebrew#40795 .
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-06-17 08:43:01 +02:00
Xu Cheng
938dc356c1
add official_taps
2015-06-01 20:08:41 +08:00
Xu Cheng
c1830828b2
search: use Formula#full_name
2015-05-29 17:02:22 +08:00
Xu Cheng
e2b0bca931
add Formula.core_names Formula.tap_names and Formula.full_names
2015-05-27 13:53:40 +08:00
Nikolaus Wittenstein
148cafa9cd
brew search
can take a --desc
argument to search descriptions
2015-05-25 17:23:50 +01:00
Dominyk Tiller
ec7b513a53
search: add homebrew/tex to search params
...
Closes Homebrew/homebrew#38855 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-04-24 18:35:06 +01:00
Alex Dunn
d85f2dabca
cmd/search: notification on attempted regex searches
...
Closes Homebrew/homebrew#38760 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-04-21 10:54:29 +01:00
Baptiste Fontaine
e5c1f5115c
search: fix --fedora URL.
...
Closes Homebrew/homebrew#37155 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-25 08:30:48 +00:00
Viktor Szakats
fc2818b7a5
Use more https in urls and updated some lost links
...
Closes Homebrew/homebrew#35531 .
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2015-01-04 02:13:16 -05:00
Misty De Meo
d57fe3eded
search: add homebrew-x11 to default taps
2014-12-28 18:42:20 -08:00
Mike McQuaid
52cda8fd80
Allow searching/installing Homebrew Casks.
...
People want to install things like GIMP using Homebrew so let's make it
easier for them to find a decent installation method.
Closes Homebrew/homebrew#34496 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-11-30 17:59:02 +00:00
Jack Nagel
10a1952d2c
Only "extend self" once on the Homebrew module
2014-06-19 13:10:36 -05:00
Jack Nagel
0291a579fb
Respect tap directory layout when searching
...
This matches the logic in find_formula.
2014-04-27 17:28:19 -05:00
Jack Nagel
ccc62a0cad
Use canonical_name to canonicalize aliases
2014-04-27 16:03:32 -05:00
Jack Nagel
82047ed901
Search results should always be sorted
2014-04-27 16:03:08 -05:00
Jack Nagel
3b15b58d00
Use Formulary.factory to find formula in taps
2014-04-27 15:32:28 -05:00
Jack Nagel
bdee729a41
Yield absolute paths from find_formula
2014-04-25 18:58:16 -05:00
Tsukasa OMOTO
54004a4759
Make the on-disk representation of taps unambiguous
...
This commit supports "-" and "_" in names of user and repository.
Closes Homebrew/homebrew#28203 .
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-04-24 17:10:41 -05:00
Mike McQuaid
daa7b7b6db
search: move nginx to Homebrew organisation.
2014-04-18 10:59:12 +01:00
Mike McQuaid
513a1f2ebd
Migrate homebrew-php to Homebrew organization.
2014-04-10 16:22:24 +01:00
Jack Nagel
7bdaa7ffe1
search: use a queue to collect errors
...
The threading in the tap search code makes handling errors difficult. If
an API-related error is raised in one thread, it is likely to be raised
in each of the rest as well. This results in duplicated error messages,
which is ugly and bad UX.
This patch adds a synchronized queue to collect these exceptions. The
first one added to the queue is re-raised after all operations are
complete.
It's not ideal, but it's minimally invasive and I don't have the energy
or time to do a rewrite.
2014-02-16 23:19:09 -05:00
Jack Nagel
a7b515e503
Use a more accurate method name and drop unhelpful block
2014-02-13 23:22:43 -05:00
Jack Nagel
345457b33e
Pass the string instead of reconstructing it from a regexp
2014-02-12 13:59:18 -05:00
Jack Nagel
d01c671d74
Drop unnecessary map + compact in search_tap
2014-02-08 17:53:08 -05:00
Jack Nagel
7d4709d9d6
Prevent repeated warnings when GitHub API rate limit is exceeded
2014-02-08 16:04:53 -05:00
Jack Nagel
2e3871c076
Raise only GitHub::Error from GitHub.open
2014-02-08 16:04:53 -05:00
Jack Nagel
4d6df3e3bc
Parse JSON early in GitHub module
2014-02-08 16:04:53 -05:00
Jack Nagel
f7e1244e6d
Don't mutate argument in search_tap
2014-02-08 16:04:52 -05:00