4951 Commits

Author SHA1 Message Date
Jack Nagel
dd331245ab Remove unused accessor 2014-07-30 20:19:43 -05:00
Jack Nagel
0a605cbf8b Simplify BuildOptions copy tests 2014-07-30 20:15:18 -05:00
Jack Nagel
bc937f56e7 Rename resource? to resource_defined? 2014-07-30 18:56:37 -05:00
Jack Nagel
3451c2d67f Handle nonexistent files when constructing ConflictError
Closes Homebrew/homebrew#31051.
2014-07-30 16:29:10 -05:00
Jack Nagel
ba4a4e4103 Limit exposure of the options data structures 2014-07-29 21:54:32 -05:00
Misty De Meo
e18faa7557 --cc=: make GNU_GCC checks stricter
Fixes Homebrew/homebrew#30668
2014-07-29 19:31:07 -07:00
Jack Nagel
c1ba34734d Remove unused require 2014-07-29 17:09:04 -05:00
Jack Nagel
9b6f83bdfa Use the library path constant to get the library path 2014-07-29 16:59:02 -05:00
Jack Nagel
5216dd54b3 Remove patch hacks from unpack 2014-07-29 16:22:07 -05:00
Jack Nagel
dc2080bd9f Remove patch hacks from audit 2014-07-29 16:22:06 -05:00
Jack Nagel
a55e196f5f Simplify internal representation of patches
- remove support for IO objects, since we no longer access ::DATA
   directly
 - since we don't need to support IO objects, use a separate class for
   string patches and stop wrapping strings in StringIO ojects
2014-07-29 16:22:06 -05:00
Jack Nagel
3f12ddbccd Decouple DATA patches from the executing script 2014-07-29 16:22:06 -05:00
Jack Nagel
e0c9717717 Store test patches in constants 2014-07-29 16:06:06 -05:00
Adam Vandenberg
fbee511eba Pathname.binread 2014-07-29 07:25:27 -07:00
Jack Nagel
8ca8ec3993 Fix up dep directories before activating ENV extensions 2014-07-28 23:20:23 -05:00
Jack Nagel
8a971f7268 Move the fixopt method into the Build class 2014-07-28 21:25:49 -05:00
Jack Nagel
8df8f437f0 Make Patch a module since it only has singleton methods 2014-07-28 16:23:42 -05:00
Jack Nagel
90f69372ce Remove inheritance patch classes 2014-07-28 16:23:42 -05:00
Mike McQuaid
2013d153e5 Add test 1x1 images for formula test fixtures.
images
2014-07-28 19:36:08 +02:00
Adam Vandenberg
5af3d319d6 backport binwrite from Ruby 2.1+ 2014-07-27 16:21:35 -07:00
Adam Vandenberg
8e96ce0aa5 Rename write_binary to binwrite 2014-07-27 15:30:46 -07:00
Adam Vandenberg
bb2c9b7ba4 audit 'def test'
Closes Homebrew/homebrew#31120
2014-07-27 15:10:15 -07:00
Adam Vandenberg
10e5fea01d add Pathname.write_binary 2014-07-27 11:14:51 -07:00
Jack Nagel
90762c2f18 A period is a valid formula name character
Fixes Homebrew/homebrew#31052.
2014-07-26 21:06:56 -05:00
Jack Nagel
5b8e564d70 Add test for reporting tap updates 2014-07-26 20:11:53 -05:00
Jack Nagel
908d7bdecf Clean up updater tests 2014-07-26 20:11:53 -05:00
Jack Nagel
87850d00cd Remove obsolete hacks from updater report 2014-07-26 20:11:53 -05:00
Jack Nagel
2b90995c3e Only populate the report with formula paths 2014-07-26 20:11:53 -05:00
Jack Nagel
197a12c900 Switch from backticks to Utils.popen_read 2014-07-26 20:11:53 -05:00
Jack Nagel
802775078c Separate reading and parsing the diff 2014-07-26 20:11:53 -05:00
Jack Nagel
6baf357f8c update: remove unused rename detection
Right now this code only produces false positives. When we have real
support for renames, we can implement it more carefully.

Closes Homebrew/homebrew#31126.
2014-07-25 12:28:05 -05:00
Jack Nagel
2cf116464d update: simplify diff parsing 2014-07-25 12:25:58 -05:00
Jack Nagel
cd02d3d540 Stop rescuing Exception when making opt link 2014-07-24 19:39:09 -05:00
Jack Nagel
07bf57b8ea Push keg_only special-case into link 2014-07-24 19:39:09 -05:00
Jack Nagel
f1fc0b788f Pass the keg object into link and fix_install_names 2014-07-24 19:39:09 -05:00
Mike McQuaid
8cf69fac3f OS::Mac: allow clearing compiler version cache.
Without this it’s impossible for brew-test-bot to be able to verify if
installing GCC has allowed it to fix a compiler selection failure.
2014-07-24 08:51:09 +01:00
Adrian Petrescu
9a15f9e3fa storm 0.9.2
Closes Homebrew/homebrew#31025.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2014-07-23 21:54:20 -07:00
Dabrien 'Dabe' Murphy
46ca68de5e Modify "git rev-parse --verify" args in "has_ref?"
Per the `git-rev-parse(1)` manpage:

  --verify Verify that exactly one parameter is provided, and that it
  can be turned into a raw 20-byte SHA-1 that can be used to access the
  object database. If so, emit it to the standard output; otherwise,
  error out.

  If you want to make sure that the output actually names an object in
  your object database and/or can be used as a specific type of object
  For example, git rev-parse "$VAR^{commit}" will make sure $VAR names
  an existing object that is a commit-ish (i.e. a commit, or an
  annotated tag that points at a commit).

That actually means that:

  git rev-parse --verify af8e768e2bd3b4398bca033998f83b0eb8874914

will _always_ return the SHA-1 hash — regardless of whether or not
that's actually a valid reference!

Thus, when `GitDownloadStragtegy#update_repo` tries to check
`has_ref?`, it mistakenly succeeds, and doesn't actually do a `git fetch
origin`.

The fix is to use:

  git rev-parse --verify "af8e768e2bd3b4398bca033998f83b0eb8874914^{commit}"

Fixes Homebrew/homebrew#31045.
Closes Homebrew/homebrew#31054.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-07-23 21:07:02 -05:00
Jack Nagel
9c5149b85a Stop exposing mirrors array 2014-07-23 13:09:28 -05:00
Jack Nagel
c3a5b1152e Stop exposing the downloader as an attribute 2014-07-22 19:14:30 -05:00
Jack Nagel
d99379bc63 Hide the downloader implementation from the installer 2014-07-22 19:14:30 -05:00
Jack Nagel
2b1b7ef0e4 Ruby 1.8 doesn't have the \h regexp metacharacter 2014-07-21 17:27:37 -05:00
Mike McQuaid
31a444ef16 dependency_collector: add :java symbol 2014-07-21 19:14:15 +01:00
Mike McQuaid
7e7b721797 requirements: add JavaDependency.
Requested in Homebrew/homebrew-science#1039.
Closes Homebrew/homebrew#30852.
2014-07-21 19:14:15 +01:00
Jack Nagel
f34fcd7781 Simplify onoe 2014-07-20 19:47:31 -05:00
Jack Nagel
5abcfad97e Fix install names in files in sbin 2014-07-20 18:37:49 -05:00
Adam Vandenberg
8b5397fa28 improve comment 2014-07-20 12:17:06 -07:00
Adam Vandenberg
929fd44082 use ObserverPathnameExtension to remove these files 2014-07-20 12:17:06 -07:00
Adam Vandenberg
557f887f24 add clarifying comments 2014-07-20 12:17:06 -07:00
Adam Vandenberg
b0138e447d fix comment 2014-07-19 23:28:39 -07:00