13531 Commits

Author SHA1 Message Date
Mike McQuaid
482568579b Merge pull request #1675 from MikeMcQuaid/diagnostic-multiple-cellars
diagnostic: check for multiple Cellars.
2016-12-18 11:18:13 -08:00
Mike McQuaid
e95c843c2e Merge pull request #1673 from MikeMcQuaid/audit-fails-with-llvm
audit: flag use of "fails_with :llvm".
2016-12-18 11:17:44 -08:00
Mike McQuaid
b87d27f939 Merge pull request #1679 from MikeMcQuaid/no-prune-top-level-dirs
prune: don't remove top-level directories.
2016-12-18 11:16:27 -08:00
Mike McQuaid
5aeb7125c4 Merge pull request #1685 from MikeMcQuaid/utils-path-string
which_all: don't assume path is a string.
2016-12-18 11:16:02 -08:00
Mike McQuaid
b0d2dc7278 Merge pull request #1683 from MikeMcQuaid/tweak-contributing
Tweak issue template and contributing guidelines.
2016-12-18 10:02:44 -08:00
Markus Reiter
60d63965f2 Merge pull request #1689 from reitermarkus/failed-install-error-message
Fix error message when cask fails to install.
2016-12-17 17:17:25 +01:00
Markus Reiter
8b04545b3f Merge pull request #1667 from jmorten/bugfix/typo
fix typo
2016-12-16 22:45:04 +01:00
Markus Reiter
3088faaf9c Fix error message when cask fails to install. 2016-12-16 18:22:04 +01:00
Mike McQuaid
ab060c9d52 super/cc: loosen cellar formula regex.
Match HOMEBREW_TAP_FORMULA_REGEX to avoid skipping valid cellar regexes.
2016-12-15 15:15:13 -08:00
Mike McQuaid
9cd5a21b47 Merge pull request #1669 from vladshablinsky/fix_method_deprecated
formulary: call tap not formula
1.1.5
2016-12-13 22:41:44 -08:00
Uladzislau Shablinski
478e4f112c formulary: call tap not formula
Fixes #1668
2016-12-14 05:07:54 +03:00
Joshua Morten
6eb7aa6d4d fix typo 2016-12-13 15:40:31 -08:00
ilovezfs
99f42146c0 Merge pull request #1665 from Homebrew/revert-1592-runtime_dependencies
Revert "formula: runtime deps of build deps aren't runtime"
1.1.4
2016-12-13 11:26:23 -08:00
ilovezfs
862c3ba4a2 Revert "formula: runtime deps of build deps aren't runtime" 2016-12-13 11:15:00 -08:00
Mike McQuaid
6b4de31504 Merge pull request #1661 from radex/patch-1
Fix typo
1.1.3
2016-12-13 06:42:01 -08:00
Radek Pietruszewski
fcc2f8701a Fix typo 2016-12-13 13:26:10 +01:00
Mike McQuaid
755be9a2ee Merge pull request #1659 from dersvenhesse/patch-1
XCode 8.2 is stable
2016-12-13 05:21:32 +00:00
Mike McQuaid
cf1fa0c5bc audit: flag use of "fails_with :llvm".
Also, add TODOs for deprecating this properly at a later point.
2016-12-13 02:10:11 +00:00
Mike McQuaid
8f80cc6568 diagnostic: check for bad tap files.
Check for Ruby files in taps that are outside of the detected `Formula`
directory for a tap but inside one of the other potential directories.

This usually indicates a formula has been added in the wrong directory
in a tap and is used to fail CI in this case.
2016-12-13 01:53:05 +00:00
Mike McQuaid
2e15f713a0 prune: don't remove top-level directories.
Even if they're empty we want to keep these top-level directories around
as the installer has nicely created them with the correct permissions
and this avoids potentially having to use `sudo` to recreate them.
2016-12-13 01:05:11 +00:00
Mike McQuaid
5efea992f0 Tweak issue template and contributing guidelines.
- Note issues may be closed without comment if sufficient information is
  not provided.
- Deprecate Homebrew/brew-evolution, note new feature request flow
- Note some issues should be created on Homebrew/brew
2016-12-13 00:49:57 +00:00
Mike McQuaid
961b5fff9d formula_installer: prevent version mismatched deps
Don't allow e.g. the use of `openssl` and `openssl@1.1` in the same
dependency tree to avoid runtime failures and general weirdness.
2016-12-13 00:37:40 +00:00
Mike McQuaid
950512ad34 diagnostic: check for multiple Cellars.
And tell people to delete the HOMEBREW_REPOSITORY one. The
HOMEBREW_PREFIX one is preferable for bottling.
2016-12-13 00:19:46 +00:00
Mike McQuaid
2b547583a3 postinstall: don't allow writes to prefix itself.
Only the top-level directories inside it. We don't want formulae writing
random junk in e.g. `/usr/local` even in `postinstall`.
2016-12-13 00:13:20 +00:00
dersvenhesse
b3174aa3e2 XCode 8.2 is stable 2016-12-12 23:29:35 +01:00
Mike McQuaid
666463ca2b Merge pull request #1592 from alyssais/runtime_dependencies
formula: runtime deps of build deps aren't runtime
2016-12-12 13:28:56 +00:00
Mike McQuaid
c317c3c31f Merge pull request #1616 from zachwhaley/zsh_functions_caveats
caveats: Differentiate zsh completion files and function files
2016-12-12 13:27:40 +00:00
Mike McQuaid
ebe45490b6 analytics: don't raise if tap doesn't exist. 2016-12-11 13:43:32 +00:00
Mike McQuaid
6a4af80b38 Merge pull request #1645 from broder/contribute_update
Made the pull request guide slightly less formula specific
2016-12-11 12:42:50 +00:00
Mike McQuaid
ef8afdf707 Merge pull request #1649 from MikeMcQuaid/prune-opt
keg: also prune opt.
2016-12-11 12:18:25 +00:00
Mike McQuaid
d085a47124 Merge pull request #1646 from MikeMcQuaid/report-deprecations-to-tap
Tell people to report URL/tap deprecations to the tap.
2016-12-11 12:17:49 +00:00
Mike McQuaid
11483d55c9 keg: also prune opt.
If there's dead symlinks in there they should be removed.
2016-12-11 11:55:07 +00:00
Uladzislau Shablinski
45ef7ea0b0 Merge pull request #1343 from vladshablinsky/explicit-specs
Allow to install any spec
2016-12-11 14:26:46 +03:00
Mike McQuaid
a3bacf1238 Merge pull request #1648 from MikeMcQuaid/remove-dependency-installer
formula_installer: remove dependency_installer.
2016-12-10 19:50:26 +00:00
Mike McQuaid
bf9da2532e formula_installer: remove dependency_installer.
This is no longer needed as the reason it was added (argument
sanitisation) is now done properly.

Also, remove `skip_deps_check?` in favour of `ignore_deps?` as it too is
no longer needed.
2016-12-10 19:21:17 +00:00
Mike McQuaid
7258557aea Merge pull request #1647 from MikeMcQuaid/fix-dependency-option-handling
Fix dependency option handling.
2016-12-10 18:20:59 +00:00
Mike McQuaid
51c31f4d51 Merge pull request #1642 from MikeMcQuaid/always-output-options
reinstall/upgrade/install: always output options.
2016-12-10 18:12:36 +00:00
Mike McQuaid
f7f15673a8 Fix dependency option handling.
- formula_installer: only recompute dependencies when necessary i.e.
when a bottle pour fails.
- formula_installer: re-add accidentally remove dependency options
- dependency: missing options are only those that actually exist on a
formula
2016-12-10 17:58:41 +00:00
David Broder-Rodgers
51e10315b7 Markup for PR guide 2016-12-10 14:25:35 +00:00
Mike McQuaid
a566540c46 Merge pull request #1641 from MikeMcQuaid/formulary-remap-options
formulary: remap deprecated options from keg.
2016-12-10 13:50:31 +00:00
Mike McQuaid
384174e542 which_all: don't assume path is a string.
Fixes #1635.
2016-12-10 13:19:01 +00:00
Mike McQuaid
e347f7ade3 reinstall/upgrade/install: always output options.
This is both easier for debugging and to communicate with users what is
being done.
2016-12-10 13:07:03 +00:00
Mike McQuaid
598c5e36f9 Tell people to report URL/tap deprecations to the tap.
Rather than Homebrew/brew or Homebrew/homebrew-core.
2016-12-10 13:04:14 +00:00
Mike McQuaid
8e2f0ccdc3 formulary: remap deprecated options from keg.
When reading a building a formula from a keg (rather than e.g. from
name) then the deprecation options were not remapped correctly as they
are only done in `Tab.for_formula` and not `Tab.for_keg`. Ensure that
after we’ve created the formula that the `used_options` are remapped
correctly.
2016-12-09 17:59:08 +00:00
Markus Reiter
f02491180b Merge pull request #1618 from rwanyoike/cask-reinstall-order
cask reinstall: download and verify cask before uninstall
2016-12-09 17:24:05 +01:00
Mike McQuaid
33b34b497c Merge pull request #1634 from strugee/patch-1
Point to GitHub Releases in CHANGELOG.md
2016-12-09 09:59:55 +00:00
David Broder-Rodgers
b83ffd53e3 Made the pull request guide slightly less formula specific 2016-12-08 22:22:38 +00:00
Alex Jordan
0b4a1ef0d4 Point to GitHub Releases in CHANGELOG.md
A lot of people (e.g. me in #1633) will look here and not find
anything. We should point them to the proper location.
2016-12-08 12:01:11 -08:00
Zach Whaley
14f46625a3 caveats: Differentiate zsh completion files and function files
When installing a file to zsh/site-functions directory, it is assumed this is a zsh completion file,
and the zsh completion caveat is printed after installation.

But not all files in the zsh/site-functions directory are completion files.
Some are files for functions that can be loaded on demand with zsh's autoload command.

- Edit Keg.completion_installed to search specifically for files in the zsh/site-functions
  directory starting with an underscore only (By convention, zsh completion files start with an underscore)
- Add Keg.zsh_functions_installed to search for non-completion files in the zsh/site-functions
- Add Caveats.zsh_function_caveats to print a caveat if non-completion files have been installed
  to zsh/site-functions
2016-12-08 07:23:26 -06:00
Zach Whaley
95688cd72e formula: Add convenience method for installing Zsh functions 2016-12-08 07:23:26 -06:00