10698 Commits

Author SHA1 Message Date
Mike McQuaid
dc9819b86c Revert "uses: properly handle untapped formulae in recursive dependency expansion" 2017-01-07 13:15:18 +00:00
Mike McQuaid
4f9c13926e Merge pull request #1784 from alyssais/uses_tap_exception
uses: properly handle untapped formulae in recursive dependency expansion
2017-01-07 12:50:45 +00:00
Mike McQuaid
4a51111454 Merge pull request #1786 from rwhogg/perl-version-may-lack-brackets
PerlRequirement: Perl version string may lack parentheses
2017-01-07 12:43:51 +00:00
Mike McQuaid
14e8f252ad Merge pull request #1792 from javian/whitelistphpshadowedheader
Whitelist PHP formulas in shadowed header audit check
2017-01-07 12:18:14 +00:00
Mike McQuaid
f814ee87fb Revert "cc: always filter flags on deps." 2017-01-07 09:52:01 +00:00
Jan Viljanen
80b7d4c1aa Whitelist PHP formulas in shadowed header audit check 2017-01-06 23:43:25 +01:00
Mike McQuaid
4497190593 keg: use resolved_path not realpath.
This guards against this being a non-symlink in which case it will fail.
2017-01-06 16:35:41 +00:00
ilovezfs
1a394aa7e5 Merge pull request #1782 from ilovezfs/prefix-fixups
Fix abv and prefix_linked?
2017-01-06 02:03:39 -08:00
Mike McQuaid
1a4ff22447 formula: tweak versioned prefix approach. 2017-01-06 08:50:35 +00:00
Mike McQuaid
6c2b614a04 pathname: make compute_disk_usage handle symlinks. 2017-01-06 08:50:20 +00:00
Mike McQuaid
3fde8624b3 Merge pull request #1780 from MikeMcQuaid/use-docs-links
Use docs.brew.sh links.
2017-01-05 17:17:07 +00:00
Mike McQuaid
2040adbe4a Merge pull request #1787 from alyssais/formula_comments
formula: correct grammar in comments
2017-01-05 17:06:52 +00:00
Mike McQuaid
3dabf82d4d Merge pull request #1771 from alyssais/license_year
licenses: update copyright year
2017-01-05 17:02:44 +00:00
Alyssa Ross
e466a65b8d formula: correct grammar in comments 2017-01-05 12:21:50 +00:00
Shaun Jackman
cd18536eff PerlRequirement: version number might not be wrapped in parentheses
For example:
This is perl, v5.10.1 (*) built for x86_64-linux-thread-multi
2017-01-04 22:57:14 -08:00
Alyssa Ross
536b6e2396 uses: properly handle recursive deps exceptions
Fixes #1776.

If any known formula had a dependency on an untapped tap,
Formula#recursive_dependencies would throw an exception, which would be
caught by the outer exception handler, causing the rest of the
dependencies for that formula to be skipped and incomplete output to be
generated.

To fix this, I added a check to avoid analysing the dependencies of
formulae from uninstalled taps.

Additionally, I removed the aforementioned outer exception handler added
in 5fdb89aed90f03413cdb21af430411c4a722876e, because the only other
place that should be capable of throwing such an exception is the
statement that was surrounded by another wider exception handler in
Homebrew/legacy-homebrew#40682.
2017-01-05 00:33:44 +00:00
Alyssa Ross
4c061fc183 dependency: TapDependency#tap returns a Tap
Previously, this returned a String, but a Tap instance seems much more
sensible.

I couldn't find anywhere this method was actually used, so the change
shouldn't break anything.
2017-01-05 00:22:56 +00:00
ilovezfs
a68d38743a formula: make prefix_linked? use versioned prefix
otherwise whenever prefix is unversioned, prefix_Linked will be false
2017-01-04 12:45:32 -08:00
ilovezfs
6195d6592b formula: realpath prefix before computing abv
versioned prefix is a directory, but unversioned is a symlink, so
realpath it before computing abv
2017-01-04 10:23:15 -08:00
Mike McQuaid
98dadd907e Merge pull request #1777 from alyssais/tests_tab_version
tests: remove temporary tab homebrew_version override
2017-01-04 11:37:48 +00:00
Mike McQuaid
a3bffe70bc Use docs.brew.sh links. 2017-01-04 11:13:41 +00:00
Alyssa Ross
56d6695bf3 tab: set homebrew_version in Tab.empty 2017-01-04 00:56:06 +00:00
Alyssa Ross
b7e10ba239 tests: remove temp tab homebrew_version override
This had to be added in #1750 to work around special-casing for tabs
generated with Homebrew versions < 1.1.6. Now that 1.1.6 is the current
version, we can remove this hack.
2017-01-04 00:46:44 +00:00
Mike McQuaid
d7ab913f31 audit: deprecate env :std/:userpaths for strict.
This should apply only for new formulae but we should start gradually
phasing it out for older ones too.
2017-01-03 22:12:21 +00:00
Mike McQuaid
fc11f633b2 Merge pull request #1677 from MikeMcQuaid/formula-prefix-opt
formula: make prefix usually return opt_prefix.
2017-01-03 20:10:22 +00:00
Mike McQuaid
619791e83d Merge pull request #1768 from MikeMcQuaid/deprecate-homebrew-versions-devel-only
Deprecate Homebrew/versions, Homebrew/devel-only.
2017-01-03 19:59:53 +00:00
Alyssa Ross
6ecf2ca013 cask: remove license
See https://github.com/Homebrew/brew/pull/1771#issuecomment-270179479.
2017-01-03 18:08:02 +00:00
Mike McQuaid
cd1579a51a Deprecate Homebrew/versions, Homebrew/devel-only.
Don't use Homebrew/versions in a test and remove them both from the
OFFICIAL_TAPS list (i.e. `brew search`).
2017-01-03 17:50:09 +00:00
Mike McQuaid
538028a735 Merge pull request #1766 from MikeMcQuaid/update-report-incoming-renames
update-report: handle homebrew/versions imports.
2017-01-02 20:42:57 +00:00
Vítor Galvão
2eed2ba434 Merge pull request #1760 from reitermarkus/version-file-separator
Disallow file separator in version strings.
2017-01-02 17:49:50 +00:00
Mike McQuaid
ed66fa3ae5 update-report: handle homebrew/versions imports.
Imports from homebrew/versions are migrated from that tap and then
renamed immediately when they hit homebrew/core. This did not trigger
our previous rename detection so address these to improve the output and
handle migration correctly.
2017-01-02 17:24:52 +00:00
Mike McQuaid
79f9896d2f bottles: --force-bottle feigns or_later.
When reproducing issues with software that hasn’t been bottled yet on
your version of macOS it can sometimes be helpful to use `or_later`
bottle functionality i.e. just use the bottle for the latest version of
macOS available. This maps well to the existing `--force-bottle`
argument so it will now act as if the latest bottle has a `or_later`
ending.
2017-01-02 16:05:14 +00:00
Markus Reiter
2c6516ef59 Disallow file separator in version strings. 2017-01-02 12:15:54 +01:00
Markus Reiter
e84e4b5566 Merge pull request #1745 from vitorgalvao/depends-on-arch
cask depends_on arch: remove everything but 64-bit intel
2017-01-02 12:08:21 +01:00
Vítor Galvão
294781cc9e cask depends_on arch: remove everything but 64-bit intel 2017-01-02 02:46:03 +00:00
Alyssa Ross
e1d7d44e5a tests: optlink fake kegs in uninstall test 2017-01-01 14:27:24 +00:00
Alyssa Ross
e4856143a6 keg: check installed dependencies iff optlinked 2017-01-01 14:27:24 +00:00
Alyssa Ross
94ead55772 keg: keg_only kegs can have installed dependents 2017-01-01 14:26:28 +00:00
Alyssa Ross
05b85a7bef keg: update installed dependency resolution
Closes #1525. (See there for a motivation for this change.)
2017-01-01 14:26:28 +00:00
Mike McQuaid
9105ccece3 rubocop_todo: autogenerate update. 2016-12-31 22:44:15 +00:00
Mike McQuaid
f0fbcf5022 ENV/super: fix set_cpu_flags stub.
It should accept arguments.

Fixes https://github.com/Homebrew/homebrew-core/issues/8362
2016-12-31 22:44:05 +00:00
Mike McQuaid
ad593cf42c Merge pull request #1757 from alyssais/moved_formula
keg: handle dependencies of moved/renamed formulae
2016-12-31 18:39:55 +00:00
Markus Reiter
4b5489e172 Merge pull request #1759 from reitermarkus/bsexec
Remove `:bsexec` parameter from `SystemCommand`.
2016-12-31 19:19:21 +01:00
Alyssa Ross
524d9ce8f3 keg: test dep fallback with unknown formulae 2016-12-31 17:53:06 +00:00
Alyssa Ross
8b30abe060 keg: handle dependencies of moved/renamed formulae
In #1497 I switched from Keg#to_formula for comparing kegs to formulae
to comparing the name and tap in the keg's tab to the name and tap of
the formula.

However, this fails to match if the name and tap of the formula have
changed since the keg was installed, so it's clearly better to use
Keg#to_formula where possible, and fall back to the information in the
tab when #to_formula can't be used.
2016-12-31 17:53:06 +00:00
Mike McQuaid
9fa95d7218 Merge pull request #1758 from MikeMcQuaid/no-duplicate-formulae
formula, ARGV: don't output duplicate formulae.
2016-12-31 17:36:33 +00:00
Mike McQuaid
33fbf3f32d Merge pull request #1750 from alyssais/fallback_dependencies
keg: fall back for dependencies of buggy tabs
2016-12-31 17:34:55 +00:00
Mike McQuaid
1c9651f04f Merge pull request #1756 from alyssais/nil_dependents
keg: don't return nil dependencies
2016-12-31 17:34:17 +00:00
Mike McQuaid
d85a83c9dc Merge pull request #1752 from alyssais/uninstalling_dependencies
keg: fix fallback dependencies with multiple kegs
2016-12-31 17:33:08 +00:00
Mike McQuaid
82f4413964 formula, ARGV: don't output duplicate formulae.
If you specify a formula more than once or it exists in the Cellar with
an alias name and the main name (e.g. `qt` and `qt5`) you can see the
same formula showing up more than once. Instead, resolve these output
lists of formulae such that they are unique based on their `name`. This
doesn't use `full_name` as it's `name` that's use for the `Cellar`.
2016-12-31 17:03:29 +00:00